From unknown Mon Jun 23 23:50:09 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#12714 <12714@debbugs.gnu.org> To: bug#12714 <12714@debbugs.gnu.org> Subject: Status: [PATCH] build: do not redefine _FORTIFY_SOURCE Reply-To: bug#12714 <12714@debbugs.gnu.org> Date: Tue, 24 Jun 2025 06:50:09 +0000 retitle 12714 [PATCH] build: do not redefine _FORTIFY_SOURCE reassign 12714 coreutils submitter 12714 Mike Frysinger severity 12714 normal tag 12714 patch thanks From debbugs-submit-bounces@debbugs.gnu.org Tue Oct 23 15:22:31 2012 Received: (at submit) by debbugs.gnu.org; 23 Oct 2012 19:22:31 +0000 Received: from localhost ([127.0.0.1]:58161 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TQk3a-0008Qk-7b for submit@debbugs.gnu.org; Tue, 23 Oct 2012 15:22:30 -0400 Received: from eggs.gnu.org ([208.118.235.92]:36716) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TQk3U-0008QV-NW for submit@debbugs.gnu.org; Tue, 23 Oct 2012 15:22:28 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TQk1V-0002NL-Gy for submit@debbugs.gnu.org; Tue, 23 Oct 2012 15:20:25 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_HI autolearn=unavailable version=3.3.2 Received: from lists.gnu.org ([208.118.235.17]:36491) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TQk1V-0002NG-Dw for submit@debbugs.gnu.org; Tue, 23 Oct 2012 15:20:21 -0400 Received: from eggs.gnu.org ([208.118.235.92]:57563) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TQk1R-00015v-FY for bug-coreutils@gnu.org; Tue, 23 Oct 2012 15:20:21 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TQk1L-0002IR-9U for bug-coreutils@gnu.org; Tue, 23 Oct 2012 15:20:17 -0400 Received: from smtp.gentoo.org ([140.211.166.183]:40468) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TQk1L-0002F3-3N for bug-coreutils@gnu.org; Tue, 23 Oct 2012 15:20:11 -0400 Received: from localhost.localdomain (localhost [127.0.0.1]) by smtp.gentoo.org (Postfix) with ESMTP id 5756433D88F for ; Tue, 23 Oct 2012 19:20:06 +0000 (UTC) From: Mike Frysinger To: bug-coreutils@gnu.org Subject: [PATCH] build: do not redefine _FORTIFY_SOURCE Date: Tue, 23 Oct 2012 15:20:07 -0400 Message-Id: <1351020007-10089-1-git-send-email-vapier@gentoo.org> X-Mailer: git-send-email 1.7.12 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-Received-From: 208.118.235.17 X-Spam-Score: -3.4 (---) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -3.4 (---) If the active compiler or flags have already defined _FORTIFY_SOURCE, don't go overriding that. Otherwise we get a lot of spew about the flag being redefined. * configure.ac (FORTIFY_SOURCE): Check if _FORTIFY_SOURCE is defined. --- configure.ac | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/configure.ac b/configure.ac index e5e05be..6504144 100644 --- a/configure.ac +++ b/configure.ac @@ -170,7 +170,7 @@ if test "$gl_gcc_warnings" = yes; then AH_VERBATIM([FORTIFY_SOURCE], [/* Enable compile-time and run-time bounds-checking, and some warnings, without upsetting glibc 2.15+. */ - #if defined __OPTIMIZE__ && __OPTIMIZE__ + #if !defined _FORTIFY_SOURCE && defined __OPTIMIZE__ && __OPTIMIZE__ # define _FORTIFY_SOURCE 2 #endif ]) -- 1.7.12 From debbugs-submit-bounces@debbugs.gnu.org Tue Oct 23 15:28:12 2012 Received: (at 12714) by debbugs.gnu.org; 23 Oct 2012 19:28:12 +0000 Received: from localhost ([127.0.0.1]:58166 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TQk96-00007T-He for submit@debbugs.gnu.org; Tue, 23 Oct 2012 15:28:12 -0400 Received: from mx.meyering.net ([88.168.87.75]:36772) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TQk94-00007K-0x for 12714@debbugs.gnu.org; Tue, 23 Oct 2012 15:28:10 -0400 Received: from rho.meyering.net (rho.meyering.net [127.0.0.1]) by rho.meyering.net (Acme Bit-Twister) with ESMTP id BE4EB604FC; Tue, 23 Oct 2012 21:26:14 +0200 (CEST) From: Jim Meyering To: Mike Frysinger Subject: Re: bug#12714: [PATCH] build: do not redefine _FORTIFY_SOURCE In-Reply-To: <1351020007-10089-1-git-send-email-vapier@gentoo.org> (Mike Frysinger's message of "Tue, 23 Oct 2012 15:20:07 -0400") References: <1351020007-10089-1-git-send-email-vapier@gentoo.org> Date: Tue, 23 Oct 2012 21:26:14 +0200 Message-ID: <87a9vdm1m1.fsf@rho.meyering.net> Lines: 26 MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.1 (/) X-Debbugs-Envelope-To: 12714 Cc: 12714@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: 0.1 (/) Mike Frysinger wrote: > If the active compiler or flags have already defined _FORTIFY_SOURCE, > don't go overriding that. Otherwise we get a lot of spew about the > flag being redefined. > > * configure.ac (FORTIFY_SOURCE): Check if _FORTIFY_SOURCE is defined. > --- > configure.ac | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/configure.ac b/configure.ac > index e5e05be..6504144 100644 > --- a/configure.ac > +++ b/configure.ac > @@ -170,7 +170,7 @@ if test "$gl_gcc_warnings" = yes; then > AH_VERBATIM([FORTIFY_SOURCE], > [/* Enable compile-time and run-time bounds-checking, and some warnings, > without upsetting glibc 2.15+. */ > - #if defined __OPTIMIZE__ && __OPTIMIZE__ > + #if !defined _FORTIFY_SOURCE && defined __OPTIMIZE__ && __OPTIMIZE__ > # define _FORTIFY_SOURCE 2 > #endif > ]) Thanks. Please adjust the log (or just tell us and we'll adjust it) so that we know which compiler motivates this change. From debbugs-submit-bounces@debbugs.gnu.org Tue Oct 23 15:53:01 2012 Received: (at submit) by debbugs.gnu.org; 23 Oct 2012 19:53:01 +0000 Received: from localhost ([127.0.0.1]:58181 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TQkX6-0000gh-Ut for submit@debbugs.gnu.org; Tue, 23 Oct 2012 15:53:01 -0400 Received: from eggs.gnu.org ([208.118.235.92]:49003) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TQkX4-0000gT-R0 for submit@debbugs.gnu.org; Tue, 23 Oct 2012 15:52:59 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TQkV4-0000Un-9y for submit@debbugs.gnu.org; Tue, 23 Oct 2012 15:51:00 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_HI autolearn=unavailable version=3.3.2 Received: from lists.gnu.org ([208.118.235.17]:41789) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TQkV4-0000UK-4h for submit@debbugs.gnu.org; Tue, 23 Oct 2012 15:50:54 -0400 Received: from eggs.gnu.org ([208.118.235.92]:48643) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TQkUw-000635-QF for bug-coreutils@gnu.org; Tue, 23 Oct 2012 15:50:54 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TQkUu-0000PY-DH for bug-coreutils@gnu.org; Tue, 23 Oct 2012 15:50:46 -0400 Received: from smtp.gentoo.org ([140.211.166.183]:42780) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TQkUt-0000On-RS for bug-coreutils@gnu.org; Tue, 23 Oct 2012 15:50:44 -0400 Received: from vapier.localnet (localhost [127.0.0.1]) by smtp.gentoo.org (Postfix) with ESMTP id 5CB3433D810; Tue, 23 Oct 2012 19:50:42 +0000 (UTC) From: Mike Frysinger Organization: wh0rd.org To: bug-coreutils@gnu.org Subject: Re: bug#12714: [PATCH] build: do not redefine _FORTIFY_SOURCE Date: Tue, 23 Oct 2012 15:50:42 -0400 User-Agent: KMail/1.13.7 (Linux/3.5.2; KDE/4.6.5; x86_64; ; ) References: <1351020007-10089-1-git-send-email-vapier@gentoo.org> <87a9vdm1m1.fsf@rho.meyering.net> In-Reply-To: <87a9vdm1m1.fsf@rho.meyering.net> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="nextPart2452179.Ey7bsVOeUv"; protocol="application/pgp-signature"; micalg=pgp-sha1 Content-Transfer-Encoding: 7bit Message-Id: <201210231550.43201.vapier@gentoo.org> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-Received-From: 208.118.235.17 X-Spam-Score: -3.4 (---) X-Debbugs-Envelope-To: submit Cc: 12714@debbugs.gnu.org, Jim Meyering X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -3.4 (---) --nextPart2452179.Ey7bsVOeUv Content-Type: Text/Plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable On Tuesday 23 October 2012 15:26:14 Jim Meyering wrote: > Mike Frysinger wrote: > > If the active compiler or flags have already defined _FORTIFY_SOURCE, > > don't go overriding that. Otherwise we get a lot of spew about the > > flag being redefined. > >=20 > > * configure.ac (FORTIFY_SOURCE): Check if _FORTIFY_SOURCE is defined. > > --- > >=20 > > configure.ac | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > >=20 > > diff --git a/configure.ac b/configure.ac > > index e5e05be..6504144 100644 > > --- a/configure.ac > > +++ b/configure.ac > > @@ -170,7 +170,7 @@ if test "$gl_gcc_warnings" =3D yes; then > >=20 > > AH_VERBATIM([FORTIFY_SOURCE], > > [/* Enable compile-time and run-time bounds-checking, and some > > warnings, > > =20 > > without upsetting glibc 2.15+. */ > >=20 > > - #if defined __OPTIMIZE__ && __OPTIMIZE__ > > + #if !defined _FORTIFY_SOURCE && defined __OPTIMIZE__ && __OPTIMIZE__ > >=20 > > # define _FORTIFY_SOURCE 2 > > #endif > > =20 > > ]) >=20 > Thanks. Please adjust the log (or just tell us and we'll adjust it) > so that we know which compiler motivates this change. Ubuntu will enable _FORTIFY_SOURCE by default. not sure about Debian. Gen= too=20 has been doing it for a while. in the past, we could just default it to 2 (in which case this wouldn't=20 normally trigger a warning), but as the comment states here, newer glibc is= =20 picky and will error out if you have -D_FORTIFY_SOURCE=3D2 -O0. so we had = to=20 update the default to read: _FORTIFY_SOURCE=3D((defined __OPTIMIZE__ && __OPTIMIZE__ > 0) ? 2 : 0) in which case this code triggers lots of false warnings. however, that isn't the only way to trigger this. if the user themselves d= o: CPPFLAGS=3D-D_FORTIFY_SOURCE=3D1 ./configure it'll cause warnings. =2Dmike --nextPart2452179.Ey7bsVOeUv Content-Type: application/pgp-signature; name=signature.asc Content-Description: This is a digitally signed message part. -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.17 (GNU/Linux) iQIcBAABAgAGBQJQhvUTAAoJEEFjO5/oN/WBlO4P/1cMBaaeXHHa9BAu2mBr5D4Q LOsGzPG4nDJvZsKLXJjywPRJkgmywobW5I4BmyqtPrWBmwESmoPAh0F6ckRieQRB mxIMyD5qdbpDVX0TXNkJnEYoFqS2KxFvOauO0ZkXaBfWV4VAOREIULWuU+LNjuNM 3AtGc5OXploRFgMcrrjtRnhWbo8uS+PPEVFo9gTcpYbm4wpPmgjd8vABHrrHbW/c yj5W9v2TqeaMg27zNEHRqkz08g4jL9vlwYhhZKixfzqifxZJ1DJhCgPDKfH4t7Hn AQjptvZ2jelk6CzyGoOcxnZEgM27V4k0G4mFP1lX3TE1WfADvqdTXUwI69Jyi7v+ yRSg6zgdHtfixYgnD564/mO0dSCw+AF4aCOi7NromniGDMNeOXGrGq6pRbZQUveS sHfLhpoNPan9HSe6iPC2uXB9eoIPXKwEvudeTL0Z5CZBp0VF8BUCIiBAlzFEdaZc cum6wkSBMuDKAQRVI2VDizn0VN3kpPWJuusImLtD+qqWUv+HdMz+lQsltyX4AF1m nqIQQ8m1TUcrFU1FpqJVnxmBUuboaheZ3U0DTIwQw9pmSDOv0sTM8KxbbubfdGJ8 Om3hpdF5HrWAVmQ66RVJxiI3eWXTGaw0mPZaZawt6a4FWSmVZ9mTVl3hd1cpxkVE Mc8Nt42a9ceWbihPND62 =+LEC -----END PGP SIGNATURE----- --nextPart2452179.Ey7bsVOeUv-- From debbugs-submit-bounces@debbugs.gnu.org Tue Oct 23 15:59:11 2012 Received: (at 12714) by debbugs.gnu.org; 23 Oct 2012 19:59:11 +0000 Received: from localhost ([127.0.0.1]:58203 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TQkd4-0000q4-VW for submit@debbugs.gnu.org; Tue, 23 Oct 2012 15:59:11 -0400 Received: from mx1.redhat.com ([209.132.183.28]:54412) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TQkd1-0000pu-6e for 12714@debbugs.gnu.org; Tue, 23 Oct 2012 15:59:09 -0400 Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q9NJvCmp019506 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Tue, 23 Oct 2012 15:57:12 -0400 Received: from [10.3.113.142] (ovpn-113-142.phx2.redhat.com [10.3.113.142]) by int-mx02.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id q9NJvBKT002942; Tue, 23 Oct 2012 15:57:11 -0400 Message-ID: <5086F697.1070009@redhat.com> Date: Tue, 23 Oct 2012 13:57:11 -0600 From: Eric Blake Organization: Red Hat User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:16.0) Gecko/20121016 Thunderbird/16.0.1 MIME-Version: 1.0 To: Mike Frysinger Subject: Re: bug#12714: [PATCH] build: do not redefine _FORTIFY_SOURCE References: <1351020007-10089-1-git-send-email-vapier@gentoo.org> <87a9vdm1m1.fsf@rho.meyering.net> <201210231550.43201.vapier@gentoo.org> In-Reply-To: <201210231550.43201.vapier@gentoo.org> X-Enigmail-Version: 1.4.5 OpenPGP: url=http://people.redhat.com/eblake/eblake.gpg Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------enigD3256CD7BA4475D874B512B1" X-Scanned-By: MIMEDefang 2.67 on 10.5.11.12 X-Spam-Score: -4.9 (----) X-Debbugs-Envelope-To: 12714 Cc: 12714@debbugs.gnu.org, jim@meyering.net X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -5.7 (-----) This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enigD3256CD7BA4475D874B512B1 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 10/23/2012 01:50 PM, Mike Frysinger wrote: > On Tuesday 23 October 2012 15:26:14 Jim Meyering wrote: >> Mike Frysinger wrote: >>> If the active compiler or flags have already defined _FORTIFY_SOURCE,= >>> don't go overriding that. Otherwise we get a lot of spew about the >>> flag being redefined. >>> >>> * configure.ac (FORTIFY_SOURCE): Check if _FORTIFY_SOURCE is defined.= >>> >>> - #if defined __OPTIMIZE__ && __OPTIMIZE__ >>> + #if !defined _FORTIFY_SOURCE && defined __OPTIMIZE__ && __OPTIMIZ= E__ Coreutils copied this line from libvirt, and I know that other packages have also copied this line. You will probably have several bug reports to file, as you track down where this has spread. I really dislike what glibc did to us by issuing a warning about an ignored macro. --=20 Eric Blake eblake@redhat.com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --------------enigD3256CD7BA4475D874B512B1 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Mozilla - http://www.enigmail.net/ iQEcBAEBCAAGBQJQhvaXAAoJEKeha0olJ0NqjqoH/0JnnQwFxy03gEkI2USDFpbn 41CWEFVqu7W05HV4WNrdRZ4NrbkbftgT1IYpdfB56zn4r5vw6MwR2ryMx6kyB+i3 9WthaX9VhlI50zKU2Up9ZxdVvt5Z10oNAGejiTQKXf78yQEOKZWLf6VSOyOmgsS/ F6bovBeoA6B8AXc6+fVhZVcVRI3L84itWShsX7AmEekIbRnNa3kmg7+LDZjbKXkV 7iGQSEusHHFXhYBxQGX1cIO3Wb57UiK1jE2qRkZOCFVZhPByjS06zxIxisKKPVjy frHsfUg1TWjn+Ssx3SoH6rWbh5x+UXoM7FDn+KJmmxHQrr5wJlrh0wwB58M771g= =LoN8 -----END PGP SIGNATURE----- --------------enigD3256CD7BA4475D874B512B1-- From debbugs-submit-bounces@debbugs.gnu.org Wed Oct 24 12:11:54 2012 Received: (at submit) by debbugs.gnu.org; 24 Oct 2012 16:11:54 +0000 Received: from localhost ([127.0.0.1]:59772 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TR3Yg-0002Cz-8B for submit@debbugs.gnu.org; Wed, 24 Oct 2012 12:11:54 -0400 Received: from eggs.gnu.org ([208.118.235.92]:49344) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TR3Ye-0002Cg-Go for submit@debbugs.gnu.org; Wed, 24 Oct 2012 12:11:53 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TR3Wa-0003YF-CP for submit@debbugs.gnu.org; Wed, 24 Oct 2012 12:09:49 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_HI autolearn=unavailable version=3.3.2 Received: from lists.gnu.org ([208.118.235.17]:58681) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TR3Wa-0003YB-9t for submit@debbugs.gnu.org; Wed, 24 Oct 2012 12:09:44 -0400 Received: from eggs.gnu.org ([208.118.235.92]:40024) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TR3WU-0006I9-FF for bug-coreutils@gnu.org; Wed, 24 Oct 2012 12:09:44 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TR3WK-0003TU-Qw for bug-coreutils@gnu.org; Wed, 24 Oct 2012 12:09:38 -0400 Received: from mx.meyering.net ([88.168.87.75]:51462) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TR3WK-0003TM-JS for bug-coreutils@gnu.org; Wed, 24 Oct 2012 12:09:28 -0400 Received: from rho.meyering.net (rho.meyering.net [127.0.0.1]) by rho.meyering.net (Acme Bit-Twister) with ESMTP id 1819F60098; Wed, 24 Oct 2012 18:09:27 +0200 (CEST) From: Jim Meyering To: Mike Frysinger Subject: Re: bug#12714: [PATCH] build: do not redefine _FORTIFY_SOURCE In-Reply-To: <201210231550.43201.vapier@gentoo.org> (Mike Frysinger's message of "Tue, 23 Oct 2012 15:50:42 -0400") References: <1351020007-10089-1-git-send-email-vapier@gentoo.org> <87a9vdm1m1.fsf@rho.meyering.net> <201210231550.43201.vapier@gentoo.org> Date: Wed, 24 Oct 2012 18:09:27 +0200 Message-ID: <87wqyfj1hk.fsf@rho.meyering.net> Lines: 50 MIME-Version: 1.0 Content-Type: text/plain X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-Received-From: 208.118.235.17 X-Spam-Score: -4.2 (----) X-Debbugs-Envelope-To: submit Cc: 12714-done@debbugs.gnu.org, bug-coreutils@gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -4.2 (----) Mike Frysinger wrote: > On Tuesday 23 October 2012 15:26:14 Jim Meyering wrote: >> Mike Frysinger wrote: >> > If the active compiler or flags have already defined _FORTIFY_SOURCE, >> > don't go overriding that. Otherwise we get a lot of spew about the >> > flag being redefined. >> > >> > * configure.ac (FORTIFY_SOURCE): Check if _FORTIFY_SOURCE is defined. >> > --- ... >> Thanks. Please adjust the log (or just tell us and we'll adjust it) >> so that we know which compiler motivates this change. > > Ubuntu will enable _FORTIFY_SOURCE by default. not sure about Debian. Gentoo > has been doing it for a while. Thanks. I've adjusted the log. Ok with you? >From 9517680ed3d4d7baff8a842a052ad405f9e9049f Mon Sep 17 00:00:00 2001 From: Mike Frysinger Date: Tue, 23 Oct 2012 15:20:07 -0400 Subject: [PATCH] build: do not redefine _FORTIFY_SOURCE When _FORTIFY_SOURCE is defined by the compiler or via flags, as it is on Gentoo, do not override it. Otherwise we get many redefinition warnings. * configure.ac (FORTIFY_SOURCE): Check if _FORTIFY_SOURCE is defined. This addresses http://bugs.gnu.org/12714 --- configure.ac | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/configure.ac b/configure.ac index e5e05be..6504144 100644 --- a/configure.ac +++ b/configure.ac @@ -170,7 +170,7 @@ if test "$gl_gcc_warnings" = yes; then AH_VERBATIM([FORTIFY_SOURCE], [/* Enable compile-time and run-time bounds-checking, and some warnings, without upsetting glibc 2.15+. */ - #if defined __OPTIMIZE__ && __OPTIMIZE__ + #if !defined _FORTIFY_SOURCE && defined __OPTIMIZE__ && __OPTIMIZE__ # define _FORTIFY_SOURCE 2 #endif ]) -- 1.8.0 From debbugs-submit-bounces@debbugs.gnu.org Wed Oct 24 13:47:43 2012 Received: (at submit) by debbugs.gnu.org; 24 Oct 2012 17:47:43 +0000 Received: from localhost ([127.0.0.1]:59921 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TR53O-0006A3-SA for submit@debbugs.gnu.org; Wed, 24 Oct 2012 13:47:43 -0400 Received: from eggs.gnu.org ([208.118.235.92]:37543) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TR53N-00069r-1f for submit@debbugs.gnu.org; Wed, 24 Oct 2012 13:47:41 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TR51I-00025k-W1 for submit@debbugs.gnu.org; Wed, 24 Oct 2012 13:45:36 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_HI autolearn=unavailable version=3.3.2 Received: from lists.gnu.org ([208.118.235.17]:36628) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TR51I-00025g-TE for submit@debbugs.gnu.org; Wed, 24 Oct 2012 13:45:32 -0400 Received: from eggs.gnu.org ([208.118.235.92]:44160) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TR51H-0006y8-E7 for bug-coreutils@gnu.org; Wed, 24 Oct 2012 13:45:32 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TR51C-00022e-IW for bug-coreutils@gnu.org; Wed, 24 Oct 2012 13:45:31 -0400 Received: from smtp.gentoo.org ([140.211.166.183]:60264) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TR51C-00022J-Cy for bug-coreutils@gnu.org; Wed, 24 Oct 2012 13:45:26 -0400 Received: from vapier.localnet (localhost [127.0.0.1]) by smtp.gentoo.org (Postfix) with ESMTP id 5796733D86A; Wed, 24 Oct 2012 17:45:24 +0000 (UTC) From: Mike Frysinger Organization: wh0rd.org To: Jim Meyering Subject: Re: bug#12714: [PATCH] build: do not redefine _FORTIFY_SOURCE Date: Wed, 24 Oct 2012 13:45:23 -0400 User-Agent: KMail/1.13.7 (Linux/3.6.3; KDE/4.6.5; x86_64; ; ) References: <1351020007-10089-1-git-send-email-vapier@gentoo.org> <201210231550.43201.vapier@gentoo.org> <87wqyfj1hk.fsf@rho.meyering.net> In-Reply-To: <87wqyfj1hk.fsf@rho.meyering.net> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="nextPart2190645.Ol3hSGkEJu"; protocol="application/pgp-signature"; micalg=pgp-sha1 Content-Transfer-Encoding: 7bit Message-Id: <201210241345.24390.vapier@gentoo.org> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-Received-From: 208.118.235.17 X-Spam-Score: -3.4 (---) X-Debbugs-Envelope-To: submit Cc: 12714-done@debbugs.gnu.org, bug-coreutils@gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -3.4 (---) --nextPart2190645.Ol3hSGkEJu Content-Type: Text/Plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable On Wednesday 24 October 2012 12:09:27 Jim Meyering wrote: > Mike Frysinger wrote: > > On Tuesday 23 October 2012 15:26:14 Jim Meyering wrote: > >> Mike Frysinger wrote: > >> > If the active compiler or flags have already defined _FORTIFY_SOURCE, > >> > don't go overriding that. Otherwise we get a lot of spew about the > >> > flag being redefined. > >> >=20 > >> > * configure.ac (FORTIFY_SOURCE): Check if _FORTIFY_SOURCE is defined. > >> > --- >=20 > ... >=20 > >> Thanks. Please adjust the log (or just tell us and we'll adjust it) > >> so that we know which compiler motivates this change. > >=20 > > Ubuntu will enable _FORTIFY_SOURCE by default. not sure about Debian.= =20 > > Gentoo has been doing it for a while. >=20 > Thanks. I've adjusted the log. > Ok with you? looks fine, thanks =2Dmike --nextPart2190645.Ol3hSGkEJu Content-Type: application/pgp-signature; name=signature.asc Content-Description: This is a digitally signed message part. -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.17 (GNU/Linux) iQIcBAABAgAGBQJQiCk0AAoJEEFjO5/oN/WBlksP/Rus+hyeG+6fvzFnmT8pKVAf 1e05+pPAiMnqf6mqpAYahhx1bMBd8Sf5SoWzDKRQgQCA7VPeh8dIXe1thCwL/4sQ 3G6CAmgAxI9ptmT62ax681POOKOAxsLp/zNtJzzOFAtuMid7TW+WlgRKylypiIFq DCxooklb3Cl/48KqLiTeh/bzyqoySD3RwGZIW1POAOTJgFA+fhE14Ty1CD58Z54H +fSzsas7JU8XuZTiSQNC2GXwo4vWvU9vnHO2jpLVbeXo2Z0QsZWClgPZgTySYyAP +83BzOBhtXeUiu7ALwaQBYq5RtXqG5CNTL4VqVOrNwpe8is2PN4IrO457DhwcOsM gXWSzPFCRASfuxMR7dqDIeD9El6AgzkVLYiiEOCug9EsLv5bb2EHaKxs99D2O82V H/fEeEtJllK3Xj6W899xz58C1qm0NZgxvoevpG+Ttyw9lNK+lsQYT2/cM0CtLJi5 MnBm8OB2Te9WTnSXqzU3Kxg4/FwB4DKNs5OSfPx5Jq4FOAnoUVScEiGg4YLKIqfA G/mr8VE5V8qKWM7YYJT5vXmA+R5hmtoWxYmsQHzYWuEII0npWJhWH5hU/4P1hpYk /s24qwNbiJxhda8mzW6s8SYFtObdVoPZtC7skpEbbAlQUH0Ipy3IwS+9NIj/f2Tk hzUxZRYERx+GpxEtQnTq =B4Cs -----END PGP SIGNATURE----- --nextPart2190645.Ol3hSGkEJu-- From unknown Mon Jun 23 23:50:09 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Thu, 22 Nov 2012 12:24:03 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator