Subject: bug#12714: [PATCH] build: do not redefine _FORTIFY_SOURCE

From: Eric Blake <[email-masked]>
Date: Tue, 23 Oct 2012 13:57:11 -0600

On 10/23/2012 01:50 PM, Mike Frysinger wrote:
> On Tuesday 23 October 2012 15:26:14 Jim Meyering wrote:
>> Mike Frysinger wrote:
>>> If the active compiler or flags have already defined _FORTIFY_SOURCE,
>>> don't go overriding that.  Otherwise we get a lot of spew about the
>>> flag being redefined.
>>>
>>> * configure.ac (FORTIFY_SOURCE): Check if _FORTIFY_SOURCE is defined.

>>>
>>> -   #if defined __OPTIMIZE__ && __OPTIMIZE__
>>> +   #if !defined _FORTIFY_SOURCE && defined __OPTIMIZE__ && __OPTIMIZE__

Coreutils copied this line from libvirt, and I know that other packages
have also copied this line.  You will probably have several bug reports
to file, as you track down where this has spread.

I really dislike what glibc did to us by issuing a warning about an
ignored macro.

-- 
Eric Blake   [email-masked]    +1-919-301-3266
Libvirt virtualization library http://libvirt.org