GNU bug report logs - #12705
24.2.50; `Info-complete-menu-item' should use `add-to-list', not `push', to prevent duplicates

Previous Next

Full log

View this message in rfc822 format

From: "Drew Adams" <drew.adams <at> oracle.com>
To: "'Chong Yidong'" <cyd <at> gnu.org>
Cc: 12705-done <at> debbugs.gnu.org, 12705 <at> debbugs.gnu.org
Subject: bug#12705: 24.2.50; `Info-complete-menu-item' should use `add-to-list', not `push', to prevent duplicates
Date: Mon, 29 Oct 2012 08:37:30 -0700

> Sounds reasonable.  Done in trunk, using delete-dups instead of
> add-to-list (in case info.el switches to lexical binding).

Thx.

Just curious - how would add-to-list interfere with lexical binding (or vice
versa)?

Seems odd that we would add and then delete, instead of adding only if not
present, just to dance around (the possibility of) lexical binding.

To be clear, I have no objection at all - nothing wrong with adding and then
deleting.  I'd just like to understand the problem being avoided.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.