From debbugs-submit-bounces@debbugs.gnu.org Mon Oct 22 12:28:03 2012 Received: (at submit) by debbugs.gnu.org; 22 Oct 2012 16:28:03 +0000 Received: from localhost ([127.0.0.1]:56108 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TQKrC-0006s5-JV for submit@debbugs.gnu.org; Mon, 22 Oct 2012 12:28:02 -0400 Received: from eggs.gnu.org ([208.118.235.92]:45631) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TQKrA-0006rZ-NT for submit@debbugs.gnu.org; Mon, 22 Oct 2012 12:28:01 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TQKpL-00044x-1L for submit@debbugs.gnu.org; Mon, 22 Oct 2012 12:26:08 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_HI, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.2 Received: from lists.gnu.org ([208.118.235.17]:43509) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TQKpK-00044t-UO for submit@debbugs.gnu.org; Mon, 22 Oct 2012 12:26:06 -0400 Received: from eggs.gnu.org ([208.118.235.92]:53970) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TQKpG-0005Wy-9B for bug-gnu-emacs@gnu.org; Mon, 22 Oct 2012 12:26:06 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TQKpE-000448-L2 for bug-gnu-emacs@gnu.org; Mon, 22 Oct 2012 12:26:02 -0400 Received: from userp1040.oracle.com ([156.151.31.81]:30255) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TQKpE-00043c-Dw for bug-gnu-emacs@gnu.org; Mon, 22 Oct 2012 12:26:00 -0400 Received: from ucsinet21.oracle.com (ucsinet21.oracle.com [156.151.31.93]) by userp1040.oracle.com (Sentrion-MTA-4.2.2/Sentrion-MTA-4.2.2) with ESMTP id q9MGPw3n016706 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Mon, 22 Oct 2012 16:25:58 GMT Received: from acsmt357.oracle.com (acsmt357.oracle.com [141.146.40.157]) by ucsinet21.oracle.com (8.14.4+Sun/8.14.4) with ESMTP id q9MGPvGH016591 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO) for ; Mon, 22 Oct 2012 16:25:57 GMT Received: from abhmt117.oracle.com (abhmt117.oracle.com [141.146.116.69]) by acsmt357.oracle.com (8.12.11.20060308/8.12.11) with ESMTP id q9MGPvk1027983 for ; Mon, 22 Oct 2012 11:25:57 -0500 Received: from dradamslap1 (/130.35.178.248) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Mon, 22 Oct 2012 09:25:56 -0700 From: "Drew Adams" To: Subject: 24.2.50; `Info-complete-menu-item' should use `add-to-list', not `push', to prevent duplicates Date: Mon, 22 Oct 2012 09:25:56 -0700 Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Mailer: Microsoft Office Outlook 11 Thread-Index: Ac2wcemfoJt4YDj1SbKNLRoZ5XHLDw== X-MimeOLE: Produced By Microsoft MimeOLE V6.00.2900.6157 X-Source-IP: ucsinet21.oracle.com [156.151.31.93] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 1) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-Received-From: 208.118.235.17 X-Spam-Score: -3.4 (---) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -3.4 (---) Subject line says it all. This sexp: (push (match-string-no-properties 1) completions) should be changed to this: (add-to-list 'completions (match-string-no-properties 1)) Otherwise the same entry can be added to `completions' multiple times. This might not be manifested in *Completions*, because Emacs removes duplicate candidates. But in other completion setups (e.g. Icicles) duplicate candidates (e.g. same display string, but perhaps different alist elements) are sometimes allowed. Yes, such other completion setups can specifically remove dups here. But it would be more polite for `Info-complete-menu-item' to not create dups in the first place. There is never any reason for dups in this context. In GNU Emacs 24.2.50.1 (i386-mingw-nt5.1.2600) of 2012-10-15 on DANI-PC Bzr revision: 110553 monnier@iro.umontreal.ca-20121015164957-6zms5w2js1xkldtg Windowing system distributor `Microsoft Corp.', version 5.1.2600 Configured using: `configure --with-gcc (4.7) --no-opt --enable-checking --cflags -I../../libs/libxpm-3.5.8/include -I../../libs/libxpm-3.5.8/src -I../../libs/libpng-1.4.10 -I../../libs/zlib-1.2.6 -I../../libs/giflib-4.1.4-1/include -I../../libs/jpeg-6b-4/include -I../../libs/tiff-3.8.2-1/include -I../../libs/libxml2-2.7.8-w32-bin/include/libxml2 -I../../libs/gnutls-3.0.16/include -I../../libs/libiconv-1.14-2-mingw32-dev/include' From debbugs-submit-bounces@debbugs.gnu.org Mon Oct 29 06:47:24 2012 Received: (at control) by debbugs.gnu.org; 29 Oct 2012 10:47:24 +0000 Received: from localhost ([127.0.0.1]:37483 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TSmsO-0005fK-67 for submit@debbugs.gnu.org; Mon, 29 Oct 2012 06:47:24 -0400 Received: from mail-pb0-f44.google.com ([209.85.160.44]:43577) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TSmsM-0005fB-E8 for control@debbugs.gnu.org; Mon, 29 Oct 2012 06:47:22 -0400 Received: by mail-pb0-f44.google.com with SMTP id ro8so4036387pbb.3 for ; Mon, 29 Oct 2012 03:44:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:from:to:subject:date:message-id:mime-version:content-type; bh=1h84aRf6pgAHKlYHFPPNfIEDDbRe9lO8h/CJmMo83lQ=; b=1EaWROQdsJFUF3rMmgo5t8Usbse9hM9Gfc4rKfwmwAVg7GyJExkVcH0IepgzrQxVVU gK7nISdsRFyqoxbpUaylyymBFXSVG7Yl3N9QDQS6De06qO4jV/2YWvP85JqQl0//VH7g kagddDgZXHBhVAlvjdmK/2A/a0H3LNLse6nOzk7fo7fYZkGCkU7iXC9SzVgYitBnbdrx bT/5AYqvk77kkCPh5kFp9AV8GczuXqRB+Tgf95CKCUVeo13Ko3AuUIDbMrLm1SE5IoNA gy4rzBeKPUHZa3nVNJUfyhev26dc1fiXY2D0QSCd9W6KdnmKGygCaWK4DVV8P9FoZ1uO xE7g== Received: by 10.68.251.197 with SMTP id zm5mr57204225pbc.30.1351507496389; Mon, 29 Oct 2012 03:44:56 -0700 (PDT) Received: from ulysses ([155.69.16.22]) by mx.google.com with ESMTPS id mn5sm5814964pbc.12.2012.10.29.03.44.53 (version=SSLv3 cipher=OTHER); Mon, 29 Oct 2012 03:44:55 -0700 (PDT) From: Chong Yidong To: control@debbugs.gnu.org Subject: close 12705 Date: Mon, 29 Oct 2012 18:44:50 +0800 Message-ID: <87ehkh5zh9.fsf@gnu.org> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.1 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: 0.1 (/) close 12705 thanks From debbugs-submit-bounces@debbugs.gnu.org Mon Oct 29 06:47:12 2012 Received: (at 12705-done) by debbugs.gnu.org; 29 Oct 2012 10:47:12 +0000 Received: from localhost ([127.0.0.1]:37480 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TSmsB-0005et-Sf for submit@debbugs.gnu.org; Mon, 29 Oct 2012 06:47:12 -0400 Received: from mail-da0-f44.google.com ([209.85.210.44]:58898) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TSms8-0005el-Rs for 12705-done@debbugs.gnu.org; Mon, 29 Oct 2012 06:47:09 -0400 Received: by mail-da0-f44.google.com with SMTP id h15so2280290dan.3 for <12705-done@debbugs.gnu.org>; Mon, 29 Oct 2012 03:44:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-type; bh=npemKgCZ9AD8WtZJd3qudqExOoU6wNUUzOOCx2mDPeQ=; b=tv6p/UQFCSAHu40rv10GreuaQWhYaweTRSgjsyOVtKxus0L5Wi0xmM92m+At7RElUD awgsZQf6XZ+lZVDZkxtkjZBOeeRqxm/VReIcNJSl6MZErEWx4XoKOXqPSyj7cCcYLfDu knAgRHh5xy7do94TCkw1qVFxhyXL4FDMSKwGUV7G7f10Xx1Y1nevEdWiweySZOH+OkqU D5v86RciVEaYVKfBsV4++h4zf+uOiqvAA9hSLkjuydWujjuOjKTXIr3I/U9n86xAMkGu +kUSddLJTvFsee2wwfYECZYkfFzVYCLOHpxN0e4cmfgIVXnWOJGjz+tylSDhY8DhOGsc BJWA== Received: by 10.68.196.170 with SMTP id in10mr92548107pbc.0.1351507482820; Mon, 29 Oct 2012 03:44:42 -0700 (PDT) Received: from ulysses ([155.69.16.22]) by mx.google.com with ESMTPS id e9sm5759882paz.28.2012.10.29.03.44.39 (version=SSLv3 cipher=OTHER); Mon, 29 Oct 2012 03:44:41 -0700 (PDT) From: Chong Yidong To: "Drew Adams" Subject: Re: bug#12705: 24.2.50; `Info-complete-menu-item' should use `add-to-list', not `push', to prevent duplicates References: Date: Mon, 29 Oct 2012 18:44:36 +0800 In-Reply-To: (Drew Adams's message of "Mon, 22 Oct 2012 09:25:56 -0700") Message-ID: <87fw4xd0bv.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.2.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.1 (/) X-Debbugs-Envelope-To: 12705-done Cc: 12705-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -0.7 (/) "Drew Adams" writes: > This sexp: > (push (match-string-no-properties 1) completions) > > should be changed to this: > (add-to-list 'completions (match-string-no-properties 1)) > > Otherwise the same entry can be added to `completions' multiple times. > > This might not be manifested in *Completions*, because Emacs removes > duplicate candidates. But in other completion setups (e.g. Icicles) > duplicate candidates (e.g. same display string, but perhaps different > alist elements) are sometimes allowed. Sounds reasonable. Done in trunk, using delete-dups instead of add-to-list (in case info.el switches to lexical binding). From debbugs-submit-bounces@debbugs.gnu.org Mon Oct 29 11:40:04 2012 Received: (at 12705) by debbugs.gnu.org; 29 Oct 2012 15:40:04 +0000 Received: from localhost ([127.0.0.1]:38303 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TSrRb-0005ls-R9 for submit@debbugs.gnu.org; Mon, 29 Oct 2012 11:40:04 -0400 Received: from userp1040.oracle.com ([156.151.31.81]:49277) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TSrRZ-0005lR-FJ; Mon, 29 Oct 2012 11:40:02 -0400 Received: from ucsinet21.oracle.com (ucsinet21.oracle.com [156.151.31.93]) by userp1040.oracle.com (Sentrion-MTA-4.2.2/Sentrion-MTA-4.2.2) with ESMTP id q9TFbXBv028368 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Mon, 29 Oct 2012 15:37:34 GMT Received: from acsmt358.oracle.com (acsmt358.oracle.com [141.146.40.158]) by ucsinet21.oracle.com (8.14.4+Sun/8.14.4) with ESMTP id q9TFbWJY021757 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Mon, 29 Oct 2012 15:37:33 GMT Received: from abhmt120.oracle.com (abhmt120.oracle.com [141.146.116.72]) by acsmt358.oracle.com (8.12.11.20060308/8.12.11) with ESMTP id q9TFbWrB031243; Mon, 29 Oct 2012 10:37:32 -0500 Received: from dradamslap1 (/130.35.178.8) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Mon, 29 Oct 2012 08:37:31 -0700 From: "Drew Adams" To: "'Chong Yidong'" References: <87fw4xd0bv.fsf@gnu.org> Subject: RE: bug#12705: 24.2.50; `Info-complete-menu-item' should use `add-to-list', not `push', to prevent duplicates Date: Mon, 29 Oct 2012 08:37:30 -0700 Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Mailer: Microsoft Office Outlook 11 In-Reply-To: <87fw4xd0bv.fsf@gnu.org> Thread-Index: Ac21wmjKhrNENPnGRuumkyNe8bkJgAAKE8bw X-MimeOLE: Produced By Microsoft MimeOLE V6.00.2900.6157 X-Source-IP: ucsinet21.oracle.com [156.151.31.93] X-Spam-Score: 0.2 (/) X-Debbugs-Envelope-To: 12705 Cc: 12705-done@debbugs.gnu.org, 12705@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: 0.2 (/) > Sounds reasonable. Done in trunk, using delete-dups instead of > add-to-list (in case info.el switches to lexical binding). Thx. Just curious - how would add-to-list interfere with lexical binding (or vice versa)? Seems odd that we would add and then delete, instead of adding only if not present, just to dance around (the possibility of) lexical binding. To be clear, I have no objection at all - nothing wrong with adding and then deleting. I'd just like to understand the problem being avoided. From debbugs-submit-bounces@debbugs.gnu.org Mon Oct 29 12:52:01 2012 Received: (at 12705) by debbugs.gnu.org; 29 Oct 2012 16:52:01 +0000 Received: from localhost ([127.0.0.1]:38392 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TSsZE-0007Q9-QI for submit@debbugs.gnu.org; Mon, 29 Oct 2012 12:52:01 -0400 Received: from pruche.dit.umontreal.ca ([132.204.246.22]:41017) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TSsZB-0007Pv-1I; Mon, 29 Oct 2012 12:51:58 -0400 Received: from faina.iro.umontreal.ca (lechon.iro.umontreal.ca [132.204.27.242]) by pruche.dit.umontreal.ca (8.14.1/8.14.1) with ESMTP id q9TGnS8k012445; Mon, 29 Oct 2012 12:49:28 -0400 Received: by faina.iro.umontreal.ca (Postfix, from userid 20848) id 4552BB4278; Mon, 29 Oct 2012 12:49:28 -0400 (EDT) From: Stefan Monnier To: "Drew Adams" Subject: Re: bug#12705: 24.2.50; `Info-complete-menu-item' should use `add-to-list', not `push', to prevent duplicates Message-ID: References: <87fw4xd0bv.fsf@gnu.org> Date: Mon, 29 Oct 2012 12:49:28 -0400 In-Reply-To: (Drew Adams's message of "Mon, 29 Oct 2012 08:37:30 -0700") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-NAI-Spam-Flag: NO X-NAI-Spam-Level: X-NAI-Spam-Threshold: 5 X-NAI-Spam-Score: 0.2 X-NAI-Spam-Rules: 2 Rules triggered GEN_SPAM_FEATRE=0.2, RV4386=0 X-NAI-Spam-Version: 2.2.0.9309 : core <4386> : streams <847813> : uri <1255130> X-Spam-Score: -1.5 (-) X-Debbugs-Envelope-To: 12705 Cc: 'Chong Yidong' , 12705-done@debbugs.gnu.org, 12705@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.8 (--) >> Sounds reasonable. Done in trunk, using delete-dups instead of >> add-to-list (in case info.el switches to lexical binding). Isn't it better to use cl-pushnew? Stefan From unknown Tue Jun 24 05:11:31 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Tue, 27 Nov 2012 12:24:03 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator