From unknown Sun Jun 22 03:48:55 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#12697 <12697@debbugs.gnu.org> To: bug#12697 <12697@debbugs.gnu.org> Subject: Status: 24.2; Emacs crashes when using it as the commit editor for git Reply-To: bug#12697 <12697@debbugs.gnu.org> Date: Sun, 22 Jun 2025 10:48:55 +0000 retitle 12697 24.2; Emacs crashes when using it as the commit editor for git reassign 12697 emacs submitter 12697 Matthew Leach severity 12697 important tag 12697 patch thanks From debbugs-submit-bounces@debbugs.gnu.org Sun Oct 21 21:56:37 2012 Received: (at submit) by debbugs.gnu.org; 22 Oct 2012 01:56:37 +0000 Received: from localhost ([127.0.0.1]:54743 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TQ7Fr-0003O9-Ho for submit@debbugs.gnu.org; Sun, 21 Oct 2012 21:56:37 -0400 Received: from eggs.gnu.org ([208.118.235.92]:48490) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TQ20I-0004KX-GS for submit@debbugs.gnu.org; Sun, 21 Oct 2012 16:20:11 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TQ1yX-0003dM-Ld for submit@debbugs.gnu.org; Sun, 21 Oct 2012 16:18:22 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_HI autolearn=unavailable version=3.3.2 Received: from lists.gnu.org ([208.118.235.17]:53149) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TQ1yX-0003dA-Ii for submit@debbugs.gnu.org; Sun, 21 Oct 2012 16:18:21 -0400 Received: from eggs.gnu.org ([208.118.235.92]:48809) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TQ1yW-0003Hv-5j for bug-gnu-emacs@gnu.org; Sun, 21 Oct 2012 16:18:21 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TQ1yU-0003bP-GK for bug-gnu-emacs@gnu.org; Sun, 21 Oct 2012 16:18:20 -0400 Received: from anakin.london.02.net ([87.194.255.134]:58373) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TQ1yU-0003aT-6U for bug-gnu-emacs@gnu.org; Sun, 21 Oct 2012 16:18:18 -0400 Received: from mail.mattleach.net (93.97.29.167) by anakin.london.02.net (8.5.140) id 4FED9D1502ACEE7C for bug-gnu-emacs@gnu.org; Sun, 21 Oct 2012 21:18:16 +0100 Received: by mail.mattleach.net (Postfix, from userid 99) id 69D497EC27; Sun, 21 Oct 2012 21:18:19 +0100 (BST) Received: from matt-laptop (matt-laptop.leach.local [192.168.0.20]) by mail.mattleach.net (Postfix) with ESMTPSA id 157DD7EC03 for ; Sun, 21 Oct 2012 21:18:16 +0100 (BST) From: Matthew Leach To: bug-gnu-emacs@gnu.org Subject: 24.2; Emacs crashes when using it as the commit editor for git Date: Sun, 21 Oct 2012 21:17:50 +0100 Message-ID: <87vce38tqp.fsf@matt-laptop.i-did-not-set--mail-host-address--so-tickle-me> MIME-Version: 1.0 Content-Type: text/plain X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-Received-From: 208.118.235.17 X-Spam-Score: -6.9 (------) X-Debbugs-Envelope-To: submit X-Mailman-Approved-At: Sun, 21 Oct 2012 21:56:34 -0400 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -6.9 (------) When I use Emacs as the editor for commit messages in git, by way of setting the EDITOR environment variable, i.e. "export EDITOR='emacs -nw '" in my .bashrc, if I press C-g when Emacs opens this causes Emacs to crash and not shut down correctly as the console is not reset properly and text from the buffer remains on the screen when I am returned to a terminal prompt. I am using git version 1.7.12.4 In GNU Emacs 24.2.1 (x86_64-unknown-linux-gnu, GTK+ Version 3.4.4) of 2012-08-28 on shaun Windowing system distributor `The X.Org Foundation', version 11.0.11300000 Configured using: `configure '--prefix=/usr' '--sysconfdir=/etc' '--libexecdir=/usr/lib' '--localstatedir=/var' '--with-x-toolkit=gtk3' '--with-xft' 'CFLAGS=-march=x86-64 -mtune=generic -O2 -pipe -fstack-protector --param=ssp-buffer-size=4 -D_FORTIFY_SOURCE=2' 'LDFLAGS=-Wl,-O1,--sort-common,--as-needed,-z,relro'' Important settings: value of $LC_ALL: nil value of $LC_COLLATE: nil value of $LC_CTYPE: nil value of $LC_MESSAGES: nil value of $LC_MONETARY: nil value of $LC_NUMERIC: nil value of $LC_TIME: nil value of $LANG: en_GB.UTF-8 value of $XMODIFIERS: nil locale-coding-system: utf-8-unix default enable-multibyte-characters: t Major mode: Fundamental Minor modes in effect: show-paren-mode: t tooltip-mode: t mouse-wheel-mode: t tool-bar-mode: t menu-bar-mode: t file-name-shadow-mode: t global-font-lock-mode: t blink-cursor-mode: t auto-composition-mode: t auto-encryption-mode: t auto-compression-mode: t line-number-mode: t transient-mark-mode: t Recent input: Recent messages: For information about GNU Emacs and the GNU system, type C-h C-a. Load-path shadows: None found. Features: (shadow sort gnus-util mail-extr emacsbug message idna format-spec rfc822 mml easymenu mml-sec mm-decode mm-bodies mm-encode mail-parse rfc2231 mailabbrev gmm-utils mailheader sendmail regexp-opt rfc2047 rfc2045 ietf-drums mm-util mail-prsvr mail-utils edmacro kmacro tango-dark-theme paren ido time-date tooltip ediff-hook vc-hooks lisp-float-type mwheel x-win x-dnd tool-bar dnd fontset image fringe lisp-mode register page menu-bar rfn-eshadow timer select scroll-bar mouse jit-lock font-lock syntax facemenu font-core frame cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean japanese hebrew greek romanian slovak czech european ethiopic indian cyrillic chinese case-table epa-hook jka-cmpr-hook help simple abbrev minibuffer loaddefs button faces cus-face files text-properties overlay sha1 md5 base64 format env code-pages mule custom widget hashtable-print-readable backquote make-network-process dbusbind dynamic-setting system-font-setting font-render-setting move-toolbar gtk x-toolkit x multi-tty emacs) From debbugs-submit-bounces@debbugs.gnu.org Mon Oct 22 04:28:30 2012 Received: (at 12697) by debbugs.gnu.org; 22 Oct 2012 08:28:30 +0000 Received: from localhost ([127.0.0.1]:54951 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TQDN8-0005Jy-AM for submit@debbugs.gnu.org; Mon, 22 Oct 2012 04:28:30 -0400 Received: from mail-out.m-online.net ([212.18.0.10]:38268) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TQDN4-0005Jl-P8 for 12697@debbugs.gnu.org; Mon, 22 Oct 2012 04:28:29 -0400 Received: from frontend1.mail.m-online.net (frontend1.mail.intern.m-online.net [192.168.8.180]) by mail-out.m-online.net (Postfix) with ESMTP id 3XlW6P4Sg8z3hhkk; Mon, 22 Oct 2012 10:26:36 +0200 (CEST) X-Auth-Info: EVddZ16dHa0fX1OYbq7pxx+kwP1iyse72Ii0KGYeWGY= Received: from igel.home (ppp-93-104-136-111.dynamic.mnet-online.de [93.104.136.111]) by mail.mnet-online.de (Postfix) with ESMTPA id 3XlW6M6sKSzbbhq; Mon, 22 Oct 2012 10:26:35 +0200 (CEST) Received: by igel.home (Postfix, from userid 501) id A4100CA2A4; Mon, 22 Oct 2012 10:26:35 +0200 (CEST) From: Andreas Schwab To: Matthew Leach Subject: Re: bug#12697: 24.2; Emacs crashes when using it as the commit editor for git References: <87vce38tqp.fsf@matt-laptop.i-did-not-set--mail-host-address--so-tickle-me> X-Yow: YOW!! The land of the rising SONY!! Date: Mon, 22 Oct 2012 10:26:35 +0200 In-Reply-To: <87vce38tqp.fsf@matt-laptop.i-did-not-set--mail-host-address--so-tickle-me> (Matthew Leach's message of "Sun, 21 Oct 2012 21:17:50 +0100") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.8 (/) X-Debbugs-Envelope-To: 12697 Cc: 12697@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -0.0 (/) Matthew Leach writes: > When I use Emacs as the editor for commit messages in git, by way of > setting the EDITOR environment variable, i.e. "export EDITOR='emacs -nw > '" in my .bashrc, if I press C-g when Emacs opens this causes Emacs to C-g in emacs -nw is equivalent to SIGINT on the controlling terminal. This causes all processes in the same process group to receive SIGINT, which includes the parent git process, now that emacs no longer puts itself and the terminal into its own process group. Andreas. -- Andreas Schwab, schwab@linux-m68k.org GPG Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5 "And now for something completely different." From debbugs-submit-bounces@debbugs.gnu.org Mon Oct 22 13:18:05 2012 Received: (at 12697) by debbugs.gnu.org; 22 Oct 2012 17:18:05 +0000 Received: from localhost ([127.0.0.1]:56154 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TQLdc-0000A8-UH for submit@debbugs.gnu.org; Mon, 22 Oct 2012 13:18:05 -0400 Received: from mtaout21.012.net.il ([80.179.55.169]:39834) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TQLda-00009Z-Rc for 12697@debbugs.gnu.org; Mon, 22 Oct 2012 13:18:03 -0400 Received: from conversion-daemon.a-mtaout21.012.net.il by a-mtaout21.012.net.il (HyperSendmail v2007.08) id <0MCB00K00191SV00@a-mtaout21.012.net.il> for 12697@debbugs.gnu.org; Mon, 22 Oct 2012 19:15:23 +0200 (IST) Received: from HOME-C4E4A596F7 ([87.69.4.28]) by a-mtaout21.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0MCB00KFI19NOZ40@a-mtaout21.012.net.il>; Mon, 22 Oct 2012 19:15:23 +0200 (IST) Date: Mon, 22 Oct 2012 19:15:19 +0200 From: Eli Zaretskii Subject: Re: bug#12697: 24.2; Emacs crashes when using it as the commit editor for git In-reply-to: X-012-Sender: halo1@inter.net.il To: Andreas Schwab Message-id: <83k3uictso.fsf@gnu.org> References: <87vce38tqp.fsf@matt-laptop.i-did-not-set--mail-host-address--so-tickle-me> X-Spam-Score: 1.5 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has identified this incoming email as possible spam. The original message has been attached to this so you can view it (if it isn't spam) or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: > From: Andreas Schwab > Date: Mon, 22 Oct 2012 10:26:35 +0200 > Cc: 12697@debbugs.gnu.org > > C-g in emacs -nw is equivalent to SIGINT on the controlling terminal. > This causes all processes in the same process group to receive SIGINT, > which includes the parent git process [...] Content analysis details: (1.5 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at http://www.dnswl.org/, no trust [80.179.55.169 listed in list.dnswl.org] 0.7 SPF_SOFTFAIL SPF: sender does not match SPF record (softfail) 0.8 BAYES_50 BODY: Bayes spam probability is 40 to 60% [score: 0.5000] X-Debbugs-Envelope-To: 12697 Cc: matthew@mattleach.net, 12697@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list Reply-To: Eli Zaretskii List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: 1.5 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has identified this incoming email as possible spam. The original message has been attached to this so you can view it (if it isn't spam) or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: > From: Andreas Schwab > Date: Mon, 22 Oct 2012 10:26:35 +0200 > Cc: 12697@debbugs.gnu.org > > C-g in emacs -nw is equivalent to SIGINT on the controlling terminal. > This causes all processes in the same process group to receive SIGINT, > which includes the parent git process [...] Content analysis details: (1.5 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at http://www.dnswl.org/, no trust [80.179.55.169 listed in list.dnswl.org] 0.7 SPF_SOFTFAIL SPF: sender does not match SPF record (softfail) 0.8 BAYES_50 BODY: Bayes spam probability is 40 to 60% [score: 0.5000] > From: Andreas Schwab > Date: Mon, 22 Oct 2012 10:26:35 +0200 > Cc: 12697@debbugs.gnu.org > > C-g in emacs -nw is equivalent to SIGINT on the controlling terminal. > This causes all processes in the same process group to receive SIGINT, > which includes the parent git process Shouldn't git block SIGINT when it invokes $EDITOR? > now that emacs no longer puts itself and the terminal into its own > process group. Did we have good reason to stop doing that? From debbugs-submit-bounces@debbugs.gnu.org Mon Oct 22 13:41:49 2012 Received: (at 12697) by debbugs.gnu.org; 22 Oct 2012 17:41:49 +0000 Received: from localhost ([127.0.0.1]:56184 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TQM0b-0000zk-3q for submit@debbugs.gnu.org; Mon, 22 Oct 2012 13:41:49 -0400 Received: from mail-out.m-online.net ([212.18.0.10]:34117) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TQM0Y-0000zY-Bc for 12697@debbugs.gnu.org; Mon, 22 Oct 2012 13:41:47 -0400 Received: from frontend1.mail.m-online.net (frontend1.mail.intern.m-online.net [192.168.8.180]) by mail-out.m-online.net (Postfix) with ESMTP id 3XllNr6xrGz3hhjc; Mon, 22 Oct 2012 19:39:56 +0200 (CEST) X-Auth-Info: qv1vaUZfvDiT2NSzu7OcPz+ti+gKeqsgyEUpyHW221g= Received: from igel.home (ppp-93-104-136-111.dynamic.mnet-online.de [93.104.136.111]) by mail.mnet-online.de (Postfix) with ESMTPA id 3XllNr4rQmzbbcm; Mon, 22 Oct 2012 19:39:56 +0200 (CEST) Received: by igel.home (Postfix, from userid 501) id 23CA2112961; Mon, 22 Oct 2012 19:39:56 +0200 (CEST) From: Andreas Schwab To: Eli Zaretskii Subject: Re: bug#12697: 24.2; Emacs crashes when using it as the commit editor for git References: <87vce38tqp.fsf@matt-laptop.i-did-not-set--mail-host-address--so-tickle-me> <83k3uictso.fsf@gnu.org> X-Yow: .. I think I'd better go back to my DESK and toy with a few common MISAPPREHENSIONS... Date: Mon, 22 Oct 2012 19:39:55 +0200 In-Reply-To: <83k3uictso.fsf@gnu.org> (Eli Zaretskii's message of "Mon, 22 Oct 2012 19:15:19 +0200") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.8 (/) X-Debbugs-Envelope-To: 12697 Cc: matthew@mattleach.net, 12697@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -1.9 (-) Eli Zaretskii writes: >> C-g in emacs -nw is equivalent to SIGINT on the controlling terminal. >> This causes all processes in the same process group to receive SIGINT, >> which includes the parent git process > > Shouldn't git block SIGINT when it invokes $EDITOR? Maybe. Perhaps the OP should report it to the git list. >> now that emacs no longer puts itself and the terminal into its own >> process group. > > Did we have good reason to stop doing that? IMHO no. All the BSD_PGRPS stuff was removed on the premise that it wasn't used any more, but disabling BSD_PGRPS in s/gnu-linux.h was already questionable. Andreas. -- Andreas Schwab, schwab@linux-m68k.org GPG Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5 "And now for something completely different." From debbugs-submit-bounces@debbugs.gnu.org Mon Oct 22 16:25:08 2012 Received: (at 12697) by debbugs.gnu.org; 22 Oct 2012 20:25:08 +0000 Received: from localhost ([127.0.0.1]:56289 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TQOYd-0005B0-Mm for submit@debbugs.gnu.org; Mon, 22 Oct 2012 16:25:08 -0400 Received: from mtaout23.012.net.il ([80.179.55.175]:39774) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TQOYZ-0005AA-Sm for 12697@debbugs.gnu.org; Mon, 22 Oct 2012 16:25:05 -0400 Received: from conversion-daemon.a-mtaout23.012.net.il by a-mtaout23.012.net.il (HyperSendmail v2007.08) id <0MCB00L009UUEH00@a-mtaout23.012.net.il> for 12697@debbugs.gnu.org; Mon, 22 Oct 2012 22:22:59 +0200 (IST) Received: from HOME-C4E4A596F7 ([87.69.4.28]) by a-mtaout23.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0MCB00LFB9YA56A0@a-mtaout23.012.net.il>; Mon, 22 Oct 2012 22:22:59 +0200 (IST) Date: Mon, 22 Oct 2012 22:22:55 +0200 From: Eli Zaretskii Subject: Re: bug#12697: 24.2; Emacs crashes when using it as the commit editor for git In-reply-to: X-012-Sender: halo1@inter.net.il To: Andreas Schwab Message-id: <83bofucl40.fsf@gnu.org> References: <87vce38tqp.fsf@matt-laptop.i-did-not-set--mail-host-address--so-tickle-me> <83k3uictso.fsf@gnu.org> X-Spam-Score: 1.5 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has identified this incoming email as possible spam. The original message has been attached to this so you can view it (if it isn't spam) or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: > From: Andreas Schwab > Cc: matthew@mattleach.net, 12697@debbugs.gnu.org > Date: Mon, 22 Oct 2012 19:39:55 +0200 > > >> now that emacs no longer puts itself and the terminal into its own > >> process group. > > > > Did we have good reason to stop doing that? > > IMHO no. All the BSD_PGRPS stuff was removed on the premise that it > wasn't used any more, but disabling BSD_PGRPS in s/gnu-linux.h was > already questionable. [...] Content analysis details: (1.5 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at http://www.dnswl.org/, no trust [80.179.55.175 listed in list.dnswl.org] 0.7 SPF_SOFTFAIL SPF: sender does not match SPF record (softfail) 0.8 BAYES_50 BODY: Bayes spam probability is 40 to 60% [score: 0.5000] X-Debbugs-Envelope-To: 12697 Cc: matthew@mattleach.net, 12697@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list Reply-To: Eli Zaretskii List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: 1.5 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has identified this incoming email as possible spam. The original message has been attached to this so you can view it (if it isn't spam) or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: > From: Andreas Schwab > Cc: matthew@mattleach.net, 12697@debbugs.gnu.org > Date: Mon, 22 Oct 2012 19:39:55 +0200 > > >> now that emacs no longer puts itself and the terminal into its own > >> process group. > > > > Did we have good reason to stop doing that? > > IMHO no. All the BSD_PGRPS stuff was removed on the premise that it > wasn't used any more, but disabling BSD_PGRPS in s/gnu-linux.h was > already questionable. [...] Content analysis details: (1.5 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at http://www.dnswl.org/, no trust [80.179.55.175 listed in list.dnswl.org] 0.7 SPF_SOFTFAIL SPF: sender does not match SPF record (softfail) 0.8 BAYES_50 BODY: Bayes spam probability is 40 to 60% [score: 0.5000] > From: Andreas Schwab > Cc: matthew@mattleach.net, 12697@debbugs.gnu.org > Date: Mon, 22 Oct 2012 19:39:55 +0200 > > >> now that emacs no longer puts itself and the terminal into its own > >> process group. > > > > Did we have good reason to stop doing that? > > IMHO no. All the BSD_PGRPS stuff was removed on the premise that it > wasn't used any more, but disabling BSD_PGRPS in s/gnu-linux.h was > already questionable. Come think about it, why not stop depending on SIGINT for quitting? We already do that in GUI session (AFAIU), so why should TTY frames be different? We could just detect C-g in the SIGIO handler, no? If this makes sense, then this whole issue would go away. Of course, we will then lose the "emergency exit" feature, but since core dumps are reportedly disabled on many systems anyway, that doesn't sound like too much of a loss, and GUI sessions already cannot use it anyway. From debbugs-submit-bounces@debbugs.gnu.org Mon Oct 22 17:36:08 2012 Received: (at 12697) by debbugs.gnu.org; 22 Oct 2012 21:36:08 +0000 Received: from localhost ([127.0.0.1]:56367 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TQPfL-00074p-8z for submit@debbugs.gnu.org; Mon, 22 Oct 2012 17:36:07 -0400 Received: from mail-out.m-online.net ([212.18.0.9]:55072) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TQPfI-00074h-PE for 12697@debbugs.gnu.org; Mon, 22 Oct 2012 17:36:06 -0400 Received: from frontend1.mail.m-online.net (unknown [192.168.8.180]) by mail-out.m-online.net (Postfix) with ESMTP id 3XlrbB17HDz4KK3f; Mon, 22 Oct 2012 23:34:14 +0200 (CEST) X-Auth-Info: CmoXWz6FWw4EbKERVvHMFVYBUjUgtY8k/bZu9UZsP6s= Received: from igel.home (ppp-93-104-136-111.dynamic.mnet-online.de [93.104.136.111]) by mail.mnet-online.de (Postfix) with ESMTPA id 3XlrbB0XD4zbbgB; Mon, 22 Oct 2012 23:34:14 +0200 (CEST) Received: by igel.home (Postfix, from userid 501) id AF8B0112961; Mon, 22 Oct 2012 23:34:13 +0200 (CEST) From: Andreas Schwab To: Eli Zaretskii Subject: Re: bug#12697: 24.2; Emacs crashes when using it as the commit editor for git References: <87vce38tqp.fsf@matt-laptop.i-did-not-set--mail-host-address--so-tickle-me> <83k3uictso.fsf@gnu.org> <83bofucl40.fsf@gnu.org> X-Yow: If I felt any more SOPHISTICATED I would DIE of EMBARRASSMENT! Date: Mon, 22 Oct 2012 23:34:13 +0200 In-Reply-To: <83bofucl40.fsf@gnu.org> (Eli Zaretskii's message of "Mon, 22 Oct 2012 22:22:55 +0200") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 12697 Cc: matthew@mattleach.net, 12697@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -1.9 (-) Eli Zaretskii writes: > We could just detect C-g in the SIGIO handler, no? That works already (just disable ISIG in init_sys_modes to try and see). Andreas. -- Andreas Schwab, schwab@linux-m68k.org GPG Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5 "And now for something completely different." From debbugs-submit-bounces@debbugs.gnu.org Sat Oct 27 01:33:46 2012 Received: (at 12697) by debbugs.gnu.org; 27 Oct 2012 05:33:46 +0000 Received: from localhost ([127.0.0.1]:35380 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TRz1l-0008PY-A0 for submit@debbugs.gnu.org; Sat, 27 Oct 2012 01:33:46 -0400 Received: from smtp.cs.ucla.edu ([131.179.128.62]:50475) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TRz1h-0008PP-HZ for 12697@debbugs.gnu.org; Sat, 27 Oct 2012 01:33:43 -0400 Received: from localhost (localhost.localdomain [127.0.0.1]) by smtp.cs.ucla.edu (Postfix) with ESMTP id 01745A60031; Fri, 26 Oct 2012 22:31:28 -0700 (PDT) X-Virus-Scanned: amavisd-new at smtp.cs.ucla.edu Received: from smtp.cs.ucla.edu ([127.0.0.1]) by localhost (smtp.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id IhAVXA8p9n9a; Fri, 26 Oct 2012 22:31:26 -0700 (PDT) Received: from [192.168.1.3] (pool-108-23-119-2.lsanca.fios.verizon.net [108.23.119.2]) by smtp.cs.ucla.edu (Postfix) with ESMTPSA id BBB58A6002C; Fri, 26 Oct 2012 22:31:26 -0700 (PDT) Message-ID: <508B71A9.40509@cs.ucla.edu> Date: Fri, 26 Oct 2012 22:31:21 -0700 From: Paul Eggert Organization: UCLA Computer Science Department User-Agent: Mozilla/5.0 (X11; Linux i686; rv:16.0) Gecko/20121011 Thunderbird/16.0.1 MIME-Version: 1.0 To: 12697@debbugs.gnu.org Subject: Re: Emacs crashes when using it as the commit editor for git Content-Type: multipart/mixed; boundary="------------060303060202050504090500" X-Spam-Score: -4.9 (----) X-Debbugs-Envelope-To: 12697 Cc: Matthew Leach , Eli Zaretskii , Andreas Schwab X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -4.9 (----) This is a multi-part message in MIME format. --------------060303060202050504090500 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit I tried Andreas's suggestion of disabling ISIG, but this didn't work on Solaris, and it doesn't look like it'd work on any host where USABLE_SIGIO is false. Instead, how about the attached patch? It reenables the BSD_PGRPS idea, although reimplemented, as the old code can't easily be resurrected as-is. I haven't thought about how this affects the Windows port, so I'll CC: this to Eli. --------------060303060202050504090500 Content-Type: text/plain; charset=UTF-8; name="git-commit.txt" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="git-commit.txt" PT09IG1vZGlmaWVkIGZpbGUgJ3NyYy9DaGFuZ2VMb2cnCi0tLSBzcmMvQ2hhbmdlTG9nCTIw MTItMTAtMjYgMDk6NDY6NDYgKzAwMDAKKysrIHNyYy9DaGFuZ2VMb2cJMjAxMi0xMC0yNyAw NToyMjo1NCArMDAwMApAQCAtMSwzICsxLDI0IEBACisyMDEyLTEwLTI3ICBQYXVsIEVnZ2Vy dCAgPGVnZ2VydEBjcy51Y2xhLmVkdT4KKworCUZpeCBjcmFzaCB3aGVuIHVzaW5nIEVtYWNz IGFzIGNvbW1pdCBlZGl0b3IgZm9yIGdpdCAoQnVnIzEyNjk3KS4KKwkqIGNhbGxwcm9jLmMg KHNldHBncnApOiBSZW1vdmUgbWFjcm8sIGFzIHdlIG5vdyB1c2Ugc2V0cGdpZAorCWFuZCBp dCBpcyBjb25maWd1cmVkIGluIGNvbmZfcG9zdC5oLgorCShGY2FsbF9wcm9jZXNzKTogRG9u J3QgaW52b2tlIGJvdGggc2V0c2lkIGFuZCBzZXRwZ2lkOyB0aGUgZm9ybWVyCisJaXMgZW5v dWdoLCBpZiBpdCBleGlzdHMuCisJKiBjYWxscHJvYy5jIChGY2FsbF9wcm9jZXNzLCBjaGls ZF9zZXR1cCk6CisJKiBwcm9jZXNzLmMgKGNyZWF0ZV9wcm9jZXNzKTogVXNlIHNldHBnaWQu CisJKiBjb25mX3Bvc3QuaCAoc2V0cGdpZCkgWyFIQVZFX1NFVFBHSURdOiBOZXcgbWFjcm8s IHdoaWNoIHN1YnN0aXR1dGVzCisJZm9yIHRoZSByZWFsIHRoaW5nLgorCSogZGlzcG5ldy5j IChpbml0X2Rpc3BsYXkpOiBJbml0aWFsaXplIHRoZSBmb3JlZ3JvdW5kIGdyb3VwCisJaWYg d2UgYXJlIHJ1bm5pbmcgYSB0dHkgZGlzcGxheS4KKwkqIGVtYWNzLmMgKG1haW4pOiBEbyBu b3Qgd29ycnkgYWJvdXQgc2V0cGdycDsgaW5pdF9kaXNwbGF5IGRvZXMgaXQgbm93LgorCSog bGlzcC5oIChpbml0X2ZvcmVncm91bmRfZ3JvdXApOiBOZXcgZGVjbC4KKwkqIHN5c2RlcC5j IChpbmhlcml0ZWRfcGdyb3VwKTogTmV3IHN0YXRpYyB2YXIuCisJKGluaXRfZm9yZWdyb3Vu ZF9ncm91cCwgdGNzZXRwZ3JwX3dpdGhvdXRfc3RvcHBpbmcpCisJKG5hcnJvd19mb3JlZ3Jv dW5kX2dyb3VwLCB3aWRlbl9mb3JlZ3JvdW5kX2dyb3VwKTogTmV3IGZ1bmN0aW9ucy4KKwko aW5pdF9zeXNfbW9kZXMpOiBOYXJyb3cgZm9yZWdyb3VuZCBncm91cC4KKwkocmVzZXRfc3lz X21vZGVzKTogV2lkZW4gZm9yZWdyb3VuZCBncm91cC4KKwogMjAxMi0xMC0yNiAgRWxpIFph cmV0c2tpaSAgPGVsaXpAZ251Lm9yZz4KIAogCSogdzMyZm5zLmMgKHczMl93bmRfcHJvYykg PFdNX01PVVNFTU9WRT46IERvbid0IGVuYWJsZSB0cmFja2luZyBvZgoKPT09IG1vZGlmaWVk IGZpbGUgJ3NyYy9jYWxscHJvYy5jJwotLS0gc3JjL2NhbGxwcm9jLmMJMjAxMi0xMC0xOSAx OToyNToxOCArMDAwMAorKysgc3JjL2NhbGxwcm9jLmMJMjAxMi0xMC0yNyAwNToyMjo1NCAr MDAwMApAQCAtNjQsMTMgKzY0LDYgQEAKICNpbmNsdWRlICJuc3Rlcm0uaCIKICNlbmRpZgog Ci0jaWZkZWYgSEFWRV9TRVRQR0lECi0jaWYgIWRlZmluZWQgKFVTRykKLSN1bmRlZiBzZXRw Z3JwCi0jZGVmaW5lIHNldHBncnAgc2V0cGdpZAotI2VuZGlmCi0jZW5kaWYKLQogLyogUGF0 dGVybiB1c2VkIGJ5IGNhbGwtcHJvY2Vzcy1yZWdpb24gdG8gbWFrZSB0ZW1wIGZpbGVzLiAg Ki8KIHN0YXRpYyBMaXNwX09iamVjdCBWdGVtcF9maWxlX25hbWVfcGF0dGVybjsKIApAQCAt NjE4LDE0ICs2MTEsMTIgQEAKICAgICAgIHsKIAlpZiAoZmRbMF0gPj0gMCkKIAkgIGVtYWNz X2Nsb3NlIChmZFswXSk7CisKICNpZmRlZiBIQVZFX1NFVFNJRAogCXNldHNpZCAoKTsKKyNl bHNlCisJc2V0cGdpZCAoMCwgMCk7CiAjZW5kaWYKLSNpZiBkZWZpbmVkIChVU0cpCi0Jc2V0 cGdycCAoKTsKLSNlbHNlCi0Jc2V0cGdycCAocGlkLCBwaWQpOwotI2VuZGlmIC8qIFVTRyAq LwogCiAJLyogRW1hY3MgaWdub3JlcyBTSUdQSVBFLCBidXQgdGhlIGNoaWxkIHNob3VsZCBu b3QuICAqLwogCXNpZ25hbCAoU0lHUElQRSwgU0lHX0RGTCk7CkBAIC0xMjk1LDEzICsxMjg2 LDkgQEAKICAgaWYgKGVyciAhPSBpbiAmJiBlcnIgIT0gb3V0KQogICAgIGVtYWNzX2Nsb3Nl IChlcnIpOwogCi0jaWYgZGVmaW5lZCAoVVNHKQotI2lmbmRlZiBTRVRQR1JQX1JFTEVBU0VT X0NUVFkKLSAgc2V0cGdycCAoKTsJCQkvKiBObyBhcmd1bWVudHMgYnV0IGVxdWl2YWxlbnQg aW4gdGhpcyBjYXNlICovCisjaWYgZGVmaW5lZCBIQVZFX1NFVFBHSUQgfHwgISAoZGVmaW5l ZCBVU0cgJiYgZGVmaW5lZCBTRVRQR1JQX1JFTEVBU0VTX0NUVFkpCisgIHNldHBnaWQgKHBp ZCwgcGlkKTsKICNlbmRpZgotI2Vsc2UgLyogbm90IFVTRyAqLwotICBzZXRwZ3JwIChwaWQs IHBpZCk7Ci0jZW5kaWYgLyogbm90IFVTRyAqLwogCiAgIC8qIHNldHBncnBfb2ZfdHR5IGlz IGluY29ycmVjdCBoZXJlOyBpdCB1c2VzIGlucHV0X2ZkLiAgKi8KICAgdGNzZXRwZ3JwICgw LCBwaWQpOwoKPT09IG1vZGlmaWVkIGZpbGUgJ3NyYy9jb25mX3Bvc3QuaCcKLS0tIHNyYy9j b25mX3Bvc3QuaAkyMDEyLTEwLTE5IDE5OjI1OjE4ICswMDAwCisrKyBzcmMvY29uZl9wb3N0 LmgJMjAxMi0xMC0yNyAwNTowNzoxNyArMDAwMApAQCAtMTEyLDYgKzExMiwxNCBAQAogI2Vu ZGlmCiAvKiBFbmQgb2YgZ251bGliLXJlbGF0ZWQgc3R1ZmYuICAqLwogCisjaWZuZGVmIEhB VkVfU0VUUEdJRAorIyBpZmRlZiBVU0cKKyMgIGRlZmluZSBzZXRwZ2lkKHBpZCwgcGdpZCkg c2V0cGdycCAoKQorIyBlbHNlCisjICBkZWZpbmUgc2V0cGdpZChwaWQsIHBnaWQpIHNldHBn cnAgKHBpZCwgcGdpZCkKKyMgZW5kaWYKKyNlbmRpZgorCiAvKiBEZWZpbmUgb25lIG9mIHRo ZXNlIGZvciBlYXNpZXIgY29uZGl0aW9uYWxzLiAgKi8KICNpZmRlZiBIQVZFX1hfV0lORE9X UwogLyogV2UgbmVlZCBhIGxpdHRsZSBleHRyYSBzcGFjZSwgc2VlIC4uLy4uL2xpc3AvbG9h ZHVwLmVsIGFuZCB0aGUKCj09PSBtb2RpZmllZCBmaWxlICdzcmMvZGlzcG5ldy5jJwotLS0g c3JjL2Rpc3BuZXcuYwkyMDEyLTEwLTE3IDE5OjAyOjQ0ICswMDAwCisrKyBzcmMvZGlzcG5l dy5jCTIwMTItMTAtMjcgMDU6MDc6MTcgKzAwMDAKQEAgLTYyODMsNiArNjI4Myw4IEBACiAg ICAgc3RydWN0IHRlcm1pbmFsICp0OwogICAgIHN0cnVjdCBmcmFtZSAqZiA9IFhGUkFNRSAo c2VsZWN0ZWRfZnJhbWUpOwogCisgICAgaW5pdF9mb3JlZ3JvdW5kX2dyb3VwICgpOworCiAg ICAgLyogT3BlbiBhIGRpc3BsYXkgb24gdGhlIGNvbnRyb2xsaW5nIHR0eS4gKi8KICAgICB0 ID0gaW5pdF90dHkgKDAsIHRlcm1pbmFsX3R5cGUsIDEpOyAvKiBFcnJvcnMgYXJlIGZhdGFs LiAqLwogCgo9PT0gbW9kaWZpZWQgZmlsZSAnc3JjL2VtYWNzLmMnCi0tLSBzcmMvZW1hY3Mu YwkyMDEyLTEwLTI1IDA0OjM1OjM5ICswMDAwCisrKyBzcmMvZW1hY3MuYwkyMDEyLTEwLTI3 IDA1OjA3OjE3ICswMDAwCkBAIC0xMDkxLDE5ICsxMDkxLDE0IEBACiAjZW5kaWYgLyogRE9T X05UICovCiAgICAgfQogCi0gIGlmICghIG5vbmludGVyYWN0aXZlKQotICAgIHsKLSNpZiBk ZWZpbmVkIChVU0c1KSAmJiBkZWZpbmVkIChJTlRFUlJVUFRfSU5QVVQpCi0gICAgICBzZXRw Z3JwICgpOwotI2VuZGlmCiAjaWYgZGVmaW5lZCAoSEFWRV9QVEhSRUFEKSAmJiAhZGVmaW5l ZCAoU1lTVEVNX01BTExPQykgJiYgIWRlZmluZWQgKERPVUdfTEVBX01BTExPQykKLSAgICAg IHsKLSAgICAgICAgZXh0ZXJuIHZvaWQgbWFsbG9jX2VuYWJsZV90aHJlYWQgKHZvaWQpOwor ICBpZiAoISBub25pbnRlcmFjdGl2ZSkKKyAgICB7CisgICAgICBleHRlcm4gdm9pZCBtYWxs b2NfZW5hYmxlX3RocmVhZCAodm9pZCk7CiAKLQltYWxsb2NfZW5hYmxlX3RocmVhZCAoKTsK LSAgICAgIH0KKyAgICAgIG1hbGxvY19lbmFibGVfdGhyZWFkICgpOworICAgIH0KICNlbmRp ZgotICAgIH0KIAogICBpbml0X3NpZ25hbHMgKGR1bXBpbmcpOwogCgo9PT0gbW9kaWZpZWQg ZmlsZSAnc3JjL2xpc3AuaCcKLS0tIHNyYy9saXNwLmgJMjAxMi0xMC0yMSAwNzoyMzozNCAr MDAwMAorKysgc3JjL2xpc3AuaAkyMDEyLTEwLTI3IDA1OjA3OjE3ICswMDAwCkBAIC0zNDc0 LDYgKzM0NzQsNyBAQAogZXh0ZXJuIGNoYXIgKmdldF9jdXJyZW50X2Rpcl9uYW1lICh2b2lk KTsKICNlbmRpZgogZXh0ZXJuIHZvaWQgc3R1ZmZfY2hhciAoY2hhciBjKTsKK2V4dGVybiB2 b2lkIGluaXRfZm9yZWdyb3VuZF9ncm91cCAodm9pZCk7CiBleHRlcm4gdm9pZCBpbml0X3Np Z2lvIChpbnQpOwogZXh0ZXJuIHZvaWQgc3lzX3N1YnNoZWxsICh2b2lkKTsKIGV4dGVybiB2 b2lkIHN5c19zdXNwZW5kICh2b2lkKTsKCj09PSBtb2RpZmllZCBmaWxlICdzcmMvcHJvY2Vz cy5jJwotLS0gc3JjL3Byb2Nlc3MuYwkyMDEyLTEwLTE5IDE5OjI1OjE4ICswMDAwCisrKyBz cmMvcHJvY2Vzcy5jCTIwMTItMTAtMjcgMDU6MDc6MTcgKzAwMDAKQEAgLTE3NTksMTIgKzE3 NTksMTAgQEAKICNlbmRpZgogCX0KICNlbHNlIC8qIG5vdCBIQVZFX1NFVFNJRCAqLwotI2lm ZGVmIFVTRwotICAgICAgLyogSXQncyB2ZXJ5IGltcG9ydGFudCB0byBjYWxsIHNldHBncnAg aGVyZSBhbmQgbm8gdGltZQorICAgICAgLyogSXQncyB2ZXJ5IGltcG9ydGFudCB0byBjYWxs IHNldHBnaWQgaGVyZSBhbmQgbm8gdGltZQogCSBhZnRlcndhcmRzLiAgT3RoZXJ3aXNlLCB3 ZSBsb3NlIG91ciBjb250cm9sbGluZyB0dHkgd2hpY2gKIAkgaXMgc2V0IHdoZW4gd2Ugb3Bl biB0aGUgcHR5LiAqLwotICAgICAgc2V0cGdycCAoKTsKLSNlbmRpZiAvKiBVU0cgKi8KKyAg ICAgIHNldHBnaWQgKDAsIDApOwogI2VuZGlmIC8qIG5vdCBIQVZFX1NFVFNJRCAqLwogI2lm IGRlZmluZWQgKExESVNDMSkKICAgICAgIGlmIChwdHlfZmxhZyAmJiB4Zm9ya2luID49IDAp CkBAIC0xODAyLDExICsxODAwLDcgQEAKIAkgIC8qIEluIG9yZGVyIHRvIGdldCBhIGNvbnRy b2xsaW5nIHRlcm1pbmFsIG9uIHNvbWUgdmVyc2lvbnMKIAkgICAgIG9mIEJTRCwgaXQgaXMg bmVjZXNzYXJ5IHRvIHB1dCB0aGUgcHJvY2VzcyBpbiBwZ3JwIDAKIAkgICAgIGJlZm9yZSBp dCBvcGVucyB0aGUgdGVybWluYWwuICAqLwotI2lmZGVmIEhBVkVfU0VUUEdJRAogCSAgc2V0 cGdpZCAoMCwgMCk7Ci0jZWxzZQotCSAgc2V0cGdycCAoMCwgMCk7Ci0jZW5kaWYKICNlbmRp ZgogCX0KICNlbmRpZiAvKiBUSU9DTk9UVFkgKi8KCj09PSBtb2RpZmllZCBmaWxlICdzcmMv c3lzZGVwLmMnCi0tLSBzcmMvc3lzZGVwLmMJMjAxMi0xMC0yNSAwNDozNTozOSArMDAwMAor Kysgc3JjL3N5c2RlcC5jCTIwMTItMTAtMjcgMDU6MDc6MTcgKzAwMDAKQEAgLTY4Myw2ICs2 ODMsNzAgQEAKIH0KIAogDAorLyogU2F2aW5nIGFuZCByZXN0b3JpbmcgdGhlIHByb2Nlc3Mg Z3JvdXAgb2YgRW1hY3MncyB0ZXJtaW5hbC4gICovCisKKy8qIFRoZSBwcm9jZXNzIGdyb3Vw IG9mIHdoaWNoIEVtYWNzIHdhcyBhIG1lbWJlciB3aGVuIGl0IGluaXRpYWxseQorICAgc3Rh cnRlZC4KKworICAgSWYgRW1hY3Mgd2FzIGluIGl0cyBvd24gcHJvY2VzcyBncm91cCAoaS5l LiBpbmhlcml0ZWRfcGdyb3VwID09CisgICBnZXRwaWQgKCkpLCB0aGVuIHdlIGtub3cgd2Un cmUgcnVubmluZyB1bmRlciBhIHNoZWxsIHdpdGggam9iCisgICBjb250cm9sIChFbWFjcyB3 b3VsZCBuZXZlciBiZSBydW4gYXMgcGFydCBvZiBhIHBpcGVsaW5lKS4KKyAgIEV2ZXJ5dGhp bmcgaXMgZmluZS4KKworICAgSWYgRW1hY3Mgd2FzIG5vdCBpbiBpdHMgb3duIHByb2Nlc3Mg Z3JvdXAsIHRoZW4gd2Uga25vdyB3ZSdyZQorICAgcnVubmluZyB1bmRlciBhIHNoZWxsIChv ciBhIGNhbGxlcikgdGhhdCBkb2Vzbid0IGtub3cgaG93IHRvCisgICBzZXBhcmF0ZSBpdHNl bGYgZnJvbSBFbWFjcyAobGlrZSBzaCkuICBFbWFjcyBtdXN0IGJlIGluIGl0cyBvd24KKyAg IHByb2Nlc3MgZ3JvdXAgaW4gb3JkZXIgdG8gcmVjZWl2ZSBTSUdJTyBjb3JyZWN0bHkuICBJ biB0aGlzCisgICBzaXR1YXRpb24sIHdlIHB1dCBvdXJzZWx2ZXMgaW4gb3VyIG93biBwZ3Jv dXAsIGZvcmNpYmx5IHNldCB0aGUKKyAgIHR0eSdzIHBncm91cCB0byBvdXIgcGdyb3VwLCBh bmQgbWFrZSBzdXJlIHRvIHJlc3RvcmUgYW5kIHJlaW5zdGF0ZQorICAgdGhlIHR0eSdzIHBn cm91cCBqdXN0IGxpa2UgYW55IG90aGVyIHRlcm1pbmFsIHNldHRpbmcuICBJZgorICAgaW5o ZXJpdGVkX2dyb3VwIHdhcyBub3QgdGhlIHR0eSdzIHBncm91cCwgdGhlbiB3ZSdsbCBnZXQg YQorICAgU0lHVFRtdW1ibGUgd2hlbiB3ZSB0cnkgdG8gY2hhbmdlIHRoZSB0dHkncyBwZ3Jv dXAsIGFuZCBhIENPTlQgaWYKKyAgIGl0IGdvZXMgZm9yZWdyb3VuZCBpbiB0aGUgZnV0dXJl LCB3aGljaCBpcyB3aGF0IHNob3VsZCBoYXBwZW4uICAqLworCitzdGF0aWMgcGlkX3QgaW5o ZXJpdGVkX3Bncm91cDsKKwordm9pZAoraW5pdF9mb3JlZ3JvdW5kX2dyb3VwICh2b2lkKQor eworICBwaWRfdCBwZ3JwID0gRU1BQ1NfR0VUUEdSUCAoMCk7CisgIGluaGVyaXRlZF9wZ3Jv dXAgPSBnZXRwaWQgKCkgPT0gcGdycCA/IDAgOiBwZ3JwOworfQorCisvKiBTYWZlbHkgc2V0 IGEgY29udHJvbGxpbmcgdGVybWluYWwgRkQncyBwcm9jZXNzIGdyb3VwIHRvIFBHSUQuCisg ICBJZiB3ZSBhcmUgbm90IGluIHRoZSBmb3JlZ3JvdW5kIGFscmVhZHksIFBPU0lYIHJlcXVp cmVzIHRjc2V0cGdycAorICAgdG8gZGVsaXZlciBhIFNJR1RUT1Ugc2lnbmFsLCB3aGljaCB3 b3VsZCBzdG9wIHVzLiAgVGhpcyBpcyBhbgorICAgYW5ub3lhbmNlLCBzbyB0ZW1wb3Jhcmls eSBpZ25vcmUgdGhlIHNpZ25hbC4gICovCitzdGF0aWMgdm9pZAordGNzZXRwZ3JwX3dpdGhv dXRfc3RvcHBpbmcgKGludCBmZCwgcGlkX3QgcGdpZCkKK3sKKyAgc2lnbmFsX2hhbmRsZXJf dCBoYW5kbGVyOworICBibG9ja19pbnB1dCAoKTsKKyAgaGFuZGxlciA9IHNpZ25hbCAoU0lH VFRPVSwgU0lHX0lHTik7CisgIHRjc2V0cGdycCAoZmQsIHBnaWQpOworICBzaWduYWwgKFNJ R1RUT1UsIGhhbmRsZXIpOworICB1bmJsb2NrX2lucHV0ICgpOworfQorCisvKiBTcGxpdCBv ZmYgdGhlIGZvcmVncm91bmQgcHJvY2VzcyBncm91cCB0byBFbWFjcyBhbG9uZS4gIFdoZW4g d2UgYXJlCisgICBpbiB0aGUgZm9yZWdyb3VuZCwgYnV0IG5vdCBzdGFydGVkIGluIG91ciBv d24gcHJvY2VzcyBncm91cCwKKyAgIHJlZGlyZWN0IHRoZSB0dHkgZGV2aWNlIGhhbmRsZSBG RCB0byBwb2ludCB0byBvdXIgb3duIHByb2Nlc3MKKyAgIGdyb3VwLiAgRkQgbXVzdCBiZSB0 aGUgZmlsZSBkZXNjcmlwdG9yIG9mIHRoZSBjb250cm9sbGluZyB0dHkuICAqLworc3RhdGlj IHZvaWQKK25hcnJvd19mb3JlZ3JvdW5kX2dyb3VwIChpbnQgZmQpCit7CisgIGlmIChpbmhl cml0ZWRfcGdyb3VwICYmIHNldHBnaWQgKDAsIDApID09IDApCisgICAgdGNzZXRwZ3JwX3dp dGhvdXRfc3RvcHBpbmcgKGZkLCBnZXRwaWQgKCkpOworfQorCisvKiBTZXQgdGhlIHR0eSB0 byBvdXIgb3JpZ2luYWwgZm9yZWdyb3VuZCBncm91cC4gICovCitzdGF0aWMgdm9pZAord2lk ZW5fZm9yZWdyb3VuZF9ncm91cCAoaW50IGZkKQoreworICBpZiAoaW5oZXJpdGVkX3Bncm91 cCAmJiBzZXRwZ2lkICgwLCBpbmhlcml0ZWRfcGdyb3VwKSA9PSAwKQorICAgIHRjc2V0cGdy cF93aXRob3V0X3N0b3BwaW5nIChmZCwgaW5oZXJpdGVkX3Bncm91cCk7Cit9CisMCiAvKiBH ZXR0aW5nIGFuZCBzZXR0aW5nIGVtYWNzX3R0eSBzdHJ1Y3R1cmVzLiAgKi8KIAogLyogU2V0 ICpUQyB0byB0aGUgcGFyYW1ldGVycyBhc3NvY2lhdGVkIHdpdGggdGhlIHRlcm1pbmFsIEZE LgpAQCAtNzk5LDYgKzg2Myw4IEBACiAgIGlmICghdHR5X291dC0+b3V0cHV0KQogICAgIHJl dHVybjsgICAgICAgICAgICAgICAgICAgICAvKiBUaGUgdHR5IGlzIHN1c3BlbmRlZC4gKi8K IAorICBuYXJyb3dfZm9yZWdyb3VuZF9ncm91cCAoZmlsZW5vICh0dHlfb3V0LT5pbnB1dCkp OworCiAgIGlmICghIHR0eV9vdXQtPm9sZF90dHkpCiAgICAgdHR5X291dC0+b2xkX3R0eSA9 IHhtYWxsb2MgKHNpemVvZiAqdHR5X291dC0+b2xkX3R0eSk7CiAKQEAgLTEyMzEsNiArMTI5 Nyw3IEBACiAgIGRvc190dGNvb2tlZCAoKTsKICNlbmRpZgogCisgIHdpZGVuX2ZvcmVncm91 bmRfZ3JvdXAgKGZpbGVubyAodHR5X291dC0+aW5wdXQpKTsKIH0KIAwKICNpZmRlZiBIQVZF X1BUWVMKCg== --------------060303060202050504090500-- From debbugs-submit-bounces@debbugs.gnu.org Sat Oct 27 01:37:05 2012 Received: (at control) by debbugs.gnu.org; 27 Oct 2012 05:37:05 +0000 Received: from localhost ([127.0.0.1]:35384 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TRz4y-0008UC-Hk for submit@debbugs.gnu.org; Sat, 27 Oct 2012 01:37:04 -0400 Received: from smtp.cs.ucla.edu ([131.179.128.62]:50601) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TRz4x-0008U6-99 for control@debbugs.gnu.org; Sat, 27 Oct 2012 01:37:03 -0400 Received: from localhost (localhost.localdomain [127.0.0.1]) by smtp.cs.ucla.edu (Postfix) with ESMTP id 28B46A60031 for ; Fri, 26 Oct 2012 22:34:50 -0700 (PDT) X-Virus-Scanned: amavisd-new at smtp.cs.ucla.edu Received: from smtp.cs.ucla.edu ([127.0.0.1]) by localhost (smtp.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id yxsUxUcbeghV for ; Fri, 26 Oct 2012 22:34:49 -0700 (PDT) Received: from [192.168.1.3] (pool-108-23-119-2.lsanca.fios.verizon.net [108.23.119.2]) by smtp.cs.ucla.edu (Postfix) with ESMTPSA id DDBB6A6002C for ; Fri, 26 Oct 2012 22:34:49 -0700 (PDT) Message-ID: <508B727B.6070501@cs.ucla.edu> Date: Fri, 26 Oct 2012 22:34:51 -0700 From: Paul Eggert Organization: UCLA Computer Science Department User-Agent: Mozilla/5.0 (X11; Linux i686; rv:16.0) Gecko/20121011 Thunderbird/16.0.1 MIME-Version: 1.0 To: control@debbugs.gnu.org Subject: 12697 has a patch Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Score: -2.2 (--) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.2 (--) tags 12697 patch From debbugs-submit-bounces@debbugs.gnu.org Sat Oct 27 03:54:51 2012 Received: (at 12697) by debbugs.gnu.org; 27 Oct 2012 07:54:51 +0000 Received: from localhost ([127.0.0.1]:35448 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TS1EJ-00055A-HY for submit@debbugs.gnu.org; Sat, 27 Oct 2012 03:54:51 -0400 Received: from mtaout21.012.net.il ([80.179.55.169]:47882) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TS1EH-000551-49 for 12697@debbugs.gnu.org; Sat, 27 Oct 2012 03:54:50 -0400 Received: from conversion-daemon.a-mtaout21.012.net.il by a-mtaout21.012.net.il (HyperSendmail v2007.08) id <0MCJ00700K8OUT00@a-mtaout21.012.net.il> for 12697@debbugs.gnu.org; Sat, 27 Oct 2012 09:52:08 +0200 (IST) Received: from HOME-C4E4A596F7 ([87.69.4.28]) by a-mtaout21.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0MCJ007G7KIVMWA0@a-mtaout21.012.net.il>; Sat, 27 Oct 2012 09:52:08 +0200 (IST) Date: Sat, 27 Oct 2012 09:52:11 +0200 From: Eli Zaretskii Subject: Re: Emacs crashes when using it as the commit editor for git In-reply-to: <508B71A9.40509@cs.ucla.edu> X-012-Sender: halo1@inter.net.il To: Paul Eggert Message-id: <83wqyc8i8k.fsf@gnu.org> References: <508B71A9.40509@cs.ucla.edu> X-Spam-Score: 1.5 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has identified this incoming email as possible spam. The original message has been attached to this so you can view it (if it isn't spam) or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: > Date: Fri, 26 Oct 2012 22:31:21 -0700 > From: Paul Eggert > CC: Andreas Schwab , Eli Zaretskii , > Matthew Leach > > Instead, how about the attached patch? It reenables > the BSD_PGRPS idea, although reimplemented, as the old > code can't easily be resurrected as-is. I haven't > thought about how this affects the Windows port [...] Content analysis details: (1.5 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at http://www.dnswl.org/, no trust [80.179.55.169 listed in list.dnswl.org] 0.7 SPF_SOFTFAIL SPF: sender does not match SPF record (softfail) 0.8 BAYES_50 BODY: Bayes spam probability is 40 to 60% [score: 0.5000] X-Debbugs-Envelope-To: 12697 Cc: matthew@mattleach.net, 12697@debbugs.gnu.org, schwab@linux-m68k.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list Reply-To: Eli Zaretskii List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: 1.5 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has identified this incoming email as possible spam. The original message has been attached to this so you can view it (if it isn't spam) or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: > Date: Fri, 26 Oct 2012 22:31:21 -0700 > From: Paul Eggert > CC: Andreas Schwab , Eli Zaretskii , > Matthew Leach > > Instead, how about the attached patch? It reenables > the BSD_PGRPS idea, although reimplemented, as the old > code can't easily be resurrected as-is. I haven't > thought about how this affects the Windows port [...] Content analysis details: (1.5 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at http://www.dnswl.org/, no trust [80.179.55.169 listed in list.dnswl.org] 0.7 SPF_SOFTFAIL SPF: sender does not match SPF record (softfail) 0.8 BAYES_50 BODY: Bayes spam probability is 40 to 60% [score: 0.4935] > Date: Fri, 26 Oct 2012 22:31:21 -0700 > From: Paul Eggert > CC: Andreas Schwab , Eli Zaretskii , > Matthew Leach > > Instead, how about the attached patch? It reenables > the BSD_PGRPS idea, although reimplemented, as the old > code can't easily be resurrected as-is. I haven't > thought about how this affects the Windows port The termios-related stuff (the call to tcsetgrp) in sysdep.c should be #ifedf'ed away for Windows (for DOS_NT, actually). Also, the references to SIGTTOU should be conditioned on that signal being defined. Other than that, this should be OK, I think, since, if setpgid is not available, it is redirected to setpgrp, which already has a no-op implementation for Windows. From debbugs-submit-bounces@debbugs.gnu.org Sun Oct 28 14:59:43 2012 Received: (at 12697) by debbugs.gnu.org; 28 Oct 2012 18:59:44 +0000 Received: from localhost ([127.0.0.1]:36900 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TSY5H-00053Z-3s for submit@debbugs.gnu.org; Sun, 28 Oct 2012 14:59:43 -0400 Received: from smtp.cs.ucla.edu ([131.179.128.62]:55696) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TSY5D-00053R-O6 for 12697@debbugs.gnu.org; Sun, 28 Oct 2012 14:59:41 -0400 Received: from localhost (localhost.localdomain [127.0.0.1]) by smtp.cs.ucla.edu (Postfix) with ESMTP id B644239E8105; Sun, 28 Oct 2012 11:57:17 -0700 (PDT) X-Virus-Scanned: amavisd-new at smtp.cs.ucla.edu Received: from smtp.cs.ucla.edu ([127.0.0.1]) by localhost (smtp.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id K31w7yRLOYJv; Sun, 28 Oct 2012 11:57:16 -0700 (PDT) Received: from [192.168.1.3] (pool-108-23-119-2.lsanca.fios.verizon.net [108.23.119.2]) by smtp.cs.ucla.edu (Postfix) with ESMTPSA id B11AA39E8100; Sun, 28 Oct 2012 11:57:16 -0700 (PDT) Message-ID: <508D800C.7090707@cs.ucla.edu> Date: Sun, 28 Oct 2012 11:57:16 -0700 From: Paul Eggert Organization: UCLA Computer Science Department User-Agent: Mozilla/5.0 (X11; Linux i686; rv:16.0) Gecko/20121011 Thunderbird/16.0.1 MIME-Version: 1.0 To: Eli Zaretskii Subject: Re: Emacs crashes when using it as the commit editor for git References: <508B71A9.40509@cs.ucla.edu> <83wqyc8i8k.fsf@gnu.org> In-Reply-To: <83wqyc8i8k.fsf@gnu.org> Content-Type: multipart/mixed; boundary="------------070102060109040902090905" X-Spam-Score: -4.8 (----) X-Debbugs-Envelope-To: 12697 Cc: matthew@mattleach.net, 12697@debbugs.gnu.org, schwab@linux-m68k.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -4.8 (----) This is a multi-part message in MIME format. --------------070102060109040902090905 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 10/27/2012 12:52 AM, Eli Zaretskii wrote: > The termios-related stuff (the call to tcsetgrp) in sysdep.c should be > #ifedf'ed away for Windows (for DOS_NT, actually). Also, the > references to SIGTTOU should be conditioned on that signal being > defined. Thanks, that problem occurs with older POSIXish systems too. Here's a simple fix for it. I'm attaching the resulting combined patch, relative to trunk bzr 110706. The bug is a relatively serious one, so I'm inclined to install the combined patch soon. === modified file 'src/sysdep.c' --- src/sysdep.c 2012-10-27 05:07:17 +0000 +++ src/sysdep.c 2012-10-28 18:39:51 +0000 @@ -716,16 +716,21 @@ /* Safely set a controlling terminal FD's process group to PGID. If we are not in the foreground already, POSIX requires tcsetpgrp to deliver a SIGTTOU signal, which would stop us. This is an - annoyance, so temporarily ignore the signal. */ + annoyance, so temporarily ignore the signal. + + In practice, platforms lacking SIGTTOU also lack tcsetpgrp, so + skip all this unless SIGTTOU is defined. */ static void tcsetpgrp_without_stopping (int fd, pid_t pgid) { +#ifdef SIGTTOU signal_handler_t handler; block_input (); handler = signal (SIGTTOU, SIG_IGN); tcsetpgrp (fd, pgid); signal (SIGTTOU, handler); unblock_input (); +#endif } /* Split off the foreground process group to Emacs alone. When we are --------------070102060109040902090905 Content-Type: text/plain; charset=UTF-8; name="git-commit.txt" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="git-commit.txt" PT09IG1vZGlmaWVkIGZpbGUgJ3NyYy9DaGFuZ2VMb2cnCi0tLSBzcmMvQ2hhbmdlTG9nCTIw MTItMTAtMjggMTc6NDI6NTIgKzAwMDAKKysrIHNyYy9DaGFuZ2VMb2cJMjAxMi0xMC0yOCAx ODozMzo0MSArMDAwMApAQCAtMSwzICsxLDI0IEBACisyMDEyLTEwLTI4ICBQYXVsIEVnZ2Vy dCAgPGVnZ2VydEBjcy51Y2xhLmVkdT4KKworCUZpeCBjcmFzaCB3aGVuIHVzaW5nIEVtYWNz IGFzIGNvbW1pdCBlZGl0b3IgZm9yIGdpdCAoQnVnIzEyNjk3KS4KKwkqIGNhbGxwcm9jLmMg KHNldHBncnApOiBSZW1vdmUgbWFjcm8sIGFzIHdlIG5vdyB1c2Ugc2V0cGdpZAorCWFuZCBp dCBpcyBjb25maWd1cmVkIGluIGNvbmZfcG9zdC5oLgorCShGY2FsbF9wcm9jZXNzKTogRG9u J3QgaW52b2tlIGJvdGggc2V0c2lkIGFuZCBzZXRwZ2lkOyB0aGUgZm9ybWVyCisJaXMgZW5v dWdoLCBpZiBpdCBleGlzdHMuCisJKiBjYWxscHJvYy5jIChGY2FsbF9wcm9jZXNzLCBjaGls ZF9zZXR1cCk6CisJKiBwcm9jZXNzLmMgKGNyZWF0ZV9wcm9jZXNzKTogVXNlIHNldHBnaWQu CisJKiBjb25mX3Bvc3QuaCAoc2V0cGdpZCkgWyFIQVZFX1NFVFBHSURdOiBOZXcgbWFjcm8s IHdoaWNoIHN1YnN0aXR1dGVzCisJZm9yIHRoZSByZWFsIHRoaW5nLgorCSogZGlzcG5ldy5j IChpbml0X2Rpc3BsYXkpOiBJbml0aWFsaXplIHRoZSBmb3JlZ3JvdW5kIGdyb3VwCisJaWYg d2UgYXJlIHJ1bm5pbmcgYSB0dHkgZGlzcGxheS4KKwkqIGVtYWNzLmMgKG1haW4pOiBEbyBu b3Qgd29ycnkgYWJvdXQgc2V0cGdycDsgaW5pdF9kaXNwbGF5IGRvZXMgaXQgbm93LgorCSog bGlzcC5oIChpbml0X2ZvcmVncm91bmRfZ3JvdXApOiBOZXcgZGVjbC4KKwkqIHN5c2RlcC5j IChpbmhlcml0ZWRfcGdyb3VwKTogTmV3IHN0YXRpYyB2YXIuCisJKGluaXRfZm9yZWdyb3Vu ZF9ncm91cCwgdGNzZXRwZ3JwX3dpdGhvdXRfc3RvcHBpbmcpCisJKG5hcnJvd19mb3JlZ3Jv dW5kX2dyb3VwLCB3aWRlbl9mb3JlZ3JvdW5kX2dyb3VwKTogTmV3IGZ1bmN0aW9ucy4KKwko aW5pdF9zeXNfbW9kZXMpOiBOYXJyb3cgZm9yZWdyb3VuZCBncm91cC4KKwkocmVzZXRfc3lz X21vZGVzKTogV2lkZW4gZm9yZWdyb3VuZCBncm91cC4KKwogMjAxMi0xMC0yOCAgRWxpIFph cmV0c2tpaSAgPGVsaXpAZ251Lm9yZz4KIAogCSogdzMycHJvYy5jIChUSU1FUl9USUNLU19Q RVJfU0VDKTogTmV3IG1hY3JvLgoKPT09IG1vZGlmaWVkIGZpbGUgJ3NyYy9jYWxscHJvYy5j JwotLS0gc3JjL2NhbGxwcm9jLmMJMjAxMi0xMC0xOSAxOToyNToxOCArMDAwMAorKysgc3Jj L2NhbGxwcm9jLmMJMjAxMi0xMC0yNyAwNToyMjo1NCArMDAwMApAQCAtNjQsMTMgKzY0LDYg QEAKICNpbmNsdWRlICJuc3Rlcm0uaCIKICNlbmRpZgogCi0jaWZkZWYgSEFWRV9TRVRQR0lE Ci0jaWYgIWRlZmluZWQgKFVTRykKLSN1bmRlZiBzZXRwZ3JwCi0jZGVmaW5lIHNldHBncnAg c2V0cGdpZAotI2VuZGlmCi0jZW5kaWYKLQogLyogUGF0dGVybiB1c2VkIGJ5IGNhbGwtcHJv Y2Vzcy1yZWdpb24gdG8gbWFrZSB0ZW1wIGZpbGVzLiAgKi8KIHN0YXRpYyBMaXNwX09iamVj dCBWdGVtcF9maWxlX25hbWVfcGF0dGVybjsKIApAQCAtNjE4LDE0ICs2MTEsMTIgQEAKICAg ICAgIHsKIAlpZiAoZmRbMF0gPj0gMCkKIAkgIGVtYWNzX2Nsb3NlIChmZFswXSk7CisKICNp ZmRlZiBIQVZFX1NFVFNJRAogCXNldHNpZCAoKTsKKyNlbHNlCisJc2V0cGdpZCAoMCwgMCk7 CiAjZW5kaWYKLSNpZiBkZWZpbmVkIChVU0cpCi0Jc2V0cGdycCAoKTsKLSNlbHNlCi0Jc2V0 cGdycCAocGlkLCBwaWQpOwotI2VuZGlmIC8qIFVTRyAqLwogCiAJLyogRW1hY3MgaWdub3Jl cyBTSUdQSVBFLCBidXQgdGhlIGNoaWxkIHNob3VsZCBub3QuICAqLwogCXNpZ25hbCAoU0lH UElQRSwgU0lHX0RGTCk7CkBAIC0xMjk1LDEzICsxMjg2LDkgQEAKICAgaWYgKGVyciAhPSBp biAmJiBlcnIgIT0gb3V0KQogICAgIGVtYWNzX2Nsb3NlIChlcnIpOwogCi0jaWYgZGVmaW5l ZCAoVVNHKQotI2lmbmRlZiBTRVRQR1JQX1JFTEVBU0VTX0NUVFkKLSAgc2V0cGdycCAoKTsJ CQkvKiBObyBhcmd1bWVudHMgYnV0IGVxdWl2YWxlbnQgaW4gdGhpcyBjYXNlICovCisjaWYg ZGVmaW5lZCBIQVZFX1NFVFBHSUQgfHwgISAoZGVmaW5lZCBVU0cgJiYgZGVmaW5lZCBTRVRQ R1JQX1JFTEVBU0VTX0NUVFkpCisgIHNldHBnaWQgKHBpZCwgcGlkKTsKICNlbmRpZgotI2Vs c2UgLyogbm90IFVTRyAqLwotICBzZXRwZ3JwIChwaWQsIHBpZCk7Ci0jZW5kaWYgLyogbm90 IFVTRyAqLwogCiAgIC8qIHNldHBncnBfb2ZfdHR5IGlzIGluY29ycmVjdCBoZXJlOyBpdCB1 c2VzIGlucHV0X2ZkLiAgKi8KICAgdGNzZXRwZ3JwICgwLCBwaWQpOwoKPT09IG1vZGlmaWVk IGZpbGUgJ3NyYy9jb25mX3Bvc3QuaCcKLS0tIHNyYy9jb25mX3Bvc3QuaAkyMDEyLTEwLTE5 IDE5OjI1OjE4ICswMDAwCisrKyBzcmMvY29uZl9wb3N0LmgJMjAxMi0xMC0yNyAwNTowNzox NyArMDAwMApAQCAtMTEyLDYgKzExMiwxNCBAQAogI2VuZGlmCiAvKiBFbmQgb2YgZ251bGli LXJlbGF0ZWQgc3R1ZmYuICAqLwogCisjaWZuZGVmIEhBVkVfU0VUUEdJRAorIyBpZmRlZiBV U0cKKyMgIGRlZmluZSBzZXRwZ2lkKHBpZCwgcGdpZCkgc2V0cGdycCAoKQorIyBlbHNlCisj ICBkZWZpbmUgc2V0cGdpZChwaWQsIHBnaWQpIHNldHBncnAgKHBpZCwgcGdpZCkKKyMgZW5k aWYKKyNlbmRpZgorCiAvKiBEZWZpbmUgb25lIG9mIHRoZXNlIGZvciBlYXNpZXIgY29uZGl0 aW9uYWxzLiAgKi8KICNpZmRlZiBIQVZFX1hfV0lORE9XUwogLyogV2UgbmVlZCBhIGxpdHRs ZSBleHRyYSBzcGFjZSwgc2VlIC4uLy4uL2xpc3AvbG9hZHVwLmVsIGFuZCB0aGUKCj09PSBt b2RpZmllZCBmaWxlICdzcmMvZGlzcG5ldy5jJwotLS0gc3JjL2Rpc3BuZXcuYwkyMDEyLTEw LTE3IDE5OjAyOjQ0ICswMDAwCisrKyBzcmMvZGlzcG5ldy5jCTIwMTItMTAtMjcgMDU6MDc6 MTcgKzAwMDAKQEAgLTYyODMsNiArNjI4Myw4IEBACiAgICAgc3RydWN0IHRlcm1pbmFsICp0 OwogICAgIHN0cnVjdCBmcmFtZSAqZiA9IFhGUkFNRSAoc2VsZWN0ZWRfZnJhbWUpOwogCisg ICAgaW5pdF9mb3JlZ3JvdW5kX2dyb3VwICgpOworCiAgICAgLyogT3BlbiBhIGRpc3BsYXkg b24gdGhlIGNvbnRyb2xsaW5nIHR0eS4gKi8KICAgICB0ID0gaW5pdF90dHkgKDAsIHRlcm1p bmFsX3R5cGUsIDEpOyAvKiBFcnJvcnMgYXJlIGZhdGFsLiAqLwogCgo9PT0gbW9kaWZpZWQg ZmlsZSAnc3JjL2VtYWNzLmMnCi0tLSBzcmMvZW1hY3MuYwkyMDEyLTEwLTI1IDA0OjM1OjM5 ICswMDAwCisrKyBzcmMvZW1hY3MuYwkyMDEyLTEwLTI3IDA1OjA3OjE3ICswMDAwCkBAIC0x MDkxLDE5ICsxMDkxLDE0IEBACiAjZW5kaWYgLyogRE9TX05UICovCiAgICAgfQogCi0gIGlm ICghIG5vbmludGVyYWN0aXZlKQotICAgIHsKLSNpZiBkZWZpbmVkIChVU0c1KSAmJiBkZWZp bmVkIChJTlRFUlJVUFRfSU5QVVQpCi0gICAgICBzZXRwZ3JwICgpOwotI2VuZGlmCiAjaWYg ZGVmaW5lZCAoSEFWRV9QVEhSRUFEKSAmJiAhZGVmaW5lZCAoU1lTVEVNX01BTExPQykgJiYg IWRlZmluZWQgKERPVUdfTEVBX01BTExPQykKLSAgICAgIHsKLSAgICAgICAgZXh0ZXJuIHZv aWQgbWFsbG9jX2VuYWJsZV90aHJlYWQgKHZvaWQpOworICBpZiAoISBub25pbnRlcmFjdGl2 ZSkKKyAgICB7CisgICAgICBleHRlcm4gdm9pZCBtYWxsb2NfZW5hYmxlX3RocmVhZCAodm9p ZCk7CiAKLQltYWxsb2NfZW5hYmxlX3RocmVhZCAoKTsKLSAgICAgIH0KKyAgICAgIG1hbGxv Y19lbmFibGVfdGhyZWFkICgpOworICAgIH0KICNlbmRpZgotICAgIH0KIAogICBpbml0X3Np Z25hbHMgKGR1bXBpbmcpOwogCgo9PT0gbW9kaWZpZWQgZmlsZSAnc3JjL2xpc3AuaCcKLS0t IHNyYy9saXNwLmgJMjAxMi0xMC0yMSAwNzoyMzozNCArMDAwMAorKysgc3JjL2xpc3AuaAky MDEyLTEwLTI3IDA1OjA3OjE3ICswMDAwCkBAIC0zNDc0LDYgKzM0NzQsNyBAQAogZXh0ZXJu IGNoYXIgKmdldF9jdXJyZW50X2Rpcl9uYW1lICh2b2lkKTsKICNlbmRpZgogZXh0ZXJuIHZv aWQgc3R1ZmZfY2hhciAoY2hhciBjKTsKK2V4dGVybiB2b2lkIGluaXRfZm9yZWdyb3VuZF9n cm91cCAodm9pZCk7CiBleHRlcm4gdm9pZCBpbml0X3NpZ2lvIChpbnQpOwogZXh0ZXJuIHZv aWQgc3lzX3N1YnNoZWxsICh2b2lkKTsKIGV4dGVybiB2b2lkIHN5c19zdXNwZW5kICh2b2lk KTsKCj09PSBtb2RpZmllZCBmaWxlICdzcmMvcHJvY2Vzcy5jJwotLS0gc3JjL3Byb2Nlc3Mu YwkyMDEyLTEwLTE5IDE5OjI1OjE4ICswMDAwCisrKyBzcmMvcHJvY2Vzcy5jCTIwMTItMTAt MjcgMDU6MDc6MTcgKzAwMDAKQEAgLTE3NTksMTIgKzE3NTksMTAgQEAKICNlbmRpZgogCX0K ICNlbHNlIC8qIG5vdCBIQVZFX1NFVFNJRCAqLwotI2lmZGVmIFVTRwotICAgICAgLyogSXQn cyB2ZXJ5IGltcG9ydGFudCB0byBjYWxsIHNldHBncnAgaGVyZSBhbmQgbm8gdGltZQorICAg ICAgLyogSXQncyB2ZXJ5IGltcG9ydGFudCB0byBjYWxsIHNldHBnaWQgaGVyZSBhbmQgbm8g dGltZQogCSBhZnRlcndhcmRzLiAgT3RoZXJ3aXNlLCB3ZSBsb3NlIG91ciBjb250cm9sbGlu ZyB0dHkgd2hpY2gKIAkgaXMgc2V0IHdoZW4gd2Ugb3BlbiB0aGUgcHR5LiAqLwotICAgICAg c2V0cGdycCAoKTsKLSNlbmRpZiAvKiBVU0cgKi8KKyAgICAgIHNldHBnaWQgKDAsIDApOwog I2VuZGlmIC8qIG5vdCBIQVZFX1NFVFNJRCAqLwogI2lmIGRlZmluZWQgKExESVNDMSkKICAg ICAgIGlmIChwdHlfZmxhZyAmJiB4Zm9ya2luID49IDApCkBAIC0xODAyLDExICsxODAwLDcg QEAKIAkgIC8qIEluIG9yZGVyIHRvIGdldCBhIGNvbnRyb2xsaW5nIHRlcm1pbmFsIG9uIHNv bWUgdmVyc2lvbnMKIAkgICAgIG9mIEJTRCwgaXQgaXMgbmVjZXNzYXJ5IHRvIHB1dCB0aGUg cHJvY2VzcyBpbiBwZ3JwIDAKIAkgICAgIGJlZm9yZSBpdCBvcGVucyB0aGUgdGVybWluYWwu ICAqLwotI2lmZGVmIEhBVkVfU0VUUEdJRAogCSAgc2V0cGdpZCAoMCwgMCk7Ci0jZWxzZQot CSAgc2V0cGdycCAoMCwgMCk7Ci0jZW5kaWYKICNlbmRpZgogCX0KICNlbmRpZiAvKiBUSU9D Tk9UVFkgKi8KCj09PSBtb2RpZmllZCBmaWxlICdzcmMvc3lzZGVwLmMnCi0tLSBzcmMvc3lz ZGVwLmMJMjAxMi0xMC0yNSAwNDozNTozOSArMDAwMAorKysgc3JjL3N5c2RlcC5jCTIwMTIt MTAtMjggMTg6NTA6MDAgKzAwMDAKQEAgLTY4Myw2ICs2ODMsNzUgQEAKIH0KIAogDAorLyog U2F2aW5nIGFuZCByZXN0b3JpbmcgdGhlIHByb2Nlc3MgZ3JvdXAgb2YgRW1hY3MncyB0ZXJt aW5hbC4gICovCisKKy8qIFRoZSBwcm9jZXNzIGdyb3VwIG9mIHdoaWNoIEVtYWNzIHdhcyBh IG1lbWJlciB3aGVuIGl0IGluaXRpYWxseQorICAgc3RhcnRlZC4KKworICAgSWYgRW1hY3Mg d2FzIGluIGl0cyBvd24gcHJvY2VzcyBncm91cCAoaS5lLiBpbmhlcml0ZWRfcGdyb3VwID09 CisgICBnZXRwaWQgKCkpLCB0aGVuIHdlIGtub3cgd2UncmUgcnVubmluZyB1bmRlciBhIHNo ZWxsIHdpdGggam9iCisgICBjb250cm9sIChFbWFjcyB3b3VsZCBuZXZlciBiZSBydW4gYXMg cGFydCBvZiBhIHBpcGVsaW5lKS4KKyAgIEV2ZXJ5dGhpbmcgaXMgZmluZS4KKworICAgSWYg RW1hY3Mgd2FzIG5vdCBpbiBpdHMgb3duIHByb2Nlc3MgZ3JvdXAsIHRoZW4gd2Uga25vdyB3 ZSdyZQorICAgcnVubmluZyB1bmRlciBhIHNoZWxsIChvciBhIGNhbGxlcikgdGhhdCBkb2Vz bid0IGtub3cgaG93IHRvCisgICBzZXBhcmF0ZSBpdHNlbGYgZnJvbSBFbWFjcyAobGlrZSBz aCkuICBFbWFjcyBtdXN0IGJlIGluIGl0cyBvd24KKyAgIHByb2Nlc3MgZ3JvdXAgaW4gb3Jk ZXIgdG8gcmVjZWl2ZSBTSUdJTyBjb3JyZWN0bHkuICBJbiB0aGlzCisgICBzaXR1YXRpb24s IHdlIHB1dCBvdXJzZWx2ZXMgaW4gb3VyIG93biBwZ3JvdXAsIGZvcmNpYmx5IHNldCB0aGUK KyAgIHR0eSdzIHBncm91cCB0byBvdXIgcGdyb3VwLCBhbmQgbWFrZSBzdXJlIHRvIHJlc3Rv cmUgYW5kIHJlaW5zdGF0ZQorICAgdGhlIHR0eSdzIHBncm91cCBqdXN0IGxpa2UgYW55IG90 aGVyIHRlcm1pbmFsIHNldHRpbmcuICBJZgorICAgaW5oZXJpdGVkX2dyb3VwIHdhcyBub3Qg dGhlIHR0eSdzIHBncm91cCwgdGhlbiB3ZSdsbCBnZXQgYQorICAgU0lHVFRtdW1ibGUgd2hl biB3ZSB0cnkgdG8gY2hhbmdlIHRoZSB0dHkncyBwZ3JvdXAsIGFuZCBhIENPTlQgaWYKKyAg IGl0IGdvZXMgZm9yZWdyb3VuZCBpbiB0aGUgZnV0dXJlLCB3aGljaCBpcyB3aGF0IHNob3Vs ZCBoYXBwZW4uICAqLworCitzdGF0aWMgcGlkX3QgaW5oZXJpdGVkX3Bncm91cDsKKwordm9p ZAoraW5pdF9mb3JlZ3JvdW5kX2dyb3VwICh2b2lkKQoreworICBwaWRfdCBwZ3JwID0gRU1B Q1NfR0VUUEdSUCAoMCk7CisgIGluaGVyaXRlZF9wZ3JvdXAgPSBnZXRwaWQgKCkgPT0gcGdy cCA/IDAgOiBwZ3JwOworfQorCisvKiBTYWZlbHkgc2V0IGEgY29udHJvbGxpbmcgdGVybWlu YWwgRkQncyBwcm9jZXNzIGdyb3VwIHRvIFBHSUQuCisgICBJZiB3ZSBhcmUgbm90IGluIHRo ZSBmb3JlZ3JvdW5kIGFscmVhZHksIFBPU0lYIHJlcXVpcmVzIHRjc2V0cGdycAorICAgdG8g ZGVsaXZlciBhIFNJR1RUT1Ugc2lnbmFsLCB3aGljaCB3b3VsZCBzdG9wIHVzLiAgVGhpcyBp cyBhbgorICAgYW5ub3lhbmNlLCBzbyB0ZW1wb3JhcmlseSBpZ25vcmUgdGhlIHNpZ25hbC4K KworICAgSW4gcHJhY3RpY2UsIHBsYXRmb3JtcyBsYWNraW5nIFNJR1RUT1UgYWxzbyBsYWNr IHRjc2V0cGdycCwgc28KKyAgIHNraXAgYWxsIHRoaXMgdW5sZXNzIFNJR1RUT1UgaXMgZGVm aW5lZC4gICovCitzdGF0aWMgdm9pZAordGNzZXRwZ3JwX3dpdGhvdXRfc3RvcHBpbmcgKGlu dCBmZCwgcGlkX3QgcGdpZCkKK3sKKyNpZmRlZiBTSUdUVE9VCisgIHNpZ25hbF9oYW5kbGVy X3QgaGFuZGxlcjsKKyAgYmxvY2tfaW5wdXQgKCk7CisgIGhhbmRsZXIgPSBzaWduYWwgKFNJ R1RUT1UsIFNJR19JR04pOworICB0Y3NldHBncnAgKGZkLCBwZ2lkKTsKKyAgc2lnbmFsIChT SUdUVE9VLCBoYW5kbGVyKTsKKyAgdW5ibG9ja19pbnB1dCAoKTsKKyNlbmRpZgorfQorCisv KiBTcGxpdCBvZmYgdGhlIGZvcmVncm91bmQgcHJvY2VzcyBncm91cCB0byBFbWFjcyBhbG9u ZS4gIFdoZW4gd2UgYXJlCisgICBpbiB0aGUgZm9yZWdyb3VuZCwgYnV0IG5vdCBzdGFydGVk IGluIG91ciBvd24gcHJvY2VzcyBncm91cCwKKyAgIHJlZGlyZWN0IHRoZSB0dHkgZGV2aWNl IGhhbmRsZSBGRCB0byBwb2ludCB0byBvdXIgb3duIHByb2Nlc3MKKyAgIGdyb3VwLiAgRkQg bXVzdCBiZSB0aGUgZmlsZSBkZXNjcmlwdG9yIG9mIHRoZSBjb250cm9sbGluZyB0dHkuICAq Lworc3RhdGljIHZvaWQKK25hcnJvd19mb3JlZ3JvdW5kX2dyb3VwIChpbnQgZmQpCit7Cisg IGlmIChpbmhlcml0ZWRfcGdyb3VwICYmIHNldHBnaWQgKDAsIDApID09IDApCisgICAgdGNz ZXRwZ3JwX3dpdGhvdXRfc3RvcHBpbmcgKGZkLCBnZXRwaWQgKCkpOworfQorCisvKiBTZXQg dGhlIHR0eSB0byBvdXIgb3JpZ2luYWwgZm9yZWdyb3VuZCBncm91cC4gICovCitzdGF0aWMg dm9pZAord2lkZW5fZm9yZWdyb3VuZF9ncm91cCAoaW50IGZkKQoreworICBpZiAoaW5oZXJp dGVkX3Bncm91cCAmJiBzZXRwZ2lkICgwLCBpbmhlcml0ZWRfcGdyb3VwKSA9PSAwKQorICAg IHRjc2V0cGdycF93aXRob3V0X3N0b3BwaW5nIChmZCwgaW5oZXJpdGVkX3Bncm91cCk7Cit9 CisMCiAvKiBHZXR0aW5nIGFuZCBzZXR0aW5nIGVtYWNzX3R0eSBzdHJ1Y3R1cmVzLiAgKi8K IAogLyogU2V0ICpUQyB0byB0aGUgcGFyYW1ldGVycyBhc3NvY2lhdGVkIHdpdGggdGhlIHRl cm1pbmFsIEZELgpAQCAtNzk5LDYgKzg2OCw4IEBACiAgIGlmICghdHR5X291dC0+b3V0cHV0 KQogICAgIHJldHVybjsgICAgICAgICAgICAgICAgICAgICAvKiBUaGUgdHR5IGlzIHN1c3Bl bmRlZC4gKi8KIAorICBuYXJyb3dfZm9yZWdyb3VuZF9ncm91cCAoZmlsZW5vICh0dHlfb3V0 LT5pbnB1dCkpOworCiAgIGlmICghIHR0eV9vdXQtPm9sZF90dHkpCiAgICAgdHR5X291dC0+ b2xkX3R0eSA9IHhtYWxsb2MgKHNpemVvZiAqdHR5X291dC0+b2xkX3R0eSk7CiAKQEAgLTEy MzEsNiArMTMwMiw3IEBACiAgIGRvc190dGNvb2tlZCAoKTsKICNlbmRpZgogCisgIHdpZGVu X2ZvcmVncm91bmRfZ3JvdXAgKGZpbGVubyAodHR5X291dC0+aW5wdXQpKTsKIH0KIAwKICNp ZmRlZiBIQVZFX1BUWVMKCg== --------------070102060109040902090905-- From debbugs-submit-bounces@debbugs.gnu.org Wed Oct 31 13:31:42 2012 Received: (at 12697-done) by debbugs.gnu.org; 31 Oct 2012 17:31:42 +0000 Received: from localhost ([127.0.0.1]:41765 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TTc8j-0008G6-Jx for submit@debbugs.gnu.org; Wed, 31 Oct 2012 13:31:41 -0400 Received: from smtp.cs.ucla.edu ([131.179.128.62]:55945) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TTc8h-0008Fy-8j for 12697-done@debbugs.gnu.org; Wed, 31 Oct 2012 13:31:40 -0400 Received: from localhost (localhost.localdomain [127.0.0.1]) by smtp.cs.ucla.edu (Postfix) with ESMTP id 5FA4BA60010 for <12697-done@debbugs.gnu.org>; Wed, 31 Oct 2012 10:29:00 -0700 (PDT) X-Virus-Scanned: amavisd-new at smtp.cs.ucla.edu Received: from smtp.cs.ucla.edu ([127.0.0.1]) by localhost (smtp.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id CVGlvxAiFzxd for <12697-done@debbugs.gnu.org>; Wed, 31 Oct 2012 10:29:00 -0700 (PDT) Received: from penguin.cs.ucla.edu (Penguin.CS.UCLA.EDU [131.179.64.200]) by smtp.cs.ucla.edu (Postfix) with ESMTPSA id EBBBFA6000F for <12697-done@debbugs.gnu.org>; Wed, 31 Oct 2012 10:28:59 -0700 (PDT) Message-ID: <50915FDB.1010206@cs.ucla.edu> Date: Wed, 31 Oct 2012 10:28:59 -0700 From: Paul Eggert User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:16.0) Gecko/20121016 Thunderbird/16.0.1 MIME-Version: 1.0 To: 12697-done@debbugs.gnu.org Subject: Re: Emacs crashes when using it as the commit editor for git Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-Spam-Score: -2.2 (--) X-Debbugs-Envelope-To: 12697-done X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.2 (--) I installed the patch into the trunk as bzr 110750 and am marking this as done. From unknown Sun Jun 22 03:48:55 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Thu, 29 Nov 2012 12:24:03 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator