From debbugs-submit-bounces@debbugs.gnu.org Fri Oct 19 18:51:55 2012 Received: (at submit) by debbugs.gnu.org; 19 Oct 2012 22:51:55 +0000 Received: from localhost ([127.0.0.1]:52304 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TPLQ2-0002wS-NO for submit@debbugs.gnu.org; Fri, 19 Oct 2012 18:51:55 -0400 Received: from eggs.gnu.org ([208.118.235.92]:51127) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TPKpA-00023G-VG for submit@debbugs.gnu.org; Fri, 19 Oct 2012 18:13:49 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TPKnb-0000Bd-GK for submit@debbugs.gnu.org; Fri, 19 Oct 2012 18:12:12 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=5.0 tests=BAYES_00,FREEMAIL_FROM, RCVD_IN_DNSWL_HI,T_DKIM_INVALID autolearn=unavailable version=3.3.2 Received: from lists.gnu.org ([208.118.235.17]:40692) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TPKnb-0000BY-DG for submit@debbugs.gnu.org; Fri, 19 Oct 2012 18:12:11 -0400 Received: from eggs.gnu.org ([208.118.235.92]:49837) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TPKna-0001Yv-FD for bug-automake@gnu.org; Fri, 19 Oct 2012 18:12:11 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TPKnZ-0000Al-Js for bug-automake@gnu.org; Fri, 19 Oct 2012 18:12:10 -0400 Received: from mail-we0-f169.google.com ([74.125.82.169]:33017) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TPKnZ-0000AV-DA for bug-automake@gnu.org; Fri, 19 Oct 2012 18:12:09 -0400 Received: by mail-we0-f169.google.com with SMTP id u3so578772wey.0 for ; Fri, 19 Oct 2012 15:12:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:date:from:to:cc:subject:message-id:mail-followup-to :mime-version:content-type:content-disposition :content-transfer-encoding:user-agent; bh=giHIq2SeeDh5ip8SuetFgXEMjg/yfhl4IPmjtK3qaj0=; b=wTQuccy+xzSegUdOmyUwjdE9Efr17niJT+vvj8K0PDpXDYrIrFe+eEiZCU8p9L50Q3 O9B5bFbV35EiOjPaZsda/JGwcdztdoYpyDyWcYRJje7zt4tGWLfM+EnDKmfY9kU47wAo r7Iy8hp7Cyw/1IlfiO2PvFzgSza5I7YMgIYHTMiEjxowdHNECsWfAlWHCn3WKmz3xTqC +0SOCLM7jrvlLgBlrOHlLkJqHnNGaiU6Ief1lpwmCA9dmA3cSUIAiWQbZwmonCMyIMRF RczKBi/ph9vCWMkpFDKdQdSjbfQ83LBVnCVtgG7fO62W0H4nVL52IUudh76dfxaRzp+y AQ+A== Received: by 10.216.204.138 with SMTP id h10mr1485208weo.168.1350684728125; Fri, 19 Oct 2012 15:12:08 -0700 (PDT) Received: from localhost (202.190-67-87.adsl-dyn.isp.belgacom.be. [87.67.190.202]) by mx.google.com with ESMTPS id v3sm5854967wiy.5.2012.10.19.15.12.04 (version=SSLv3 cipher=OTHER); Fri, 19 Oct 2012 15:12:06 -0700 (PDT) Date: Sat, 20 Oct 2012 00:11:55 +0200 From: =?iso-8859-1?Q?S=E9bastien?= Wilmet To: bug-automake@gnu.org Subject: AM_PROG_VALAC: error message -> warning message Message-ID: <20121019221155.GF1219@aragorn.home> Mail-Followup-To: bug-automake@gnu.org, latexila-list@gnome.org MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit User-Agent: Mutt/1.5.21 (2010-09-15) X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-Received-From: 208.118.235.17 X-Spam-Score: -3.4 (---) X-Debbugs-Envelope-To: submit X-Mailman-Approved-At: Fri, 19 Oct 2012 18:51:52 -0400 Cc: latexila-list@gnome.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -3.4 (---) Hello, In the AM_PROG_VALAC macro, when the optional parameter specifying the minimum release number is not provided, and if the Vala compiler is not found, then there is a _warning_ message. On the other hand, when the version number is specified, when the Vala compiler is too old, there is an _error_ message. This error message is problematic, because for a tarball, the Vala compiler is not required: the generated C code is included in the tarball. So if a user wants to compile the software, he shouldn't need the valac program. So the AC_MSG_ERROR should be modified as a AC_MSG_WARN. Best regards, Sébastien From debbugs-submit-bounces@debbugs.gnu.org Sat Oct 20 14:21:03 2012 Received: (at 12688) by debbugs.gnu.org; 20 Oct 2012 18:21:03 +0000 Received: from localhost ([127.0.0.1]:53465 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TPdfS-000831-E7 for submit@debbugs.gnu.org; Sat, 20 Oct 2012 14:21:03 -0400 Received: from mail-ea0-f172.google.com ([209.85.215.172]:59525) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TPWMk-0001gC-Mj for 12688@debbugs.gnu.org; Sat, 20 Oct 2012 06:33:15 -0400 Received: by mail-ea0-f172.google.com with SMTP id k13so378879eaa.3 for <12688@debbugs.gnu.org>; Sat, 20 Oct 2012 03:31:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:message-id:subject:from:to:cc:date:in-reply-to:references :content-type:x-mailer:mime-version; bh=2uciF1tt0vNDin50iSKSGN4EX8Kcp4r73mwU+M/NyQI=; b=ic8DEDFVuEsy89zeWKXXzZAzajUWasEBDhWOcoBZybJ3RZ1Fo+/pzKEwbNxRSW4p+7 pAGxWJr2RsakTTatEsFxQnNOivca9/82mY4HveSKLr/4vxL4xHOGje2vuAcy8S5CKkDE wT0QmPtF+PrfEg5lhY7zqx0OlfFjfakWqbNNnoTvz687GWmuhW84qD0RpcfNLsxXf8zj ns2Mz0eO/jVOOun1k1UMYrVcYnU+aWgaHNf6EJRmXLPTfIHmD4AXKzZE0t4YEPtpEjQH Hd7cn3qKAX0m8UTvpxK31j56se/C3AH6obvGJ4eY0YhImhbIF3NLMzY+mVPmYqMmo9nN sK4w== Received: by 10.14.0.198 with SMTP id 46mr5183869eeb.21.1350729094276; Sat, 20 Oct 2012 03:31:34 -0700 (PDT) Received: from [192.168.1.6] ([77.109.117.51]) by mx.google.com with ESMTPS id e1sm5547078eem.3.2012.10.20.03.31.32 (version=SSLv3 cipher=OTHER); Sat, 20 Oct 2012 03:31:33 -0700 (PDT) Message-ID: <1350729081.2826.9.camel@Matth> Subject: Re: [LaTeXila] AM_PROG_VALAC: error message -> warning message From: Matthieu Baerts To: 12688@debbugs.gnu.org Date: Sat, 20 Oct 2012 12:31:21 +0200 In-Reply-To: <20121019221155.GF1219@aragorn.home> References: <20121019221155.GF1219@aragorn.home> Content-Type: multipart/signed; micalg="pgp-sha1"; protocol="application/pgp-signature"; boundary="=-uhWK0yiY6AmlQoMwNAxx" X-Mailer: Evolution 3.6.0-0ubuntu3 Mime-Version: 1.0 X-Spam-Score: 0.1 (/) X-Debbugs-Envelope-To: 12688 X-Mailman-Approved-At: Sat, 20 Oct 2012 14:20:59 -0400 Cc: =?ISO-8859-1?Q?S=E9bastien?= Wilmet X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: 0.1 (/) --=-uhWK0yiY6AmlQoMwNAxx Content-Type: multipart/mixed; boundary="=-flkK+z4s5RIcXDj5IHqh" --=-flkK+z4s5RIcXDj5IHqh Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hello 20/10/2012 00:11 +0200, S=C3=A9bastien Wilmet wrote: > Hello, >=20 > In the AM_PROG_VALAC macro, when the optional parameter specifying the= =20 > minimum release number is not provided, and if the Vala compiler is not= =20 > found, then there is a _warning_ message. >=20 > On the other hand, when the version number is specified, when the Vala= =20 > compiler is too old, there is an _error_ message. >=20 > This error message is problematic, because for a tarball, the Vala=20 > compiler is not required: the generated C code is included in the=20 > tarball. So if a user wants to compile the software, he shouldn't need= =20 > the valac program. >=20 > So the AC_MSG_ERROR should be modified as a AC_MSG_WARN. I confirm that I had this problem with LaTeXila: I had a too old version of Vala and I was not able to compile LaTeXila except if '/usr/bin/valac' was removed/renamed. This is how this bug has been fixed in LaTeXila: https://github.com/swilmet/latexila/commit/993b073c71f094ca5c15cb2a44e69399= 176b882a (for those who wants a workaround ;) ) Note that if a warning message is produced when a too old version is detected, 'VALAC' variable has to be unset in vala.m4 This bug should be fixed with the attached patch :) Thank you, Matt --=-flkK+z4s5RIcXDj5IHqh Content-Disposition: attachment; filename="0001-m4-AM_PROG_VALAC-should-not-produce-an-error.patch" Content-Type: text/x-patch; name="0001-m4-AM_PROG_VALAC-should-not-produce-an-error.patch"; charset="UTF-8" Content-Transfer-Encoding: base64 RnJvbSBjYmQ5MzZjZDM1MTljOTZjMDdkNjg0YzVlNWZlMDAxZjg0OWZlZWYwIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQ0KRnJvbTogTWF0dGhpZXUgQmFlcnRzIDxtYXR0dGJlQGdtYWlsLmNvbT4N CkRhdGU6IFNhdCwgMjAgT2N0IDIwMTIgMTI6MTI6MjggKzAyMDANClN1YmplY3Q6IFtQQVRDSF0g bTQ6IEFNX1BST0dfVkFMQUMgc2hvdWxkIG5vdCBwcm9kdWNlIGFuIGVycm9yDQoNCkluIHRoZSBB TV9QUk9HX1ZBTEFDIG1hY3JvLCB3aGVuIHRoZSBvcHRpb25hbCBwYXJhbWV0ZXIgc3BlY2lmeWlu ZyB0aGUNCm1pbmltdW0gcmVsZWFzZSBudW1iZXIgaXMgbm90IHByb3ZpZGVkLCBhbmQvb3IgaWYg dGhlIFZhbGEgY29tcGlsZXIgaXMNCm5vdCBmb3VuZCwgdGhlbiB0aGVyZSBpcyBhIF93YXJuaW5n XyBtZXNzYWdlLg0KDQpPbiB0aGUgb3RoZXIgaGFuZCwgd2hlbiB0aGUgdmVyc2lvbiBudW1iZXIg aXMgc3BlY2lmaWVkIGFuZCBpZiB0aGUgVmFsYQ0KY29tcGlsZXIgaXMgdG9vIG9sZCwgdGhlcmUg aXMgYW4gX2Vycm9yXyBtZXNzYWdlLg0KDQpUaGlzIGVycm9yIG1lc3NhZ2UgaXMgcHJvYmxlbWF0 aWMsIGJlY2F1c2UgZm9yIGEgdGFyYmFsbCwgdGhlIFZhbGENCmNvbXBpbGVyIGlzIG5vdCByZXF1 aXJlZDogdGhlIGdlbmVyYXRlZCBDIGNvZGUgaXMgaW5jbHVkZWQgaW4gdGhlDQp0YXJiYWxsLiBT byBpZiBhIHVzZXIgd2FudHMgdG8gY29tcGlsZSB0aGUgc29mdHdhcmUsIGhlIHNob3VsZG4ndCBu ZWVkDQp0aGUgdmFsYWMgcHJvZ3JhbSB3aXRoIHRoZSByaWdodCB2ZXJzaW9uLg0KDQpTbyB0aGUg QUNfTVNHX0VSUk9SIHNob3VsZCBiZSBtb2RpZmllZCBhcyBhIEFDX01TR19XQVJOIGFuZCB0aGUg bmV3DQpWQUxBQyB2YXJpYWJsZSBzaG91bGQgYmUgdW5zZXQgaWYgdGhlIHVzZXIgaGFzIGEgdG9v IG9sZCB2ZXJzaW9uIG9mDQpWYWxhYy4NCi0tLQ0KIG00L3ZhbGEubTQgfCAgICAzICsrLQ0KIDEg ZmlsZSBjaGFuZ2VkLCAyIGluc2VydGlvbnMoKyksIDEgZGVsZXRpb24oLSkNCg0KZGlmZiAtLWdp dCBhL200L3ZhbGEubTQgYi9tNC92YWxhLm00DQppbmRleCA1ZGFkNDUyLi4xYzYzM2UyIDEwMDY0 NA0KLS0tIGEvbTQvdmFsYS5tNA0KKysrIGIvbTQvdmFsYS5tNA0KQEAgLTIzLDUgKzIzLDYgQEAg QUNfREVGVU4oW0FNX1BST0dfVkFMQUNdLA0KICAgICAgICAgIFtBQ19NU0dfUkVTVUxUKFt5ZXNd KV0sDQogICAgICAgICAgW0FDX01TR19SRVNVTFQoW3llc10pXSwNCiAgICAgICAgICBbQUNfTVNH X1JFU1VMVChbbm9dKQ0KLSAgICAgICAgICBBQ19NU0dfRVJST1IoW1ZhbGEgJDEgbm90IGZvdW5k Ll0sIFs3N10pXSldKV0pDQorICAgICAgICAgIEFDX01TR19XQVJOKFtWYWxhICQxIG5vdCBmb3Vu ZC4gIFlvdSB3aWxsIG5vdCBiZSBhYmxlIHRvIGNvbXBpbGUgLnZhbGEgc291cmNlIGZpbGVzLl0p DQorICAgICAgICAgIHVuc2V0IFZBTEFDXSldKV0pDQogXSkNCi0tIA0KMS43LjEwLjQNCg0K --=-flkK+z4s5RIcXDj5IHqh-- --=-uhWK0yiY6AmlQoMwNAxx Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (GNU/Linux) iQEcBAABAgAGBQJQgn15AAoJED6s7mrP107ed0gH/3bGYfRjrIA+6sXdp2ICX398 rBBluj55Mbqoj92Ycub1OV2YkfezKJuvt9MMsqPzM1Cdd1DY+HB6+5CqcIt83m1T ICPXYWZMNcm1UR6QDDT2yzS+EvoWdaQuuR/iIrTpXqfmv89JFevDridLbnMpdDlw OkIpHlUKp2+kqRmlhUSJX8vUlJ6/+UzDJndCt08krfUOE3YqbYGPOgLFnhZyeEPE UnFY8skGxhqQ3uRMzRmgDLUoq7ze7flwDo4sJmFR9mDgd8NimRtUjSc9pfMPqhb5 AaSuO7MAp2WWlyJ3ScC85OZpjwrfBvJ+z7G2LoN7YXJkISqaQ/tkMD1w5ELgCxA= =54f3 -----END PGP SIGNATURE----- --=-uhWK0yiY6AmlQoMwNAxx-- From debbugs-submit-bounces@debbugs.gnu.org Fri Oct 26 10:01:26 2012 Received: (at 12688) by debbugs.gnu.org; 26 Oct 2012 14:01:26 +0000 Received: from localhost ([127.0.0.1]:34844 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TRkTW-0000vf-Ax for submit@debbugs.gnu.org; Fri, 26 Oct 2012 10:01:26 -0400 Received: from mail-bk0-f44.google.com ([209.85.214.44]:61880) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TRkTU-0000vX-1Y for 12688@debbugs.gnu.org; Fri, 26 Oct 2012 10:01:25 -0400 Received: by mail-bk0-f44.google.com with SMTP id jc3so1188315bkc.3 for <12688@debbugs.gnu.org>; Fri, 26 Oct 2012 06:59:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=message-id:date:from:mime-version:to:cc:subject:references :in-reply-to:content-type:content-transfer-encoding; bh=kr9OVSMzC1xPTUgxO2laVDBvFIefT1zhqPz3fxBzELk=; b=FMXqlPr3zyDf8jM0gpAuE7UNpJ1bxDlL18DlJ9Efr1fIDuQQbpZ1bAo68z6aBVVC2M UYfSefhC/NtBd6sgb8fqidySiv+m3oORWiPX4U7zfezRyH9FdEfa8ExM7WInQnU+LNF1 7t6SUqwiCgzgKrkEad2aVm+X5eyrEwgyp2N72jfaatuPXC8oNNK6XT6rtm1hO+RchHjk qsKBi8m2pvumqdkt+K83Cj3NB9tsPERGHAi+q0mNiNVA7alGRTuh5ehTQjmNLGWF46V6 p73HgUtaoflWP3bYn9vgd6nvoIFftWkSU94d8g6GQBI1+lxW2PQvnd4aROmligluFxbl o1Hg== Received: by 10.204.9.4 with SMTP id j4mr7098345bkj.22.1351259953977; Fri, 26 Oct 2012 06:59:13 -0700 (PDT) Received: from [192.168.178.21] (host247-100-dynamic.8-87-r.retail.telecomitalia.it. [87.8.100.247]) by mx.google.com with ESMTPS id k21sm1070022bkv.1.2012.10.26.06.59.12 (version=SSLv3 cipher=OTHER); Fri, 26 Oct 2012 06:59:13 -0700 (PDT) Message-ID: <508A972D.3030802@gmail.com> Date: Fri, 26 Oct 2012 15:59:09 +0200 From: Stefano Lattarini MIME-Version: 1.0 To: Matthieu Baerts Subject: Re: bug#12688: [LaTeXila] AM_PROG_VALAC: error message -> warning message References: <20121019221155.GF1219@aragorn.home> <1350729081.2826.9.camel@Matth> In-Reply-To: <1350729081.2826.9.camel@Matth> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Score: 0.1 (/) X-Debbugs-Envelope-To: 12688 Cc: 12688@debbugs.gnu.org, =?UTF-8?B?U8OpYmFzdGllbiBXaWxtZXQ=?= X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: 0.1 (/) Hi Matthieu, Sébastien, sorry for the delay. On 10/20/2012 12:31 PM, Matthieu Baerts wrote: > Hello > > 20/10/2012 00:11 +0200, Sébastien Wilmet wrote: >> Hello, >> >> In the AM_PROG_VALAC macro, when the optional parameter specifying the >> minimum release number is not provided, and if the Vala compiler is not >> found, then there is a _warning_ message. >> >> On the other hand, when the version number is specified, when the Vala >> compiler is too old, there is an _error_ message. >> >> This error message is problematic, because for a tarball, the Vala >> compiler is not required: the generated C code is included in the >> tarball. So if a user wants to compile the software, he shouldn't need >> the valac program. >> >> So the AC_MSG_ERROR should be modified as a AC_MSG_WARN. > > I confirm that I had this problem with LaTeXila: I had a too old version > of Vala and I was not able to compile LaTeXila except if > '/usr/bin/valac' was removed/renamed. > > This is how this bug has been fixed in LaTeXila: > https://github.com/swilmet/latexila/commit/993b073c71f094ca5c15cb2a44e69399176b882a > (for those who wants a workaround ;) ) > > Note that if a warning message is produced when a too old version is > detected, 'VALAC' variable has to be unset in vala.m4 > > > This bug should be fixed with the attached patch :) > > > Thank you, > > Matt > I agree the behaviour you want is better and more sensible than the current one. In fact, it mimics the behaviour of a macro like AC_PROG_YACC, which doesn't abort configure if a bison/yacc program is not found in PATH (which makes perfect sense, since Automake distributes the bison-generated C sources, exactly to ensure the final user doesn't need to have a proper bison/yacc program himself). However, I'm not going to apply your patch right away because first I'd like to work on this other enhancement: Once that is done (might be a few days), I will get back to your patch. I definitely plan to have it committed (in one form or another) before releasing Automake 1.12.5. Thanks, Stefano From debbugs-submit-bounces@debbugs.gnu.org Fri Oct 26 11:31:46 2012 Received: (at 12688) by debbugs.gnu.org; 26 Oct 2012 15:31:46 +0000 Received: from localhost ([127.0.0.1]:34899 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TRlsv-0003oh-6e for submit@debbugs.gnu.org; Fri, 26 Oct 2012 11:31:46 -0400 Received: from mail-bk0-f44.google.com ([209.85.214.44]:61884) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TRlss-0003oU-0E; Fri, 26 Oct 2012 11:31:44 -0400 Received: by mail-bk0-f44.google.com with SMTP id jc3so1223034bkc.3 for ; Fri, 26 Oct 2012 08:29:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=message-id:date:from:mime-version:to:cc:subject:references :in-reply-to:content-type:content-transfer-encoding; bh=ujrNR484zVcmLJmCOJyqG+c3fK2uJ4/t6RID1zdKh7U=; b=ubEl1Cx9XaRxUKJztgWCfqiifB19LeGaVNfwc/jUH1CIPOoDBZZt2wn10t9eZUN1Kc KDuKfvQ8aQqLtfNfUYwJ1rFbRfOotb5gvufPD8pJgq/JEibJssAgWf9Deu7JD9Np+XGY rUiDWHqlny/EvJjewrBt5ZjbMEk6/TPWnJmXr10/UqwrI/QsFEzIqoGcz04NKQcLgEE7 q7r3qEE7+uE8Y5ruMDfgPv6+ggtHgl/bXYvtr1JkyLd4vZxzTNrdD2c05W15rRnkzZuP Thvsf3AeMB7OJCR9DtEUqjOWEwZFq6dgkcTPvuHjpPrNK8ARkCYyId4rYTEoGOmmo9qK Tkag== Received: by 10.204.12.195 with SMTP id y3mr7164419bky.7.1351265371429; Fri, 26 Oct 2012 08:29:31 -0700 (PDT) Received: from [192.168.178.21] (host247-100-dynamic.8-87-r.retail.telecomitalia.it. [87.8.100.247]) by mx.google.com with ESMTPS id e13sm1246890bkw.12.2012.10.26.08.29.29 (version=SSLv3 cipher=OTHER); Fri, 26 Oct 2012 08:29:30 -0700 (PDT) Message-ID: <508AAC55.1070401@gmail.com> Date: Fri, 26 Oct 2012 17:29:25 +0200 From: Stefano Lattarini MIME-Version: 1.0 To: Matthieu Baerts Subject: Re: bug#12688: [LaTeXila] AM_PROG_VALAC: error message -> warning message References: <20121019221155.GF1219@aragorn.home> <1350729081.2826.9.camel@Matth> <508A972D.3030802@gmail.com> In-Reply-To: <508A972D.3030802@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Score: 0.1 (/) X-Debbugs-Envelope-To: 12688 Cc: 12688@debbugs.gnu.org, =?UTF-8?B?U8OpYmFzdGllbiBXaWxtZXQ=?= X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.6 (--) tags 12688 + patch thanks On 10/26/2012 03:59 PM, Stefano Lattarini wrote: > Hi Matthieu, Sébastien, sorry for the delay. > > On 10/20/2012 12:31 PM, Matthieu Baerts wrote: >> Hello >> >> 20/10/2012 00:11 +0200, Sébastien Wilmet wrote: >>> Hello, >>> >>> In the AM_PROG_VALAC macro, when the optional parameter specifying the >>> minimum release number is not provided, and if the Vala compiler is not >>> found, then there is a _warning_ message. >>> >>> On the other hand, when the version number is specified, when the Vala >>> compiler is too old, there is an _error_ message. >>> >>> This error message is problematic, because for a tarball, the Vala >>> compiler is not required: the generated C code is included in the >>> tarball. So if a user wants to compile the software, he shouldn't need >>> the valac program. >>> >>> So the AC_MSG_ERROR should be modified as a AC_MSG_WARN. >> >> I confirm that I had this problem with LaTeXila: I had a too old version >> of Vala and I was not able to compile LaTeXila except if >> '/usr/bin/valac' was removed/renamed. >> >> This is how this bug has been fixed in LaTeXila: >> https://github.com/swilmet/latexila/commit/993b073c71f094ca5c15cb2a44e69399176b882a >> (for those who wants a workaround ;) ) >> >> Note that if a warning message is produced when a too old version is >> detected, 'VALAC' variable has to be unset in vala.m4 >> >> >> This bug should be fixed with the attached patch :) >> >> >> Thank you, >> >> Matt >> > I agree the behaviour you want is better and more sensible than the > current one. In fact, it mimics the behaviour of a macro like > AC_PROG_YACC, which doesn't abort configure if a bison/yacc program > is not found in PATH (which makes perfect sense, since Automake > distributes the bison-generated C sources, exactly to ensure the > final user doesn't need to have a proper bison/yacc program himself). > > However, I'm not going to apply your patch right away because first > I'd like to work on this other enhancement: > > > > Once that is done (might be a few days), I will get back to your > patch. I definitely plan to have it committed (in one form or another) > before releasing Automake 1.12.5. > Here is the patch. Can I have your ACK on it? I will push it by this evening if there is no answer by then? Thanks, Stefano P.S. note that this patch is part of a wider patch series I'm writing, so it won't apply cleanly on maint or master. I will later post the whole series on the automake-patches list, in case anyone is interested. -----8<-----8<-----8<-----8<-----8<-----8<-----8<-----8<-----8<-----8<----- >From 8a1f86381f1c7a8b21b4da38ebb53b44e1664667 Mon Sep 17 00:00:00 2001 Message-Id: <8a1f86381f1c7a8b21b4da38ebb53b44e1664667.1351264987.git.stefano.lattarini@gmail.com> From: =?UTF-8?q?S=C3=A9bastien=20Wilmet?= Date: Fri, 26 Oct 2012 17:08:09 +0200 Subject: [PATCH] vala: AM_PROG_VALAC should not produce an error for tool-old valac This change fixes automake bug#12688. In the AM_PROG_VALAC macro, when the optional parameter specifying the minimum release number is not provided, and/or if the Vala compiler is not found, then there is a _warning_ message. On the other hand, when the version number is specified and if the Vala compiler is too old, there is an _error_ message. This error message is problematic, because for a tarball, the Vala compiler is not required: the generated C code is included in the tarball. So if a user wants to compile the software, he shouldn't need the valac program with the right version. * m4/vala.m4 (AM_PROG_VALAC): Modify to use AC_MSG_WARN instead of AC_MSG_ERROR. * t/vala4.sh: Adjust and enhance. * doc/automake.texi (Vala Support): Likewise. * THANKS: Update. Co-authored-by: Matthieu Baerts Co-authored-by: Stefano Lattarini Copyright-paperwork-exempt: yes Signed-off-by: Stefano Lattarini --- THANKS | 2 ++ doc/automake.texi | 3 +-- m4/vala.m4 | 2 +- t/vala4.sh | 40 +++++++++++++++++++++++++++------------- 4 files changed, 31 insertions(+), 16 deletions(-) diff --git a/THANKS b/THANKS index 88f539c..1ff7c08 100644 --- a/THANKS +++ b/THANKS @@ -247,6 +247,7 @@ Matthew D. Langston langston@SLAC.Stanford.EDU Matthias Andree matthias.andree@gmx.de Matthias Clasen clasen@mathematik.uni-freiburg.de Matthias Klose doko@ubuntu.com +Matthieu Baerts matttbe@glx-dock.org Max Horn max@quendi.de Maxim Sinev good@goods.ru Maynard Johnson maynardj@us.ibm.com @@ -348,6 +349,7 @@ Sam Steingold sds@gnu.org Sander Niemeijer niemeijer@science-and-technology.nl Santiago Vila sanvila@unex.es Scott James Remnant scott@netsplit.com +Sébastien Wilmet swilmet@gnome.org Sergey Poznyakoff gray@gnu.org.ua Sergey Vlasov vsu@mivlgu.murom.ru Seth Alves alves@hungry.com diff --git a/doc/automake.texi b/doc/automake.texi index 54262c8..aaf4a98 100644 --- a/doc/automake.texi +++ b/doc/automake.texi @@ -6893,8 +6893,7 @@ package. If a compiler is found and satisfies @var{minimum-version}, then @var{action-if-found} is run (this defaults to do nothing). Otherwise, @var{action-if-not-found} is run. If @var{action-if-not-found} is not specified, the default value is to print a warning in case no -compiler is found, and to abort the configure script (with status 77) -if a too-old version of the compiler is found. +compiler is found, or if a too-old version of the compiler is found. @end defmac There are a few variables that are used when compiling Vala sources: diff --git a/m4/vala.m4 b/m4/vala.m4 index 0674c8e..0da8d67 100644 --- a/m4/vala.m4 +++ b/m4/vala.m4 @@ -27,7 +27,7 @@ AC_DEFUN([AM_PROG_VALAC], [AC_MSG_RESULT([no]) VALAC=:])]) if test x"$VALAC" = x":"; then - m4_default([$3], [AC_MSG_ERROR([no proper vala compiler found], [77])]) + m4_default([$3], [AC_MSG_WARN([no proper vala compiler found])]) else m4_default([$2], [:]) fi])]) diff --git a/t/vala4.sh b/t/vala4.sh index f622e5c..fcb60ed 100755 --- a/t/vala4.sh +++ b/t/vala4.sh @@ -26,7 +26,7 @@ END cat > Makefile.am << 'END' has-valac: - case '$(VALAC)' in *valac) exit 0;; *) exit 1;; esac + case '$(VALAC)' in */valac) exit 0;; *) exit 1;; esac no-valac: test x'$(VALAC)' = x: END @@ -59,23 +59,29 @@ $ACLOCAL $AUTOMAKE -a $AUTOCONF -# The "|| exit 1" are required here even if 'set -e' is active, -# because ./configure might exit with status 77, and in that case -# we want to FAIL, not to SKIP. -./configure || exit 1 +st=0; ./configure 2>stderr || st=$? +cat stderr >&2 +grep 'WARNING.*vala' stderr && exit 1 +test $st -eq 0 $MAKE has-valac -vala_version=99.9 ./configure || exit 1 + +st=0; vala_version=99.9 ./configure 2>stderr || st=$? +cat stderr >&2 +grep 'WARNING.*vala' stderr && exit 1 +test $st -eq 0 $MAKE has-valac st=0; vala_version=0.1.2 ./configure 2>stderr || st=$? cat stderr >&2 -test $st -eq 77 || exit 1 -#$MAKE no-valac +test $st -eq 0 +grep '^configure: WARNING: no proper vala compiler found' stderr +$MAKE no-valac st=0; ./configure VALAC="$(pwd)/bin/valac.old" 2>stderr || st=$? cat stderr >&2 -test $st -eq 77 || exit 1 -#$MAKE no-valac +test $st -eq 0 || exit 1 +grep '^configure: WARNING: no proper vala compiler found' stderr +$MAKE no-valac sed 's/^\(AM_PROG_VALAC\).*/\1([1], [: > ok], [: > ko])/' t mv -f t configure.ac @@ -83,19 +89,27 @@ rm -rf autom4te*.cache $ACLOCAL $AUTOCONF -./configure +st=0; ./configure 2>stderr || st=$? +cat stderr >&2 +grep 'WARNING.*vala' stderr && exit 1 test -f ok test ! -e ko $MAKE has-valac rm -f ok ko -vala_version=0.1.2 ./configure +st=0; vala_version=0.1.2 ./configure 2>stderr || st=$? +cat stderr >&2 +grep 'WARNING.*vala' stderr && exit 1 +test $st -eq 0 test ! -e ok test -f ko $MAKE no-valac rm -f ok ko -./configure VALAC="$(pwd)/bin/valac.old" +st=0; ./configure VALAC="$(pwd)/bin/valac.old" 2>stderr || st=$? +cat stderr >&2 +grep 'WARNING.*vala' stderr && exit 1 +test $st -eq 0 test ! -e ok test -f ko $MAKE no-valac -- 1.8.0 From debbugs-submit-bounces@debbugs.gnu.org Fri Oct 26 11:57:27 2012 Received: (at 12688) by debbugs.gnu.org; 26 Oct 2012 15:57:27 +0000 Received: from localhost ([127.0.0.1]:34933 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TRmHn-0005FQ-K5 for submit@debbugs.gnu.org; Fri, 26 Oct 2012 11:57:27 -0400 Received: from mail-ea0-f172.google.com ([209.85.215.172]:61740) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TRmHl-0005FJ-Gy for 12688@debbugs.gnu.org; Fri, 26 Oct 2012 11:57:26 -0400 Received: by mail-ea0-f172.google.com with SMTP id k13so945180eaa.3 for <12688@debbugs.gnu.org>; Fri, 26 Oct 2012 08:55:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:message-id:subject:from:to:cc:date:in-reply-to:references :content-type:x-mailer:mime-version; bh=I65jOteEkVuNdJIOzu4jwuliztVzR/fAWGc5Z87kshM=; b=qnvu+ok9Eij65CCyHVjIJt1z+bpkGbiGb9fQjwGxGORzNFLXlWW7f8RUp0bav59YoA 61UAps7/0+6M+Q9kQe9uvgHodr5ikS/kiOCRdVR964IR5men4JbGVRYzHOymHF2MNiMG e6t1cDWvVM0PteBAVPDNcZRXLIhA1VupzKV049MPNXqsIliUw13nZD1u31JX+OTtK03f XIZX0rWnACMRVlTBGeaHSTjeR0CMjgCtQxS7D0reebUJpSz8wfTf85B1WhIXcB2+7yDj txTW1Rh0FxRf9yxcCwtqjYHP/bB+qd/Vd2EDPshEPQruq7yqWFEGyp45OL1sLDwp0p6B oQbA== Received: by 10.14.194.136 with SMTP id m8mr33599144een.10.1351266914957; Fri, 26 Oct 2012 08:55:14 -0700 (PDT) Received: from [192.168.1.7] (ip-83-134-50-172.dsl.scarlet.be. [83.134.50.172]) by mx.google.com with ESMTPS id e7sm3402676eep.1.2012.10.26.08.55.13 (version=SSLv3 cipher=OTHER); Fri, 26 Oct 2012 08:55:14 -0700 (PDT) Message-ID: <1351266904.6815.5.camel@Matth> Subject: Re: bug#12688: [LaTeXila] AM_PROG_VALAC: error message -> warning message From: Matthieu Baerts To: Stefano Lattarini Date: Fri, 26 Oct 2012 17:55:04 +0200 In-Reply-To: <508AAC55.1070401@gmail.com> References: <20121019221155.GF1219@aragorn.home> <1350729081.2826.9.camel@Matth> <508A972D.3030802@gmail.com> <508AAC55.1070401@gmail.com> Content-Type: multipart/signed; micalg="pgp-sha1"; protocol="application/pgp-signature"; boundary="=-Qjp7+DC636bG/C/q3TMn" X-Mailer: Evolution 3.6.0-0ubuntu3 Mime-Version: 1.0 X-Spam-Score: 0.1 (/) X-Debbugs-Envelope-To: 12688 Cc: 12688@debbugs.gnu.org, =?ISO-8859-1?Q?S=E9bastien?= Wilmet X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: 0.1 (/) --=-Qjp7+DC636bG/C/q3TMn Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hi Stefano and thank you for maintaining Automake :) On 10/26/2012 17:29 +0200, Stefano Lattarini wrote: > tags 12688 + patch > thanks >=20 > On 10/26/2012 03:59 PM, Stefano Lattarini wrote: > > Hi Matthieu, S=C3=A9bastien, sorry for the delay. > > I agree the behaviour you want is better and more sensible than the > > current one. In fact, it mimics the behaviour of a macro like > > AC_PROG_YACC, which doesn't abort configure if a bison/yacc program > > is not found in PATH (which makes perfect sense, since Automake > > distributes the bison-generated C sources, exactly to ensure the > > final user doesn't need to have a proper bison/yacc program himself). > >=20 > > However, I'm not going to apply your patch right away because first > > I'd like to work on this other enhancement: > >=20 > > > >=20 > > Once that is done (might be a few days), I will get back to your > > patch. I definitely plan to have it committed (in one form or another) > > before releasing Automake 1.12.5. > > > Here is the patch. Can I have your ACK on it? I will push it by this > evening if there is no answer by then? This seems perfect, thank you for this fix! > Thanks, > Stefano >=20 > P.S. note that this patch is part of a wider patch series I'm writing, so > it won't apply cleanly on maint or master. I will later post the whole > series on the automake-patches list, in case anyone is interested. I'll test this new version asap. Have a nice day, Thanks, Matt --=-Qjp7+DC636bG/C/q3TMn Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (GNU/Linux) iQEcBAABAgAGBQJQirJZAAoJED6s7mrP107eqjgH/3Bca9TxiH78yInkQXpQz345 IFzM/A/5U2wIe8/03q0SKgj6wf/2zqKWKohLUVHz2C8zm2QfAMryefSDfFyWvaaJ 8AKEiUWuiH8dGhwLZbovw/mcBr2G3vUW+E4k0LmcEWgcByBJROYp79VeqGUkBrIl 3+I07RiS2dD5gz6s7FvCyt4HlPasCT4qTm4Poz7N9Tpytd3g2EjidRhrwdUnwr9H MsNgaFW/jUC2xZuyqAQ3GdKOnMycUnZU5Tb0hdpGymAZW4NM/2FidY2KqqbrQnGL vfgxvdywfL5PUUF1Lc293U7ceUWs4MZPoDHulWIaQ40ovLHoCjnqoyqW9lPeIkU= =ZKBM -----END PGP SIGNATURE----- --=-Qjp7+DC636bG/C/q3TMn-- From debbugs-submit-bounces@debbugs.gnu.org Wed Nov 21 08:23:36 2012 Received: (at control) by debbugs.gnu.org; 21 Nov 2012 13:23:36 +0000 Received: from localhost ([127.0.0.1]:58319 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TbAH9-0007E4-Qo for submit@debbugs.gnu.org; Wed, 21 Nov 2012 08:23:36 -0500 Received: from mail-la0-f44.google.com ([209.85.215.44]:53653) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TbAH8-0007Dx-PR for control@debbugs.gnu.org; Wed, 21 Nov 2012 08:23:35 -0500 Received: by mail-la0-f44.google.com with SMTP id d3so5855439lah.3 for ; Wed, 21 Nov 2012 05:22:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=message-id:date:from:mime-version:to:subject:content-type :content-transfer-encoding; bh=JgHMzHQADid8G1CRPB4X3DlcvW77Vxm1lDEMIp1spvY=; b=kxeqhFGjkeBQ2ZShD5IGaraon5IUxO0N2rIsrIlaWEQ5eav8JjaIfmVkhvHMJdEKrO MbZZjf6o+XpzEM/9lUnaP+0K5v2HlJrAxwiCK80pfduKe974Xi0t+4UV0psnx6V5qqu3 B7/lP/x7o/q5U5v1r1DY1pAMrwNj4pn8se8kaeQXb0PMWIxWNUifNVVir0KFxF6W/nck 5ybzsQ/BAzfBY8Is8FFzs5wJfFzBu297JaCHu8j1WHB8MX/kTbH+QZgyiK9DszoOOBou jQMqMRw231c2lr2LeYkv062hH75jNpaASbh3CwbxApSwvHCER1RJEIkfHbpsbWrCqebK vDdg== Received: by 10.152.114.100 with SMTP id jf4mr17939294lab.47.1353504138549; Wed, 21 Nov 2012 05:22:18 -0800 (PST) Received: from [192.168.178.21] (host247-100-dynamic.8-87-r.retail.telecomitalia.it. [87.8.100.247]) by mx.google.com with ESMTPS id d5sm251824lbk.10.2012.11.21.05.22.16 (version=SSLv3 cipher=OTHER); Wed, 21 Nov 2012 05:22:17 -0800 (PST) Message-ID: <50ACD585.2060801@gmail.com> Date: Wed, 21 Nov 2012 14:22:13 +0100 From: Stefano Lattarini MIME-Version: 1.0 To: GNU bug tracker automated control server Subject: 12688 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Score: 0.1 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: 0.1 (/) close 12688 stop From unknown Sun Jun 15 08:59:25 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Thu, 20 Dec 2012 12:24:04 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator