From unknown Sat Aug 16 14:25:33 2025 X-Loop: help-debbugs@gnu.org Subject: bug#12670: 24.2.50; Uncustomizable defcustom Resent-From: Katsumi Yamaoka Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 18 Oct 2012 09:36:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 12670 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: 12670@debbugs.gnu.org X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.13505529201114 (code B ref -1); Thu, 18 Oct 2012 09:36:02 +0000 Received: (at submit) by debbugs.gnu.org; 18 Oct 2012 09:35:20 +0000 Received: from localhost ([127.0.0.1]:49392 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TOmVb-0000Hu-AO for submit@debbugs.gnu.org; Thu, 18 Oct 2012 05:35:20 -0400 Received: from eggs.gnu.org ([208.118.235.92]:44454) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TOmVY-0000He-Lx for submit@debbugs.gnu.org; Thu, 18 Oct 2012 05:35:17 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TOmU2-00046G-Kp for submit@debbugs.gnu.org; Thu, 18 Oct 2012 05:33:48 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_HI, T_TVD_MIME_NO_HEADERS autolearn=unavailable version=3.3.2 Received: from lists.gnu.org ([208.118.235.17]:57220) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TOmU2-000462-IH for submit@debbugs.gnu.org; Thu, 18 Oct 2012 05:33:42 -0400 Received: from eggs.gnu.org ([208.118.235.92]:59485) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TOmTw-0001e5-PE for bug-gnu-emacs@gnu.org; Thu, 18 Oct 2012 05:33:42 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TOmTs-000434-Eo for bug-gnu-emacs@gnu.org; Thu, 18 Oct 2012 05:33:36 -0400 Received: from orlando.hostforweb.net ([216.246.45.90]:33614) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TOmTs-00042f-BH for bug-gnu-emacs@gnu.org; Thu, 18 Oct 2012 05:33:32 -0400 Received: from localhost ([127.0.0.1]:43576) by orlando.hostforweb.net with smtp (Exim 4.77) (envelope-from ) id 1TOmTp-0006xk-K4; Thu, 18 Oct 2012 04:33:29 -0500 Date: Thu, 18 Oct 2012 18:33:25 +0900 Message-ID: From: Katsumi Yamaoka Organization: Emacsen advocacy group X-Face: #kKnN,xUnmKia.'[pp`; Omh}odZK)?7wQSl"4o04=EixTF+V[""w~iNbM9ZL+.b*_CxUmFk B#Fu[*?MZZH@IkN:!"\w%I_zt>[$nm7nQosZ<3eu; B:$Q_:p!',P.c0-_Cy[dz4oIpw0ESA^D*1Lw= L&i*6&( User-Agent: Gnus/5.130006 (=?UTF-8?Q?=E7=9C=9F?= Gnus v0.6) Emacs/24.2.50 (i686-pc-cygwin) Cancel-Lock: sha1:fP671QBUYNzENSmQlWL4khZNyEg= MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - orlando.hostforweb.net X-AntiAbuse: Original Domain - gnu.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - jpl.org X-Source: X-Source-Args: X-Source-Dir: X-detected-operating-system: by eggs.gnu.org: Linux 2.6? (barebone, rare!) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-Received-From: 208.118.235.17 X-Spam-Score: -4.2 (----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -4.2 (----) --=-=-= Hi, I realized that a certain defcustom form is unable to customize a user option. To reproduce this, evaluate the following form, perform M-x customize-option, and press the [INS] button. (defcustom foo nil "Doc" :type '(repeat (group (group :inline t (choice string function))))) Then you will find a funny thing there and see it is unable to edit. After some investigations I found this is due to `widget-default-get', that fails to get the default value of components within an inlined form (I mean (bar :inline t ...)). A patch is attached, not tested with all sorts of defcustom forms though. --=-=-= Content-Type: text/x-patch Content-Disposition: inline; filename=DIFF --- wid-edit.el~ 2012-04-22 21:52:01.618551000 +0000 +++ wid-edit.el 2012-10-18 09:27:17.158803700 +0000 @@ -525,9 +525,18 @@ (defun widget-default-get (widget) "Extract the default external value of WIDGET." (widget-apply widget :value-to-external (or (widget-get widget :value) - (widget-apply widget :default-get)))) + (progn + (when (widget-get widget :args) + (let (args) + (dolist (arg (widget-get widget :args)) + (setq args (append args + (if (widget-get arg :inline) + (widget-get arg :args) + (list arg))))) + (widget-put widget :args args))) + (widget-apply widget :default-get))))) (defun widget-match-inline (widget vals) "In WIDGET, match the start of VALS." (cond ((widget-get widget :inline) --=-=-=-- From unknown Sat Aug 16 14:25:33 2025 X-Loop: help-debbugs@gnu.org Subject: bug#12670: 24.2.50; Uncustomizable defcustom Resent-From: Chong Yidong Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 22 Dec 2012 01:43:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 12670 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Katsumi Yamaoka Cc: 12670@debbugs.gnu.org Received: via spool by 12670-submit@debbugs.gnu.org id=B12670.135614052620360 (code B ref 12670); Sat, 22 Dec 2012 01:43:02 +0000 Received: (at 12670) by debbugs.gnu.org; 22 Dec 2012 01:42:06 +0000 Received: from localhost ([127.0.0.1]:54761 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TmE6H-0005IK-DU for submit@debbugs.gnu.org; Fri, 21 Dec 2012 20:42:06 -0500 Received: from mail-pb0-f42.google.com ([209.85.160.42]:55195) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TmE6E-0005IB-NS for 12670@debbugs.gnu.org; Fri, 21 Dec 2012 20:42:03 -0500 Received: by mail-pb0-f42.google.com with SMTP id rp2so3039817pbb.15 for <12670@debbugs.gnu.org>; Fri, 21 Dec 2012 17:41:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=x-received:sender:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-type; bh=ssSxaCmekgaKbGVSvCdm3f9ZvQDq6OewQUJx2/SmE2U=; b=RrvigBpqnq3hv5DJGoIA85bbAdLpzB2PfEVJxufAB+rPQ3Ys/DhfWEr5VRNcGjecoJ /AXKVk8AqjiRj4BuKkx4ePMjK3zln3XBczQvSMl2PQS30L/p3i44RVQo5MM9QblzdN50 5SJso1IC8YsS9vRVokh0r89NXPD0UitAsKhWlXoEm78BaTcU1ImNtJKO/nJWMISCVDDS 34zIHRPz/xvmariJKT5OG7fX2wE6lwJsN9SMBo8NU8ulel0TA13nKWboi++HcwBoUHO3 yNZ0JUSgOSBVch9+tOEnDVjo4ySLipNq3r8P4sOfsSCH6gbeYu9JSx10SFpYeUDmUwZE SDAw== X-Received: by 10.69.0.199 with SMTP id ba7mr28751087pbd.165.1356140505559; Fri, 21 Dec 2012 17:41:45 -0800 (PST) Received: from ulysses (cm107.delta179.maxonline.com.sg. [59.189.179.107]) by mx.google.com with ESMTPS id i1sm8309039pav.35.2012.12.21.17.41.31 (version=SSLv3 cipher=OTHER); Fri, 21 Dec 2012 17:41:44 -0800 (PST) From: Chong Yidong References: Date: Sat, 22 Dec 2012 09:41:27 +0800 In-Reply-To: (Katsumi Yamaoka's message of "Thu, 18 Oct 2012 18:33:25 +0900") Message-ID: <87fw2y7tiw.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.2.91 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.1 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.6 (--) Katsumi Yamaoka writes: > evaluate the following form, perform M-x customize-option, and press > the [INS] button. > > (defcustom foo nil > "Doc" > :type '(repeat (group (group :inline t (choice string function))))) > > Then you will find a funny thing there and see it is unable to > edit. I can't reproduce this on Emacs 23.4, the emacs-24 branch, or trunk. After opening the customization buffer for `foo', I click on INS and it opens up INS DEL Choice: Value Menu invalid (nil) and clicking on "Value Menu" allows me to insert a function or string. From unknown Sat Aug 16 14:25:33 2025 X-Loop: help-debbugs@gnu.org Subject: bug#12670: 24.2.50; Uncustomizable defcustom In-Reply-To: Resent-From: Katsumi Yamaoka Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 22 Dec 2012 13:37:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 12670 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Chong Yidong Cc: 12670@debbugs.gnu.org Received: via spool by 12670-submit@debbugs.gnu.org id=B12670.13561833813212 (code B ref 12670); Sat, 22 Dec 2012 13:37:02 +0000 Received: (at 12670) by debbugs.gnu.org; 22 Dec 2012 13:36:21 +0000 Received: from localhost ([127.0.0.1]:55133 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TmPFU-0000pl-MX for submit@debbugs.gnu.org; Sat, 22 Dec 2012 08:36:21 -0500 Received: from mail-halifax.hostforweb.net ([205.234.137.17]:56592 helo=halifax.hostforweb.net) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TmPFQ-0000pc-RJ for 12670@debbugs.gnu.org; Sat, 22 Dec 2012 08:36:18 -0500 Received: from softbank219034144017.bbtec.net ([219.34.144.17]:38171 helo=) by halifax.hostforweb.net with esmtpsa (TLSv1:DHE-RSA-AES128-SHA:128) (Exim 4.80) (envelope-from ) id 1TmPF6-0003tG-Bs; Sat, 22 Dec 2012 07:35:56 -0600 From: Katsumi Yamaoka References: <87fw2y7tiw.fsf@gnu.org> X-Face: #kKnN,xUnmKia.'[pp`; Omh}odZK)?7wQSl"4o04=EixTF+V[""w~iNbM9ZL+.b*_CxUmFk B#Fu[*?MZZH@IkN:!"\w%I_zt>[$nm7nQosZ<3eu; B:$Q_:p!',P.c0-_Cy[dz4oIpw0ESA^D*1Lw= L&i*6&( Date: Sat, 22 Dec 2012 22:35:51 +0900 Message-ID: User-Agent: Gnus/5.130006 (Ma Gnus v0.6) Emacs/24.3.50 (gnu/linux) Cancel-Lock: sha1:xSkWZNW0LqnfpaZ26TSLyej2YrA= MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - halifax.hostforweb.net X-AntiAbuse: Original Domain - debbugs.gnu.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - jpl.org X-Get-Message-Sender-Via: halifax.hostforweb.net: authenticated_id: yamaokac/only user confirmed/virtual account not confirmed X-Source: X-Source-Args: X-Source-Dir: X-Spam-Score: 0.8 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -0.0 (/) Chong Yidong wrote: > Katsumi Yamaoka writes: >> evaluate the following form, perform M-x customize-option, and press >> the [INS] button. >> (defcustom foo nil >> "Doc" >> :type '(repeat (group (group :inline t (choice string function))))) >> Then you will find a funny thing there and see it is unable to >> edit. > I can't reproduce this on Emacs 23.4, the emacs-24 branch, or trunk. > After opening the customization buffer for `foo', I click on INS and it > opens up > INS DEL Choice: Value Menu invalid (nil) > and clicking on "Value Menu" allows me to insert a function or string. Oops, you're right. I don't recall why I said it's uncustomisable, but please let me rephrase it: That defcustom form is unable to suggest a default value, that's the one suitable to beginners for example, to a user. Could you try the following two examples? Both behaviors should be the same. And my patch solves it. (defcustom foo1 nil "Doc" :type '(repeat (group (group :inline t (choice (string :value "foo") function))))) (defcustom foo2 nil "Doc" :type '(repeat (group (choice (string :value "foo") function)))) From unknown Sat Aug 16 14:25:33 2025 X-Loop: help-debbugs@gnu.org Subject: bug#12670: 24.2.50; Uncustomizable defcustom Resent-From: Chong Yidong Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 06 Jan 2013 03:39:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 12670 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Katsumi Yamaoka Cc: 12670@debbugs.gnu.org Received: via spool by 12670-submit@debbugs.gnu.org id=B12670.1357443497573 (code B ref 12670); Sun, 06 Jan 2013 03:39:02 +0000 Received: (at 12670) by debbugs.gnu.org; 6 Jan 2013 03:38:17 +0000 Received: from localhost ([127.0.0.1]:46833 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1Trh3w-00009C-NB for submit@debbugs.gnu.org; Sat, 05 Jan 2013 22:38:17 -0500 Received: from mail-da0-f52.google.com ([209.85.210.52]:45126) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1Trh3t-000097-9k for 12670@debbugs.gnu.org; Sat, 05 Jan 2013 22:38:14 -0500 Received: by mail-da0-f52.google.com with SMTP id f10so8095022dak.25 for <12670@debbugs.gnu.org>; Sat, 05 Jan 2013 19:37:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=x-received:sender:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-type; bh=K74tjV+HmK6I+V17mo9E1tpXDX8FkKS0NGSrh6WNQwU=; b=hC1wLPWCFlt6xoe45WQVhBx94kHCTgpmiDdtxpz0yka654ZvKzLTmAqdAtcJ4lIK38 5D7b1ZtT/pShZ++vvzhA/nK3hepn0LoUuv6Q4pznvn+PbpnwG4zYgeVrxwzTyK76AWZg lqvS8Hei+IhLqh1iKUMN0LxCXFkZGpGQGP6LbAS9wLFxLXvwvvGy4cQTctvu1krbODzi 9eAUQ45cAovzCAi+V2gvwRt5oaGOL0iz4y9ZpCTCmF67eRjpBEEhxQjES+eCsk+buHTW BHh/E5VeyUHpQ3RjIjk7LbdKaB1kEhIh0N28VTcpVQWVl4aGkiuAoIsIXNger/LPvnEQ 6R0Q== X-Received: by 10.69.0.101 with SMTP id ax5mr173369902pbd.105.1357443474826; Sat, 05 Jan 2013 19:37:54 -0800 (PST) Received: from tsparkle (cm107.delta179.maxonline.com.sg. [59.189.179.107]) by mx.google.com with ESMTPS id oi3sm35077491pbb.1.2013.01.05.19.37.52 (version=SSLv3 cipher=OTHER); Sat, 05 Jan 2013 19:37:53 -0800 (PST) From: Chong Yidong References: <87fw2y7tiw.fsf@gnu.org> Date: Sun, 06 Jan 2013 11:37:49 +0800 In-Reply-To: (Katsumi Yamaoka's message of "Sat, 22 Dec 2012 22:35:51 +0900") Message-ID: <87txqvvv5e.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.2.91 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.6 (--) Katsumi Yamaoka writes: > Oops, you're right. I don't recall why I said it's uncustomisable, > but please let me rephrase it: > That defcustom form is unable to suggest a default value, that's > the one suitable to beginners for example, to a user. Could you > try the following two examples? Both behaviors should be the same. > And my patch solves it. Ah, OK. Looks fine to me, please go ahead and commit to trunk. From unknown Sat Aug 16 14:25:33 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.428 (Entity 5.428) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: Katsumi Yamaoka Subject: bug#12670: closed (Re: bug#12670: 24.2.50; Uncustomizable defcustom) Message-ID: References: X-Gnu-PR-Message: they-closed 12670 X-Gnu-PR-Package: emacs Reply-To: 12670@debbugs.gnu.org Date: Mon, 07 Jan 2013 11:27:07 +0000 Content-Type: multipart/mixed; boundary="----------=_1357558027-22891-1" This is a multi-part message in MIME format... ------------=_1357558027-22891-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #12670: 24.2.50; Uncustomizable defcustom which was filed against the emacs package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 12670@debbugs.gnu.org. --=20 12670: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D12670 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1357558027-22891-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 12670-done) by debbugs.gnu.org; 7 Jan 2013 11:26:42 +0000 Received: from localhost ([127.0.0.1]:33773 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TsAqZ-0005wO-Lt for submit@debbugs.gnu.org; Mon, 07 Jan 2013 06:26:41 -0500 Received: from hampton.hostforweb.net ([205.234.140.233]:38553) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TsAq1-0005vF-8h for 12670-done@debbugs.gnu.org; Mon, 07 Jan 2013 06:26:10 -0500 Received: from localhost.localdomain ([127.0.0.1]:45538 helo=localhost) by hampton.hostforweb.net with smtp (Exim 4.80) (envelope-from ) id 1TsApn-003V8w-Ua; Mon, 07 Jan 2013 05:25:40 -0600 Date: Mon, 07 Jan 2013 20:25:49 +0900 Message-ID: From: Katsumi Yamaoka To: 12670-done@debbugs.gnu.org Subject: Re: bug#12670: 24.2.50; Uncustomizable defcustom References: <87fw2y7tiw.fsf@gnu.org> <87txqvvv5e.fsf@gnu.org> Organization: Emacsen advocacy group X-Face: #kKnN,xUnmKia.'[pp`; Omh}odZK)?7wQSl"4o04=EixTF+V[""w~iNbM9ZL+.b*_CxUmFk B#Fu[*?MZZH@IkN:!"\w%I_zt>[$nm7nQosZ<3eu; B:$Q_:p!',P.c0-_Cy[dz4oIpw0ESA^D*1Lw= L&i*6&( User-Agent: Gnus/5.130006 (=?iso-2022-jp?B?GyRCPz8bKEI=?= Gnus v0.6) Emacs/24.3.50 (i686-pc-cygwin) Cancel-Lock: sha1:XWshRRUn4wORgWftejiCFw4LuxE= MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - hampton.hostforweb.net X-AntiAbuse: Original Domain - debbugs.gnu.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - jpl.org X-Get-Message-Sender-Via: hampton.hostforweb.net: acl_c_authenticated_local_user: root X-Source: X-Source-Args: X-Source-Dir: X-Spam-Score: 0.8 (/) X-Debbugs-Envelope-To: 12670-done Cc: cyd@gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: 0.8 (/) Chong Yidong wrote: > Ah, OK. Looks fine to me, please go ahead and commit to trunk. Thanks. Done. ------------=_1357558027-22891-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 18 Oct 2012 09:35:20 +0000 Received: from localhost ([127.0.0.1]:49392 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TOmVb-0000Hu-AO for submit@debbugs.gnu.org; Thu, 18 Oct 2012 05:35:20 -0400 Received: from eggs.gnu.org ([208.118.235.92]:44454) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TOmVY-0000He-Lx for submit@debbugs.gnu.org; Thu, 18 Oct 2012 05:35:17 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TOmU2-00046G-Kp for submit@debbugs.gnu.org; Thu, 18 Oct 2012 05:33:48 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_HI, T_TVD_MIME_NO_HEADERS autolearn=unavailable version=3.3.2 Received: from lists.gnu.org ([208.118.235.17]:57220) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TOmU2-000462-IH for submit@debbugs.gnu.org; Thu, 18 Oct 2012 05:33:42 -0400 Received: from eggs.gnu.org ([208.118.235.92]:59485) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TOmTw-0001e5-PE for bug-gnu-emacs@gnu.org; Thu, 18 Oct 2012 05:33:42 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TOmTs-000434-Eo for bug-gnu-emacs@gnu.org; Thu, 18 Oct 2012 05:33:36 -0400 Received: from orlando.hostforweb.net ([216.246.45.90]:33614) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TOmTs-00042f-BH for bug-gnu-emacs@gnu.org; Thu, 18 Oct 2012 05:33:32 -0400 Received: from localhost ([127.0.0.1]:43576) by orlando.hostforweb.net with smtp (Exim 4.77) (envelope-from ) id 1TOmTp-0006xk-K4; Thu, 18 Oct 2012 04:33:29 -0500 Date: Thu, 18 Oct 2012 18:33:25 +0900 Message-ID: From: Katsumi Yamaoka To: bug-gnu-emacs@gnu.org Subject: 24.2.50; Uncustomizable defcustom Organization: Emacsen advocacy group X-Face: #kKnN,xUnmKia.'[pp`; Omh}odZK)?7wQSl"4o04=EixTF+V[""w~iNbM9ZL+.b*_CxUmFk B#Fu[*?MZZH@IkN:!"\w%I_zt>[$nm7nQosZ<3eu; B:$Q_:p!',P.c0-_Cy[dz4oIpw0ESA^D*1Lw= L&i*6&( User-Agent: Gnus/5.130006 (=?iso-2022-jp?B?GyRCPz8bKEI=?= Gnus v0.6) Emacs/24.2.50 (i686-pc-cygwin) Cancel-Lock: sha1:fP671QBUYNzENSmQlWL4khZNyEg= MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - orlando.hostforweb.net X-AntiAbuse: Original Domain - gnu.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - jpl.org X-Source: X-Source-Args: X-Source-Dir: X-detected-operating-system: by eggs.gnu.org: Linux 2.6? (barebone, rare!) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-Received-From: 208.118.235.17 X-Spam-Score: -4.2 (----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -4.2 (----) --=-=-= Hi, I realized that a certain defcustom form is unable to customize a user option. To reproduce this, evaluate the following form, perform M-x customize-option, and press the [INS] button. (defcustom foo nil "Doc" :type '(repeat (group (group :inline t (choice string function))))) Then you will find a funny thing there and see it is unable to edit. After some investigations I found this is due to `widget-default-get', that fails to get the default value of components within an inlined form (I mean (bar :inline t ...)). A patch is attached, not tested with all sorts of defcustom forms though. --=-=-= Content-Type: text/x-patch Content-Disposition: inline; filename=DIFF --- wid-edit.el~ 2012-04-22 21:52:01.618551000 +0000 +++ wid-edit.el 2012-10-18 09:27:17.158803700 +0000 @@ -525,9 +525,18 @@ (defun widget-default-get (widget) "Extract the default external value of WIDGET." (widget-apply widget :value-to-external (or (widget-get widget :value) - (widget-apply widget :default-get)))) + (progn + (when (widget-get widget :args) + (let (args) + (dolist (arg (widget-get widget :args)) + (setq args (append args + (if (widget-get arg :inline) + (widget-get arg :args) + (list arg))))) + (widget-put widget :args args))) + (widget-apply widget :default-get))))) (defun widget-match-inline (widget vals) "In WIDGET, match the start of VALS." (cond ((widget-get widget :inline) --=-=-=-- ------------=_1357558027-22891-1--