GNU bug report logs - #12670
24.2.50; Uncustomizable defcustom

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 12670 in the body.
You can then email your comments to 12670 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Katsumi Yamaoka <yamaoka <at> jpl.org>
To: bug-gnu-emacs <at> gnu.org
Subject: 24.2.50; Uncustomizable defcustom
Date: Thu, 18 Oct 2012 18:33:25 +0900

[Message part 1 (text/plain, inline)]

Hi,

I realized that a certain defcustom form is unable to customize
a user option.  To reproduce this, evaluate the following form,
perform M-x customize-option, and press the [INS] button.

(defcustom foo nil
  "Doc"
  :type '(repeat (group (group :inline t (choice string function)))))

Then you will find a funny thing there and see it is unable to
edit.  After some investigations I found this is due to
`widget-default-get', that fails to get the default value of
components within an inlined form (I mean (bar :inline t ...)).

A patch is attached, not tested with all sorts of defcustom
forms though.

[DIFF (text/x-patch, inline)]

--- wid-edit.el~	2012-04-22 21:52:01.618551000 +0000
+++ wid-edit.el	2012-10-18 09:27:17.158803700 +0000
@@ -525,9 +525,18 @@
 (defun widget-default-get (widget)
   "Extract the default external value of WIDGET."
   (widget-apply widget :value-to-external
 		(or (widget-get widget :value)
-		    (widget-apply widget :default-get))))
+		    (progn
+		      (when (widget-get widget :args)
+			(let (args)
+			  (dolist (arg (widget-get widget :args))
+			    (setq args (append args
+					       (if (widget-get arg :inline)
+						   (widget-get arg :args)
+						 (list arg)))))
+			  (widget-put widget :args args)))
+		      (widget-apply widget :default-get)))))
 
 (defun widget-match-inline (widget vals)
   "In WIDGET, match the start of VALS."
   (cond ((widget-get widget :inline)

Message #8 received at 12670 <at> debbugs.gnu.org (full text, mbox):

From: Chong Yidong <cyd <at> gnu.org>
To: Katsumi Yamaoka <yamaoka <at> jpl.org>
Cc: 12670 <at> debbugs.gnu.org
Subject: Re: bug#12670: 24.2.50; Uncustomizable defcustom
Date: Sat, 22 Dec 2012 09:41:27 +0800

Katsumi Yamaoka <yamaoka <at> jpl.org> writes:

> evaluate the following form, perform M-x customize-option, and press
> the [INS] button.
>
> (defcustom foo nil
>   "Doc"
>   :type '(repeat (group (group :inline t (choice string function)))))
>
> Then you will find a funny thing there and see it is unable to
> edit.

I can't reproduce this on Emacs 23.4, the emacs-24 branch, or trunk.
After opening the customization buffer for `foo', I click on INS and it
opens up

INS DEL Choice: Value Menu invalid (nil)

and clicking on "Value Menu" allows me to insert a function or string.

Message #11 received at 12670 <at> debbugs.gnu.org (full text, mbox):

From: Katsumi Yamaoka <yamaoka <at> jpl.org>
To: Chong Yidong <cyd <at> gnu.org>
Cc: 12670 <at> debbugs.gnu.org
Subject: Re: bug#12670: 24.2.50; Uncustomizable defcustom
Date: Sat, 22 Dec 2012 22:35:51 +0900

Chong Yidong <cyd <at> gnu.org> wrote:
> Katsumi Yamaoka <yamaoka <at> jpl.org> writes:

>> evaluate the following form, perform M-x customize-option, and press
>> the [INS] button.

>> (defcustom foo nil
>>   "Doc"
>>   :type '(repeat (group (group :inline t (choice string function)))))

>> Then you will find a funny thing there and see it is unable to
>> edit.

> I can't reproduce this on Emacs 23.4, the emacs-24 branch, or trunk.
> After opening the customization buffer for `foo', I click on INS and it
> opens up

> INS DEL Choice: Value Menu invalid (nil)

> and clicking on "Value Menu" allows me to insert a function or string.

Oops, you're right.  I don't recall why I said it's uncustomisable,
but please let me rephrase it:
That defcustom form is unable to suggest a default value, that's
the one suitable to beginners for example, to a user.  Could you
try the following two examples?  Both behaviors should be the same.
And my patch solves it.

(defcustom foo1 nil
  "Doc"
  :type '(repeat (group (group :inline t
			       (choice (string :value "foo")
				       function)))))
(defcustom foo2 nil
  "Doc"
  :type '(repeat (group (choice (string :value "foo")
				function))))

Message #14 received at 12670 <at> debbugs.gnu.org (full text, mbox):

From: Chong Yidong <cyd <at> gnu.org>
To: Katsumi Yamaoka <yamaoka <at> jpl.org>
Cc: 12670 <at> debbugs.gnu.org
Subject: Re: bug#12670: 24.2.50; Uncustomizable defcustom
Date: Sun, 06 Jan 2013 11:37:49 +0800

Katsumi Yamaoka <yamaoka <at> jpl.org> writes:

> Oops, you're right.  I don't recall why I said it's uncustomisable,
> but please let me rephrase it:
> That defcustom form is unable to suggest a default value, that's
> the one suitable to beginners for example, to a user.  Could you
> try the following two examples?  Both behaviors should be the same.
> And my patch solves it.

Ah, OK.  Looks fine to me, please go ahead and commit to trunk.

Message #19 received at 12670-done <at> debbugs.gnu.org (full text, mbox):

From: Katsumi Yamaoka <yamaoka <at> jpl.org>
To: 12670-done <at> debbugs.gnu.org
Cc: cyd <at> gnu.org
Subject: Re: bug#12670: 24.2.50; Uncustomizable defcustom
Date: Mon, 07 Jan 2013 20:25:49 +0900

Chong Yidong wrote:
> Ah, OK.  Looks fine to me, please go ahead and commit to trunk.

Thanks.  Done.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.