GNU bug report logs - #1259
quit-window: does it quit the wrong buffer?

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (Emacs bug Tracking System)
To: David Reitter <david.reitter <at> gmail.com>
Subject: bug#1259 closed by martin rudalics <rudalics <at> gmx.at> (Re: 
 bug#1259: quit-window: does it quit the wrong buffer?)

[Message part 1 (text/plain, inline)]

This is an automatic notification regarding your bug report
which was filed against the emacs package:

#1259: quit-window: does it quit the wrong buffer?

It has been closed by martin rudalics <rudalics <at> gmx.at>.

Their explanation is attached below along with your original report.
If this explanation is unsatisfactory and you have not received a
better one in a separate message then please contact martin rudalics <rudalics <at> gmx.at> by
replying to this email.


-- 
1259: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=1259
Emacs Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: martin rudalics <rudalics <at> gmx.at>
To: 1259-done <at> debbugs.gnu.org
Cc: David Reitter <david.reitter <at> gmail.com>
Subject: Re: bug#1259: quit-window: does it quit the wrong buffer?
Date: Thu, 30 Oct 2008 16:42:17 +0100

Fixed as

2008-10-30  Martin Rudalics  <rudalics <at> gmx.at>

	* window.el (quit-window): Simplify code.  Say in doc-string
	that it operates on the selected window's buffer.  (Bug#1259)

Thanks, martin

[Message part 3 (message/rfc822, inline)]

From: David Reitter <david.reitter <at> gmail.com>
To: emacs-pretest-bug <at> gnu.org
Subject: quit-window: does it quit the wrong buffer?
Date: Sun, 26 Oct 2008 21:19:48 -0400

I'm wondering if there is a discrepancy between the doc string of quit- 
window and its implementation:  The function is supposed to quit the  
current buffer, but what it seems to do is to quit the buffer in the  
selected window.


(defun quit-window (&optional kill window)
  "Quit the current buffer.  Bury it, and maybe delete the selected  
frame.
\(The frame is deleted if it contains a dedicated window for the  
buffer.)
With a prefix argument, kill the buffer instead.

Noninteractively, if KILL is non-nil, then kill the current buffer,
otherwise bury it.

If WINDOW is non-nil, it specifies a window; we delete that window,
and the buffer that is killed or buried is the one in that window."
  (interactive "P")
  (let ((buffer (window-buffer window))
	(frame (window-frame (or window (selected-window))))

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.