From unknown Sat Sep 13 15:28:11 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#12583 <12583@debbugs.gnu.org> To: bug#12583 <12583@debbugs.gnu.org> Subject: Status: latest org-mode changes exposes bug in `comment-forward' in newcomment.el Reply-To: bug#12583 <12583@debbugs.gnu.org> Date: Sat, 13 Sep 2025 22:28:11 +0000 retitle 12583 latest org-mode changes exposes bug in `comment-forward' in n= ewcomment.el reassign 12583 emacs submitter 12583 Le Wang severity 12583 minor thanks From debbugs-submit-bounces@debbugs.gnu.org Sat Oct 06 07:07:48 2012 Received: (at submit) by debbugs.gnu.org; 6 Oct 2012 11:07:48 +0000 Received: from localhost ([127.0.0.1]:57679 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TKSEW-0008BN-1O for submit@debbugs.gnu.org; Sat, 06 Oct 2012 07:07:48 -0400 Received: from eggs.gnu.org ([208.118.235.92]:46940) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TKSET-0008BA-Si for submit@debbugs.gnu.org; Sat, 06 Oct 2012 07:07:46 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TKSE8-0002FS-3R for submit@debbugs.gnu.org; Sat, 06 Oct 2012 07:07:24 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=5.0 tests=BAYES_00,FREEMAIL_FROM, RCVD_IN_DNSWL_HI,T_DKIM_INVALID autolearn=unavailable version=3.3.2 Received: from lists.gnu.org ([208.118.235.17]:55704) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TKSE8-0002FO-0I for submit@debbugs.gnu.org; Sat, 06 Oct 2012 07:07:24 -0400 Received: from eggs.gnu.org ([208.118.235.92]:37803) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TKSE7-0006lM-7o for bug-gnu-emacs@gnu.org; Sat, 06 Oct 2012 07:07:23 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TKSE6-0002F1-5r for bug-gnu-emacs@gnu.org; Sat, 06 Oct 2012 07:07:23 -0400 Received: from mail-qa0-f41.google.com ([209.85.216.41]:48281) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TKSE6-0002Ex-1u for bug-gnu-emacs@gnu.org; Sat, 06 Oct 2012 07:07:22 -0400 Received: by mail-qa0-f41.google.com with SMTP id p27so1309758qat.0 for ; Sat, 06 Oct 2012 04:07:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:date:message-id:subject:from:to:content-type; bh=MJUgMe6zjmla8cjOk1TIdV1H749FlRlA+T5HhO2bn9I=; b=swfUuFDzGDL4zm3T9ApJk6jHzWey7kkGJPaM80GwTOvpKGjsmrT/QlHCJU7CxwfnNw 9Ji4PNKi6EfNN3LSGF/PIxn9yW0NXHueZNxrAeWtiXc+WSCGdq0e33bxVByvZhEp1AfN XEGCuP4Y6F43YI8ZF0/IuAFP3sbDA688VfAuEeMVn3g5s10naXKDbIK9LO+5MB2jbZ5n mJa2znU7QkhtniXaQbGgrMxMFQ5thBsRfQoXTQ5AR6cTrHx4rzSFwg4KhXKdqe+5f36u bZ9nbHQLsyxGXgL3Y5dmyKXnr+OCbBQ1kU2ADIj9//URCFK8TtTiWlvCejRfDaZcbJD3 dTxA== MIME-Version: 1.0 Received: by 10.49.51.7 with SMTP id g7mr30371826qeo.34.1349521641394; Sat, 06 Oct 2012 04:07:21 -0700 (PDT) Received: by 10.49.50.7 with HTTP; Sat, 6 Oct 2012 04:07:21 -0700 (PDT) Date: Sat, 6 Oct 2012 19:07:21 +0800 Message-ID: Subject: latest org-mode changes exposes bug in `comment-forward' in newcomment.el From: Le Wang To: bug-gnu-emacs@gnu.org Content-Type: text/plain; charset=ISO-8859-1 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-Received-From: 208.118.235.17 X-Spam-Score: -3.4 (---) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -3.4 (---) Repro with Emacs head: 1. emacs -Q 2. create new org file 3. insert "# blah" 4. C-a 5. M-: (comment-forward 1) The problem is that `comment-use-syntax' changed from 'undecided to nil in org.el, which intern exposed a problem in `comment-forward': It contains: (re-search-forward comment-end-skip nil 'move) But comment-end-skip can validly be nil according to documentation. -- Le From debbugs-submit-bounces@debbugs.gnu.org Sat Oct 06 08:50:06 2012 Received: (at 12583) by debbugs.gnu.org; 6 Oct 2012 12:50:06 +0000 Received: from localhost ([127.0.0.1]:57878 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TKTpV-0002vL-Oc for submit@debbugs.gnu.org; Sat, 06 Oct 2012 08:50:06 -0400 Received: from ironport2-out.teksavvy.com ([206.248.154.182]:57930) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TKTpS-0002um-Mw for 12583@debbugs.gnu.org; Sat, 06 Oct 2012 08:50:02 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: Av0EAG6Zu09FxLQG/2dsb2JhbABEtBGBCIIVAQEEAVYjBQsLDiYSFBgNJIgcBboJkEQDozOBWIMF X-IronPort-AV: E=Sophos;i="4.75,637,1330923600"; d="scan'208";a="200791977" Received: from 69-196-180-6.dsl.teksavvy.com (HELO pastel.home) ([69.196.180.6]) by ironport2-out.teksavvy.com with ESMTP/TLS/ADH-AES256-SHA; 06 Oct 2012 08:49:40 -0400 Received: by pastel.home (Postfix, from userid 20848) id 7C301594CB; Sat, 6 Oct 2012 08:49:40 -0400 (EDT) From: Stefan Monnier To: Le Wang Subject: Re: bug#12583: latest org-mode changes exposes bug in `comment-forward' in newcomment.el Message-ID: References: Date: Sat, 06 Oct 2012 08:49:40 -0400 In-Reply-To: (Le Wang's message of "Sat, 6 Oct 2012 19:07:21 +0800") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.2.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.8 (/) X-Debbugs-Envelope-To: 12583 Cc: 12583@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: 0.8 (/) > 1. emacs -Q > 2. create new org file > 3. insert "# blah" > 4. C-a > 5. M-: (comment-forward 1) Before using the comment-* functions, you need to call comment-normalize-vars. Stefan From debbugs-submit-bounces@debbugs.gnu.org Sat Oct 06 11:54:17 2012 Received: (at 12583) by debbugs.gnu.org; 6 Oct 2012 15:54:17 +0000 Received: from localhost ([127.0.0.1]:58373 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TKWhl-0007u1-5T for submit@debbugs.gnu.org; Sat, 06 Oct 2012 11:54:17 -0400 Received: from rcsinet15.oracle.com ([148.87.113.117]:32518) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TKWhj-0007to-54 for 12583@debbugs.gnu.org; Sat, 06 Oct 2012 11:54:16 -0400 Received: from acsinet22.oracle.com (acsinet22.oracle.com [141.146.126.238]) by rcsinet15.oracle.com (Sentrion-MTA-4.2.2/Sentrion-MTA-4.2.2) with ESMTP id q96FrpwM032392 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Sat, 6 Oct 2012 15:53:52 GMT Received: from acsmt357.oracle.com (acsmt357.oracle.com [141.146.40.157]) by acsinet22.oracle.com (8.14.4+Sun/8.14.4) with ESMTP id q96FrobT029510 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Sat, 6 Oct 2012 15:53:51 GMT Received: from abhmt106.oracle.com (abhmt106.oracle.com [141.146.116.58]) by acsmt357.oracle.com (8.12.11.20060308/8.12.11) with ESMTP id q96Fro4K022168; Sat, 6 Oct 2012 10:53:50 -0500 Received: from dradamslap1 (/71.202.147.44) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Sat, 06 Oct 2012 08:53:50 -0700 From: "Drew Adams" To: "'Stefan Monnier'" , "'Le Wang'" References: Subject: RE: bug#12583: latest org-mode changes exposes bug in `comment-forward'in newcomment.el Date: Sat, 6 Oct 2012 08:53:42 -0700 Message-ID: <91FE7CF1DA974412A922D439CF16A994@us.oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Mailer: Microsoft Office Outlook 11 In-Reply-To: Thread-Index: Ac2jwTxXjPbqloAJROKXe3q1IpLrywAGClhQ X-MimeOLE: Produced By Microsoft MimeOLE V6.00.2900.6157 X-Source-IP: acsinet22.oracle.com [141.146.126.238] X-Spam-Score: -6.3 (------) X-Debbugs-Envelope-To: 12583 Cc: 12583@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -6.3 (------) > Before using the comment-* functions, you need to call > comment-normalize-vars. Which comment-* functions? All of them? Why don't you add a specific guideline about this to the code comments or to some doc string? The doc string of `comment-normalize-vars' says, BTW, that it is the functions that are autoloaded from newcomment.el that should call `c-n-v'. But you seem to be saying that those are not the only ones. It is also the case that not all functions that are autoloaded from newcomment.el call `c-n-v'. So what exactly is the proper criterion? (Or do some such functions in newcomment.el perhaps need to be corrected to call `c-n-v'?) For my own use, I wonder whether I should be calling `c-n-v' before I make use of `comment-search-forward'. That function has no autoload cookie, so it does not fit your prescription, and I have not been calling `c-n-v' and have not noticed any problem, but I wonder anyway, since you brought this up. Just when is it necessary or useful to call `c-n-v'? BTW, why are there so many things besided commands that have autoload cookies in newcomment.el? I know that you are not particularly in favor of unnecessarily autoloading variables, so I wonder what the story is here. Thx. From debbugs-submit-bounces@debbugs.gnu.org Sat Oct 06 12:12:22 2012 Received: (at 12583) by debbugs.gnu.org; 6 Oct 2012 16:12:22 +0000 Received: from localhost ([127.0.0.1]:58381 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TKWzG-0008Ia-As for submit@debbugs.gnu.org; Sat, 06 Oct 2012 12:12:22 -0400 Received: from chene.dit.umontreal.ca ([132.204.246.20]:58511) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TKWzE-0008IU-Hu for 12583@debbugs.gnu.org; Sat, 06 Oct 2012 12:12:21 -0400 Received: from faina.iro.umontreal.ca (lechon.iro.umontreal.ca [132.204.27.242]) by chene.dit.umontreal.ca (8.14.1/8.14.1) with ESMTP id q96GC3vD026821; Sat, 6 Oct 2012 12:12:03 -0400 Received: by faina.iro.umontreal.ca (Postfix, from userid 20848) id 40273B40A1; Sat, 6 Oct 2012 12:12:03 -0400 (EDT) From: Stefan Monnier To: "Drew Adams" Subject: Re: bug#12583: latest org-mode changes exposes bug in `comment-forward'in newcomment.el Message-ID: References: <91FE7CF1DA974412A922D439CF16A994@us.oracle.com> Date: Sat, 06 Oct 2012 12:12:03 -0400 In-Reply-To: <91FE7CF1DA974412A922D439CF16A994@us.oracle.com> (Drew Adams's message of "Sat, 6 Oct 2012 08:53:42 -0700") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.2.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -3.0 (---) X-Debbugs-Envelope-To: 12583 Cc: 12583@debbugs.gnu.org, 'Le Wang' X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -3.0 (---) > For my own use, I wonder whether I should be calling `c-n-v' before > I make use of `comment-search-forward'. Yes, you should. > BTW, why are there so many things besided commands that have autoload > cookies in newcomment.el? I know that you are not particularly in > favor of unnecessarily autoloading variables, so I wonder what the > story is here. Thx. The functionality of newcomment.el used to be in simple.el and hence preloaded. To make the transition as smooth as possible (there were already plenty of changes) I autoloaded all the things which used to be preloaded. Stefan From debbugs-submit-bounces@debbugs.gnu.org Sat Oct 06 12:38:27 2012 Received: (at 12583) by debbugs.gnu.org; 6 Oct 2012 16:38:27 +0000 Received: from localhost ([127.0.0.1]:58390 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TKXOU-0000Tm-N4 for submit@debbugs.gnu.org; Sat, 06 Oct 2012 12:38:26 -0400 Received: from acsinet15.oracle.com ([141.146.126.227]:37548) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TKXOR-0000TZ-7t for 12583@debbugs.gnu.org; Sat, 06 Oct 2012 12:38:24 -0400 Received: from ucsinet22.oracle.com (ucsinet22.oracle.com [156.151.31.94]) by acsinet15.oracle.com (Sentrion-MTA-4.2.2/Sentrion-MTA-4.2.2) with ESMTP id q96GbwXD029574 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Sat, 6 Oct 2012 16:37:59 GMT Received: from acsmt356.oracle.com (acsmt356.oracle.com [141.146.40.156]) by ucsinet22.oracle.com (8.14.4+Sun/8.14.4) with ESMTP id q96GbvVj001928 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Sat, 6 Oct 2012 16:37:57 GMT Received: from abhmt102.oracle.com (abhmt102.oracle.com [141.146.116.54]) by acsmt356.oracle.com (8.12.11.20060308/8.12.11) with ESMTP id q96Gbv3t032430; Sat, 6 Oct 2012 11:37:57 -0500 Received: from dradamslap1 (/71.202.147.44) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Sat, 06 Oct 2012 09:37:56 -0700 From: "Drew Adams" To: "'Stefan Monnier'" References: <91FE7CF1DA974412A922D439CF16A994@us.oracle.com> Subject: RE: bug#12583: latest org-mode changes exposes bug in `comment-forward'in newcomment.el Date: Sat, 6 Oct 2012 09:37:48 -0700 Message-ID: <8A74257275DC479D86CE39485F0D5FB7@us.oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Mailer: Microsoft Office Outlook 11 In-Reply-To: Thread-Index: Ac2j3VVuemXAm/FUQa+hqU2PmFXLggAA1NRg X-MimeOLE: Produced By Microsoft MimeOLE V6.00.2900.6157 X-Source-IP: ucsinet22.oracle.com [156.151.31.94] X-Spam-Score: -6.3 (------) X-Debbugs-Envelope-To: 12583 Cc: 12583@debbugs.gnu.org, 'Le Wang' X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -6.3 (------) > > For my own use, I wonder whether I should be calling `c-n-v' before > > I make use of `comment-search-forward'. > > Yes, you should. OK, thanks. Please consider providing specific guidelines about this, somewhere. > > BTW, why are there so many things besided commands that > > have autoload cookies in newcomment.el? I know that you > > are not particularly in favor of unnecessarily autoloading > > variables, so I wonder what the story is here. Thx. > > The functionality of newcomment.el used to be in simple.el and hence > preloaded. To make the transition as smooth as possible (there were > already plenty of changes) I autoloaded all the things which used to > be preloaded. OK, so it was only for a transition. Presumably that means that some of those autoloads will be removed at some point. From debbugs-submit-bounces@debbugs.gnu.org Sat Oct 06 12:49:02 2012 Received: (at 12583) by debbugs.gnu.org; 6 Oct 2012 16:49:02 +0000 Received: from localhost ([127.0.0.1]:58400 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TKXYi-0000ih-TM for submit@debbugs.gnu.org; Sat, 06 Oct 2012 12:49:01 -0400 Received: from pruche.dit.umontreal.ca ([132.204.246.22]:47127) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TKXYg-0000iY-7q for 12583@debbugs.gnu.org; Sat, 06 Oct 2012 12:48:59 -0400 Received: from faina.iro.umontreal.ca (lechon.iro.umontreal.ca [132.204.27.242]) by pruche.dit.umontreal.ca (8.14.1/8.14.1) with ESMTP id q96GmerU019579; Sat, 6 Oct 2012 12:48:40 -0400 Received: by faina.iro.umontreal.ca (Postfix, from userid 20848) id 98C8EB40A1; Sat, 6 Oct 2012 12:48:40 -0400 (EDT) From: Stefan Monnier To: "Drew Adams" Subject: Re: bug#12583: latest org-mode changes exposes bug in `comment-forward'in newcomment.el Message-ID: References: <91FE7CF1DA974412A922D439CF16A994@us.oracle.com> <8A74257275DC479D86CE39485F0D5FB7@us.oracle.com> Date: Sat, 06 Oct 2012 12:48:40 -0400 In-Reply-To: <8A74257275DC479D86CE39485F0D5FB7@us.oracle.com> (Drew Adams's message of "Sat, 6 Oct 2012 09:37:48 -0700") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.2.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -3.0 (---) X-Debbugs-Envelope-To: 12583 Cc: 12583@debbugs.gnu.org, 'Le Wang' X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -3.0 (---) >> > For my own use, I wonder whether I should be calling `c-n-v' before >> > I make use of `comment-search-forward'. >> Yes, you should. > OK, thanks. Please consider providing specific guidelines about this, > somewhere. I think the guideline "commands that use comment-* functions should call c-n-v first" is a good approximation. > OK, so it was only for a transition. Presumably that means that some > of those autoloads will be removed at some point. Except that I don't know how to mark obsolete the auto-loading of a variable, so the transition would be just as abrupt now as it would have been then. I guess we can remove autoloads one at a time and see when someone screams. Stefan From debbugs-submit-bounces@debbugs.gnu.org Sat Oct 06 12:58:06 2012 Received: (at 12583) by debbugs.gnu.org; 6 Oct 2012 16:58:06 +0000 Received: from localhost ([127.0.0.1]:58420 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TKXhV-0000vj-LC for submit@debbugs.gnu.org; Sat, 06 Oct 2012 12:58:06 -0400 Received: from acsinet15.oracle.com ([141.146.126.227]:46200) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TKXhU-0000vG-7w for 12583@debbugs.gnu.org; Sat, 06 Oct 2012 12:58:04 -0400 Received: from ucsinet22.oracle.com (ucsinet22.oracle.com [156.151.31.94]) by acsinet15.oracle.com (Sentrion-MTA-4.2.2/Sentrion-MTA-4.2.2) with ESMTP id q96Gvd05006029 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Sat, 6 Oct 2012 16:57:40 GMT Received: from acsmt357.oracle.com (acsmt357.oracle.com [141.146.40.157]) by ucsinet22.oracle.com (8.14.4+Sun/8.14.4) with ESMTP id q96Gvc3h013482 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Sat, 6 Oct 2012 16:57:39 GMT Received: from abhmt107.oracle.com (abhmt107.oracle.com [141.146.116.59]) by acsmt357.oracle.com (8.12.11.20060308/8.12.11) with ESMTP id q96GvcV7012313; Sat, 6 Oct 2012 11:57:38 -0500 Received: from dradamslap1 (/71.202.147.44) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Sat, 06 Oct 2012 09:57:38 -0700 From: "Drew Adams" To: "'Stefan Monnier'" References: <91FE7CF1DA974412A922D439CF16A994@us.oracle.com><8A74257275DC479D86CE39485F0D5FB7@us.oracle.com> Subject: RE: bug#12583: latest org-mode changes exposes bug in `comment-forward'in newcomment.el Date: Sat, 6 Oct 2012 09:57:29 -0700 Message-ID: <9FE23C01EF7D4042831DD263641C79D9@us.oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Mailer: Microsoft Office Outlook 11 In-Reply-To: Thread-Index: Ac2j4nLxp85+SEBiQomVOQvUXV9nvAAAHzRQ X-MimeOLE: Produced By Microsoft MimeOLE V6.00.2900.6157 X-Source-IP: ucsinet22.oracle.com [156.151.31.94] X-Spam-Score: -6.3 (------) X-Debbugs-Envelope-To: 12583 Cc: 12583@debbugs.gnu.org, 'Le Wang' X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -6.3 (------) > > OK, thanks. Please consider providing specific guidelines > > about this, somewhere. > > I think the guideline "commands that use comment-* functions > should call c-n-v first" is a good approximation. Then please put that guideline somewhere. (Currently, the doc string mentions only autoloaded functions in newcomment.el.) IOW, I've gotten the message, but this is not obvious, so please help other users by pointing this out somewhere. > > OK, so it was only for a transition. Presumably that means > > that some of those autoloads will be removed at some point. > > Except that I don't know how to mark obsolete the auto-loading of > a variable, so the transition would be just as abrupt now as it would > have been then. I guess we can remove autoloads one at a time > and see when someone screams. I see. Is this what is done whenever something that was formerly preloaded gets moved to a library that is not preloaded? To be clear, it doesn't bother me that we autoload something that you might consider extra. I'm just pointing this out as an apparent exception - a place where you might want to take a second look (which you've now done). From debbugs-submit-bounces@debbugs.gnu.org Sat Oct 06 13:07:53 2012 Received: (at 12583) by debbugs.gnu.org; 6 Oct 2012 17:07:53 +0000 Received: from localhost ([127.0.0.1]:58429 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TKXqz-0001AA-04 for submit@debbugs.gnu.org; Sat, 06 Oct 2012 13:07:53 -0400 Received: from chene.dit.umontreal.ca ([132.204.246.20]:34605) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TKXqx-0001A3-GH for 12583@debbugs.gnu.org; Sat, 06 Oct 2012 13:07:52 -0400 Received: from faina.iro.umontreal.ca (lechon.iro.umontreal.ca [132.204.27.242]) by chene.dit.umontreal.ca (8.14.1/8.14.1) with ESMTP id q96H7XGv029996; Sat, 6 Oct 2012 13:07:34 -0400 Received: by faina.iro.umontreal.ca (Postfix, from userid 20848) id AAEC8B40A1; Sat, 6 Oct 2012 13:07:33 -0400 (EDT) From: Stefan Monnier To: "Drew Adams" Subject: Re: bug#12583: latest org-mode changes exposes bug in `comment-forward'in newcomment.el Message-ID: References: <91FE7CF1DA974412A922D439CF16A994@us.oracle.com> Date: Sat, 06 Oct 2012 13:07:33 -0400 In-Reply-To: <91FE7CF1DA974412A922D439CF16A994@us.oracle.com> (Drew Adams's message of "Sat, 6 Oct 2012 08:53:42 -0700") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.2.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -3.0 (---) X-Debbugs-Envelope-To: 12583 Cc: 12583@debbugs.gnu.org, 'Le Wang' X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -3.0 (---) > The doc string of `comment-normalize-vars' says, BTW, that it is the > functions that are autoloaded from newcomment.el that should call > `c-n-v'. That's actually a good guideline, yes. > But you seem to be saying that those are not the only ones. No. AFAICT it's basically the same since all the autoloaded functions of newcomment.el are commands. > It is also the case that not all functions that are autoloaded from > newcomment.el call `c-n-v'. That would be a bug, I think. Stefan From debbugs-submit-bounces@debbugs.gnu.org Sat Oct 06 13:12:45 2012 Received: (at 12583) by debbugs.gnu.org; 6 Oct 2012 17:12:45 +0000 Received: from localhost ([127.0.0.1]:58433 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TKXvg-0001HD-T2 for submit@debbugs.gnu.org; Sat, 06 Oct 2012 13:12:45 -0400 Received: from acsinet15.oracle.com ([141.146.126.227]:21625) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TKXvf-0001Gz-1V for 12583@debbugs.gnu.org; Sat, 06 Oct 2012 13:12:43 -0400 Received: from acsinet21.oracle.com (acsinet21.oracle.com [141.146.126.237]) by acsinet15.oracle.com (Sentrion-MTA-4.2.2/Sentrion-MTA-4.2.2) with ESMTP id q96HCIle012893 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Sat, 6 Oct 2012 17:12:19 GMT Received: from acsmt358.oracle.com (acsmt358.oracle.com [141.146.40.158]) by acsinet21.oracle.com (8.14.4+Sun/8.14.4) with ESMTP id q96HCHMW018788 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Sat, 6 Oct 2012 17:12:18 GMT Received: from abhmt117.oracle.com (abhmt117.oracle.com [141.146.116.69]) by acsmt358.oracle.com (8.12.11.20060308/8.12.11) with ESMTP id q96HCHE8020644; Sat, 6 Oct 2012 12:12:17 -0500 Received: from dradamslap1 (/71.202.147.44) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Sat, 06 Oct 2012 10:12:17 -0700 From: "Drew Adams" To: "'Stefan Monnier'" References: <91FE7CF1DA974412A922D439CF16A994@us.oracle.com> Subject: RE: bug#12583: latest org-mode changes exposes bug in `comment-forward'in newcomment.el Date: Sat, 6 Oct 2012 10:12:08 -0700 Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Mailer: Microsoft Office Outlook 11 In-Reply-To: Thread-Index: Ac2j5RZDVETgFlh1SmuREw59msrsEgAAGRUA X-MimeOLE: Produced By Microsoft MimeOLE V6.00.2900.6157 X-Source-IP: acsinet21.oracle.com [141.146.126.237] X-Spam-Score: -6.3 (------) X-Debbugs-Envelope-To: 12583 Cc: 12583@debbugs.gnu.org, 'Le Wang' X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -6.3 (------) > > The doc string of `comment-normalize-vars' says, BTW, that it is the > > functions that are autoloaded from newcomment.el that should call > > `c-n-v'. > > That's actually a good guideline, yes. But apparently not sufficient, in terms of helping users with their own uses of newcomment.el functions. IOW, it should apparently be about not commands that use newcomment functions, not just newcomment commands. From debbugs-submit-bounces@debbugs.gnu.org Sat Oct 06 20:49:02 2012 Received: (at 12583) by debbugs.gnu.org; 7 Oct 2012 00:49:02 +0000 Received: from localhost ([127.0.0.1]:58766 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TKf3F-0003wx-RI for submit@debbugs.gnu.org; Sat, 06 Oct 2012 20:49:02 -0400 Received: from ironport2-out.teksavvy.com ([206.248.154.182]:18431) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TKf3D-0003we-Dj for 12583@debbugs.gnu.org; Sat, 06 Oct 2012 20:48:59 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: Av0EAG6Zu09FxLQG/2dsb2JhbABEtBGBCIIVAQEEAVYjBQsLNBIUGA0kiBwFugmQRAOjM4FYgwU X-IronPort-AV: E=Sophos;i="4.75,637,1330923600"; d="scan'208";a="200810820" Received: from 69-196-180-6.dsl.teksavvy.com (HELO pastel.home) ([69.196.180.6]) by ironport2-out.teksavvy.com with ESMTP/TLS/ADH-AES256-SHA; 06 Oct 2012 20:48:34 -0400 Received: by pastel.home (Postfix, from userid 20848) id BE7A6594D1; Sat, 6 Oct 2012 20:48:33 -0400 (EDT) From: Stefan Monnier To: "Drew Adams" Subject: Re: bug#12583: latest org-mode changes exposes bug in `comment-forward'in newcomment.el Message-ID: References: <91FE7CF1DA974412A922D439CF16A994@us.oracle.com> Date: Sat, 06 Oct 2012 20:48:33 -0400 In-Reply-To: (Drew Adams's message of "Sat, 6 Oct 2012 10:12:08 -0700") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.2.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.8 (/) X-Debbugs-Envelope-To: 12583 Cc: 12583@debbugs.gnu.org, 'Le Wang' X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: 0.8 (/) > But apparently not sufficient, in terms of helping users with their > own uses of newcomment.el functions. IOW, it should apparently be > about not commands that use newcomment functions, not just ^^^ I assume you meant "all" rather than "not", right? If so, I agree. > newcomment commands. Stefan From debbugs-submit-bounces@debbugs.gnu.org Sat Oct 06 22:52:22 2012 Received: (at 12583) by debbugs.gnu.org; 7 Oct 2012 02:52:22 +0000 Received: from localhost ([127.0.0.1]:58843 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TKgyc-00006n-Dc for submit@debbugs.gnu.org; Sat, 06 Oct 2012 22:52:22 -0400 Received: from rcsinet15.oracle.com ([148.87.113.117]:20408) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TKgyb-00006b-4J for 12583@debbugs.gnu.org; Sat, 06 Oct 2012 22:52:21 -0400 Received: from acsinet21.oracle.com (acsinet21.oracle.com [141.146.126.237]) by rcsinet15.oracle.com (Sentrion-MTA-4.2.2/Sentrion-MTA-4.2.2) with ESMTP id q972psHM003283 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Sun, 7 Oct 2012 02:51:55 GMT Received: from acsmt358.oracle.com (acsmt358.oracle.com [141.146.40.158]) by acsinet21.oracle.com (8.14.4+Sun/8.14.4) with ESMTP id q972psJ6019200 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Sun, 7 Oct 2012 02:51:54 GMT Received: from abhmt118.oracle.com (abhmt118.oracle.com [141.146.116.70]) by acsmt358.oracle.com (8.12.11.20060308/8.12.11) with ESMTP id q972proN023404; Sat, 6 Oct 2012 21:51:54 -0500 Received: from dradamslap1 (/71.202.147.44) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Sat, 06 Oct 2012 19:51:53 -0700 From: "Drew Adams" To: "'Stefan Monnier'" References: <91FE7CF1DA974412A922D439CF16A994@us.oracle.com> Subject: RE: bug#12583: latest org-mode changes exposes bug in `comment-forward'in newcomment.el Date: Sat, 6 Oct 2012 19:51:43 -0700 Message-ID: <0FC13E54414147E7A8022BC694817C04@us.oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Mailer: Microsoft Office Outlook 11 In-Reply-To: Thread-Index: Ac2kJYB8oc1bfVDnTke5C3+J04cccwAERNHg X-MimeOLE: Produced By Microsoft MimeOLE V6.00.2900.6157 X-Source-IP: acsinet21.oracle.com [141.146.126.237] X-Spam-Score: -6.3 (------) X-Debbugs-Envelope-To: 12583 Cc: 12583@debbugs.gnu.org, 'Le Wang' X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -6.3 (------) > > But apparently not sufficient, in terms of helping users with their > > own uses of newcomment.el functions. IOW, it should apparently be > > about not commands that use newcomment functions, not just > ^^^ > I assume you meant "all" rather than "not", right? If so, I agree. > > > newcomment commands. Yes (in fact I meant that that first `not' be removed). Thx. From debbugs-submit-bounces@debbugs.gnu.org Mon Oct 22 22:20:28 2012 Received: (at 12583) by debbugs.gnu.org; 23 Oct 2012 02:20:28 +0000 Received: from localhost ([127.0.0.1]:56590 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TQU6U-0007gA-KX for submit@debbugs.gnu.org; Mon, 22 Oct 2012 22:20:27 -0400 Received: from mail-vc0-f172.google.com ([209.85.220.172]:42106) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TQU6N-0007fn-D4 for 12583@debbugs.gnu.org; Mon, 22 Oct 2012 22:20:20 -0400 Received: by mail-vc0-f172.google.com with SMTP id fl11so4046928vcb.3 for <12583@debbugs.gnu.org>; Mon, 22 Oct 2012 19:18:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-type; bh=RUmgghxcmyFTSVeNJPQtE4ugdzlLksmmBgaj/M49/js=; b=iqbfCXgPzf6nSCk2ZIpneWPTJy8Y3z21h6XtfgXpvfNOk/v7+E2UZs1MMDBc+P5uOW 3FrsVM7GxmMb15HAqj7f4D79d/ApBViuam15npI2LurHyp+1wKfoWEHlQXN0cJWiHaoF bO1St7mKfpazT+cLtuKHQ0I5xW1ivtIoFoX3PbtqsoB//7oMYtDmG4yrRx0bh56B2lmu pd+lWMGiFD7R3oG+KWY53AV2Nixhj0pvKwpdE2TNFDRLWrbiivsG173f5fLXjRZKBDFp hY0u1uFOSHmCFx/q4rhm6tiigmVWzDAOh2BpFf1OpC/stjxmHGtSuusFlg+gqfarHtgf XTGg== Received: by 10.52.65.147 with SMTP id x19mr14802221vds.113.1350958702483; Mon, 22 Oct 2012 19:18:22 -0700 (PDT) Received: from ulysses (173-166-11-18-newengland.hfc.comcastbusiness.net. [173.166.11.18]) by mx.google.com with ESMTPS id dp6sm11277428vec.11.2012.10.22.19.18.20 (version=SSLv3 cipher=OTHER); Mon, 22 Oct 2012 19:18:21 -0700 (PDT) From: Chong Yidong To: Stefan Monnier Subject: Re: bug#12583: latest org-mode changes exposes bug in `comment-forward'in newcomment.el References: <91FE7CF1DA974412A922D439CF16A994@us.oracle.com> Date: Tue, 23 Oct 2012 10:18:19 +0800 In-Reply-To: (Stefan Monnier's message of "Sat, 06 Oct 2012 20:48:33 -0400") Message-ID: <87obju6idw.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.2.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.1 (/) X-Debbugs-Envelope-To: 12583 Cc: 12583@debbugs.gnu.org, Drew Adams , 'Le Wang' X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: 0.1 (/) Stefan Monnier writes: >> But apparently not sufficient, in terms of helping users with their >> own uses of newcomment.el functions. IOW, it should apparently be >> about not commands that use newcomment functions, not just > ^^^ > I assume you meant "all" rather than "not", right? If so, I agree. I updated the doc of comment-normalize-vars, and the commentary of newcomment.el, accordingly. From debbugs-submit-bounces@debbugs.gnu.org Mon Oct 22 22:20:29 2012 Received: (at control) by debbugs.gnu.org; 23 Oct 2012 02:20:29 +0000 Received: from localhost ([127.0.0.1]:56592 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TQU6W-0007gD-7p for submit@debbugs.gnu.org; Mon, 22 Oct 2012 22:20:28 -0400 Received: from mail-vc0-f172.google.com ([209.85.220.172]:42106) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TQU6Q-0007fn-PX for control@debbugs.gnu.org; Mon, 22 Oct 2012 22:20:24 -0400 Received: by mail-vc0-f172.google.com with SMTP id fl11so4046928vcb.3 for ; Mon, 22 Oct 2012 19:18:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:from:to:subject:date:message-id:mime-version:content-type; bh=s3WGBINT0PYL2VHphlh2TYlWC02y0bEJzw3YxnjFwfs=; b=BNBbESG7lZm/w497LUUGgbHxMo9eOy7SM084Z/irgk1FOYl3vDIQlKFfou63yjptB2 P4qSt3Rh2+Hx0J3h//MHOe447BcpBoQ5NvDWwku+J99xgeDnxlCp4EB7U1SY8rSYcOha JHHVomJwpeD1vqNIOejKo4alIuVC2QWFjgb8mTFQnsMIC0hQYKJH1jlIHKk8w1afdOnv dSDMlHRDH6C6orojZWsZd6lyEYsE166b90ODtLFHvG8VvANt4uWIlD7ZQ8iuId2tktK/ FbM3aNm6fpSYBFjgCO7sbO4G9GBo7ZOrkcVe/hQTpwT8pLsEGkSRScXClCSIvS0GU/YC Y4qw== Received: by 10.52.98.66 with SMTP id eg2mr14646915vdb.60.1350958713138; Mon, 22 Oct 2012 19:18:33 -0700 (PDT) Received: from ulysses (173-166-11-18-newengland.hfc.comcastbusiness.net. [173.166.11.18]) by mx.google.com with ESMTPS id g11sm4495119vdj.20.2012.10.22.19.18.31 (version=SSLv3 cipher=OTHER); Mon, 22 Oct 2012 19:18:32 -0700 (PDT) From: Chong Yidong To: control@debbugs.gnu.org Subject: close 12583 Date: Tue, 23 Oct 2012 10:18:30 +0800 Message-ID: <87fw56nd6x.fsf@gnu.org> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.1 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: 0.1 (/) close 12583 thanks From unknown Sat Sep 13 15:28:11 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Tue, 20 Nov 2012 12:24:03 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator