GNU bug report logs - #1256
Race condition in vc-diff

Previous Next

Full log

View this message in rfc822 format

From: Chong Yidong <cyd <at> stupidchicken.com>
To: Bob Rogers <rogers-emacs <at> rgrjr.dyndns.org>
Cc: 1256 <at> debbugs.gnu.org
Subject: bug#1256: Race condition in vc-diff
Date: Sat, 09 Jul 2011 21:44:02 -0400

>    If you visit this file and do "C-x v =" in a single-window frame
> that is more than about 30 lines tall, and if the backend diff command
> is fast enough, the diff window will remain half the size of the
> screen, rather than being shrunk to fit the buffer.  This is because
> vc-exec-after finds that the buffer process has already finished, and
> runs vc-diff-finish before the diff buffer has been made visible.  In
> that case, vc-diff-finish assumes that the user has already buried it.
>
>    I am not a big fan of this shrink-wrapping, but I do think vc-diff
> ought to behave consistently (and it has worked this way for quite a
> while now).  The attached patch is sufficient to fix it.

I committed the patch to trunk.  Thanks.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.