From debbugs-submit-bounces@debbugs.gnu.org Tue Oct 02 12:26:55 2012 Received: (at submit) by debbugs.gnu.org; 2 Oct 2012 16:26:55 +0000 Received: from localhost ([127.0.0.1]:37950 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TJ5J8-0001Rv-A1 for submit@debbugs.gnu.org; Tue, 02 Oct 2012 12:26:55 -0400 Received: from eggs.gnu.org ([208.118.235.92]:37446) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TJ1pt-0002HL-8z for submit@debbugs.gnu.org; Tue, 02 Oct 2012 08:44:30 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TJ1pH-00082A-8v for submit@debbugs.gnu.org; Tue, 02 Oct 2012 08:43:57 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-6.6 required=5.0 tests=BAYES_00, FREEMAIL_ENVFROM_END_DIGIT, FREEMAIL_FROM, RCVD_IN_DNSWL_HI, T_DKIM_INVALID autolearn=unavailable version=3.3.2 Received: from lists.gnu.org ([208.118.235.17]:34952) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TJ1pH-000824-5X for submit@debbugs.gnu.org; Tue, 02 Oct 2012 08:43:51 -0400 Received: from eggs.gnu.org ([208.118.235.92]:32855) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TJ1pB-0000kQ-Br for bug-gnu-emacs@gnu.org; Tue, 02 Oct 2012 08:43:51 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TJ1p6-00080Y-Tq for bug-gnu-emacs@gnu.org; Tue, 02 Oct 2012 08:43:45 -0400 Received: from mail-wg0-f49.google.com ([74.125.82.49]:48418) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TJ1p6-00080P-Le for bug-gnu-emacs@gnu.org; Tue, 02 Oct 2012 08:43:40 -0400 Received: by wgbgg4 with SMTP id gg4so2998930wgb.30 for ; Tue, 02 Oct 2012 05:43:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:subject:date:message-id:mime-version:content-type; bh=36oqiP9/xrUhvIIxqwuMhR+QUDxeafxh6dlAEetIj+Q=; b=X0B3QCX6fUY9qKuCsf/6m4lFVPkY2QfP9p4R6CFmeHJfcgyjLs5poCxythmmH4A/XV Dv4Gv2Ldqcr89Kjysi4/Axv/G/1Sz18x1nuXV1hfkA+IODylAQeKpYJKil2Q+oqpLxzk fA1maYg3Pvfce/ddJHt2aVZAS1U3DPyq9dql3VQpsgj3gaCIb70OG8K5/jCY+0K3hF19 KFc/dcKEgmN6pXPDqjOhpZ17mj5uSJIcC89ZkZdrAqOl90+7eUfF2OdYBIa2BdLpnfRE sFxE6eoIL0eoLMG8tWp5jq1CpJOHoQ9C4lE7G8Ul95vKhkfohEqrLpsntSbUc+HU0OIV 6HMg== Received: by 10.180.73.76 with SMTP id j12mr21759229wiv.11.1349181819407; Tue, 02 Oct 2012 05:43:39 -0700 (PDT) Received: from macbook.local (p57946129.dip.t-dialin.net. [87.148.97.41]) by mx.google.com with ESMTPS id dm3sm2270463wib.3.2012.10.02.05.43.37 (version=TLSv1/SSLv3 cipher=OTHER); Tue, 02 Oct 2012 05:43:38 -0700 (PDT) From: Julian Scheid To: bug-gnu-emacs@gnu.org Subject: Incorrect docstrings for color-rgb-to-hsl and color-hsl-to-rgb Date: Tue, 02 Oct 2012 14:43:36 +0200 Message-ID: MIME-Version: 1.0 Content-Type: text/plain X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-Received-From: 208.118.235.17 X-Spam-Score: -3.2 (---) X-Debbugs-Envelope-To: submit X-Mailman-Approved-At: Tue, 02 Oct 2012 12:26:53 -0400 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -3.2 (---) The docstrings for `color-rgb-to-hsl' and `color-hsl-to-rgb' both state that the HUE component is given in radians, but in fact it's in range 0..1 in both cases. It's easy to see that the value returned by `color-rgb-to-hsl' for hue is the result of (mod N 1.0), and `color-hsl-to-rgb' uses the same representation: (apply 'color-hsl-to-rgb (color-rgb-to-hsl 0.7 0.8 0.9)) ;; -> (0.7000000000000001 0.7999999999999999 0.9) 2012-10-02 Julian Scheid * color.el (color-rgb-to-hsl, color-hsl-to-rgb): Fix docstring. === modified file 'lisp/color.el' *** lisp/color.el 2012-08-13 19:10:35 +0000 --- lisp/color.el 2012-10-02 11:49:04 +0000 *************** resulting list." *** 102,110 **** (t v1))) (defun color-hsl-to-rgb (H S L) ! "Convert H S L (HUE, SATURATION, LUMINANCE) , where HUE is in ! radians and both SATURATION and LUMINANCE are between 0.0 and ! 1.0, inclusive to their RGB representation. Return a list (RED, GREEN, BLUE) which each be numbers between 0.0 and 1.0, inclusive." --- 102,110 ---- (t v1))) (defun color-hsl-to-rgb (H S L) ! "Convert H S L (HUE, SATURATION, LUMINANCE), where H S L should ! each be numbers between 0.0 and 1.0 inclusive, to their RGB ! representation. Return a list (RED, GREEN, BLUE) which each be numbers between 0.0 and 1.0, inclusive." *************** inclusive." *** 159,167 **** RED, GREEN, and BLUE should each be numbers between 0.0 and 1.0, inclusive. ! Return a list (HUE, SATURATION, LUMINANCE), where HUE is in radians ! and both SATURATION and LUMINANCE are between 0.0 and 1.0, ! inclusive." (let* ((r red) (g green) (b blue) --- 159,166 ---- RED, GREEN, and BLUE should each be numbers between 0.0 and 1.0, inclusive. ! Return a list (HUE, SATURATION, LUMINANCE) which each be numbers ! between 0.0 and 1.0, inclusive." (let* ((r red) (g green) (b blue) From debbugs-submit-bounces@debbugs.gnu.org Fri Oct 05 03:18:34 2012 Received: (at 12558-done) by debbugs.gnu.org; 5 Oct 2012 07:18:34 +0000 Received: from localhost ([127.0.0.1]:55004 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TK2B7-000160-DS for submit@debbugs.gnu.org; Fri, 05 Oct 2012 03:18:34 -0400 Received: from fencepost.gnu.org ([208.118.235.10]:33941 ident=Debian-exim) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TK2B5-00015s-Dm for 12558-done@debbugs.gnu.org; Fri, 05 Oct 2012 03:18:32 -0400 Received: from rgm by fencepost.gnu.org with local (Exim 4.71) (envelope-from ) id 1TK2Au-0001o3-89; Fri, 05 Oct 2012 03:18:20 -0400 From: Glenn Morris To: 12558-done@debbugs.gnu.org Subject: Re: bug#12558: Incorrect docstrings for color-rgb-to-hsl and color-hsl-to-rgb References: X-Spook: SAPO Fedayeen corporate security CID bce explosion Steve X-Ran: ;,WphcV0%8;Vx#usg#ae~B\@GN9?=a(FV/ (Julian Scheid's message of "Tue, 02 Oct 2012 14:43:36 +0200") Message-ID: User-Agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Spam-Score: -6.3 (------) X-Debbugs-Envelope-To: 12558-done X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -6.3 (------) Version: 24.3 Thanks; corrected in emacs-24 branch. From unknown Tue Aug 19 21:03:31 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Fri, 02 Nov 2012 11:24:03 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator