GNU bug report logs - #12541
Prefer plain 'static' to 'static inline'.

Previous Next

Full log

Message #34 received at 12541-done <at> debbugs.gnu.org (full text, mbox):

From: Paul Eggert <eggert <at> cs.ucla.edu>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 12541-done <at> debbugs.gnu.org
Subject: Re: bug#12541: Prefer plain 'static' to 'static inline'.
Date: Tue, 02 Oct 2012 00:00:54 -0700

On 10/01/2012 10:14 AM, Eli Zaretskii wrote:
> Perhaps that's because STRING_CHAR could call a function?

Yes, I suspect that's it.  When there's enough register pressure it
can sometimes make sense to put a call inside a function rather than
inline it.

> Nevertheless, I'm okay with removing the 'inline' qualifier from
> bidi.c.  If the performance hit is significant, I'm sure we will hear
> from users shortly.  Otherwise, I'll try to measure the performance
> with and without 'inline' when I have time, and we can take it from
> there.

Thanks, I did that as trunk bzr 110345 and am marking this as done.

For what it's worth, the amount of inlining often depends greatly on
exactly which compiler flags are used -- with GCC, for example, it can
matter quite a bit whether one uses -O1, -O2, or -O3.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.