GNU bug report logs - #1251
23.0.60; `process-status' does not work with buffer names

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 1251 in the body.
You can then email your comments to 1251 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> emacsbugs.donarmstrong.com (full text, mbox):

From: Markus Triska <markus.triska <at> gmx.at>
To: emacs-pretest-bug <at> gnu.org
Subject: 23.0.60; `process-status' does not work with buffer names
Date: Sat, 25 Oct 2008 19:14:16 +0200 (CEST)

Contrary to what its info entry says, process-status does not work if
its argument is a buffer name; in emacs -Q, evaluating the form:

   (let* ((buffer "bc-buf")
          (bc (start-process "bc" buffer "/usr/bin/bc")))
     (mapcar 'process-status (list buffer (get-buffer buffer))))

yields:

     (nil run)

The following patch fixes this problem for me:

2008-10-25  Markus Triska  <markus.triska <at> gmx.at>

	* process.c (Fprocess_status): Accept buffer names.
	Update docstring to match info description.

diff --git a/src/process.c b/src/process.c
index b8e390e..4a238f7 100644
--- a/src/process.c
+++ b/src/process.c
@@ -828,18 +828,15 @@ closed -- for a network stream connection that is closed.
 connect -- when waiting for a non-blocking connection to complete.
 failed -- when a non-blocking connection has failed.
 nil -- if arg is a process name and no such process exists.
-PROCESS may be a process, a buffer, the name of a process, or
-nil, indicating the current buffer's process.  */)
+PROCESS may be a process, a buffer, a process name, a buffer name, or
+nil, indicating the current buffer's process. */)
      (process)
      register Lisp_Object process;
 {
   register struct Lisp_Process *p;
   register Lisp_Object status;
 
-  if (STRINGP (process))
-    process = Fget_process (process);
-  else
-    process = get_process (process);
+  process = get_process (process);
 
   if (NILP (process))
     return process;


In GNU Emacs 23.0.60.14 (i386-apple-darwin8.11.1, GTK+ Version 2.12.9)
 of 2008-10-25 on mt-computer.local
Windowing system distributor `The XFree86 Project, Inc', version 11.0.40400000
Important settings:
  value of $LC_ALL: nil
  value of $LC_COLLATE: nil
  value of $LC_CTYPE: nil
  value of $LC_MESSAGES: nil
  value of $LC_MONETARY: nil
  value of $LC_NUMERIC: nil
  value of $LC_TIME: nil
  value of $LANG: en_GB.UTF-8
  value of $XMODIFIERS: nil
  locale-coding-system: nil
  default-enable-multibyte-characters: t

Message #10 received at submit <at> emacsbugs.donarmstrong.com (full text, mbox):

From: Stefan Monnier <monnier <at> iro.umontreal.ca>
To: Markus Triska <markus.triska <at> gmx.at>
Cc: 1251 <at> debbugs.gnu.org, emacs-pretest-bug <at> gnu.org
Subject: Re: bug#1251: 23.0.60; `process-status' does not work with buffer names
Date: Sat, 25 Oct 2008 15:11:18 -0400

> Contrary to what its info entry says, process-status does not work if
> its argument is a buffer name; in emacs -Q, evaluating the form:

I think we should fix the info entry, rather than the code.


        Stefan

Message #20 received at 1251-done <at> emacsbugs.donarmstrong.com (full text, mbox):

From: Chong Yidong <cyd <at> stupidchicken.com>
To: Markus Triska <markus.triska <at> gmx.at>
Cc: Stefan Monnier <monnier <at> iro.umontreal.ca>,
        1251-done <at> debbugs.gnu.org
Subject: Re: 23.0.60; `process-status' does not work with buffer names
Date: Tue, 28 Oct 2008 16:17:43 -0400

> > Contrary to what its info entry says, process-status does not work if
> > its argument is a buffer name; in emacs -Q, evaluating the form:
>
> I think we should fix the info entry, rather than the code.

Yes, we can't accept buffer names in process-status because it already
treats strings as process names.

I've updated the lisp manual.  Thanks for spotting this.

Message #21 received at 1251-done <at> emacsbugs.donarmstrong.com (full text, mbox):

From: Markus Triska <markus.triska <at> gmx.at>
To: Chong Yidong <cyd <at> stupidchicken.com>
Cc: Stefan Monnier <monnier <at> iro.umontreal.ca>,
        1251-done <at> debbugs.gnu.org
Subject: Re: 23.0.60; `process-status' does not work with buffer names
Date: Tue, 28 Oct 2008 23:15:42 +0100

Chong Yidong <cyd <at> stupidchicken.com> writes:

> Yes, we can't accept buffer names in process-status because it already
> treats strings as process names.

Only for completeness: There are several functions dealing with
processes (e.g., `process-send-string') that allow strings to mean both
process and buffer names. Unfortunately it's not very consistent, and
sometimes incorrectly documented; for example, `comint-send-string':

   Like `process-send-string', ...

but in `comint-send-string', you cannot use process names.

Message #22 received at 1251-done <at> emacsbugs.donarmstrong.com (full text, mbox):

From: Stefan Monnier <monnier <at> iro.umontreal.ca>
To: Markus Triska <markus.triska <at> gmx.at>
Cc: Chong Yidong <cyd <at> stupidchicken.com>, 1251-done <at> debbugs.gnu.org
Subject: Re: 23.0.60; `process-status' does not work with buffer names
Date: Wed, 29 Oct 2008 10:45:03 -0400

>> Yes, we can't accept buffer names in process-status because it already
>> treats strings as process names.

> Only for completeness: There are several functions dealing with
> processes (e.g., `process-send-string') that allow strings to mean both
> process and buffer names. Unfortunately it's not very consistent, and
> sometimes incorrectly documented; for example, `comint-send-string':

>    Like `process-send-string', ...

> but in `comint-send-string', you cannot use process names.

We should discourage this use.  I.e. we should start by removing mention
of it in the docstrings (and/or manual).


        Stefan

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.