GNU bug report logs - #12507
24.2.50; `bookmark-write-file': use `write-file', not `write-region', to get backups

Previous Next

Full log

View this message in rfc822 format

From: Drew Adams <drew.adams <at> oracle.com>
To: Karl Fogel <kfogel <at> red-bean.com>
Cc: Lars Ingebrigtsen <larsi <at> gnus.org>, Chong Yidong <cyd <at> gnu.org>, 12507 <at> debbugs.gnu.org
Subject: bug#12507: [debbugs-tracker] Processed: severity 12507 wishlist
Date: Tue, 29 Sep 2020 08:45:17 -0700 (PDT)

> >What's wrong with the obvious, simple solution to the
> >real, recognized problem of no backups for bookmark
> >files: use `write-file'?  That's the first question
> >to ask and answer, no?
> 
> I can't think of any reason now.  I have a vague memory that there *was* a
> specific reason, but if there was, I failed to document adequately at the
> time and have been unable to recover it now.
> 
> Eli helpfully linked to Richard's message
> (https://urldefense.com/v3/__https://lists.gnu.org/archive/html/emacs-
> devel/2005-
> 05/msg01376.html__;!!GqivPVa7Brio!OesHeMbHNKqFeUCyyW2WJ0UeXBZjSXngBYlvA1Q5G9F
> zXXgAa30g7LGrcwolObMB$ ), in which Richard points out that if bookmark visits
> the file anyway when reading, then there's nothing to be gained (from the
> perspective of saveplace.el interference) from avoiding visiting it when
> writing.
> 
> And `bookmark-load' *does* visit the file when reading, so I'm leaning toward
> just taking your suggestion and reverting to `write-file' -- but this time
> leaving better historical breadcrumbs (in comments and/or log messages) in
> case my vaguely-remembered bug turns out to be real and reappears.
> 
> I will do this as soon as I have time to focus on it and make sure I don't
> make a silly blunder; that may be several days.

Thanks for looking into this, Karl.  (No hurry.)

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.