GNU bug report logs - #12507
24.2.50; `bookmark-write-file': use `write-file', not `write-region', to get backups

Previous Next

Full log

Message #147 received at 12507 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Lars Ingebrigtsen <larsi <at> gnus.org>
Cc: kfogel <at> red-bean.com, cyd <at> gnu.org, 12507 <at> debbugs.gnu.org
Subject: Re: bug#12507: [debbugs-tracker] Processed: severity 12507 wishlist
Date: Wed, 23 Sep 2020 19:23:03 +0300

> From: Lars Ingebrigtsen <larsi <at> gnus.org>
> Date: Wed, 23 Sep 2020 15:34:01 +0200
> Cc: Chong Yidong <cyd <at> gnu.org>, 12507 <at> debbugs.gnu.org
> 
> Karl Fogel <kfogel <at> red-bean.com> writes:
> 
> > I've just been deep-diving into this again.  I'd like feedback on this general plan for a solution:
> >
> > 1) In files.el: define a new function `back-up-file' [a] that takes a
> >    file name as argument and does most of what `backup-buffer' currently
> >    does -- basically, everything from the second `when' on down to the
> >    end of the function.
> >
> > 2) Change `backup-buffer' to use the new function `back-up-file'.
> >
> >    In other words, we abstract out most of the Emacs file backup
> >    functionality to this new function `back-up-file' so we can call it
> >    in (3) below, passing a file name argument.
> 
> Sounds perfect.  There's a bunch of modes in Emacs that want to do a
> backup file, and they go through all these contortions to make this
> happen.  

Maybe this would be a good feature to have, but going back to the
original problem of bookmark file, I think that the easiest fix is to
go back to using write-file.  Karl changed that 15 years ago because
he followed suit of saveplace.el, but I think there's a significant
difference between the files these two packages maintain: the file
with bookmarks is much more close to being "user data" than the file
written by saveplace.el.  So I don't think they need both to treat
their files the same, wrt backing them up.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.