Subject: Re: bug#12492: Acknowledgement (24.2.50; Open vc-dir buffer easier and faster)

From: Juri Linkov <[email-masked]>
Date: Wed, 04 Mar 2020 01:27:16 +0200

>> But the command has more unsolved issues:
>> 1. command name - the most natural name would be vc-root-dir,
>>     but this name is already taken by a non-interactive function.
>
> vc-dir-quick was my idea.

This name implies its implementation has better performance
over its slower competitor.

>> 2. keybinding - there are many contradicting proposals,
>>     and leaving it unbound is not the best solution.
>
> Like mentioned already, I think it's fine unbound. Not worse than having
> a user option. It comes down to the user either customizing the option, 
> or binding the command to 'C-x v d' in their init script. We shouldn't
> provide both in the core, though.
>
>>>> +(defcustom vc-dir-default-directory nil
>>>> +  "Default directory name for the command `vc-dir'.
>>>
>>> Both of these lines look wrong.
>>>
>>> VC-Dir already uses the correct directory as the default. What you're
>>> looking for is to avoid prompting the user.
>> These details are explained further down in the docstring:
>
> I'm saying both the option name and the first sentence of the docstring
> don't fit its purpose, or the later description.

This option is multi-purpose and one of its possible values is:

  When a string and `vc-dir' is invoked in a directory outside of
  version control, then this string is used as a default directory name.