Subject: Re: bug#12461: unrecognized file system type 0xbacbacbc

From: Daniel Tschinder <[email-masked]>
Date: Sun, 23 Sep 2012 11:46:06 +0200

Ahh great, that woks. Magical comments :)

Thanks for fixing this bug.
Am 23.09.2012 um 09:24 schrieb Jim Meyering <[email-masked]>:

> Daniel Tschinder wrote:
>> This patch does not seem to work.
>> I've tested to tail -f inside the vm and append from host. The initial
>> error message is not shown, but also the file does not refresh. So all
>> the appended changes to the file from the host, do not show up in the
>> running tail-session in vm.
>> 
>> I did not test the other way round, as vmhgfs is only used inside the
>> vm and for the host system Mac OS X 10.8 the shared path is normal mac
>> filesystem.
>> 
>> So it seems inotify is not supported :(
> 
> Thanks for checking.
> I've adjusted the patch, NEWS and log to reflect that and pushed this:
> 
> From 2dad87f6415ec68564e934ace33496db1abc68c7 Mon Sep 17 00:00:00 2001
> From: Jim Meyering <[email-masked]>
> Date: Wed, 19 Sep 2012 21:52:05 +0200
> Subject: [PATCH] tail,stat: improve support for vmhgfs
> 
> Teach tail -f that it must use polling on vmhgfs file systems, and
> let stat -f --format=%T report the file system type name, "vmhgfs".
> * src/stat.c (human_fstype): Add a case: vmhgfs, 0xbacbacbc, remote.
> * NEWS (Improvements): Mention it.
> * THANKS.in: Update.
> Reported by Daniel Tschinder in http://bugs.gnu.org/12461.
> ---
> NEWS       | 9 +++++----
> THANKS.in  | 1 +
> src/stat.c | 2 ++
> 3 files changed, 8 insertions(+), 4 deletions(-)
> 
> diff --git a/NEWS b/NEWS
> index 59a8510..9bd5d58 100644
> --- a/NEWS
> +++ b/NEWS
> @@ -49,10 +49,11 @@ GNU coreutils NEWS                                    -*- outline -*-
>   but only with non-negative whole numbers, an increment of 1, and no
>   format-changing options.
> 
> -  stat and tail work better with ZFS and VZFS.  stat -f --format=%T now
> -  reports the file system type, and tail -f now uses inotify for files
> -  on those file systems, rather than the default (for unknown file system
> -  types) of issuing a warning and reverting to polling.
> +  stat and tail know about ZFS, VZFS and VMHGFS.  stat -f --format=%T now
> +  reports the file system type, and tail -f now uses inotify for files on
> +  ZFS and VZFS file systems, rather than the default (for unknown file
> +  system types) of issuing a warning and reverting to polling.  tail -f
> +  still uses polling for files on VMHGFS file systems.
> 
> ** Build-related
> 
> diff --git a/THANKS.in b/THANKS.in
> index b0061b3..0f06aa0 100644
> --- a/THANKS.in
> +++ b/THANKS.in
> @@ -139,6 +139,7 @@ Dan Pascu                           [email-masked]
> Daniel Bergstrom                    [email-masked]
> Daniel P. Berrangé                  [email-masked]
> Daniel Stavrovski                   [email-masked]
> +Daniel Tschinder                    [email-masked]
> Dániel Varga                        [email-masked]
> Danny Levinson                      [email-masked]
> Darrel Francis                      [email-masked]
> diff --git a/src/stat.c b/src/stat.c
> index a9fb951..51f4b90 100644
> --- a/src/stat.c
> +++ b/src/stat.c
> @@ -413,6 +413,8 @@ human_fstype (STRUCT_STATVFS const *statfsbuf)
>       return "usbdevfs";
>     case S_MAGIC_V9FS: /* 0x01021997 local */
>       return "v9fs";
> +    case S_MAGIC_VMHGFS: /* 0xBACBACBC remote */
> +      return "vmhgfs";
>     case S_MAGIC_VXFS: /* 0xA501FCF5 local */
>       return "vxfs";
>     case S_MAGIC_VZFS: /* 0x565A4653 local */
> --
> 1.7.12.1.382.gb0576a6