GNU bug report logs - #12460
24.2.50; toggling read-only interactively: echo new state

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 12460 in the body.
You can then email your comments to 12460 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: "Drew Adams" <drew.adams <at> oracle.com>
To: <bug-gnu-emacs <at> gnu.org>
Subject: 24.2.50; toggling read-only interactively: echo new state
Date: Mon, 17 Sep 2012 08:37:25 -0700

For `toggle-read-only' and similar commands: Please add an optional,
boolean MSGP parameter which when non-nil echoes the new state.  Make
the argument non-nil when the command is called interactively.

In GNU Emacs 24.2.50.1 (i386-mingw-nt5.1.2600)
 of 2012-09-17 on MARVIN
Bzr revision: 110062 cyd <at> gnu.org-20120917054104-r93rtwkrtva73ewe
Windowing system distributor `Microsoft Corp.', version 5.1.2600
Configured using:
 `configure --with-gcc (4.7) --no-opt --enable-checking --cflags
 -ID:/devel/emacs/libs/libXpm-3.5.8/include
 -ID:/devel/emacs/libs/libXpm-3.5.8/src
 -ID:/devel/emacs/libs/libpng-dev_1.4.3-1/include
 -ID:/devel/emacs/libs/zlib-dev_1.2.5-2/include
 -ID:/devel/emacs/libs/giflib-4.1.4-1/include
 -ID:/devel/emacs/libs/jpeg-6b-4/include
 -ID:/devel/emacs/libs/tiff-3.8.2-1/include
 -ID:/devel/emacs/libs/gnutls-3.0.9/include
 -ID:/devel/emacs/libs/libiconv-1.13.1-1-dev/include
 -ID:/devel/emacs/libs/libxml2-2.7.8/include/libxml2'
 

Message #8 received at 12460 <at> debbugs.gnu.org (full text, mbox):

From: "Drew Adams" <drew.adams <at> oracle.com>
To: <12460 <at> debbugs.gnu.org>
Subject: RE: bug#12460: 24.2.50;
	toggling read-only interactively: echo new state
Date: Mon, 17 Sep 2012 09:05:34 -0700

And since you've now made `toggle-read-only' obsolete (though it is still
invoked by `C-x C-q' - see bug #12462), please make `read-only-mode' echo the
new state as well.  It too should provide a Boolean arg or equivalent to control
the display of the new-state message from Lisp.

Message #11 received at 12460 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Monnier <monnier <at> IRO.UMontreal.CA>
To: "Drew Adams" <drew.adams <at> oracle.com>
Cc: 12460 <at> debbugs.gnu.org
Subject: Re: bug#12460: 24.2.50;
	toggling read-only interactively: echo new state
Date: Mon, 17 Sep 2012 13:32:20 -0400

> And since you've now made `toggle-read-only' obsolete (though it is
> still invoked by `C-x C-q' - see bug #12462), please make
> `read-only-mode' echo the new state as well.  It too should provide
> a Boolean arg or equivalent to control the display of the new-state
> message from Lisp.

All minor modes follow the same rule and use `called-interactively-p'
rather than an extra argument.  So if we want to change it it's in
easy-mmode.el and will apply to all minor modes.


        Stefan

Message #14 received at 12460 <at> debbugs.gnu.org (full text, mbox):

From: "Drew Adams" <drew.adams <at> oracle.com>
To: "'Stefan Monnier'" <monnier <at> IRO.UMontreal.CA>
Cc: 12460 <at> debbugs.gnu.org
Subject: RE: bug#12460: 24.2.50;
	toggling read-only interactively: echo new state
Date: Mon, 17 Sep 2012 10:44:54 -0700

> > And since you've now made `toggle-read-only' obsolete (though it is
> > still invoked by `C-x C-q' - see bug #12462), please make
> > `read-only-mode' echo the new state as well.  It too should provide
> > a Boolean arg or equivalent to control the display of the new-state
> > message from Lisp.
> 
> All minor modes follow the same rule and use `called-interactively-p'
> rather than an extra argument.  So if we want to change it it's in
> easy-mmode.el and will apply to all minor modes.

I see.  And I see that `read-only-mode' already does echo the new state when
invoked interactively.  I guess this can be closed - I'll do that.  But please
update the doc (bug #12462).

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.