From debbugs-submit-bounces@debbugs.gnu.org Fri Sep 14 13:05:25 2012 Received: (at submit) by debbugs.gnu.org; 14 Sep 2012 17:05:25 +0000 Received: from localhost ([127.0.0.1]:34079 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TCZKX-0006m6-2G for submit@debbugs.gnu.org; Fri, 14 Sep 2012 13:05:25 -0400 Received: from eggs.gnu.org ([208.118.235.92]:53887) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TCZBb-0006Y0-Td for submit@debbugs.gnu.org; Fri, 14 Sep 2012 12:56:12 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TCZAe-0005n4-Pm for submit@debbugs.gnu.org; Fri, 14 Sep 2012 12:55:13 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_HI autolearn=unavailable version=3.3.2 Received: from lists.gnu.org ([208.118.235.17]:33781) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TCZAe-0005mp-Lz for submit@debbugs.gnu.org; Fri, 14 Sep 2012 12:55:12 -0400 Received: from eggs.gnu.org ([208.118.235.92]:56442) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TCZAd-0006zV-P7 for bug-coreutils@gnu.org; Fri, 14 Sep 2012 12:55:12 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TCZAc-0005k5-Jl for bug-coreutils@gnu.org; Fri, 14 Sep 2012 12:55:11 -0400 Received: from bureau59.ns.utoronto.ca ([128.100.132.146]:34676) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TCZAc-0005La-FA for bug-coreutils@gnu.org; Fri, 14 Sep 2012 12:55:10 -0400 Received: from ara-think-vm (biolab-gw60.cs.toronto.edu [128.100.3.60]) (authenticated bits=0) by bureau59.ns.utoronto.ca (8.13.8/8.13.8) with ESMTP id q8EGsrVw015419 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO) for ; Fri, 14 Sep 2012 12:54:55 -0400 Date: Fri, 14 Sep 2012 12:54:51 -0400 From: Matei David To: bug-coreutils@gnu.org Subject: ls --color does not color symlinks when not resolving them Message-ID: <20120914125451.563aa815@ara-think-vm> X-Mailer: Claws Mail 3.8.0 (GTK+ 2.24.4; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="MP_/SWTuTJ0w3e.Jqgnen0zgwaY" X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-Received-From: 208.118.235.17 X-Spam-Score: -6.1 (------) X-Debbugs-Envelope-To: submit X-Mailman-Approved-At: Fri, 14 Sep 2012 13:05:23 -0400 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -6.1 (------) --MP_/SWTuTJ0w3e.Jqgnen0zgwaY Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Content-Disposition: inline When the ORPHAN property is disabled in dircolors, ls --color does not stat() symlinks. However, in this case symlinks are not colored using the LINK property. How to reproduce: $ eval $(dircolors -p | sed 's/^ORPHAN.*/ORPHAN 00/' | dircolors -) $ mkdir /tmp/xxx $ ln -s /tmp/nowhere /tmp/xxx/yyy $ ls --color /tmp/xxx Expected output: yyy, colored cyan (default for LINK) Actual output: yyy, not colored Fix attached. Basically, in gobble_file(), assume a symlink is ok if stat() is not run on it. Thanks, M --MP_/SWTuTJ0w3e.Jqgnen0zgwaY Content-Type: application/octet-stream; name=fix Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename=fix ZGlmZiAtLWdpdCBhL3NyYy9scy5jIGIvc3JjL2xzLmMKaW5kZXggOTQ5NGFlOS4uNDJlN2JjMyAx MDA2NDQKLS0tIGEvc3JjL2xzLmMKKysrIGIvc3JjL2xzLmMKQEAgLTI4ODMsNiArMjg4Myw3IEBA IGdvYmJsZV9maWxlIChjaGFyIGNvbnN0ICpuYW1lLCBlbnVtIGZpbGV0eXBlIHR5cGUsIGlub190 IGlub2RlLAogICBtZW1zZXQgKGYsICdcMCcsIHNpemVvZiAqZik7CiAgIGYtPnN0YXQuc3RfaW5v ID0gaW5vZGU7CiAgIGYtPmZpbGV0eXBlID0gdHlwZTsKKyAgZi0+bGlua29rID0gdHJ1ZTsKIAog ICBpZiAoY29tbWFuZF9saW5lX2FyZwogICAgICAgfHwgZm9ybWF0X25lZWRzX3N0YXQKQEAgLTI5 MjgsNiArMjkyOSw3IEBAIGdvYmJsZV9maWxlIChjaGFyIGNvbnN0ICpuYW1lLCBlbnVtIGZpbGV0 eXBlIHR5cGUsIGlub190IGlub2RlLAogICAgICAgYm9vbCBkb19kZXJlZjsKICAgICAgIGludCBl cnI7CiAKKyAgICAgIGYtPmxpbmtvayA9IGZhbHNlOwogICAgICAgaWYgKG5hbWVbMF0gPT0gJy8n IHx8IGRpcm5hbWVbMF0gPT0gMCkKICAgICAgICAgYWJzb2x1dGVfbmFtZSA9IChjaGFyICopIG5h bWU7CiAgICAgICBlbHNlCg== --MP_/SWTuTJ0w3e.Jqgnen0zgwaY-- From debbugs-submit-bounces@debbugs.gnu.org Fri Sep 14 19:56:29 2012 Received: (at 12445) by debbugs.gnu.org; 14 Sep 2012 23:56:29 +0000 Received: from localhost ([127.0.0.1]:34486 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TCfkL-00087f-3p for submit@debbugs.gnu.org; Fri, 14 Sep 2012 19:56:29 -0400 Received: from mx1.redhat.com ([209.132.183.28]:39332) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TCfkI-00087T-VL; Fri, 14 Sep 2012 19:56:28 -0400 Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q8ENtFqW018253 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Fri, 14 Sep 2012 19:55:15 -0400 Received: from [10.36.116.76] (ovpn-116-76.ams2.redhat.com [10.36.116.76]) by int-mx02.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id q8ENtCYu014720 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Fri, 14 Sep 2012 19:55:14 -0400 Message-ID: <5053C3E0.3090804@draigBrady.com> Date: Sat, 15 Sep 2012 00:55:12 +0100 From: =?ISO-8859-1?Q?P=E1draig_Brady?= User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:6.0) Gecko/20110816 Thunderbird/6.0 MIME-Version: 1.0 To: Matei David Subject: Re: bug#12445: ls --color does not color symlinks when not resolving them References: <20120914125451.563aa815@ara-think-vm> In-Reply-To: <20120914125451.563aa815@ara-think-vm> Content-Type: text/plain; charset=ISO-8859-1; format=flowed X-Scanned-By: MIMEDefang 2.67 on 10.5.11.12 Content-Transfer-Encoding: quoted-printable X-MIME-Autoconverted: from 8bit to quoted-printable by mx1.redhat.com id q8ENtFqW018253 X-Spam-Score: -6.9 (------) X-Debbugs-Envelope-To: 12445 Cc: 12445@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -6.9 (------) tag 12445 + notabug close 12445 stop On 09/14/2012 05:54 PM, Matei David wrote: > When the ORPHAN property is disabled in dircolors, ls --color does not = stat() > symlinks. However, in this case symlinks are not colored using the LINK > property. > > How to reproduce: > $ eval $(dircolors -p | sed 's/^ORPHAN.*/ORPHAN 00/' | dircolors -) > $ mkdir /tmp/xxx > $ ln -s /tmp/nowhere /tmp/xxx/yyy > $ ls --color /tmp/xxx > > Expected output: > yyy, colored cyan (default for LINK) > > Actual output: > yyy, not colored > > Fix attached. Basically, in gobble_file(), assume a symlink is ok if st= at() is > not run on it. It seems this was fixed over 5 years ago in version 6.9 http://git.sv.gnu.org/gitweb/?p=3Dcoreutils.git;a=3Dcommit;h=3D0a744370 Are you using an older version than that? I'm marking as done for now. thanks, P=E1draig. From debbugs-submit-bounces@debbugs.gnu.org Fri Sep 14 22:29:21 2012 Received: (at 12445) by debbugs.gnu.org; 15 Sep 2012 02:29:21 +0000 Received: from localhost ([127.0.0.1]:34553 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TCi8G-0004uR-VI for submit@debbugs.gnu.org; Fri, 14 Sep 2012 22:29:21 -0400 Received: from bureau58.ns.utoronto.ca ([128.100.132.145]:44913) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TCi8D-0004uJ-Nh for 12445@debbugs.gnu.org; Fri, 14 Sep 2012 22:29:19 -0400 Received: from ara-think-vm (dsl-173-206-253-106.tor.primus.ca [173.206.253.106]) (authenticated bits=0) by bureau58.ns.utoronto.ca (8.13.8/8.13.8) with ESMTP id q8F2S9dq019795 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO); Fri, 14 Sep 2012 22:28:15 -0400 Date: Fri, 14 Sep 2012 22:28:06 -0400 From: Matei David To: =?UTF-8?B?UMOhZHJhaWc=?= Brady Subject: Re: bug#12445: ls --color does not color symlinks when not resolving them Message-ID: <20120914222806.728dccc3@ara-think-vm> In-Reply-To: <5053C3E0.3090804@draigBrady.com> References: <20120914125451.563aa815@ara-think-vm> <5053C3E0.3090804@draigBrady.com> X-Mailer: Claws Mail 3.8.0 (GTK+ 2.24.4; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -1.8 (-) X-Debbugs-Envelope-To: 12445 Cc: 12445@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -1.8 (-) On Sat, 15 Sep 2012 00:55:12 +0100 P=C3=A1draig Brady wrote: > tag 12445 + notabug > close 12445 > stop >=20 > On 09/14/2012 05:54 PM, Matei David wrote: > > When the ORPHAN property is disabled in dircolors, ls --color does not > > stat() symlinks. However, in this case symlinks are not colored using t= he > > LINK property. > > > > How to reproduce: > > $ eval $(dircolors -p | sed 's/^ORPHAN.*/ORPHAN 00/' | dircolors -) > > $ mkdir /tmp/xxx > > $ ln -s /tmp/nowhere /tmp/xxx/yyy > > $ ls --color /tmp/xxx > > > > Expected output: > > yyy, colored cyan (default for LINK) > > > > Actual output: > > yyy, not colored > > > > Fix attached. Basically, in gobble_file(), assume a symlink is ok if st= at() > > is not run on it. >=20 > It seems this was fixed over 5 years ago in version 6.9 > http://git.sv.gnu.org/gitweb/?p=3Dcoreutils.git;a=3Dcommit;h=3D0a744370 > Are you using an older version than that? >=20 > I'm marking as done for now. >=20 > thanks, > P=C3=A1draig. I'm using coreutils 8.19. There are 2 lines which ever modify f->linkok (bo= th set it to true): 2700 and 2720. Both are inside the if block starting at line 2560. By design, the if block is _not_ executed under the conditions I= laid out above in order to avoid both fstat() and stat() calls on the symlink (w= hich is ok!) However, the coloring is missing. Did you try my code? The bug you mention was about avoiding the stat() call, i.e. following the link. There is also this one, related: http://git.savannah.gnu.org/cgit/coreutils.git/commit/src/ls.c?id=3Da085b6f= c6c8fa03dac20f01f2f2b64b50b8bdf66 The behaviour I observe is: no fstat(), no stat(), (great so far...) but no color either- that's the bug. From debbugs-submit-bounces@debbugs.gnu.org Sat Sep 15 06:41:58 2012 Received: (at 12445) by debbugs.gnu.org; 15 Sep 2012 10:41:58 +0000 Received: from localhost ([127.0.0.1]:34929 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TCpp0-0001H4-Bd for submit@debbugs.gnu.org; Sat, 15 Sep 2012 06:41:58 -0400 Received: from mx1.redhat.com ([209.132.183.28]:33394) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TCpox-0001Gt-IJ; Sat, 15 Sep 2012 06:41:56 -0400 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q8FAefA1006130 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Sat, 15 Sep 2012 06:40:42 -0400 Received: from [10.36.116.33] (ovpn-116-33.ams2.redhat.com [10.36.116.33]) by int-mx01.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id q8FAed05027344 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Sat, 15 Sep 2012 06:40:40 -0400 Message-ID: <50545B27.2050206@draigBrady.com> Date: Sat, 15 Sep 2012 11:40:39 +0100 From: =?UTF-8?B?UMOhZHJhaWcgQnJhZHk=?= User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:6.0) Gecko/20110816 Thunderbird/6.0 MIME-Version: 1.0 To: Matei David Subject: Re: bug#12445: ls --color does not color symlinks when not resolving them References: <20120914125451.563aa815@ara-think-vm> <5053C3E0.3090804@draigBrady.com> <20120914222806.728dccc3@ara-think-vm> In-Reply-To: <20120914222806.728dccc3@ara-think-vm> Content-Type: text/plain; charset=UTF-8; format=flowed X-Scanned-By: MIMEDefang 2.67 on 10.5.11.11 Content-Transfer-Encoding: quoted-printable X-MIME-Autoconverted: from 8bit to quoted-printable by mx1.redhat.com id q8FAefA1006130 X-Spam-Score: -6.9 (------) X-Debbugs-Envelope-To: 12445 Cc: 12445@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -6.9 (------) reopen 12445 stop On 09/15/2012 03:28 AM, Matei David wrote: > On Sat, 15 Sep 2012 00:55:12 +0100 > P=C3=A1draig Brady wrote: > >> tag 12445 + notabug >> close 12445 >> stop >> >> On 09/14/2012 05:54 PM, Matei David wrote: >>> When the ORPHAN property is disabled in dircolors, ls --color does no= t >>> stat() symlinks. However, in this case symlinks are not colored using= the >>> LINK property. >>> >>> How to reproduce: >>> $ eval $(dircolors -p | sed 's/^ORPHAN.*/ORPHAN 00/' | dircolors -) >>> $ mkdir /tmp/xxx >>> $ ln -s /tmp/nowhere /tmp/xxx/yyy >>> $ ls --color /tmp/xxx >>> >>> Expected output: >>> yyy, colored cyan (default for LINK) >>> >>> Actual output: >>> yyy, not colored >>> >>> Fix attached. Basically, in gobble_file(), assume a symlink is ok if = stat() >>> is not run on it. >> >> It seems this was fixed over 5 years ago in version 6.9 >> http://git.sv.gnu.org/gitweb/?p=3Dcoreutils.git;a=3Dcommit;h=3D0a74437= 0 >> Are you using an older version than that? >> >> I'm marking as done for now. >> >> thanks, >> P=C3=A1draig. > > I'm using coreutils 8.19. There are 2 lines which ever modify f->linkok= (both > set it to true): 2700 and 2720. Both are inside the if block starting a= t > line 2560. By design, the if block is _not_ executed under the conditio= ns I laid > out above in order to avoid both fstat() and stat() calls on the symlin= k (which > is ok!) However, the coloring is missing. Did you try my code? > > The bug you mention was about avoiding the stat() call, i.e. following = the > link. There is also this one, related: > http://git.savannah.gnu.org/cgit/coreutils.git/commit/src/ls.c?id=3Da08= 5b6fc6c8fa03dac20f01f2f2b64b50b8bdf66 > > The behaviour I observe is: no fstat(), no stat(), (great so far...) bu= t no > color either- that's the bug. Drats, I was too hasty sorry. ls 8.10 doesn't have the issue, and when I tested the latest version I only did so with -l which also doesn't show the issue. So this regression was added since 8.10 and only when -l is not used. I'll add tests etc. and apply a fix in your name. thanks! P=C3=A1draig. From unknown Mon Jun 23 13:12:31 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: Did not alter fixed versions and reopened. Date: Sat, 15 Sep 2012 10:42:02 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # Did not alter fixed versions and reopened. thanks # This fakemail brought to you by your local debbugs # administrator From debbugs-submit-bounces@debbugs.gnu.org Sat Sep 15 23:48:18 2012 Received: (at 12445) by debbugs.gnu.org; 16 Sep 2012 03:48:18 +0000 Received: from localhost ([127.0.0.1]:36117 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TD5qD-00053P-Le for submit@debbugs.gnu.org; Sat, 15 Sep 2012 23:48:18 -0400 Received: from mx1.redhat.com ([209.132.183.28]:17057) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TD5q9-00053G-L6 for 12445@debbugs.gnu.org; Sat, 15 Sep 2012 23:48:15 -0400 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q8G3kofU025428 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Sat, 15 Sep 2012 23:46:50 -0400 Received: from [10.36.116.18] (ovpn-116-18.ams2.redhat.com [10.36.116.18]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id q8G3kleF028526 (version=TLSv1/SSLv3 cipher=DHE-RSA-CAMELLIA256-SHA bits=256 verify=NO); Sat, 15 Sep 2012 23:46:49 -0400 Message-ID: <50554BA6.3080206@draigBrady.com> Date: Sun, 16 Sep 2012 04:46:46 +0100 From: =?UTF-8?B?UMOhZHJhaWcgQnJhZHk=?= User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:6.0) Gecko/20110816 Thunderbird/6.0 MIME-Version: 1.0 To: Matei David Subject: Re: bug#12445: ls --color does not color symlinks when not resolving them References: <20120914125451.563aa815@ara-think-vm> <5053C3E0.3090804@draigBrady.com> <20120914222806.728dccc3@ara-think-vm> <50545B27.2050206@draigBrady.com> In-Reply-To: <50545B27.2050206@draigBrady.com> Content-Type: multipart/mixed; boundary="------------090607030108090808020306" X-Scanned-By: MIMEDefang 2.68 on 10.5.11.23 X-Spam-Score: -6.9 (------) X-Debbugs-Envelope-To: 12445 Cc: 12445@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -6.9 (------) This is a multi-part message in MIME format. --------------090607030108090808020306 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable X-MIME-Autoconverted: from 8bit to quoted-printable by mx1.redhat.com id q8G3kofU025428 On 09/15/2012 11:40 AM, P=C3=A1draig Brady wrote: > reopen 12445 > stop > > On 09/15/2012 03:28 AM, Matei David wrote: >> On Sat, 15 Sep 2012 00:55:12 +0100 >> P=C3=A1draig Brady wrote: >> >>> tag 12445 + notabug >>> close 12445 >>> stop >>> >>> On 09/14/2012 05:54 PM, Matei David wrote: >>>> When the ORPHAN property is disabled in dircolors, ls --color does n= ot >>>> stat() symlinks. However, in this case symlinks are not colored usin= g the >>>> LINK property. >>>> >>>> How to reproduce: >>>> $ eval $(dircolors -p | sed 's/^ORPHAN.*/ORPHAN 00/' | dircolors -) >>>> $ mkdir /tmp/xxx >>>> $ ln -s /tmp/nowhere /tmp/xxx/yyy >>>> $ ls --color /tmp/xxx >>>> >>>> Expected output: >>>> yyy, colored cyan (default for LINK) >>>> >>>> Actual output: >>>> yyy, not colored >>>> >>>> Fix attached. Basically, in gobble_file(), assume a symlink is ok if= stat() >>>> is not run on it. >>> >>> It seems this was fixed over 5 years ago in version 6.9 >>> http://git.sv.gnu.org/gitweb/?p=3Dcoreutils.git;a=3Dcommit;h=3D0a7443= 70 >>> Are you using an older version than that? >>> >>> I'm marking as done for now. >>> >>> thanks, >>> P=C3=A1draig. >> >> I'm using coreutils 8.19. There are 2 lines which ever modify f->linko= k (both >> set it to true): 2700 and 2720. Both are inside the if block starting = at >> line 2560. By design, the if block is _not_ executed under the conditi= ons I laid >> out above in order to avoid both fstat() and stat() calls on the symli= nk (which >> is ok!) However, the coloring is missing. Did you try my code? >> >> The bug you mention was about avoiding the stat() call, i.e. following= the >> link. There is also this one, related: >> http://git.savannah.gnu.org/cgit/coreutils.git/commit/src/ls.c?id=3Da0= 85b6fc6c8fa03dac20f01f2f2b64b50b8bdf66 >> >> The behaviour I observe is: no fstat(), no stat(), (great so far...) b= ut no >> color either- that's the bug. > > Drats, I was too hasty sorry. > > ls 8.10 doesn't have the issue, and when I tested the latest version > I only did so with -l which also doesn't show the issue. > > So this regression was added since 8.10 and only when -l is not used. > > I'll add tests etc. and apply a fix in your name. So the regression was introduced in coreutils 8.14 in: http://git.sv.gnu.org/gitweb/?p=3Dcoreutils.git;a=3Dcommit;h=3D84457c49 I dug a little deeper and was confused as to the need for the simulated "linkok" at all. That was originally introduced with: http://thread.gmane.org/gmane.comp.gnu.coreutils.bugs/10608/focus=3D10927 I also noticed that is_colored() was not used with C_ORPHAN, thus meaning any of or=3D00, or=3D0, or=3D in LS_COLORS was considered si= gnificant. One could argue that for any attribute, 00 should mean color as 00, rather than don't color, but for consistency with all other color checks I changed that to use is_colored(). As that was the only part of the code= inspecting the "linkok" variable, I removed the simulated linkok referenced in the above link. All tests pass with the new code. cheers, P=C3=A1draig. --------------090607030108090808020306 Content-Type: text/plain; name="ls-linkok.diff" Content-Disposition: attachment; filename="ls-linkok.diff" Content-Transfer-Encoding: base64 RnJvbSBlYmY2OTdiNjIzNDM1ZDQ2ZGQ0ODk5ODQwOGUxYzdjZjNlYmExNjIzIE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiA9P1VURi04P3E/UD1DMz1BMWRyYWlnPTIwQnJhZHk/ PSA8UEBkcmFpZ0JyYWR5LmNvbT4KRGF0ZTogU3VuLCAxNiBTZXAgMjAxMiAwNDoxMDo1MCAr MDEwMApTdWJqZWN0OiBbUEFUQ0hdIGxzOiBmaXggY29sb3Jpbmcgb2YgZGFuZ2xpbmcgc3lt bGlua3MgaW4gZGVmYXVsdCBsaXN0aW5nCiBtb2RlCgpXaGVuIGxpc3RpbmcgYSBkaXJlY3Rv cnkgY29udGFpbmluZyBkYW5nbGluZyBzeW1saW5rcywKYW5kIG5vdCBvdXRwdXR0aW5nIGEg bG9uZyBmb3JtYXQgbGlzdGluZywgYW5kIG9ycGhhbmVkIGxpbmtzCmFyZSBzZXQgdG8gbm8g Y29sb3JpbmcgaW4gTFNfQ09MT1JTLCB0aGVuIHRoZSBzeW1saW5rcwp3b3VsZCBnZXQgbm8g Y29sb3IgcmF0aGVyIHRoYW4gcmV2ZXJ0aW5nIHRvIHRoZSBzdGFuZGFyZApzeW1saW5rIGNv bG9yLiAgVGhlIGlzc3VlIHdhcyBpbnRyb2R1Y2VkIGluIHY4LjEzLTE5LWc4NDQ1N2M0Cgoq IHNyYy9scy5jIChwcmludF9jb2xvcl9pbmRpY2F0b3IpOiBVc2UgdGhlIHN0YW5kYXJkIG1l dGhvZAp0byBjaGVjayBpZiBjb2xvcmluZyBpcyBzcGVjaWZpZWQgZm9yIG9ycGhhbmVkIHN5 bWxpbmtzLgpUaGUgZXhpc3RpbmcgbWV0aG9kIHdvdWxkIGNvbnNpZGVyICdvcj0wMCcgb3Ig J29yPTAnIGFzIHNpZ25pZmljYW50CmluIExTX0NPTE9SUy4gRXZlbiAnb3I9JyB3YXMgc2ln bmlmaWNhbnQgYXMgaW4gdGhhdCBjYXNlIHRoZQpzdHJpbmc9J29yPScgYW5kIHRoZSBsZW5n dGg9MC4gIEFsc28gYXBwbHkgdGhlIHNhbWUgY2hhbmdlCmZvciBtaXNzaW5nIHN5bWxpbmtz IGZvciBjb25zaXN0ZW5jeS4KKGdvYmJsZV9maWxlKTogUmVtb3ZlIHRoZSBzaW11bGF0aW9u IG9mIGxpbmtvaywgd2hpY2ggaXMgb25seQp0ZXN0ZWQgaW4gcHJpbnRfY29sb3JfaW5kaWNh dG9yKCkgd2hpY2ggbm93IGhhbmRsZXMgdGhpcyBkaXJlY3RseQpieSBrZXlpbmcgb24gdGhl IExTX0NPTE9SUyB2YWx1ZXMgY29ycmVjdGx5LgoqIHRlc3RzL21pc2MvbHMtbWlzYy5wbDog QWRkIGEgdGVzdCBjYXNlLgoqIFRIQU5LUzogQWRkIHRoZSByZXBvcnRlci4KKiBORVdTOiBN ZW50aW9uIHRoZSBmaXguClJlcG9ydGVkLWJ5OiBEYXZpZCBNYXRlaQotLS0KIE5FV1MgICAg ICAgICAgICAgICAgICB8ICAgIDQgKysrKwogVEhBTktTLmluICAgICAgICAgICAgIHwgICAg MSArCiBzcmMvbHMuYyAgICAgICAgICAgICAgfCAgIDExICsrLS0tLS0tLS0tCiB0ZXN0cy9t aXNjL2xzLW1pc2MucGwgfCAgIDE1ICsrKysrKysrKysrKysrKwogNCBmaWxlcyBjaGFuZ2Vk LCAyMiBpbnNlcnRpb25zKCspLCA5IGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL05FV1Mg Yi9ORVdTCmluZGV4IDJlNjkzOTEuLmFiMjA1ZjUgMTAwNjQ0Ci0tLSBhL05FV1MKKysrIGIv TkVXUwpAQCAtMjEsNiArMjEsMTAgQEAgR05VIGNvcmV1dGlscyBORVdTICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgLSotIG91dGxpbmUgLSotCiAgIG51bWJlcnMsIGFu ZCB1cCB0byA4IHRpbWVzIHNsb3dlciBmb3Igc29tZSB3b3JzdC1jYXNlIGluZGl2aWR1YWwg bnVtYmVycy4KICAgW2J1ZyBpbnRyb2R1Y2VkIGluIGNvcmV1dGlscy03LjAsIHdpdGggR05V IE1QIHN1cHBvcnRdCiAKKyAgbHMgbm93IGNvcnJlY3RseSBjb2xvcnMgZGFuZ2xpbmcgc3lt bGlua3Mgd2hlbiBsaXN0aW5nIHRoZWlyIGNvbnRhaW5pbmcKKyAgZGlyZWN0b3JpZXMsIHdp dGggb3JwaGFuZWQgc3ltbGluayBjb2xvcmluZyBkaXNhYmxlZCBpbiBMU19DT0xPUlMuCisg IFtidWcgaW50cm9kdWNlZCBpbiBjb3JldXRpbHMtOC4xNF0KKwogICBybSAtaSAtZCBub3cg cHJvbXB0cyB0aGUgdXNlciB0aGVuIHJlbW92ZXMgYW4gZW1wdHkgZGlyZWN0b3J5LCByYXRo ZXIKICAgdGhhbiBpZ25vcmluZyB0aGUgLWQgb3B0aW9uIGFuZCBmYWlsaW5nIHdpdGggYW4g J0lzIGEgZGlyZWN0b3J5JyBlcnJvci4KICAgW2J1ZyBpbnRyb2R1Y2VkIGluIGNvcmV1dGls cy04LjE5LCB3aXRoIHRoZSBhZGRpdGlvbiBvZiAtLWRpciAoLWQpXQpkaWZmIC0tZ2l0IGEv VEhBTktTLmluIGIvVEhBTktTLmluCmluZGV4IDJjM2Y4M2MuLmIwMDYxYjMgMTAwNjQ0Ci0t LSBhL1RIQU5LUy5pbgorKysgYi9USEFOS1MuaW4KQEAgLTE1Myw2ICsxNTMsNyBAQCBEYXZp ZCBHb2RmcmV5ICAgICAgICAgICAgICAgICAgICAgICBkYXZlQGRlbHRhLmRlbW9uLmNvLnVr CiBEYXZpZCBMdXllciAgICAgICAgICAgICAgICAgICAgICAgICBkYXZpZF9sdXllckBwYWNp ZmljLm5ldC5hdQogRGF2aWQgTWFkb3JlICAgICAgICAgICAgICAgICAgICAgICAgZGF2aWQu bWFkb3JlQGVucy5mcgogRGF2aWQgTWFsb25lICAgICAgICAgICAgICAgICAgICAgICAgZHdt YWxvbmVAY25yaS5kaXQuaWUKK0RhdmlkIE1hdGVpICAgICAgICAgICAgICAgICAgICAgICAg IG1hdGVpQGNzLnRvcm9udG8uZWR1CiBEYXZpZGUgQ2Fub3ZhICAgICAgICAgICAgICAgICAg ICAgICBrYy5jYW5vdmFAZ21haWwuY29tCiBEYXdzb24gRW5nbGVyICAgICAgICAgICAgICAg ICAgICAgICBlbmdsZXJAc3RhbmZvcmQuZWR1CiBEZWFuIEdhdWRldCAgICAgICAgICAgICAg ICAgICAgICAgICBkZWFuLXNhdmFubmFoQGFyY3RpYy5vcmcKZGlmZiAtLWdpdCBhL3NyYy9s cy5jIGIvc3JjL2xzLmMKaW5kZXggOTQ5NGFlOS4uMTA2ZDIzNCAxMDA2NDQKLS0tIGEvc3Jj L2xzLmMKKysrIGIvc3JjL2xzLmMKQEAgLTMwNjQsMTIgKzMwNjQsNiBAQCBnb2JibGVfZmls ZSAoY2hhciBjb25zdCAqbmFtZSwgZW51bSBmaWxldHlwZSB0eXBlLCBpbm9fdCBpbm9kZSwK ICAgICAgICAgICBmcmVlIChsaW5rbmFtZSk7CiAgICAgICAgIH0KIAotICAgICAgLyogV2hl biBub3QgZGlzdGluZ3Vpc2hpbmcgdHlwZXMgb2Ygc3ltbGlua3MsIHByZXRlbmQgd2Uga25v dyB0aGF0Ci0gICAgICAgICBpdCBpcyBzdGF0J2FibGUsIHNvIHRoYXQgaXQgd2lsbCBiZSBj b2xvcmVkIGFzIGEgcmVndWxhciBzeW1saW5rLAotICAgICAgICAgYW5kIG5vdCBhcyBhbiBv cnBoYW4uICAqLwotICAgICAgaWYgKFNfSVNMTksgKGYtPnN0YXQuc3RfbW9kZSkgJiYgIWNo ZWNrX3N5bWxpbmtfY29sb3IpCi0gICAgICAgIGYtPmxpbmtvayA9IHRydWU7Ci0KICAgICAg IGlmIChTX0lTTE5LIChmLT5zdGF0LnN0X21vZGUpKQogICAgICAgICBmLT5maWxldHlwZSA9 IHN5bWJvbGljX2xpbms7CiAgICAgICBlbHNlIGlmIChTX0lTRElSIChmLT5zdGF0LnN0X21v ZGUpKQpAQCAtNDI5Myw3ICs0Mjg3LDcgQEAgcHJpbnRfY29sb3JfaW5kaWNhdG9yIChjb25z dCBzdHJ1Y3QgZmlsZWluZm8gKmYsIGJvb2wgc3ltbGlua190YXJnZXQpCiAKICAgLyogSXMg dGhpcyBhIG5vbmV4aXN0ZW50IGZpbGU/ICBJZiBzbywgbGlua29rID09IC0xLiAgKi8KIAot ICBpZiAobGlua29rID09IC0xICYmIGNvbG9yX2luZGljYXRvcltDX01JU1NJTkddLnN0cmlu ZyAhPSBOVUxMKQorICBpZiAobGlua29rID09IC0xICYmIGlzX2NvbG9yZWQgKENfTUlTU0lO RykpCiAgICAgdHlwZSA9IENfTUlTU0lORzsKICAgZWxzZSBpZiAoIWYtPnN0YXRfb2spCiAg ICAgewpAQCAtNDM2OCw4ICs0MzYyLDcgQEAgcHJpbnRfY29sb3JfaW5kaWNhdG9yIChjb25z dCBzdHJ1Y3QgZmlsZWluZm8gKmYsIGJvb2wgc3ltbGlua190YXJnZXQpCiAgIC8qIEFkanVz dCB0aGUgY29sb3IgZm9yIG9ycGhhbmVkIHN5bWxpbmtzLiAgKi8KICAgaWYgKHR5cGUgPT0g Q19MSU5LICYmICFsaW5rb2spCiAgICAgewotICAgICAgaWYgKGNvbG9yX3N5bWxpbmtfYXNf cmVmZXJlbnQKLSAgICAgICAgICB8fCBjb2xvcl9pbmRpY2F0b3JbQ19PUlBIQU5dLnN0cmlu ZykKKyAgICAgIGlmIChjb2xvcl9zeW1saW5rX2FzX3JlZmVyZW50IHx8IGlzX2NvbG9yZWQg KENfT1JQSEFOKSkKICAgICAgICAgdHlwZSA9IENfT1JQSEFOOwogICAgIH0KIApkaWZmIC0t Z2l0IGEvdGVzdHMvbWlzYy9scy1taXNjLnBsIGIvdGVzdHMvbWlzYy9scy1taXNjLnBsCmlu ZGV4IDcxNjQ3ZjkuLjA0ZDgwMTYgMTAwNzU1Ci0tLSBhL3Rlc3RzL21pc2MvbHMtbWlzYy5w bAorKysgYi90ZXN0cy9taXNjL2xzLW1pc2MucGwKQEAgLTI2Myw2ICsyNjMsMjEgQEAgbXkg QFRlc3RzID0KICAgICAgIHtQT1NUID0+IHN1YiB7dW5saW5rICdzJyBvciBkaWUgInM6ICQh XG4iOwogICAgICAgICAgICAgICAgICAgICByZXN0b3JlX2xzX2NvbG9yczsgfX0sCiAgICAg IF0sCisgICAgICMgVGhlIGNvZGUgcmVsYXRlZCB0byB0aGUgYWJvdmUgZml4ZXMgaW50cm9k dWNlZCBhIHJlZ3Jlc3Npb24sCisgICAgICMgdGhhdCB3YXMgZml4ZWQgYWZ0ZXIgY29yZXV0 aWxzLTguMTkuICBUaGlzIGlzIHRoZSBjYXNlIHdoZW4KKyAgICAgIyBsaXN0aW5nIGEgZGly IGNvbnRhaW5pbmcgZGFuZ2xpbmcgc3ltbGlua3MsIGJ1dCB3aXRoIG9ycGhhbnMgdW5jb2xv cmVkLgorICAgICAjIEkuRS4gdGhlIHNhbWUgYXMgdGhlIHByZXZpb3VzIHRlc3QsIGJ1dCBs aXN0aW5nIHRoZSBkaXJlY3RvcnkKKyAgICAgIyByYXRoZXIgdGhhbiB0aGUgc3ltbGluayBk aXJlY3RseS4KKyAgICAgWydzbC1kYW5nbGU5JywgJy0tY29sb3I9YWx3YXlzIGQnLAorICAg ICAge09VVCA9PiAiJGVcZVsxOzM2bXMkZVxuIn0sCisgICAgICB7UFJFID0+IHN1YiB7bWtk aXIgJ2QnLDA3NTUgb3IgZGllICJkOiAkIVxuIjsKKyAgICAgICAgICAgICAgICAgICBzeW1s aW5rICdkYW5nbGUnLCAnZC9zJyBvciBkaWUgImQvczogJCFcbiI7CisgICAgICAgICAgICAg ICAgICAgcHVzaF9sc19jb2xvcnMoJ2xuPTE7MzY6b3I9OicpCisgICAgICAgfX0sCisgICAg ICB7UE9TVCA9PiBzdWIge3VubGluayAnZC9zJyBvciBkaWUgImQvczogJCFcbiI7CisgICAg ICAgICAgICAgICAgICAgIHJtZGlyICdkJyBvciBkaWUgImQ6ICQhXG4iOworICAgICAgICAg ICAgICAgICAgICByZXN0b3JlX2xzX2NvbG9yczsgfX0sCisgICAgIF0sCiAKICAgICAgIyBU ZXN0IGZvciBhIGJ1ZyB0aGF0IHdhcyBpbnRyb2R1Y2VkIGluIGNvcmV1dGlscy00LjUuNDsg Zml4ZWQgaW4gNC41LjUuCiAgICAgICMgVG8gZGVtb25zdHJhdGUgaXQsIHRoZSBmaWxlIGlu IHF1ZXN0aW9uICh3aXRoIGV4ZWN1dGFibGUgYml0IHNldCkKLS0gCjEuNy42LjQKCg== --------------090607030108090808020306-- From debbugs-submit-bounces@debbugs.gnu.org Sun Sep 16 04:46:20 2012 Received: (at 12445) by debbugs.gnu.org; 16 Sep 2012 08:46:20 +0000 Received: from localhost ([127.0.0.1]:36399 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TDAUe-0006CM-8e for submit@debbugs.gnu.org; Sun, 16 Sep 2012 04:46:20 -0400 Received: from mx.meyering.net ([88.168.87.75]:52105) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TDAUa-0006C6-RE for 12445@debbugs.gnu.org; Sun, 16 Sep 2012 04:46:18 -0400 Received: from rho.meyering.net (rho.meyering.net [127.0.0.1]) by rho.meyering.net (Acme Bit-Twister) with ESMTP id A75DA60073; Sun, 16 Sep 2012 10:45:06 +0200 (CEST) From: Jim Meyering To: =?iso-8859-1?Q?P=E1draig?= Brady Subject: Re: bug#12445: ls --color does not color symlinks when not resolving them In-Reply-To: <50554BA6.3080206@draigBrady.com> (=?iso-8859-1?Q?=22P=E1drai?= =?iso-8859-1?Q?g?= Brady"'s message of "Sun, 16 Sep 2012 04:46:46 +0100") References: <20120914125451.563aa815@ara-think-vm> <5053C3E0.3090804@draigBrady.com> <20120914222806.728dccc3@ara-think-vm> <50545B27.2050206@draigBrady.com> <50554BA6.3080206@draigBrady.com> Date: Sun, 16 Sep 2012 10:45:06 +0200 Message-ID: <87fw6itkz1.fsf@rho.meyering.net> Lines: 79 MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.4 (--) X-Debbugs-Envelope-To: 12445 Cc: 12445@debbugs.gnu.org, Matei David X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.4 (--) P=E1draig Brady wrote: ... >> ls 8.10 doesn't have the issue, and when I tested the latest version >> I only did so with -l which also doesn't show the issue. >> >> So this regression was added since 8.10 and only when -l is not used. >> >> I'll add tests etc. and apply a fix in your name. > > So the regression was introduced in coreutils 8.14 in: > http://git.sv.gnu.org/gitweb/?p=3Dcoreutils.git;a=3Dcommit;h=3D84457c49 http://git.sv.gnu.org/cgit/coreutils.git/commit/?id=3Dc5ccf29bb > > I dug a little deeper and was confused as to the need > for the simulated "linkok" at all. That was originally introduced with: > http://thread.gmane.org/gmane.comp.gnu.coreutils.bugs/10608/focus=3D10927 > > I also noticed that is_colored() was not used with C_ORPHAN, > thus meaning any of or=3D00, or=3D0, or=3D in LS_COLORS was considered si= gnificant. > One could argue that for any attribute, 00 should mean color as 00, > rather than don't color, but for consistency with all other color checks > I changed that to use is_colored(). As that was the only part of the > code inspecting > the "linkok" variable, I removed the simulated linkok referenced > in the above link. > > All tests pass with the new code. > > cheers, > P=E1draig. > > From ebf697b623435d46dd48998408e1c7cf3eba1623 Mon Sep 17 00:00:00 2001 > From: =3D?UTF-8?q?P=3DC3=3DA1draig=3D20Brady?=3D > Date: Sun, 16 Sep 2012 04:10:50 +0100 > Subject: [PATCH] ls: fix coloring of dangling symlinks in default listing > mode > > When listing a directory containing dangling symlinks, > and not outputting a long format listing, and orphaned links > are set to no coloring in LS_COLORS, then the symlinks > would get no color rather than reverting to the standard > symlink color. The issue was introduced in v8.13-19-g84457c4 > > * src/ls.c (print_color_indicator): Use the standard method > to check if coloring is specified for orphaned symlinks. > The existing method would consider 'or=3D00' or 'or=3D0' as significant > in LS_COLORS. Even 'or=3D' was significant as in that case the > string=3D'or=3D' and the length=3D0. Also apply the same change > for missing symlinks for consistency. > (gobble_file): Remove the simulation of linkok, which is only > tested in print_color_indicator() which now handles this directly > by keying on the LS_COLORS values correctly. > * tests/misc/ls-misc.pl: Add a test case. > * THANKS: Add the reporter. > * NEWS: Mention the fix. > Reported-by: David Matei > --- > NEWS | 4 ++++ > THANKS.in | 1 + > src/ls.c | 11 ++--------- > tests/misc/ls-misc.pl | 15 +++++++++++++++ > 4 files changed, 22 insertions(+), 9 deletions(-) > > diff --git a/NEWS b/NEWS > index 2e69391..ab205f5 100644 > --- a/NEWS > +++ b/NEWS > @@ -21,6 +21,10 @@ GNU coreutils NEWS = -*- outline -*- > numbers, and up to 8 times slower for some worst-case individual numbe= rs. > [bug introduced in coreutils-7.0, with GNU MP support] > > + ls now correctly colors dangling symlinks when listing their containing > + directories, with orphaned symlink coloring disabled in LS_COLORS. > + [bug introduced in coreutils-8.14] Thanks for digging into that. I confirm it solves the problem, and the test would fail without the ls.c patch. Your commit looks perfect. From debbugs-submit-bounces@debbugs.gnu.org Sun Sep 16 04:54:15 2012 Received: (at 12445) by debbugs.gnu.org; 16 Sep 2012 08:54:15 +0000 Received: from localhost ([127.0.0.1]:36420 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TDAcH-0006NP-4m for submit@debbugs.gnu.org; Sun, 16 Sep 2012 04:54:15 -0400 Received: from moutng.kundenserver.de ([212.227.126.171]:63219) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TDAcD-0006NG-MA for 12445@debbugs.gnu.org; Sun, 16 Sep 2012 04:54:11 -0400 Received: from [192.168.2.108] (p4FF75306.dip.t-dialin.net [79.247.83.6]) by mrelayeu.kundenserver.de (node=mrbap1) with ESMTP (Nemesis) id 0Lpggw-1ThGYc1EIA-00eoxW; Sun, 16 Sep 2012 10:53:00 +0200 Message-ID: <5055936B.4040005@bernhard-voelker.de> Date: Sun, 16 Sep 2012 10:52:59 +0200 From: Bernhard Voelker User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:15.0) Gecko/20120825 Thunderbird/15.0 MIME-Version: 1.0 To: =?UTF-8?B?UMOhZHJhaWcgQnJhZHk=?= Subject: Re: bug#12445: ls --color does not color symlinks when not resolving them References: <20120914125451.563aa815@ara-think-vm> <5053C3E0.3090804@draigBrady.com> <20120914222806.728dccc3@ara-think-vm> <50545B27.2050206@draigBrady.com> <50554BA6.3080206@draigBrady.com> In-Reply-To: <50554BA6.3080206@draigBrady.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Provags-ID: V02:K0:Drlt3Uo6K/JEllCH+nsec72QTtBg5Uli/nrFAiaodGN Dg+uWpMwEhWnzeyHtfzyozyE0PQuRiv5ZgW/1DdS+8RtSz3EO8 tfGKqtgQE2CKkcmZ1sh6t68h9xxcE2BiYeDgWURe0YZr6HFl5l mz1E/p5HB/GwNWDvoM/ahiVqrqyZPLkvq7E6xsZL58UdjvVzOJ wMSTW2lKbXhTIKXLzKzK0eEVPmssQOB1bOP4m+XxXDsegifaQW H2edchAvHESwmwXDEnN8akAbORAFnQ2xENaekoX7ALZP+MYKwm Q+ZZwhkzdH4BIZcCr6kLlFLRnadicso6aotSsNdJJs+g9X3qtP WC/wwojirF7B0rkCmwgEnr0ZcoUcAt2ENXM5f/Iee X-Spam-Score: -1.9 (-) X-Debbugs-Envelope-To: 12445 Cc: 12445@debbugs.gnu.org, Matei David X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -1.9 (-) On 09/16/2012 05:46 AM, Pádraig Brady wrote: > +++ b/tests/misc/ls-misc.pl > @@ -263,6 +263,21 @@ my @Tests = > {POST => sub {unlink 's' or die "s: $!\n"; > restore_ls_colors; }}, > ], > + # The code related to the above fixes introduced a regression, > + # that was fixed after coreutils-8.19. What did you want to say by this? Have a nice day, Berny From debbugs-submit-bounces@debbugs.gnu.org Sun Sep 16 05:04:17 2012 Received: (at 12445) by debbugs.gnu.org; 16 Sep 2012 09:04:18 +0000 Received: from localhost ([127.0.0.1]:36428 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TDAm1-0006bv-E0 for submit@debbugs.gnu.org; Sun, 16 Sep 2012 05:04:17 -0400 Received: from mx.meyering.net ([88.168.87.75]:52143) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TDAly-0006bm-7m for 12445@debbugs.gnu.org; Sun, 16 Sep 2012 05:04:15 -0400 Received: from rho.meyering.net (rho.meyering.net [127.0.0.1]) by rho.meyering.net (Acme Bit-Twister) with ESMTP id EB51964215; Sun, 16 Sep 2012 11:03:05 +0200 (CEST) From: Jim Meyering To: Bernhard Voelker Subject: Re: bug#12445: ls --color does not color symlinks when not resolving them In-Reply-To: <5055936B.4040005@bernhard-voelker.de> (Bernhard Voelker's message of "Sun, 16 Sep 2012 10:52:59 +0200") References: <20120914125451.563aa815@ara-think-vm> <5053C3E0.3090804@draigBrady.com> <20120914222806.728dccc3@ara-think-vm> <50545B27.2050206@draigBrady.com> <50554BA6.3080206@draigBrady.com> <5055936B.4040005@bernhard-voelker.de> Date: Sun, 16 Sep 2012 11:03:05 +0200 Message-ID: <87a9wqtk52.fsf@rho.meyering.net> Lines: 18 MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.4 (--) X-Debbugs-Envelope-To: 12445 Cc: 12445@debbugs.gnu.org, =?iso-8859-1?Q?P=E1draig?= Brady , Matei David X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.4 (--) Bernhard Voelker wrote: > On 09/16/2012 05:46 AM, P=E1draig Brady wrote: > >> +++ b/tests/misc/ls-misc.pl >> @@ -263,6 +263,21 @@ my @Tests =3D >> {POST =3D> sub {unlink 's' or die "s: $!\n"; >> restore_ls_colors; }}, >> ], >> + # The code related to the above fixes introduced a regression, >> + # that was fixed after coreutils-8.19. > > What did you want to say by this? I understood it as: The patch associated with the above test case introduced a regression, which was fixed after coreutils-8.19. From debbugs-submit-bounces@debbugs.gnu.org Sun Sep 16 05:15:55 2012 Received: (at 12445) by debbugs.gnu.org; 16 Sep 2012 09:15:55 +0000 Received: from localhost ([127.0.0.1]:36433 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TDAxG-0006rk-O9 for submit@debbugs.gnu.org; Sun, 16 Sep 2012 05:15:55 -0400 Received: from moutng.kundenserver.de ([212.227.126.187]:62307) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TDAxE-0006rc-Bo for 12445@debbugs.gnu.org; Sun, 16 Sep 2012 05:15:53 -0400 Received: from [192.168.2.108] (p4FF75306.dip.t-dialin.net [79.247.83.6]) by mrelayeu.kundenserver.de (node=mrbap4) with ESMTP (Nemesis) id 0Lql1O-1TiN1d1hGE-00eIiA; Sun, 16 Sep 2012 11:14:43 +0200 Message-ID: <50559882.4090400@bernhard-voelker.de> Date: Sun, 16 Sep 2012 11:14:42 +0200 From: Bernhard Voelker User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:15.0) Gecko/20120825 Thunderbird/15.0 MIME-Version: 1.0 To: Jim Meyering Subject: Re: bug#12445: ls --color does not color symlinks when not resolving them References: <20120914125451.563aa815@ara-think-vm> <5053C3E0.3090804@draigBrady.com> <20120914222806.728dccc3@ara-think-vm> <50545B27.2050206@draigBrady.com> <50554BA6.3080206@draigBrady.com> <5055936B.4040005@bernhard-voelker.de> <87a9wqtk52.fsf@rho.meyering.net> In-Reply-To: <87a9wqtk52.fsf@rho.meyering.net> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 8bit X-Provags-ID: V02:K0:cYjgelqDJC6IFphtd3mXfITTC8QTShYmzkC6CUUpzMd wAKfzay1SKX4H2gu7C6V5W7MNZukf7cFhx9xlutmM/yyUgRZS8 J6WFfyexPMVX+MfycailVw+p5OiJ1NebrbbZhIgIrdNQp4g3Af 4LEdtbROt8R8d7f/3qquje/fjfFENyCKFqPADstxvMEpmvZtsQ NLMxXpbRYHUSzGKmcIdImSM7xaFfV0xSorrvZ+cHk0PrayDhzZ AJoJhMDMBSiGSXx6VJErxCBPlv031mrYgyVO41qfNGQnoM9Nks NLPE2Tp+d38J6RHj9wN6FXQAraYVXbJkl58LqJGr8VFEozSukB WQAlOc3YT4Kl/DTI7y6SC9VI4gplnLDlyr9y4ZmKX X-Spam-Score: -1.9 (-) X-Debbugs-Envelope-To: 12445 Cc: 12445@debbugs.gnu.org, =?ISO-8859-1?Q?P=E1draig_Brady?= , Matei David X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -1.9 (-) On 09/16/2012 11:03 AM, Jim Meyering wrote: > Bernhard Voelker wrote: > >> On 09/16/2012 05:46 AM, Pádraig Brady wrote: >> >>> + # The code related to the above fixes introduced a regression, >>> + # that was fixed after coreutils-8.19. >> >> What did you want to say by this? > > I understood it as: > > The patch associated with the above test case introduced a > regression, which was fixed after coreutils-8.19. so maybe s/fixes introduced/introduced/ ? Have a nice day, Berny From debbugs-submit-bounces@debbugs.gnu.org Mon Oct 15 13:41:43 2018 Received: (at control) by debbugs.gnu.org; 15 Oct 2018 17:41:43 +0000 Received: from localhost ([127.0.0.1]:51215 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gC6sB-00019K-Kd for submit@debbugs.gnu.org; Mon, 15 Oct 2018 13:41:43 -0400 Received: from mail-it1-f170.google.com ([209.85.166.170]:53324) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gC6sA-000196-Fb for control@debbugs.gnu.org; Mon, 15 Oct 2018 13:41:42 -0400 Received: by mail-it1-f170.google.com with SMTP id q70-v6so29800683itb.3 for ; Mon, 15 Oct 2018 10:41:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=to:from:message-id:date:user-agent:mime-version:content-language :content-transfer-encoding; bh=UlzNPn3RHc7fMxO23GNmIJamiLkrAy6DiWDeY8dVGN8=; b=jLvG9ACjvkuBPwUYfcBBIs9l1CC4Hbh4uOfuhcxMSB2+yTKNV4jr1mehpMuauyFO9L eVV6iTHOvgAdKPQJxJ6Y9JVc5Z+7+J5tQEoAgSko6gm2HAhJ38gnTFkv+fj1C6T3SZnM crBwBfSbwQu0TSN6jt/OeQRer7jAZofjAYFYyj17uBHAb9/96phKWtx48SkMASIhIX1Z jYw0AAp3CdLEozOAsx2Ip1KOQUkOn3Y+bFWsIQ3mqJkXf4jEp8PMQ9PvkPWmwKyAMgwV WXyI04YfFnpYJbKZD7dVzcP0xnzAzZkz6ySOJwwap7qI4nfwQr4WYW2Q+o1X3p2dyXzr uPaQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:to:from:message-id:date:user-agent:mime-version :content-language:content-transfer-encoding; bh=UlzNPn3RHc7fMxO23GNmIJamiLkrAy6DiWDeY8dVGN8=; b=MO5fh454RUqoY9xdq8RYdbPMzzS+gpgelraduEU0VrfUdlytO6L2YjJ/yJdWEJjpbf 8jodso0YT5X6N5cbfBm9We+wPLkrZI2IwJGrcZ4LSsnqTMYJc4vVjTaFOwNodPuEquu/ D8Cl59ecv2KJSwvtEln1Sx1cZiERPP6cRfUA5XB7MI33Qs5jThjM2WqWwFC5Q2g4DSXx Gv6p86JbkCQDMmD7doG4iwgztUeTludUedW9UtKIy4HJ8cJQT8DoOYc5sICxdZKvElJy bbSUYFKXTiot2sUDdZ0N5M/M1qvP3zJ0bjSEiF5vGmJKpOza16m6Rrh45YWUNlQJY0Xk QdXA== X-Gm-Message-State: ABuFfoiLSdI/l9ZKNKvAHXydw6lsrob8DscM9jjryQdJ+HReUMPPhAOt PA9xVKGa4rVkfwv+uCCOAO94s1dwLiE= X-Google-Smtp-Source: ACcGV631NnpeHYzyQIP/sv4l8fP98AjIUrI5A6njmHp+HVcaTqRDoGAbVNZ/hlqWf9vdK1+501mgwg== X-Received: by 2002:a24:c9c6:: with SMTP id h189-v6mr13412840itg.161.1539625296470; Mon, 15 Oct 2018 10:41:36 -0700 (PDT) Received: from tomato.housegordon.com (moose.housegordon.com. [184.68.105.38]) by smtp.googlemail.com with ESMTPSA id 125-v6sm1956634itl.7.2018.10.15.10.41.34 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 15 Oct 2018 10:41:35 -0700 (PDT) To: control@debbugs.gnu.org From: Assaf Gordon Message-ID: <7f970f5d-e476-21c1-3eca-2a0566b8ba9c@gmail.com> Date: Mon, 15 Oct 2018 11:41:33 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Score: 2.0 (++) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: tags 12445 fixed close 12445 [...] Content analysis details: (2.0 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (assafgordon[at]gmail.com) -0.0 SPF_PASS SPF: sender matches SPF record -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at http://www.dnswl.org/, no trust [209.85.166.170 listed in list.dnswl.org] -0.0 RCVD_IN_MSPIKE_H2 RBL: Average reputation (+2) [209.85.166.170 listed in wl.mailspike.net] 1.8 MISSING_SUBJECT Missing Subject: header 0.2 NO_SUBJECT Extra score for no subject X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.0 (+) tags 12445 fixed close 12445 From unknown Mon Jun 23 13:12:31 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Tue, 13 Nov 2018 12:24:08 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator