From debbugs-submit-bounces@debbugs.gnu.org Thu Sep 06 11:11:43 2012 Received: (at submit) by debbugs.gnu.org; 6 Sep 2012 15:11:43 +0000 Received: from localhost ([127.0.0.1]:44278 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1T9dk7-0007Ex-4h for submit@debbugs.gnu.org; Thu, 06 Sep 2012 11:11:43 -0400 Received: from eggs.gnu.org ([208.118.235.92]:57984) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1T9dk5-0007Er-M8 for submit@debbugs.gnu.org; Thu, 06 Sep 2012 11:11:42 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1T9djn-0002W8-1p for submit@debbugs.gnu.org; Thu, 06 Sep 2012 11:11:28 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-5.4 required=5.0 tests=BAYES_00,BODY_8BITS, FREEMAIL_FROM,RCVD_IN_DNSWL_HI,T_DKIM_INVALID autolearn=unavailable version=3.3.2 Received: from lists.gnu.org ([208.118.235.17]:56651) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T9djm-0002W1-V5 for submit@debbugs.gnu.org; Thu, 06 Sep 2012 11:11:22 -0400 Received: from eggs.gnu.org ([208.118.235.92]:49753) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T9djd-00017g-F2 for bug-automake@gnu.org; Thu, 06 Sep 2012 11:11:22 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1T9djc-0002SN-43 for bug-automake@gnu.org; Thu, 06 Sep 2012 11:11:13 -0400 Received: from mail-qc0-f169.google.com ([209.85.216.169]:55059) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T9djc-0002SH-08 for bug-automake@gnu.org; Thu, 06 Sep 2012 11:11:12 -0400 Received: by qcsd16 with SMTP id d16so978593qcs.0 for ; Thu, 06 Sep 2012 08:11:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:date:message-id:subject:from:to:content-type :content-transfer-encoding; bh=ntN63CgbaE/kKkclwhVSTXLlLxH3Zq4XpK2+MuwOoK0=; b=qtz65pK+3IZ5SowEAzeN5DLmu9U3Pc7EDewuwjmAz7VAs6BmCxTSzsIJF19lh9lMzc UcTDozv4FqqrWcSWHNFNK51LNfVGp8lZ3QvU8K0eAsISt/W5QZ92ODDk8eNJn+T3XynS Lizj7mU7+pAqQbxfEIZnrKYkm0/qjpDemplpJB69A30lB89rxiBf6bXzuL4nitmd+rXq U/yloUZGHSeZy9JsBH/KLHECSLWlYqyfb3CYUvZA7SlRPWPsQU8/9ZTLAflEOYqj9sbw rHvGkyuuHcuudrvFCXMXYYjg7ZXKCnDvNOEK3S2tnTRJ065r8CYk0p7tZqRgACtzTKrM XUIQ== MIME-Version: 1.0 Received: by 10.224.71.74 with SMTP id g10mr4494574qaj.34.1346944270767; Thu, 06 Sep 2012 08:11:10 -0700 (PDT) Received: by 10.49.51.227 with HTTP; Thu, 6 Sep 2012 08:11:10 -0700 (PDT) Date: Thu, 6 Sep 2012 19:11:10 +0400 Message-ID: Subject: arbitrary suffix sources are not added to the tags From: =?UTF-8?B?0K7RgNC40Lkg0J/Rg9GF0LDQu9GM0YHQutC40Lk=?= To: bug-automake@gnu.org Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-Received-From: 208.118.235.17 X-Spam-Score: -6.1 (------) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -6.1 (------) So the .am file is like this: .POSIX: SUFFIXES =3D .pc .pc.lo: cp $*.pc $*.c $(LIBTOOL) --tag=3DCC $(AM_LIBTOOLFLAGS) $(LIBTOOLFLAGS) --mode=3Dcompile $(CC) $(DEFS) $(DEFAULT_INCLUDES) $(INCLUDES) $(AM_CPPFLAGS) $(CPPFLAGS) $(AM_CFLAGS) $(CFLAGS) -c -o $@ $*.c rm -f $*.c CCLD =3D $(CC) LINK =3D $(LIBTOOL) --tag=3DCC $(AM_LIBTOOLFLAGS) $(LIBTOOLFLAGS) \ --mode=3Dlink $(CCLD) $(AM_CFLAGS) $(CFLAGS) $(AM_LDFLAGS) \ $(LDFLAGS) -o $@ noinst_LTLIBRARIES=3Dlibfoo.la libfoo_la_SOURCES=3Dfoo.pc bar.c The libfoo_la_SOURCES are not added to the tags list and the tags goals are not generated: excerpt from the Makefile.in --------- tags: TAGS TAGS: ctags: CTAGS CTAGS: --------- Adding them to the TAGS_FILES explicitly (as Stefano had advised) doesn't help. It seems that it's being overridden. ---------- Forwarded message ---------- From: =D0=AE=D1=80=D0=B8=D0=B9 =D0=9F=D1=83=D1=85=D0=B0=D0=BB=D1=8C=D1=81= =D0=BA=D0=B8=D0=B9 Date: Mon, Jul 23, 2012 at 4:49 PM Subject: bug#7824: Automatic chaining of make suffix rules (was: Re: bug#7824: won't fix) To: Stefano Lattarini Cc: 7824@debbugs.gnu.org, Automake List On Mon, Jul 23, 2012 at 4:42 PM, Stefano Lattarini wrote: > [Re-adding the list, as this discussion is worth being registered in > the archives IMHO] > Ok. >>>> The situation is that both of the approaches (.pc.c rule and .pc.lo >>>> rule) have problems entailed. >>> >>>> * .pc.lo rule doesn't create tags for *.pc sources. >>>> >>> Try to add the relevant '.pc' files to $(TAGS_FILES) explicitly. It sh= ould >>> solve your issue. If it doesn't, you've found a new Automake bug, whic= h I >>> will gladly fix :-) >> >> Ah, ok! I knew there must be something like that. >> But why in the first place it doesn't do it automatically? I have it >> in the _SOURCES=E2=80=A6 Is it afraid of the .pc extension? >> > I'm not sure actually. Might be a tiny bug in automake. Care to open a > new report about the issue, so I won't forget? I'll get to it eventually= , > but not right now. --=20 =C2=ABEvery person has a certain horizon. When it narrows and becomes infinitely small, it changes into a point and then the person says: =E2=80=9CThis is my point of view.=E2=80=9D=C2=BB From debbugs-submit-bounces@debbugs.gnu.org Fri Sep 07 05:16:35 2012 Received: (at 12372) by debbugs.gnu.org; 7 Sep 2012 09:16:35 +0000 Received: from localhost ([127.0.0.1]:45432 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1T9ufy-00029L-KS for submit@debbugs.gnu.org; Fri, 07 Sep 2012 05:16:35 -0400 Received: from mail-bk0-f44.google.com ([209.85.214.44]:61906) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1T9ufv-000296-Nt; Fri, 07 Sep 2012 05:16:34 -0400 Received: by bkty12 with SMTP id y12so1181634bkt.3 for ; Fri, 07 Sep 2012 02:16:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=message-id:date:from:mime-version:to:cc:subject:references :in-reply-to:content-type:content-transfer-encoding; bh=xIJ6jefJEtDzPdJZdV+GQ3bUm4Xo0uWRlevf1cQlBj4=; b=CkXFMU+nCdpjsXR0ud0hH187ne2n7VbvjkBMmCy7wvzw1od5vlgwPkdNvx/VQYYKO5 3AV6OKdwooxG22x41mynF2M2MGre8FL7MrooQvhSmOW99DWhAztLT+SW+qv2DtNPkUko A1eSDwJZ3ZddSVpXMH4+9UdA80+v0YWJLpZIjWAE5pXXAAv0Fupzx+g10cnFSkJTOAl/ qkJ+75JTDVKoFFpBHp7l425gpKSD2pogl/ACUj8Usd+zB3CEUL23K0eADe3FBjuIoqjD F2SyTORWWVxLQt8z+sA0bYGZyp1PFEx8OjkaWS18W/U1GVOczqyAG7osbRnlZH4N+hx7 j4XQ== Received: by 10.204.130.10 with SMTP id q10mr2216877bks.90.1347009373764; Fri, 07 Sep 2012 02:16:13 -0700 (PDT) Received: from [192.168.178.21] (host194-94-dynamic.2-87-r.retail.telecomitalia.it. [87.2.94.194]) by mx.google.com with ESMTPS id hg13sm2860064bkc.7.2012.09.07.02.16.12 (version=SSLv3 cipher=OTHER); Fri, 07 Sep 2012 02:16:12 -0700 (PDT) Message-ID: <5049BB53.4010209@gmail.com> Date: Fri, 07 Sep 2012 11:16:03 +0200 From: Stefano Lattarini MIME-Version: 1.0 To: =?UTF-8?B?0K7RgNC40Lkg0J/Rg9GF0LDQu9GM0YHQutC40Lk=?= Subject: Re: bug#12372: arbitrary suffix sources are not added to the tags References: In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.6 (--) X-Debbugs-Envelope-To: 12372 Cc: 12372@debbugs.gnu.org, "automake-patches@gnu.org" X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.6 (--) severity 12372 minor close 12372 thanks On 09/06/2012 05:11 PM, Юрий Пухальский wrote: > So the .am file is like this: > > .POSIX: > > SUFFIXES = .pc > > .pc.lo: > cp $*.pc $*.c > $(LIBTOOL) --tag=CC $(AM_LIBTOOLFLAGS) $(LIBTOOLFLAGS) --mode=compile > $(CC) $(DEFS) $(DEFAULT_INCLUDES) $(INCLUDES) $(AM_CPPFLAGS) > $(CPPFLAGS) $(AM_CFLAGS) $(CFLAGS) -c -o $@ $*.c > rm -f $*.c > > CCLD = $(CC) > LINK = $(LIBTOOL) --tag=CC $(AM_LIBTOOLFLAGS) $(LIBTOOLFLAGS) \ > --mode=link $(CCLD) $(AM_CFLAGS) $(CFLAGS) $(AM_LDFLAGS) \ > $(LDFLAGS) -o $@ > > noinst_LTLIBRARIES=libfoo.la > > libfoo_la_SOURCES=foo.pc bar.c > > The libfoo_la_SOURCES are not added to the tags list and the tags > goals are not generated: > I'm not able to reproduce this failure with the latest version of Automake (1.12.4). In fact ... > excerpt from the Makefile.in > --------- > tags: TAGS > TAGS: > > ctags: CTAGS > CTAGS: > --------- > ... in my case, the generated makefile reads: ctags: CTAGS CTAGS: $(HEADERS) $(SOURCES) $(TAGS_DEPENDENCIES) \ $(TAGS_FILES) $(LISP) list='$(SOURCES) $(HEADERS) $(LISP) $(TAGS_FILES)'; \ unique=`for i in $$list; do \ if test -f "$$i"; then echo $$i; else echo $(srcdir)/$$i; fi; \ done | \ $(AWK) '{ files[$$0] = 1; nonempty = 1; } \ END { if (nonempty) { for (i in files) print i; }; }'`; \ test -z "$(CTAGS_ARGS)$$unique" \ || $(CTAGS) $(CTAGSFLAGS) $(AM_CTAGSFLAGS) $(CTAGS_ARGS) \ $$unique (and similarly for TAGS/tags), which is correct. Anyway, I've added a new test case (see patch below) to check against this bug, to ensure it won't surreptitiously represent itself. In case the problem persists for you also with Autoamke 1.12.4, feel free to re-open this ticket. Thanks, Stefano > Adding them to the TAGS_FILES explicitly (as Stefano had advised) > doesn't help. It seems that it's being overridden. > > ---------- Forwarded message ---------- > From: Юрий Пухальский > Date: Mon, Jul 23, 2012 at 4:49 PM > Subject: bug#7824: Automatic chaining of make suffix rules (was: Re: > bug#7824: won't fix) > To: Stefano Lattarini > Cc: 7824@debbugs.gnu.org, Automake List > > > On Mon, Jul 23, 2012 at 4:42 PM, Stefano Lattarini > wrote: >> [Re-adding the list, as this discussion is worth being registered in >> the archives IMHO] >> > Ok. > >>>>> The situation is that both of the approaches (.pc.c rule and .pc.lo >>>>> rule) have problems entailed. >>>> >>>>> * .pc.lo rule doesn't create tags for *.pc sources. >>>>> >>>> Try to add the relevant '.pc' files to $(TAGS_FILES) explicitly. It should >>>> solve your issue. If it doesn't, you've found a new Automake bug, which I >>>> will gladly fix :-) >>> >>> Ah, ok! I knew there must be something like that. >>> But why in the first place it doesn't do it automatically? I have it >>> in the _SOURCES… Is it afraid of the .pc extension? >>> >> I'm not sure actually. Might be a tiny bug in automake. Care to open a >> new report about the issue, so I won't forget? I'll get to it eventually, >> but not right now. > -----8<-----8<-----8<-----8<-----8<-----8<-----8<-----8<-----8<-----8<----- >From 94b7b8ecd4bae85782b45a9bb36f42c4d2b93805 Mon Sep 17 00:00:00 2001 Message-Id: <94b7b8ecd4bae85782b45a9bb36f42c4d2b93805.1347009166.git.stefano.lattarini@gmail.com> From: Stefano Lattarini Date: Fri, 7 Sep 2012 10:42:42 +0200 Subject: [PATCH] coverage: expose automake bug#12372 (tags-related) That bug is somehow already been fixed in the latest automake version (1.12.4); but exercise it anyway in the testsuite, to ensure we won't regress. * t/tags-pr12372.sh: New test. * t/list-of-tests.mk: Add it. Signed-off-by: Stefano Lattarini --- t/list-of-tests.mk | 1 + t/tags-pr12372.sh | 56 ++++++++++++++++++++++++++++++++++++++++++++++++++++++ 2 files changed, 57 insertions(+) create mode 100755 t/tags-pr12372.sh diff --git a/t/list-of-tests.mk b/t/list-of-tests.mk index 8e1093a..c20fead 100644 --- a/t/list-of-tests.mk +++ b/t/list-of-tests.mk @@ -1154,6 +1154,7 @@ t/tap-summary-color.sh \ t/tags.sh \ t/tags2.sh \ t/tagsub.sh \ +t/tags-pr12372.sh \ t/tar.sh \ t/tar2.sh \ t/tar3.sh \ diff --git a/t/tags-pr12372.sh b/t/tags-pr12372.sh new file mode 100755 index 0000000..d46927e --- /dev/null +++ b/t/tags-pr12372.sh @@ -0,0 +1,56 @@ +#! /bin/sh +# Copyright (C) 2012 Free Software Foundation, Inc. +# +# This program is free software; you can redistribute it and/or modify +# it under the terms of the GNU General Public License as published by +# the Free Software Foundation; either version 2, or (at your option) +# any later version. +# +# This program is distributed in the hope that it will be useful, +# but WITHOUT ANY WARRANTY; without even the implied warranty of +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +# GNU General Public License for more details. +# +# You should have received a copy of the GNU General Public License +# along with this program. If not, see . + +# Test to make sure tags are processed also for files with non-standard +# extensions. See automake bug#12372. + +required='cc etags' +. ./defs || exit 1 + +cat >> configure.ac <<'END' +AC_PROG_CC +AC_OUTPUT +END + +cat > Makefile.am <<'END' +all-local: tags +.pc.o: + sed -e 's/\[/{/' -e 's/\]/}/' $(srcdir)/$*.pc >$*.c + $(CC) $(DEFS) $(CPPFLAGS) $(CFLAGS) -c $*.c + rm -f $*.c + +LINK = $(CCLD) $(CFLAGS) $(LDFLAGS) -o $@ +noinst_PROGRAMS = foo +foo_SOURCES = foo-main.pc barbar.c +END + +echo 'int main(void) [ return bar(1); ]' > foo-main.pc +echo 'int bar(int x) { return !x; }' > barbar.c + +$ACLOCAL +$AUTOCONF +$AUTOMAKE + +./configure + +$MAKE +cat TAGS +$FGREP foo-main.pc TAGS +$FGREP barbar.c TAGS + +$MAKE distcheck + +: -- 1.7.12 From debbugs-submit-bounces@debbugs.gnu.org Fri Sep 07 07:44:38 2012 Received: (at 12372) by debbugs.gnu.org; 7 Sep 2012 11:44:38 +0000 Received: from localhost ([127.0.0.1]:45645 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1T9wzF-0001Rf-OG for submit@debbugs.gnu.org; Fri, 07 Sep 2012 07:44:38 -0400 Received: from mail-bk0-f44.google.com ([209.85.214.44]:61945) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1T9wzD-0001RX-EX for 12372@debbugs.gnu.org; Fri, 07 Sep 2012 07:44:36 -0400 Received: by bkty12 with SMTP id y12so1257901bkt.3 for <12372@debbugs.gnu.org>; Fri, 07 Sep 2012 04:44:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=message-id:date:from:mime-version:to:cc:subject:references :in-reply-to:content-type:content-transfer-encoding; bh=qE/MYcAzq1tM61uZvDDj4+xczXC8oheJYfgdmYnQXV8=; b=cKymUcT2bb5YwHbWnAbCUsKSW49do8M1dKt+2PeLZEaiWrxrmRDWqrOojs6PEtOiJ8 6eEO+XMOqyeW07pdHaCQRKpziUhfHS0QLzU1oxFIMn1OiUSJpO3YHb/D+3WNgJUdb/50 EbqEcaiMDt+qDQCbIvlIT1DKl2/VMNDQdm19+gceNhwq4/W0bq3ddiVYUo3WGWMBJdgz JfIEY57si7pwyUPKJetM2Kz17FKDOwIH5ObOx8/hTCEqXN0pr8uxK4Sq8XMRNw1YA91V R1iLgJCfW7+Tv6IKIuR9J4VuiVVsCm36rejM9XVOfnEsA8TYLOjLkeqK+r2cq7zoqVL0 ZEeA== Received: by 10.204.151.81 with SMTP id b17mr2560676bkw.95.1347018256786; Fri, 07 Sep 2012 04:44:16 -0700 (PDT) Received: from [192.168.178.21] (host194-94-dynamic.2-87-r.retail.telecomitalia.it. [87.2.94.194]) by mx.google.com with ESMTPS id y20sm3226418bkv.11.2012.09.07.04.44.15 (version=SSLv3 cipher=OTHER); Fri, 07 Sep 2012 04:44:16 -0700 (PDT) Message-ID: <5049DE0D.7000006@gmail.com> Date: Fri, 07 Sep 2012 13:44:13 +0200 From: Stefano Lattarini MIME-Version: 1.0 To: =?UTF-8?B?0K7RgNC40Lkg0J/Rg9GF0LDQu9GM0YHQutC40Lk=?= Subject: Re: bug#12372: arbitrary suffix sources are not added to the tags References: <5049BB53.4010209@gmail.com> <5049C887.7090205@gmail.com> In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.6 (--) X-Debbugs-Envelope-To: 12372 Cc: 12372@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.6 (--) [Re-adding the list, please keep it in the loop in future answers] On 09/07/2012 01:16 PM, Юрий Пухальский wrote: > Ok, got it. > > The automake version i've tried is 1.12.3, the latest available > from the site. > > If there is .pc.lo rule, .pc don't get into the tags and for .pc-only > sourced libraries nothing gets to the tags. > But if i add .c file to the sources, the target is generated and all > the sources go there alongside this .c file. > > If there is no .pc.lo rule, .pc go to the tags regardless whether > there is .c file with them or not. > > The makefile to play is like this: > > SUFFIXES = .pc > .pc.lo: > touch $*.lo > noinst_LTLIBRARIES=libfoo.la > libfoo_la_SOURCES=foo.pc # bar.c > I'll try to get a better look this evening or tomorrow. Thanks, Stefano From debbugs-submit-bounces@debbugs.gnu.org Tue Sep 11 05:25:19 2012 Received: (at 12372) by debbugs.gnu.org; 11 Sep 2012 09:25:19 +0000 Received: from localhost ([127.0.0.1]:53634 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TBMic-00079W-SM for submit@debbugs.gnu.org; Tue, 11 Sep 2012 05:25:19 -0400 Received: from mail-ey0-f172.google.com ([209.85.215.172]:62026) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TBMia-00079O-99 for 12372@debbugs.gnu.org; Tue, 11 Sep 2012 05:25:17 -0400 Received: by eaai11 with SMTP id i11so140052eaa.3 for <12372@debbugs.gnu.org>; Tue, 11 Sep 2012 02:24:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=message-id:date:from:mime-version:to:cc:subject:references :in-reply-to:content-type:content-transfer-encoding; bh=sb2ClbSn8D5jiTo1H2nS8SnMY6C66mqG1PE9mRI4zC4=; b=k8PjGsLAB5FJ84ytWjqdX8Y35Arpbhsx8Ge12QCiOr+qcFPPXxlaImdnUPNL8zv01d 9Zh7PIRs8zqQOLrwC2/m1DrPGpxDPJy3GrNZjsPoFaOSKW5/fuKEKnPmViJsduelcGmI iYd7f0UCjXNN4cWrpW9zsTmzLLHPVSqByFpeSiXMExA7WS4iOG78to9Nb5Rq4hd/YAm5 KZinyWxYYXLRUusYpqz8jecnXiz3RpcDpG7oL1GwWE2Ruuds9mfvypmbes2oZTwsFovy 7ZVO2AwBcyiOLd+YvzbY/O5p6efrqb+DhVXqTHbsL4ZvJTRF+I50jyFEKkUVx3cjHgph nyaA== Received: by 10.205.136.194 with SMTP id il2mr4605982bkc.81.1347355475974; Tue, 11 Sep 2012 02:24:35 -0700 (PDT) Received: from [192.168.178.21] (host194-94-dynamic.2-87-r.retail.telecomitalia.it. [87.2.94.194]) by mx.google.com with ESMTPS id n17sm8807764bks.6.2012.09.11.02.24.34 (version=SSLv3 cipher=OTHER); Tue, 11 Sep 2012 02:24:35 -0700 (PDT) Message-ID: <504F0350.5040408@gmail.com> Date: Tue, 11 Sep 2012 11:24:32 +0200 From: Stefano Lattarini MIME-Version: 1.0 To: =?UTF-8?B?0K7RgNC40Lkg0J/Rg9GF0LDQu9GM0YHQutC40Lk=?= Subject: Re: bug#12372: arbitrary suffix sources are not added to the tags References: <5049BB53.4010209@gmail.com> <5049C887.7090205@gmail.com> <5049DE0D.7000006@gmail.com> In-Reply-To: <5049DE0D.7000006@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.6 (--) X-Debbugs-Envelope-To: 12372 Cc: 12372@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.6 (--) On 09/07/2012 01:44 PM, Stefano Lattarini wrote: > [Re-adding the list, please keep it in the loop in future answers] > > On 09/07/2012 01:16 PM, Юрий Пухальский wrote: >> Ok, got it. >> >> The automake version i've tried is 1.12.3, the latest available >> from the site. >> >> If there is .pc.lo rule, .pc don't get into the tags and for .pc-only >> sourced libraries nothing gets to the tags. >> But if i add .c file to the sources, the target is generated and all >> the sources go there alongside this .c file. >> >> If there is no .pc.lo rule, .pc go to the tags regardless whether >> there is .c file with them or not. >> >> The makefile to play is like this: >> >> SUFFIXES = .pc >> .pc.lo: >> touch $*.lo >> noinst_LTLIBRARIES=libfoo.la >> libfoo_la_SOURCES=foo.pc # bar.c >> > I'll try to get a better look this evening or tomorrow. > OK, with your new information, I can reproduce the bug in the maint branch of Automake But luckily, the overhauling of tags support done in master has fixed it there already, so the bug will be gone in 1.13. Thus I'm not reopening this ticket. Patches exposing the bug in maint and documenting its fixing in master (with a NEWS entry) will follow shorty. Thanks, Stefano From debbugs-submit-bounces@debbugs.gnu.org Tue Sep 11 05:41:22 2012 Received: (at 12372) by debbugs.gnu.org; 11 Sep 2012 09:41:22 +0000 Received: from localhost ([127.0.0.1]:53672 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TBMyA-0007W9-22 for submit@debbugs.gnu.org; Tue, 11 Sep 2012 05:41:22 -0400 Received: from mail-qc0-f172.google.com ([209.85.216.172]:61967) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TBMy7-0007W2-KQ for 12372@debbugs.gnu.org; Tue, 11 Sep 2012 05:41:20 -0400 Received: by qcac10 with SMTP id c10so200222qca.3 for <12372@debbugs.gnu.org>; Tue, 11 Sep 2012 02:40:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type:content-transfer-encoding; bh=VtqFQ4M7nJdKbbom5MjGjEENkn5QmcMY0DqwmpNGrJo=; b=jFlK/KDlPFCpC6hehj/aIqaM967uLqxYHENSKrsUh8u+uAk5W+f3v2giakuCuwtZMR As2tRLlGBXkrjchAZVdDF4x1yuqrD4EEx1NsgkKdn6wduMzCU7/lNhIIrZ0hpJEMZzP1 jjFA6nknY58yTNhjVNWRKQWw8NkK0OYLRXmRv1ADULZoUIj8Di1jO6p7g2JN5wfJyj/O OpoFbr7C5h1EhREX9Na36BFay74VsUBzNtZyz6RslaqEvGLXCPy/Rx52+Gww8G4Z51Na uxoLnUA9p3cxcX3Nay904f4saSa95iOyZtkreovdUcs+Yz9qN9FDOgG3AD55WPd60oec KOLQ== MIME-Version: 1.0 Received: by 10.224.180.7 with SMTP id bs7mr18078428qab.37.1347356437560; Tue, 11 Sep 2012 02:40:37 -0700 (PDT) Received: by 10.49.12.71 with HTTP; Tue, 11 Sep 2012 02:40:37 -0700 (PDT) In-Reply-To: <504F0350.5040408@gmail.com> References: <5049BB53.4010209@gmail.com> <5049C887.7090205@gmail.com> <5049DE0D.7000006@gmail.com> <504F0350.5040408@gmail.com> Date: Tue, 11 Sep 2012 13:40:37 +0400 Message-ID: Subject: Re: bug#12372: arbitrary suffix sources are not added to the tags From: =?UTF-8?B?0K7RgNC40Lkg0J/Rg9GF0LDQu9GM0YHQutC40Lk=?= To: Stefano Lattarini Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.6 (--) X-Debbugs-Envelope-To: 12372 Cc: 12372@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.6 (--) Ok, nice to hear:) Thank you for your effort! PS. I've started the ticket at Autstin about chain rules and the POSIX standard. We'll see what they tell. On Tue, Sep 11, 2012 at 1:24 PM, Stefano Lattarini wrote: > On 09/07/2012 01:44 PM, Stefano Lattarini wrote: >> [Re-adding the list, please keep it in the loop in future answers] >> >> On 09/07/2012 01:16 PM, =D0=AE=D1=80=D0=B8=D0=B9 =D0=9F=D1=83=D1=85=D0= =B0=D0=BB=D1=8C=D1=81=D0=BA=D0=B8=D0=B9 wrote: >>> Ok, got it. >>> >>> The automake version i've tried is 1.12.3, the latest available >>> from the site. >>> >>> If there is .pc.lo rule, .pc don't get into the tags and for .pc-only >>> sourced libraries nothing gets to the tags. >>> But if i add .c file to the sources, the target is generated and all >>> the sources go there alongside this .c file. >>> >>> If there is no .pc.lo rule, .pc go to the tags regardless whether >>> there is .c file with them or not. >>> >>> The makefile to play is like this: >>> >>> SUFFIXES =3D .pc >>> .pc.lo: >>> touch $*.lo >>> noinst_LTLIBRARIES=3Dlibfoo.la >>> libfoo_la_SOURCES=3Dfoo.pc # bar.c >>> >> I'll try to get a better look this evening or tomorrow. >> > OK, with your new information, I can reproduce the bug in the maint > branch of Automake But luckily, the overhauling of tags support done > in master has fixed it there already, so the bug will be gone in 1.13. > Thus I'm not reopening this ticket. > > Patches exposing the bug in maint and documenting its fixing in master > (with a NEWS entry) will follow shorty. > > Thanks, > Stefano --=20 =C2=ABEvery person has a certain horizon. When it narrows and becomes infinitely small, it changes into a point and then the person says: =E2=80=9CThis is my point of view.=E2=80=9D=C2=BB From debbugs-submit-bounces@debbugs.gnu.org Tue Sep 11 05:47:04 2012 Received: (at 12372) by debbugs.gnu.org; 11 Sep 2012 09:47:04 +0000 Received: from localhost ([127.0.0.1]:53678 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TBN3e-0007e7-PX for submit@debbugs.gnu.org; Tue, 11 Sep 2012 05:47:04 -0400 Received: from mail-ee0-f44.google.com ([74.125.83.44]:45142) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TBN3b-0007dh-Nr for 12372@debbugs.gnu.org; Tue, 11 Sep 2012 05:47:01 -0400 Received: by eekb45 with SMTP id b45so214196eek.3 for <12372@debbugs.gnu.org>; Tue, 11 Sep 2012 02:46:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id:x-mailer:in-reply-to:references; bh=O0RiYo+4dF10tn4wFX/ZvrpW3IbGKDY4pWoO6VyTka4=; b=VOkHYtJfKiyYrMhRYMIX+qHpIYYZVfFdZlTwEABbAyV8q2US/oA04Haf2r6y+Db2GF XZlMxhI45ATm3Y/8WwiFpVZjKQXv1cfjrMBD+KlUMb5U6c6NUBQzcFkBAsXmfDeY7WL3 ShCbK47F3m8G6lrzbODZNsiWUFrEao40PoOj6iXgiOQgqF0/sW3b6ckhpuhwShfx93uR xlUdBNGT2ghXgxvYfytn/XEnJIxF4akSpUJN52fhUF6WfIL9wsdxt7DhzKqJWsSPzxiW Ifejvucsw+pw+Fr04hsE+MO/lWHjeGXN2V4/N8AM63fRc7CkBf3H9RX0bHgrBPA04AMN JuoA== Received: by 10.204.149.217 with SMTP id u25mr4456789bkv.107.1347356779327; Tue, 11 Sep 2012 02:46:19 -0700 (PDT) Received: from localhost.localdomain (host194-94-dynamic.2-87-r.retail.telecomitalia.it. [87.2.94.194]) by mx.google.com with ESMTPS id fu8sm8883548bkc.5.2012.09.11.02.46.17 (version=TLSv1/SSLv3 cipher=OTHER); Tue, 11 Sep 2012 02:46:18 -0700 (PDT) From: Stefano Lattarini To: automake-patches@gnu.org Subject: [FYI 1/2] {maint} coverage: expose automake bug#12372 (tags-related) Date: Tue, 11 Sep 2012 11:46:06 +0200 Message-Id: <94b7b8ecd4bae85782b45a9bb36f42c4d2b93805.1347356523.git.stefano.lattarini@gmail.com> X-Mailer: git-send-email 1.7.12 In-Reply-To: <504F0350.5040408@gmail.com> References: <504F0350.5040408@gmail.com> X-Spam-Score: -2.6 (--) X-Debbugs-Envelope-To: 12372 Cc: 12372@debbugs.gnu.org, aikipooh@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.6 (--) That bug is somehow already been fixed in the latest automake version (1.12.4); but exercise it anyway in the testsuite, to ensure we won't regress. * t/tags-pr12372.sh: New test. * t/list-of-tests.mk: Add it. Signed-off-by: Stefano Lattarini --- t/list-of-tests.mk | 1 + t/tags-pr12372.sh | 56 ++++++++++++++++++++++++++++++++++++++++++++++++++++++ 2 files changed, 57 insertions(+) create mode 100755 t/tags-pr12372.sh diff --git a/t/list-of-tests.mk b/t/list-of-tests.mk index 8e1093a..c20fead 100644 --- a/t/list-of-tests.mk +++ b/t/list-of-tests.mk @@ -1154,6 +1154,7 @@ t/tap-summary-color.sh \ t/tags.sh \ t/tags2.sh \ t/tagsub.sh \ +t/tags-pr12372.sh \ t/tar.sh \ t/tar2.sh \ t/tar3.sh \ diff --git a/t/tags-pr12372.sh b/t/tags-pr12372.sh new file mode 100755 index 0000000..d46927e --- /dev/null +++ b/t/tags-pr12372.sh @@ -0,0 +1,56 @@ +#! /bin/sh +# Copyright (C) 2012 Free Software Foundation, Inc. +# +# This program is free software; you can redistribute it and/or modify +# it under the terms of the GNU General Public License as published by +# the Free Software Foundation; either version 2, or (at your option) +# any later version. +# +# This program is distributed in the hope that it will be useful, +# but WITHOUT ANY WARRANTY; without even the implied warranty of +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +# GNU General Public License for more details. +# +# You should have received a copy of the GNU General Public License +# along with this program. If not, see . + +# Test to make sure tags are processed also for files with non-standard +# extensions. See automake bug#12372. + +required='cc etags' +. ./defs || exit 1 + +cat >> configure.ac <<'END' +AC_PROG_CC +AC_OUTPUT +END + +cat > Makefile.am <<'END' +all-local: tags +.pc.o: + sed -e 's/\[/{/' -e 's/\]/}/' $(srcdir)/$*.pc >$*.c + $(CC) $(DEFS) $(CPPFLAGS) $(CFLAGS) -c $*.c + rm -f $*.c + +LINK = $(CCLD) $(CFLAGS) $(LDFLAGS) -o $@ +noinst_PROGRAMS = foo +foo_SOURCES = foo-main.pc barbar.c +END + +echo 'int main(void) [ return bar(1); ]' > foo-main.pc +echo 'int bar(int x) { return !x; }' > barbar.c + +$ACLOCAL +$AUTOCONF +$AUTOMAKE + +./configure + +$MAKE +cat TAGS +$FGREP foo-main.pc TAGS +$FGREP barbar.c TAGS + +$MAKE distcheck + +: -- 1.7.12 From debbugs-submit-bounces@debbugs.gnu.org Tue Sep 11 05:47:06 2012 Received: (at 12372) by debbugs.gnu.org; 11 Sep 2012 09:47:06 +0000 Received: from localhost ([127.0.0.1]:53680 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TBN3h-0007eL-OQ for submit@debbugs.gnu.org; Tue, 11 Sep 2012 05:47:06 -0400 Received: from mail-ee0-f44.google.com ([74.125.83.44]:57554) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TBN3c-0007dj-US for 12372@debbugs.gnu.org; Tue, 11 Sep 2012 05:47:03 -0400 Received: by eekb45 with SMTP id b45so214225eek.3 for <12372@debbugs.gnu.org>; Tue, 11 Sep 2012 02:46:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id:x-mailer:in-reply-to:references :in-reply-to:references:mime-version:content-type :content-transfer-encoding; bh=3KIvCbG92TPx0Em58/WKAJ9kWG9ztYB2PqP7CnuXrn0=; b=iUCgiXfiftn9CGT83eFx1kKWYbodtqxH7j2SIl+wXPOJ6a9sG5w/M6acOHXFFytcAm cOeKjfL0tYzLo5e64GUAbfNubIhM8/yQrjeDNyHZuvtzcJIzMB8AFwVKTMGo2/1IsGGf uUrdWAmE8dfhkfOu40+vT4t6e86768T3FAVuzPyZ9FgO/GvYSLdnVzivYqgrKxxYTpRi lnz4taF0QzExxmFqwjpILzItPS11TR0oT/y3Ts1nu2wYls91oy/5Ey9R20OMVlWzrfel r28THJNH7R9/N0DQn7vUdpwngfw7wqSzb8rCHPg8eDr/QXPU3OuNhqfZSjNkPhuWWGBc ilZw== Received: by 10.205.130.17 with SMTP id hk17mr4607826bkc.76.1347356780774; Tue, 11 Sep 2012 02:46:20 -0700 (PDT) Received: from localhost.localdomain (host194-94-dynamic.2-87-r.retail.telecomitalia.it. [87.2.94.194]) by mx.google.com with ESMTPS id fu8sm8883548bkc.5.2012.09.11.02.46.19 (version=TLSv1/SSLv3 cipher=OTHER); Tue, 11 Sep 2012 02:46:20 -0700 (PDT) From: Stefano Lattarini To: automake-patches@gnu.org Subject: [FYI 2/2] {maint} coverage: better exposure for automake bug#12372 (tags-related) Date: Tue, 11 Sep 2012 11:46:07 +0200 Message-Id: <9c4ad6973eedb074a9381e14a6c1eeeb285c2465.1347356523.git.stefano.lattarini@gmail.com> X-Mailer: git-send-email 1.7.12 In-Reply-To: <94b7b8ecd4bae85782b45a9bb36f42c4d2b93805.1347356523.git.stefano.lattarini@gmail.com> References: <504F0350.5040408@gmail.com> <94b7b8ecd4bae85782b45a9bb36f42c4d2b93805.1347356523.git.stefano.lattarini@gmail.com> In-Reply-To: <94b7b8ecd4bae85782b45a9bb36f42c4d2b93805.1347356523.git.stefano.lattarini@gmail.com> References: <94b7b8ecd4bae85782b45a9bb36f42c4d2b93805.1347356523.git.stefano.lattarini@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.6 (--) X-Debbugs-Envelope-To: 12372 Cc: 12372@debbugs.gnu.org, aikipooh@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.6 (--) Alas, in contrast with what is said in the commit message of previous commit 'v1.12.3-14-g94b7b8e', that bug is still present also in the current maint branch (which will become automake version 1.12.4); it is just that it only triggers when a _SOURCES variable contains only files with custom extension. * t/tags-pr12372.sh: Extend. * t/list-of-tests.mk: Add it. Suggested-by: Юрий Пухальский Signed-off-by: Stefano Lattarini --- t/list-of-tests.mk | 1 + t/tags-pr12372.sh | 18 ++++++++++++++++++ 2 files changed, 19 insertions(+) diff --git a/t/list-of-tests.mk b/t/list-of-tests.mk index c20fead..6effe77 100644 --- a/t/list-of-tests.mk +++ b/t/list-of-tests.mk @@ -41,6 +41,7 @@ t/pr8365-remake-timing.sh \ t/lex-subobj-nodep.sh \ t/remake-am-pr10111.sh \ t/remake-m4-pr10111.sh \ +t/tags-pr12372.sh \ t/txinfo5.sh \ $(perl_fake_XFAIL_TESTS) diff --git a/t/tags-pr12372.sh b/t/tags-pr12372.sh index d46927e..66b40a0 100755 --- a/t/tags-pr12372.sh +++ b/t/tags-pr12372.sh @@ -22,6 +22,7 @@ required='cc etags' cat >> configure.ac <<'END' AC_PROG_CC +AC_CONFIG_FILES([sub/Makefile]) AC_OUTPUT END @@ -35,10 +36,25 @@ all-local: tags LINK = $(CCLD) $(CFLAGS) $(LDFLAGS) -o $@ noinst_PROGRAMS = foo foo_SOURCES = foo-main.pc barbar.c +SUBDIRS = sub +END + +mkdir sub +cat > sub/Makefile.am <<'END' +all-local: tags +.pc.o: + sed -e 's/@/a/g' $(srcdir)/$*.pc >$*.c + $(CC) $(DEFS) $(CPPFLAGS) $(CFLAGS) -c $*.c + rm -f $*.c + +LINK = $(CCLD) $(CFLAGS) $(LDFLAGS) -o $@ +noinst_PROGRAMS = zap +zap_SOURCES = zardoz.pc END echo 'int main(void) [ return bar(1); ]' > foo-main.pc echo 'int bar(int x) { return !x; }' > barbar.c +echo 'int m@in(void) { return 0; }' > sub/zardoz.pc $ACLOCAL $AUTOCONF @@ -48,8 +64,10 @@ $AUTOMAKE $MAKE cat TAGS +cat sub/TAGS $FGREP foo-main.pc TAGS $FGREP barbar.c TAGS +$FGREP zardoz.pc sub/TAGS $MAKE distcheck -- 1.7.12 From debbugs-submit-bounces@debbugs.gnu.org Tue Sep 11 05:49:41 2012 Received: (at 12372) by debbugs.gnu.org; 11 Sep 2012 09:49:41 +0000 Received: from localhost ([127.0.0.1]:53685 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TBN6C-0007hn-D0 for submit@debbugs.gnu.org; Tue, 11 Sep 2012 05:49:41 -0400 Received: from mail-ey0-f172.google.com ([209.85.215.172]:58780) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TBN6A-0007hf-60 for 12372@debbugs.gnu.org; Tue, 11 Sep 2012 05:49:38 -0400 Received: by eaai11 with SMTP id i11so153385eaa.3 for <12372@debbugs.gnu.org>; Tue, 11 Sep 2012 02:48:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id:x-mailer:in-reply-to:references; bh=QEd+i36O+/ZRsbw8+nMqvOQ1UFuDCsRc3LUi/l8sDgo=; b=soqqSCi48WpCPJHJReS9J7qts3nUqiu1lS+F7pAtZAclsWYhd5Zm+cCJFqmOfLcmzi kPeUiP6hq23UTDqEDuWhShKSWuurH/J8CpTBsXaq5TdjJsNpuN05Ifwj6tIVeTq504iR p7s0pk/grhsCSt+h1Qe0OOZMLb1ETmROsq5QArxclBtKt5ZhFEZI7x+8yN8rQGuB3Xmf RAylmxuFlJ5FYQlDmH0JXzRU8+YMQpUeTprNsxBUsB8xNvEAFqwMcpe86d14otrWLRf7 6u3ldGPCcVk7vlTt1WRGWHT8phOfe6wHjStKLTcykWwnqyEcJoMY1ZDzoTU/0++ybnOD 3nkA== Received: by 10.204.149.217 with SMTP id u25mr4458909bkv.107.1347356937846; Tue, 11 Sep 2012 02:48:57 -0700 (PDT) Received: from localhost.localdomain (host194-94-dynamic.2-87-r.retail.telecomitalia.it. [87.2.94.194]) by mx.google.com with ESMTPS id 14sm8892983bkq.12.2012.09.11.02.48.56 (version=TLSv1/SSLv3 cipher=OTHER); Tue, 11 Sep 2012 02:48:56 -0700 (PDT) From: Stefano Lattarini To: automake-patches@gnu.org Subject: [FYI] {master} tags: automake bug bug#12372 is fixed Date: Tue, 11 Sep 2012 11:48:48 +0200 Message-Id: <46426e70de0a417a3195ea704a52814b03ed4e56.1347356876.git.stefano.lattarini@gmail.com> X-Mailer: git-send-email 1.7.12 In-Reply-To: <504F0350.5040408@gmail.com> References: <504F0350.5040408@gmail.com> X-Spam-Score: -2.6 (--) X-Debbugs-Envelope-To: 12372 Cc: 12372@debbugs.gnu.org, aikipooh@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.6 (--) It has been fixed as a side effect of the overhauling of tags support. * t/list-of-tests.mk (XFAIL_TESTS): No longer list 'tags-pr12372.sh'. * NEWS: Update. Signed-off-by: Stefano Lattarini --- NEWS | 5 +++++ t/list-of-tests.mk | 1 - 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/NEWS b/NEWS index f243d8c..46aa8cd 100644 --- a/NEWS +++ b/NEWS @@ -127,10 +127,15 @@ New in 1.13: specifying the name of such targets in invocations of the new 'AM_EXTRA_RECURSIVE_TARGETS' m4 macro. +* Tags: + - Any failure in the recipe of the "tags", "ctags", "cscope" or "cscopelist" targets in a subdirectory is now propagated to the top-level make invocation. + - Tags are correctly computed also for files in _SOURCES variables that + only list files with non-standard suffixes (see automake bug#12372). + * Improvements to aclocal and related rebuilds rules: - The Autoconf-provided macro AC_CONFIG_MACRO_DIR is now traced by diff --git a/t/list-of-tests.mk b/t/list-of-tests.mk index c024171..3708ef7 100644 --- a/t/list-of-tests.mk +++ b/t/list-of-tests.mk @@ -41,7 +41,6 @@ t/pr8365-remake-timing.sh \ t/lex-subobj-nodep.sh \ t/remake-am-pr10111.sh \ t/remake-m4-pr10111.sh \ -t/tags-pr12372.sh \ t/txinfo5.sh \ $(perl_fake_XFAIL_TESTS) -- 1.7.12 From unknown Thu Jun 19 14:19:05 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Tue, 09 Oct 2012 11:24:03 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator