From debbugs-submit-bounces@debbugs.gnu.org Wed Sep 05 13:14:40 2012 Received: (at submit) by debbugs.gnu.org; 5 Sep 2012 17:14:40 +0000 Received: from localhost ([127.0.0.1]:40743 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1T9JBY-0004xk-MN for submit@debbugs.gnu.org; Wed, 05 Sep 2012 13:14:40 -0400 Received: from eggs.gnu.org ([208.118.235.92]:54101) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1T9JBW-0004xd-ES for submit@debbugs.gnu.org; Wed, 05 Sep 2012 13:14:39 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1T9JBH-0002fi-GY for submit@debbugs.gnu.org; Wed, 05 Sep 2012 13:14:31 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=5.0 tests=BAYES_00,FREEMAIL_FROM, HTML_MESSAGE,RCVD_IN_DNSWL_HI,T_DKIM_INVALID autolearn=unavailable version=3.3.2 Received: from lists.gnu.org ([208.118.235.17]:44176) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T9JBH-0002fe-DM for submit@debbugs.gnu.org; Wed, 05 Sep 2012 13:14:23 -0400 Received: from eggs.gnu.org ([208.118.235.92]:41548) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T9JBC-0004K7-VD for bug-gnu-emacs@gnu.org; Wed, 05 Sep 2012 13:14:23 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1T9JB8-0002e3-VO for bug-gnu-emacs@gnu.org; Wed, 05 Sep 2012 13:14:18 -0400 Received: from mail-qc0-f169.google.com ([209.85.216.169]:40933) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T9JB8-0002dr-R9 for bug-gnu-emacs@gnu.org; Wed, 05 Sep 2012 13:14:14 -0400 Received: by qcsd16 with SMTP id d16so281215qcs.0 for ; Wed, 05 Sep 2012 10:14:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:date:message-id:subject:from:to:content-type; bh=QQedMLBFyOSs0aTJhBXlVuM5dY6n+7dd40rZCJP1veM=; b=qDhkopNv23dLTKrUjOHKYJyYUhfrV6q9EeoJbjUpFA/4PjR1I4UPecx/XpOwxCZBs3 DSfYyyFO7Ot1NMu9RFTY1EUsL1SayH/+AsLAB3smz4LUZjARd//FTtu1/gyoFJQ13LsS dCPmTVkpyQD2tNCrozwlK+Q02+E5/FeuKAmTj3g3jj7DM7FVVglW1xeY02/enHGO1LaB V+OC9fCO5G04sqVzjyhc42k1fvVd2kl4wnQzn+KNG7/iWbsu8nsGTNdWQwwU8O93IXS7 ihVcINtvprG7959aGhWTD0HV4w2POlpLEQsluSptVma41FLamff7PPItOHkj4JuEBC8o rJjw== MIME-Version: 1.0 Received: by 10.224.39.195 with SMTP id h3mr46841866qae.10.1346865254273; Wed, 05 Sep 2012 10:14:14 -0700 (PDT) Received: by 10.49.24.211 with HTTP; Wed, 5 Sep 2012 10:14:14 -0700 (PDT) Date: Thu, 6 Sep 2012 01:14:14 +0800 Message-ID: Subject: hilit-chg.el bug causes conflict with yasnippet (patch included) From: Le Wang To: bug-gnu-emacs@gnu.org Content-Type: multipart/mixed; boundary=20cf306f7d140a930004c8f781ff X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-Received-From: 208.118.235.17 X-Spam-Score: -3.6 (---) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -3.6 (---) --20cf306f7d140a930004c8f781ff Content-Type: multipart/alternative; boundary=20cf306f7d140a92f704c8f781fd --20cf306f7d140a92f704c8f781fd Content-Type: text/plain; charset=ISO-8859-1 hilit changes assumes that if the end has hilit-chg-delete property, property between END and (+ 1 END) be set. This isn't true if the buffer has been narrowed, which yasnippet does regularly. Attached patch fixes it. I'm not completely sure if it's the best fix. -- Le --20cf306f7d140a92f704c8f781fd Content-Type: text/html; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable hilit changes assumes that if the end has hilit-chg-delete property, proper= ty between END and (+ 1 END) be set. =A0This isn't true if the buffer h= as been narrowed, which yasnippet does regularly.
Attached patch fixes it. =A0I'm not completely sure if it= 9;s the best fix.

--
Le
--20cf306f7d140a92f704c8f781fd-- --20cf306f7d140a930004c8f781ff Content-Type: application/octet-stream; name="hilit-chg.el.patch" Content-Disposition: attachment; filename="hilit-chg.el.patch" Content-Transfer-Encoding: base64 X-Attachment-Id: f_h6qoroif0 ZGlmZiAtLWdpdCBhL2xpc3AvaGlsaXQtY2hnLmVsIGIvbGlzcC9oaWxpdC1jaGcuZWwKaW5kZXgg MDk3MGVjZS4uMjBkNDQzNyAxMDA2NDQKLS0tIGEvbGlzcC9oaWxpdC1jaGcuZWwKKysrIGIvbGlz cC9oaWxpdC1jaGcuZWwKQEAgLTU5Miw4ICs1OTIsOSBAQCBUaGlzIGFsbG93cyB5b3UgdG8gbWFu dWFsbHkgcmVtb3ZlIGhpZ2hsaWdodGluZyBmcm9tIHVuaW50ZXJlc3RpbmcgY2hhbmdlcy4iCiAg ICAgICAgICAgICA7OyB0ZXh0IHRoZW4gcmVtb3ZlIHRoZSBkZWxldGlvbiBtYXJraW5nLCBidXQg c2V0IGl0IHRvCiAJICA7OyBjaGFuZ2VkIG90aGVyd2lzZSBpdHMgaGlnaGxpZ2h0aW5nIGRpc2Fw cGVhcnMuCiAJICAoaWYgKGVxIChnZXQtdGV4dC1wcm9wZXJ0eSBlbmQgJ2hpbGl0LWNoZykgJ2hp bGl0LWNoZy1kZWxldGUpCi0JICAgICAgKHByb2duCi0JCShwdXQtdGV4dC1wcm9wZXJ0eSBlbmQg KCsgZW5kIDEpICdoaWxpdC1jaGcgJ2hpbGl0LWNoZykKKyAgICAgICAgICAgICAgKHNhdmUtcmVz dHJpY3Rpb24KKyAgICAgICAgICAgICAgICAod2lkZW4pCisgICAgICAgICAgICAgICAgKHB1dC10 ZXh0LXByb3BlcnR5IGVuZCAoKyBlbmQgMSkgJ2hpbGl0LWNoZyAnaGlsaXQtY2hnKQogCQkoaWYg aGlnaGxpZ2h0LWNoYW5nZXMtdmlzaWJsZS1tb2RlCiAJCSAgICAoaGlsaXQtY2hnLWZpeHVwIGJl ZyAoKyBlbmQgMSkpKSkpKQogICAgICAgICAgICh1bmxlc3Mgbm8tcHJvcGVydHktY2hhbmdlCg== --20cf306f7d140a930004c8f781ff-- From debbugs-submit-bounces@debbugs.gnu.org Fri Dec 07 00:00:58 2012 Received: (at 12361-done) by debbugs.gnu.org; 7 Dec 2012 05:00:58 +0000 Received: from localhost ([127.0.0.1]:57629 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1Tgq3W-0004Yv-2S for submit@debbugs.gnu.org; Fri, 07 Dec 2012 00:00:58 -0500 Received: from ironport2-out.teksavvy.com ([206.248.154.182]:26053) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1Tgq3U-0004Yo-AY for 12361-done@debbugs.gnu.org; Fri, 07 Dec 2012 00:00:56 -0500 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: Av0EAG6Zu09soXOY/2dsb2JhbABEtBGBCIIVAQEEAVYjBQsLDiYSFBgNJIgcBboJkEQDiEKacYFYgwc X-IronPort-AV: E=Sophos;i="4.75,637,1330923600"; d="scan'208";a="209265788" Received: from 108-161-115-152.dsl.teksavvy.com (HELO pastel.home) ([108.161.115.152]) by ironport2-out.teksavvy.com with ESMTP/TLS/ADH-AES256-SHA; 07 Dec 2012 00:00:37 -0500 Received: by pastel.home (Postfix, from userid 20848) id 1A33C58F5C; Fri, 7 Dec 2012 00:00:35 -0500 (EST) From: Stefan Monnier To: Le Wang Subject: Re: bug#12361: hilit-chg.el bug causes conflict with yasnippet (patch included) Message-ID: References: Date: Fri, 07 Dec 2012 00:00:35 -0500 In-Reply-To: (Le Wang's message of "Thu, 6 Sep 2012 01:14:14 +0800") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.8 (/) X-Debbugs-Envelope-To: 12361-done Cc: 12361-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -0.0 (/) > Attached patch fixes it. I'm not completely sure if it's the best fix. That looks about right, thank you, installed in emacs-24, Stefan From unknown Fri Sep 05 08:43:41 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Fri, 04 Jan 2013 12:24:03 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator