GNU bug report logs - #12347
24.2.50; doc of `completion-table-subvert'

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 12347 in the body.
You can then email your comments to 12347 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: "Drew Adams" <drew.adams <at> oracle.com>
To: <bug-gnu-emacs <at> gnu.org>
Subject: 24.2.50; doc of `completion-table-subvert'
Date: Mon, 3 Sep 2012 20:03:18 -0700

Doc string:
 
"Completion table that replaces the prefix S1 with S2 in STRING."
 
What's STRING?  STRING is described/defined nowhere.  And this is the
first sentence of the doc string, which should be able to stand alone.

In GNU Emacs 24.2.50.1 (i386-mingw-nt5.1.2600)
 of 2012-09-02 on MARVIN
Bzr revision: 109861 eggert <at> cs.ucla.edu-20120902171035-7mzihil3xd6bjfiy
Windowing system distributor `Microsoft Corp.', version 5.1.2600
Configured using:
 `configure --with-gcc (4.6) --no-opt --enable-checking --cflags
 -ID:/devel/emacs/libs/libXpm-3.5.8/include
 -ID:/devel/emacs/libs/libXpm-3.5.8/src
 -ID:/devel/emacs/libs/libpng-dev_1.4.3-1/include
 -ID:/devel/emacs/libs/zlib-dev_1.2.5-2/include
 -ID:/devel/emacs/libs/giflib-4.1.4-1/include
 -ID:/devel/emacs/libs/jpeg-6b-4/include
 -ID:/devel/emacs/libs/tiff-3.8.2-1/include
 -ID:/devel/emacs/libs/gnutls-3.0.9/include
 -ID:/devel/emacs/libs/libiconv-1.13.1-1-dev/include
 -ID:/devel/emacs/libs/libxml2-2.7.8/include/libxml2'
 

Message #10 received at 12347-done <at> debbugs.gnu.org (full text, mbox):

From: Bastien <bzg <at> altern.org>
To: "Drew Adams" <drew.adams <at> oracle.com>
Cc: 12347-done <at> debbugs.gnu.org
Subject: Re: bug#12347: 24.2.50; doc of `completion-table-subvert'
Date: Tue, 11 Sep 2012 16:07:15 +0200

[Message part 1 (text/plain, inline)]

"Drew Adams" <drew.adams <at> oracle.com> writes:

> "Completion table that replaces the prefix S1 with S2 in STRING."

I applied the patch below.

Thanks,

[minibuffer.el.patch (text/x-patch, inline)]

=== modified file 'lisp/minibuffer.el'
--- lisp/minibuffer.el	2012-09-01 04:28:24 +0000
+++ lisp/minibuffer.el	2012-09-11 14:05:33 +0000
@@ -211,10 +211,10 @@
       (complete-with-action action table string pred))))
 
 (defun completion-table-subvert (table s1 s2)
-  "Completion table that replaces the prefix S1 with S2 in STRING.
+  "Return a completion table from TABLE with S1 replaced by S2.
 The result is a completion table which completes strings of the
-form (concat S1 S) in the same way as TABLE completes strings of
-the form (concat S2 S)."
+form (concat S2 S) in the same way as TABLE completes strings of
+the form (concat S1 S)."
   (lambda (string pred action)
     (let* ((str (if (eq t (compare-strings string 0 (length s1) s1 nil nil
                                            completion-ignore-case))

[Message part 3 (text/plain, inline)]

-- 
 Bastien

Message #13 received at 12347-done <at> debbugs.gnu.org (full text, mbox):

From: "Drew Adams" <drew.adams <at> oracle.com>
To: "'Bastien'" <bzg <at> altern.org>
Cc: 12347-done <at> debbugs.gnu.org
Subject: RE: bug#12347: 24.2.50; doc of `completion-table-subvert'
Date: Tue, 11 Sep 2012 07:28:18 -0700

> I applied the patch below.

Looks good; thanks.

Message #16 received at 12347 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Monnier <monnier <at> IRO.UMontreal.CA>
To: 12347 <at> debbugs.gnu.org
Cc: bzg <at> altern.org
Subject: Re: bug#12347: 24.2.50; doc of `completion-table-subvert'
Date: Tue, 11 Sep 2012 13:27:36 -0400

> -form (concat S1 S) in the same way as TABLE completes strings of
> -the form (concat S2 S)."
> +form (concat S2 S) in the same way as TABLE completes strings of
> +the form (concat S1 S)."

That's wrong.  Check the code: it's (concat S2 S), aka `str', which is
passed to TABLE, not (concat S1 S).


        Stefan

Message #19 received at 12347 <at> debbugs.gnu.org (full text, mbox):

From: Bastien <bzg <at> altern.org>
To: Stefan Monnier <monnier <at> IRO.UMontreal.CA>
Cc: 12347 <at> debbugs.gnu.org
Subject: Re: bug#12347: 24.2.50; doc of `completion-table-subvert'
Date: Tue, 11 Sep 2012 19:43:38 +0200

Stefan Monnier <monnier <at> IRO.UMontreal.CA> writes:

>> -form (concat S1 S) in the same way as TABLE completes strings of
>> -the form (concat S2 S)."
>> +form (concat S2 S) in the same way as TABLE completes strings of
>> +the form (concat S1 S)."
>
> That's wrong.  Check the code: it's (concat S2 S), aka `str', which is
> passed to TABLE, not (concat S1 S).

Indeed.  Fixed,

-- 
 Bastien

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.