From unknown Mon Aug 18 11:10:05 2025 X-Loop: help-debbugs@gnu.org Subject: bug#12345: 24.2.50; doc string of `text-scale-adjust' Resent-From: "Drew Adams" Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 04 Sep 2012 02:57:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 12345 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: 12345@debbugs.gnu.org X-Debbugs-Original-To: Received: via spool by submit@debbugs.gnu.org id=B.134672738732764 (code B ref -1); Tue, 04 Sep 2012 02:57:02 +0000 Received: (at submit) by debbugs.gnu.org; 4 Sep 2012 02:56:27 +0000 Received: from localhost ([127.0.0.1]:37311 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1T8jJS-0008WO-Ip for submit@debbugs.gnu.org; Mon, 03 Sep 2012 22:56:27 -0400 Received: from eggs.gnu.org ([208.118.235.92]:47606) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1T8jJO-0008WG-VP for submit@debbugs.gnu.org; Mon, 03 Sep 2012 22:56:23 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1T8jHq-0000Zk-BA for submit@debbugs.gnu.org; Mon, 03 Sep 2012 22:54:47 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_HI, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.2 Received: from lists.gnu.org ([208.118.235.17]:57257) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T8jHq-0000Zg-8T for submit@debbugs.gnu.org; Mon, 03 Sep 2012 22:54:46 -0400 Received: from eggs.gnu.org ([208.118.235.92]:33898) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T8jHp-00050Z-8Q for bug-gnu-emacs@gnu.org; Mon, 03 Sep 2012 22:54:46 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1T8jHo-0000ZR-D8 for bug-gnu-emacs@gnu.org; Mon, 03 Sep 2012 22:54:45 -0400 Received: from acsinet15.oracle.com ([141.146.126.227]:51481) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T8jHo-0000ZN-7I for bug-gnu-emacs@gnu.org; Mon, 03 Sep 2012 22:54:44 -0400 Received: from acsinet22.oracle.com (acsinet22.oracle.com [141.146.126.238]) by acsinet15.oracle.com (Sentrion-MTA-4.2.2/Sentrion-MTA-4.2.2) with ESMTP id q842sfxT012232 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Tue, 4 Sep 2012 02:54:42 GMT Received: from acsmt358.oracle.com (acsmt358.oracle.com [141.146.40.158]) by acsinet22.oracle.com (8.14.4+Sun/8.14.4) with ESMTP id q842sfi8010760 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO) for ; Tue, 4 Sep 2012 02:54:41 GMT Received: from abhmt112.oracle.com (abhmt112.oracle.com [141.146.116.64]) by acsmt358.oracle.com (8.12.11.20060308/8.12.11) with ESMTP id q842sfNi031226 for ; Mon, 3 Sep 2012 21:54:41 -0500 Received: from dradamslap1 (/71.202.147.44) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Mon, 03 Sep 2012 19:54:41 -0700 From: "Drew Adams" Date: Mon, 3 Sep 2012 19:54:25 -0700 Message-ID: <703AC3C70837474CADDB99BA7E9E59A1@us.oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Mailer: Microsoft Office Outlook 11 Thread-Index: Ac2KSJfDvpDRtQJ+Rn6iW7zxfzL9TA== X-MimeOLE: Produced By Microsoft MimeOLE V6.00.2900.6157 X-Source-IP: acsinet22.oracle.com [141.146.126.238] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 1) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-Received-From: 208.118.235.17 X-Spam-Score: -6.1 (------) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -6.1 (------) 1. Describe the parameter, INC. 2. Describe the use of a prefix argument. In general, describe this as a user command, from a user point of view, and not just as a function to be called from code. In GNU Emacs 24.2.50.1 (i386-mingw-nt5.1.2600) of 2012-09-02 on MARVIN Bzr revision: 109861 eggert@cs.ucla.edu-20120902171035-7mzihil3xd6bjfiy Windowing system distributor `Microsoft Corp.', version 5.1.2600 Configured using: `configure --with-gcc (4.6) --no-opt --enable-checking --cflags -ID:/devel/emacs/libs/libXpm-3.5.8/include -ID:/devel/emacs/libs/libXpm-3.5.8/src -ID:/devel/emacs/libs/libpng-dev_1.4.3-1/include -ID:/devel/emacs/libs/zlib-dev_1.2.5-2/include -ID:/devel/emacs/libs/giflib-4.1.4-1/include -ID:/devel/emacs/libs/jpeg-6b-4/include -ID:/devel/emacs/libs/tiff-3.8.2-1/include -ID:/devel/emacs/libs/gnutls-3.0.9/include -ID:/devel/emacs/libs/libiconv-1.13.1-1-dev/include -ID:/devel/emacs/libs/libxml2-2.7.8/include/libxml2' From unknown Mon Aug 18 11:10:05 2025 X-Loop: help-debbugs@gnu.org Subject: bug#12345: 24.2.50; doc string of `text-scale-adjust' Resent-From: Bastien Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 11 Sep 2012 13:39:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 12345 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: "Drew Adams" Cc: 12345@debbugs.gnu.org Received: via spool by 12345-submit@debbugs.gnu.org id=B12345.134737069620443 (code B ref 12345); Tue, 11 Sep 2012 13:39:01 +0000 Received: (at 12345) by debbugs.gnu.org; 11 Sep 2012 13:38:16 +0000 Received: from localhost ([127.0.0.1]:53874 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TBQfQ-0005Jf-3I for submit@debbugs.gnu.org; Tue, 11 Sep 2012 09:38:16 -0400 Received: from mail-wi0-f180.google.com ([209.85.212.180]:51617) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TBQfM-0005JX-N8 for 12345@debbugs.gnu.org; Tue, 11 Sep 2012 09:38:14 -0400 Received: by wibhm6 with SMTP id hm6so470006wib.15 for <12345@debbugs.gnu.org>; Tue, 11 Sep 2012 06:37:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:from:to:cc:subject:in-reply-to:references:user-agent:date :message-id:mime-version:content-type; bh=KG0aEMGV9DpDNYPf2KASWoAGjIzKnkBgLkrCOqZzy+g=; b=bvwz/4/jCLyxQepSKU/nnZESPvA8EiJMuqfTOmClTg/G6hLfDRbDK45WKQ93Y3Y56t xTFKPHDwWGlH7QHyCbl28sq4+/N9YAA4LQNii9EXBMN3nSVUbOI9Bidu535ps4UoI/Es piG4iOnJUwoieG+ZvLa/Hh8s9dLMPeKecHdXNujnonZqHZS4zMTHrYqK890KbZE8Bs7m eKZEXi2jZmB8mft/t5W5ZfT7WUDndoWEs75jeGrVMwkc5tz8c5SLT5bfCdJTka8F0Kru j1CEgK0m7ztCHD3P9qP1V+0BGlls9Z9jWO0ZIYE2pS2IMQMXRZNrndCrwm+rQuUHEuDr jNqw== Received: by 10.216.197.162 with SMTP id t34mr10872421wen.5.1347370651345; Tue, 11 Sep 2012 06:37:31 -0700 (PDT) Received: from myhost.localdomain (mar75-2-81-56-68-112.fbx.proxad.net. [81.56.68.112]) by mx.google.com with ESMTPS id w7sm2643943wiz.0.2012.09.11.06.37.29 (version=TLSv1/SSLv3 cipher=OTHER); Tue, 11 Sep 2012 06:37:30 -0700 (PDT) Received: by myhost.localdomain (Postfix, from userid 1000) id 2E69E89A2; Tue, 11 Sep 2012 15:37:31 +0200 (CEST) From: Bastien In-Reply-To: <703AC3C70837474CADDB99BA7E9E59A1@us.oracle.com> (Drew Adams's message of "Mon, 3 Sep 2012 19:54:25 -0700") References: <703AC3C70837474CADDB99BA7E9E59A1@us.oracle.com> User-Agent: Gnus/5.130006 (Ma Gnus v0.6) Emacs/24.2.50 (gnu/linux) Date: Tue, 11 Sep 2012 15:37:31 +0200 Message-ID: <87vcfkr884.fsf@altern.org> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Spam-Score: -2.6 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.6 (--) --=-=-= Content-Type: text/plain "Drew Adams" writes: > 1. Describe the parameter, INC. > > 2. Describe the use of a prefix argument. > > In general, describe this as a user command, from a user point of view, > and not just as a function to be called from code. See attached patch. I enhanced the docstring and rewrote the command so that it does not use a temporary keymap. When I tried `C-x C-+' I was left with the `+' and `-' keys not usable anymore. The patch also removes the redundant keybinding `C-x C-='. And C-x C-0 does not allow adjusting further. My feeling is that it is not useful. I'll apply this patch within a week if nobody is against it. --=-=-= Content-Type: text/x-patch Content-Disposition: attachment; filename=face-remap.el.patch === modified file 'lisp/face-remap.el' --- lisp/face-remap.el 2012-07-10 11:51:54 +0000 +++ lisp/face-remap.el 2012-09-11 13:18:59 +0000 @@ -281,22 +281,26 @@ ;;;###autoload (define-key ctl-x-map [(control ?+)] 'text-scale-adjust) ;;;###autoload (define-key ctl-x-map [(control ?-)] 'text-scale-adjust) -;;;###autoload (define-key ctl-x-map [(control ?=)] 'text-scale-adjust) ;;;###autoload (define-key ctl-x-map [(control ?0)] 'text-scale-adjust) ;;;###autoload -(defun text-scale-adjust (inc) - "Increase or decrease the height of the default face in the current buffer. +(defun text-scale-adjust (inc &optional mod) + "Adjust the height of the default face by INC. + +INC may be passed as a numeric prefix argument. + +The optional argument MOD is used internally to pass the previous +modifier to the command, when used repeatedly. The actual adjustment made depends on the final component of the -key-binding used to invoke the command, with all modifiers removed: +keybinding used to invoke the command. - +, = Increase the default face height by one step + + Increase the default face height by one step - Decrease the default face height by one step 0 Reset the default face height to the global default -Then, continue to read input events and further adjust the face -height as long as the input event read (with all modifiers removed) -is one of the above. +After the first invokation, continue to read input events and +further adjust the face height as long as the input event read +is `+' or `-'. Each step scales the height of the default face by the variable `text-scale-mode-step' (a negative number of steps decreases the @@ -309,30 +313,15 @@ a top-level keymap, `text-scale-increase' or `text-scale-decrease' may be more appropriate." (interactive "p") - (let ((first t) - (ev last-command-event) - (echo-keystrokes nil)) - (let* ((base (event-basic-type ev)) - (step - (pcase base - ((or ?+ ?=) inc) - (?- (- inc)) - (?0 0) - (t inc)))) - (text-scale-increase step) - ;; FIXME: do it after every "iteration of the loop". - (message "+,-,0 for further adjustment: ") - (set-temporary-overlay-map - (let ((map (make-sparse-keymap))) - (dolist (mods '(() (control))) - (define-key map (vector (append mods '(?-))) 'text-scale-decrease) - (define-key map (vector (append mods '(?+))) 'text-scale-increase) - ;; = is unshifted + on most keyboards. - (define-key map (vector (append mods '(?=))) 'text-scale-increase) - (define-key map (vector (append mods '(?0))) - (lambda () (interactive) (text-scale-increase 0)))) - map) - t)))) + (let* ((ev (or (event-basic-type (or mod last-command-event)))) + (step (pcase ev (?+ inc) (?- (- inc)) (?0 0) (t inc))) + c) + (text-scale-increase step) + (when (and (not (zerop step)) + (setq c (read-event "Hit + or - for further adjustment, RET to finish"))) + (cond ((member (event-basic-type c) '(?+ ?-)) + (text-scale-adjust (abs step) c)) + (t (message "Done")))))) ;; ---------------------------------------------------------------- --=-=-= Content-Type: text/plain -- Bastien --=-=-=-- From unknown Mon Aug 18 11:10:05 2025 X-Loop: help-debbugs@gnu.org Subject: bug#12345: 24.2.50; doc string of `text-scale-adjust' Resent-From: Stefan Monnier Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 11 Sep 2012 13:50:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 12345 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Bastien Cc: 12345@debbugs.gnu.org, Drew Adams Received: via spool by 12345-submit@debbugs.gnu.org id=B12345.134737135121430 (code B ref 12345); Tue, 11 Sep 2012 13:50:02 +0000 Received: (at 12345) by debbugs.gnu.org; 11 Sep 2012 13:49:11 +0000 Received: from localhost ([127.0.0.1]:53906 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TBQpy-0005Za-Of for submit@debbugs.gnu.org; Tue, 11 Sep 2012 09:49:10 -0400 Received: from ironport2-out.teksavvy.com ([206.248.154.182]:35597) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TBQpw-0005ZT-9Y for 12345@debbugs.gnu.org; Tue, 11 Sep 2012 09:49:08 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: Ai0FAG6Zu09soXr9/2dsb2JhbABEsEiDSYEIghUBAQQBViMFCws0EhQYDSSIHAW6CZBEA6MzgViDBYE6Gg X-IronPort-AV: E=Sophos;i="4.75,637,1330923600"; d="scan'208";a="198061066" Received: from 108-161-122-253.dsl.teksavvy.com (HELO pastel.home) ([108.161.122.253]) by ironport2-out.teksavvy.com with ESMTP/TLS/ADH-AES256-SHA; 11 Sep 2012 09:48:27 -0400 Received: by pastel.home (Postfix, from userid 20848) id C65C158CDE; Tue, 11 Sep 2012 09:48:26 -0400 (EDT) From: Stefan Monnier Message-ID: References: <703AC3C70837474CADDB99BA7E9E59A1@us.oracle.com> <87vcfkr884.fsf@altern.org> Date: Tue, 11 Sep 2012 09:48:26 -0400 In-Reply-To: <87vcfkr884.fsf@altern.org> (Bastien's message of "Tue, 11 Sep 2012 15:37:31 +0200") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.2.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -1.9 (-) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -1.9 (-) > I enhanced the docstring and rewrote the command so that it does > not use a temporary keymap. Not using a temporary keymap means reverting to the old code: please explain precisely why using a temporary keymap is a problem (there are good reasons to use it: e.g. it makes key-translation-map and friends work correctly). Stefan From unknown Mon Aug 18 11:10:05 2025 X-Loop: help-debbugs@gnu.org Subject: bug#12345: 24.2.50; doc string of `text-scale-adjust' Resent-From: "Drew Adams" Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 11 Sep 2012 14:26:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 12345 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: "'Bastien'" Cc: 12345@debbugs.gnu.org Received: via spool by 12345-submit@debbugs.gnu.org id=B12345.134737350225287 (code B ref 12345); Tue, 11 Sep 2012 14:26:02 +0000 Received: (at 12345) by debbugs.gnu.org; 11 Sep 2012 14:25:02 +0000 Received: from localhost ([127.0.0.1]:54777 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TBROg-0006Zn-08 for submit@debbugs.gnu.org; Tue, 11 Sep 2012 10:25:02 -0400 Received: from acsinet15.oracle.com ([141.146.126.227]:21179) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TBROe-0006ZP-2Y for 12345@debbugs.gnu.org; Tue, 11 Sep 2012 10:25:01 -0400 Received: from ucsinet22.oracle.com (ucsinet22.oracle.com [156.151.31.94]) by acsinet15.oracle.com (Sentrion-MTA-4.2.2/Sentrion-MTA-4.2.2) with ESMTP id q8BEOEIG014800 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Tue, 11 Sep 2012 14:24:15 GMT Received: from acsmt358.oracle.com (acsmt358.oracle.com [141.146.40.158]) by ucsinet22.oracle.com (8.14.4+Sun/8.14.4) with ESMTP id q8BEOCrn008493 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Tue, 11 Sep 2012 14:24:12 GMT Received: from abhmt116.oracle.com (abhmt116.oracle.com [141.146.116.68]) by acsmt358.oracle.com (8.12.11.20060308/8.12.11) with ESMTP id q8BEOCcr006129; Tue, 11 Sep 2012 09:24:12 -0500 Received: from dradamslap1 (/10.159.175.11) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Tue, 11 Sep 2012 07:24:11 -0700 From: "Drew Adams" References: <703AC3C70837474CADDB99BA7E9E59A1@us.oracle.com> <87vcfkr884.fsf@altern.org> Date: Tue, 11 Sep 2012 07:24:08 -0700 Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Mailer: Microsoft Office Outlook 11 In-Reply-To: <87vcfkr884.fsf@altern.org> X-MimeOLE: Produced By Microsoft MimeOLE V6.00.2900.6157 Thread-Index: Ac2QIpqPAZxTXg0aRA2iVAOy500stQAA4vrQ X-Source-IP: ucsinet22.oracle.com [156.151.31.94] X-Spam-Score: -7.2 (-------) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -7.2 (-------) Hi Bastien, 1. I think any changes in the behavior and bindings should be proposed on emacs-devel. Personally, I don't care much, but I'm pretty sure that at least some people will want to keep the `=' binding because `+' is often on a Shift key. Emacs-devel is also the place to pose your question about zero. 2. Please consider changing the name of the parameter to INCREMENT, so the doc string is more readable: "Adjust the height of the default face by INCREMENT." Say explicitly that INCREMENT defaults to 1. 3. Alternatively, you could say something like this: "Adjust the height of face `default' by N text-scale steps. N is the numeric prefix agument: positive to increase height, negative to decrease. Step size is the value of `text-scale-mode-step'." The rest is OK. 4. Don't be surprised if Stefan doesn't go along with your change to not use the temporary keymap. He just got through _adding_ such code here and there throughout Emacs. (Makes no difference to me - my bug report was about the doc string.) Thx - Drew > > 1. Describe the parameter, INC. > > 2. Describe the use of a prefix argument. > > In general, describe this as a user command, from a user > > point of view, and not just as a function to be called from code. > > See attached patch. > > I enhanced the docstring and rewrote the command so that it does > not use a temporary keymap. When I tried `C-x C-+' I was left with > the `+' and `-' keys not usable anymore. > > The patch also removes the redundant keybinding `C-x C-='. > > And C-x C-0 does not allow adjusting further. My feeling is that > it is not useful. > > I'll apply this patch within a week if nobody is against it. From unknown Mon Aug 18 11:10:05 2025 X-Loop: help-debbugs@gnu.org Subject: bug#12345: 24.2.50; doc string of `text-scale-adjust' Resent-From: Bastien Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 11 Sep 2012 14:26:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 12345 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Stefan Monnier Cc: 12345@debbugs.gnu.org Received: via spool by 12345-submit@debbugs.gnu.org id=B12345.134737351125306 (code B ref 12345); Tue, 11 Sep 2012 14:26:02 +0000 Received: (at 12345) by debbugs.gnu.org; 11 Sep 2012 14:25:11 +0000 Received: from localhost ([127.0.0.1]:54780 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TBROo-0006a6-TF for submit@debbugs.gnu.org; Tue, 11 Sep 2012 10:25:11 -0400 Received: from mail-wi0-f180.google.com ([209.85.212.180]:39679) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TBROl-0006Zy-QP for 12345@debbugs.gnu.org; Tue, 11 Sep 2012 10:25:08 -0400 Received: by wibhm6 with SMTP id hm6so528295wib.15 for <12345@debbugs.gnu.org>; Tue, 11 Sep 2012 07:24:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:from:to:cc:subject:in-reply-to:references:user-agent:date :message-id:mime-version:content-type; bh=AhDpddT9cBjotCUCjGGQosofvB24rwwjnYs20ZBmFWY=; b=iTCsLB7gCT5s2acbmYDBRUPzHBJeJ8e/AsbzgVrLFhI6zhTKDkftECvu4LSVpwm5yW JVuyZqJm90NMFdUR7ZNMt7InFQdT8UtCg/LuPNyHW9RsgBGntONub25FOBK1lkSQb0xP ETVWChkRul0NkRXfWRVduHA+BD9E3dZu53NmQJJ2fHncsN3ua2X9m+HQqTxtUE4eObRW pjyE5L4rkQOjJjcCfnwYTG6LmCTJFG/b35gpvC7pul71ADaoo5ov4zlHdJ0snskLM+ca lK1eWYqPabHBG928RsqWpHt1BKbXAS3+slcDmEVHEoeK39UwkYP2kp+80krDUD6nCeqo 3yrg== Received: by 10.216.242.204 with SMTP id i54mr10749745wer.114.1347373466265; Tue, 11 Sep 2012 07:24:26 -0700 (PDT) Received: from myhost.localdomain (mar75-2-81-56-68-112.fbx.proxad.net. [81.56.68.112]) by mx.google.com with ESMTPS id dp8sm4285967wib.3.2012.09.11.07.24.24 (version=TLSv1/SSLv3 cipher=OTHER); Tue, 11 Sep 2012 07:24:25 -0700 (PDT) Received: by myhost.localdomain (Postfix, from userid 1000) id E74D689A2; Tue, 11 Sep 2012 16:24:26 +0200 (CEST) From: Bastien In-Reply-To: (Stefan Monnier's message of "Tue, 11 Sep 2012 09:48:26 -0400") References: <703AC3C70837474CADDB99BA7E9E59A1@us.oracle.com> <87vcfkr884.fsf@altern.org> User-Agent: Gnus/5.130006 (Ma Gnus v0.6) Emacs/24.2.50 (gnu/linux) Date: Tue, 11 Sep 2012 16:24:26 +0200 Message-ID: <87ehm8r61x.fsf@altern.org> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.6 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.6 (--) Stefan Monnier writes: >> I enhanced the docstring and rewrote the command so that it does >> not use a temporary keymap. > > Not using a temporary keymap means reverting to the old code: please > explain precisely why using a temporary keymap is a problem (there are > good reasons to use it: e.g. it makes key-translation-map and friends > work correctly). The `read-event' loop allows to keep the message displayed (see the FIXME). But I hit something weird. from emacs -q, try to edebug-defun `text-scale-adjust', then use `C-x C-+', then `c' in the debug loop, then quit. The temporary keymap is not temporary anymore, and the `-' and `+' keys are still bounded to `text-scale-adjust'. Surely something weird when `set-temporary-overlay-map' is called from within a debug loop? -- Bastien From unknown Mon Aug 18 11:10:05 2025 X-Loop: help-debbugs@gnu.org Subject: bug#12345: 24.2.50; doc string of `text-scale-adjust' Resent-From: "Drew Adams" Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 11 Sep 2012 14:41:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 12345 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: "'Bastien'" , "'Stefan Monnier'" Cc: 12345@debbugs.gnu.org Received: via spool by 12345-submit@debbugs.gnu.org id=B12345.134737444026763 (code B ref 12345); Tue, 11 Sep 2012 14:41:01 +0000 Received: (at 12345) by debbugs.gnu.org; 11 Sep 2012 14:40:40 +0000 Received: from localhost ([127.0.0.1]:54796 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TBRdo-0006xc-El for submit@debbugs.gnu.org; Tue, 11 Sep 2012 10:40:40 -0400 Received: from acsinet15.oracle.com ([141.146.126.227]:40959) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TBRdi-0006xP-B4 for 12345@debbugs.gnu.org; Tue, 11 Sep 2012 10:40:35 -0400 Received: from ucsinet22.oracle.com (ucsinet22.oracle.com [156.151.31.94]) by acsinet15.oracle.com (Sentrion-MTA-4.2.2/Sentrion-MTA-4.2.2) with ESMTP id q8BEdnuf003542 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Tue, 11 Sep 2012 14:39:50 GMT Received: from acsmt358.oracle.com (acsmt358.oracle.com [141.146.40.158]) by ucsinet22.oracle.com (8.14.4+Sun/8.14.4) with ESMTP id q8BEdmuC013869 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Tue, 11 Sep 2012 14:39:48 GMT Received: from abhmt112.oracle.com (abhmt112.oracle.com [141.146.116.64]) by acsmt358.oracle.com (8.12.11.20060308/8.12.11) with ESMTP id q8BEdluI020139; Tue, 11 Sep 2012 09:39:47 -0500 Received: from dradamslap1 (/10.159.175.11) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Tue, 11 Sep 2012 07:39:47 -0700 From: "Drew Adams" References: <703AC3C70837474CADDB99BA7E9E59A1@us.oracle.com><87vcfkr884.fsf@altern.org> <87ehm8r61x.fsf@altern.org> Date: Tue, 11 Sep 2012 07:39:43 -0700 Message-ID: <3B9A6A891CD0485AAC47DEBD891BE144@us.oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Mailer: Microsoft Office Outlook 11 In-Reply-To: <87ehm8r61x.fsf@altern.org> X-MimeOLE: Produced By Microsoft MimeOLE V6.00.2900.6157 Thread-Index: Ac2QKU6UUluBcQ7UTyODXY4qzqyoAAAALRfA X-Source-IP: ucsinet22.oracle.com [156.151.31.94] X-Spam-Score: -7.2 (-------) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -7.2 (-------) > from emacs -q, try to edebug-defun `text-scale-adjust', > then use `C-x C-+', then `c' in the debug loop, then quit. > > The temporary keymap is not temporary anymore, and the `-' > and `+' keys are still bounded to `text-scale-adjust'. > > Surely something weird when `set-temporary-overlay-map' is > called from within a debug loop? Debugging is notoriously difficult when events are read. I usually have to resort to adding `message' calls or similar. See also bug (regression) #12232, which similarly was changed recently to use `set-temporary-overlay-map' (and to use lexical binding), and which since that change leads to the error "Lisp nesting exceeds `max-lisp-eval-depth'". No one has responded to that bug at all so far. I located the commit that introduced the regression, but debugging it further and fixing it is beyond me. From unknown Mon Aug 18 11:10:05 2025 X-Loop: help-debbugs@gnu.org Subject: bug#12345: 24.2.50; doc string of `text-scale-adjust' Resent-From: Bastien Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 11 Sep 2012 14:54:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 12345 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: "Drew Adams" Cc: 12345@debbugs.gnu.org Received: via spool by 12345-submit@debbugs.gnu.org id=B12345.134737523127962 (code B ref 12345); Tue, 11 Sep 2012 14:54:02 +0000 Received: (at 12345) by debbugs.gnu.org; 11 Sep 2012 14:53:51 +0000 Received: from localhost ([127.0.0.1]:54826 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TBRqX-0007Gw-No for submit@debbugs.gnu.org; Tue, 11 Sep 2012 10:53:50 -0400 Received: from mail-wg0-f46.google.com ([74.125.82.46]:52371) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TBRqU-0007Go-Rp for 12345@debbugs.gnu.org; Tue, 11 Sep 2012 10:53:47 -0400 Received: by wgi16 with SMTP id 16so422379wgi.15 for <12345@debbugs.gnu.org>; Tue, 11 Sep 2012 07:53:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:from:to:cc:subject:in-reply-to:references:user-agent:date :message-id:mime-version:content-type; bh=F8i2qEY1Hgfu3b3gK4BPbBFIPr7UWWtpJvz+SgQL3aY=; b=vQolJLGGdJcd3H8BToeYvAjcJ+YMD4scowW2g9imOqutxq4Z8GKrct3DKHwjxsWGAA MxWcjwSnxjiqfJz9rIjVp+81COzwzdF/33IJQI7z2bdBNTLacbOV3gWwadjSZHZYnXSe IkbhW4hU4t3dH3CXUT39BAFJMHhmBz0/abnwcUyDwD43HA8SjTjtVILSeHAowBkbvHIY BWmHN66cPXv7bZ93ISNvV90ZaX0txdQQlLiQEoHBEXG6Kf802i1npXOVr47dYBDrUHAH C5xCiCc0JwT5pKeepQSj1kyKUcKXrhrztnglUAKGxpmJZYT/0K82PqIlUt+qSwTRegID sNmg== Received: by 10.216.138.13 with SMTP id z13mr9960985wei.65.1347375185206; Tue, 11 Sep 2012 07:53:05 -0700 (PDT) Received: from myhost.localdomain (mar75-2-81-56-68-112.fbx.proxad.net. [81.56.68.112]) by mx.google.com with ESMTPS id bc2sm4457224wib.0.2012.09.11.07.53.03 (version=TLSv1/SSLv3 cipher=OTHER); Tue, 11 Sep 2012 07:53:04 -0700 (PDT) Received: by myhost.localdomain (Postfix, from userid 1000) id 348DA89A2; Tue, 11 Sep 2012 16:53:06 +0200 (CEST) From: Bastien In-Reply-To: (Drew Adams's message of "Tue, 11 Sep 2012 07:24:08 -0700") References: <703AC3C70837474CADDB99BA7E9E59A1@us.oracle.com> <87vcfkr884.fsf@altern.org> User-Agent: Gnus/5.130006 (Ma Gnus v0.6) Emacs/24.2.50 (gnu/linux) Date: Tue, 11 Sep 2012 16:53:06 +0200 Message-ID: <87txv4zk4t.fsf@altern.org> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.6 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.6 (--) Hi Drew, "Drew Adams" writes: > 1. I think any changes in the behavior and bindings should be proposed on > emacs-devel. Personally, I don't care much, but I'm pretty sure that at least > some people will want to keep the `=' binding because `+' is often on a Shift > key. Emacs-devel is also the place to pose your question about zero. Right, I will ask on emacs-devel. > 2. Please consider changing the name of the parameter to INCREMENT, so the doc > string is more readable: "Adjust the height of the default face by INCREMENT." > Say explicitly that INCREMENT defaults to 1. "INC" seems a rather standard and self-explanatory pet name for "INCREMENT". > 3. Alternatively, you could say something like this: > > "Adjust the height of face `default' by N text-scale steps. > N is the numeric prefix agument: positive to increase height, negative > to decrease. Step size is the value of `text-scale-mode-step'." Yes. > 4. Don't be surprised if Stefan doesn't go along with your change to not use the > temporary keymap. He just got through _adding_ such code here and there > throughout Emacs. (Makes no difference to me - my bug report was about the doc > string.) I've nothing against temporary keymaps -- I thought the buggy behavior I've found and reported was the default one, so I just implemented text-scale-adjust another way. Also, I think the (while ... read-event) construct is a simple way to keep the message displayed. But surely more a matter of taste than a technical point. Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 11 Sep 2012 16:29:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 12345 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Stefan Monnier Cc: 12345@debbugs.gnu.org Received: via spool by 12345-submit@debbugs.gnu.org id=B12345.13473809144036 (code B ref 12345); Tue, 11 Sep 2012 16:29:02 +0000 Received: (at 12345) by debbugs.gnu.org; 11 Sep 2012 16:28:34 +0000 Received: from localhost ([127.0.0.1]:54913 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TBTKE-000132-2b for submit@debbugs.gnu.org; Tue, 11 Sep 2012 12:28:34 -0400 Received: from mail-wg0-f46.google.com ([74.125.82.46]:59534) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TBTKC-00012v-8g for 12345@debbugs.gnu.org; Tue, 11 Sep 2012 12:28:33 -0400 Received: by wgi16 with SMTP id 16so492228wgi.15 for <12345@debbugs.gnu.org>; Tue, 11 Sep 2012 09:27:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:from:to:cc:subject:in-reply-to:references:user-agent:date :message-id:mime-version:content-type; bh=XmlOkLOPfoFVk9py2yyA5GUp5EJU08xwOZyoUl8HsbI=; b=LCXUMWpxp73iaxShjotiBMzB06Q+7PuZ9MDxQz82JLJJBYqUwRpQ37+QaC95BBpr9X ZEiww+2FvLILwruvyVbZmLXhHQ98gmf9cPJ/s7Cr2fRnCL3GoJ4Zp0+rXwFCrmk+asQj 3/rArrrwICcSZShIBXmTHbvrxdGxYmwlR/FwbrPZl+CMMfeYELGiLwOqC/Qk3dnn3+WA nxKGR1Ea5UKFAtL8VVVteYWEm9YFeFdDDZngLUCTQIYclkAyEQWZtlwbX028nSRqHVNC t2GEC7Uee3BjRe/Gt5w/xrwMAPtkK6HopSrIvBCp8+EdWqg5z72kN7mKfzzX3UMNFKu8 IxlA== Received: by 10.216.134.101 with SMTP id r79mr10180058wei.60.1347380869819; Tue, 11 Sep 2012 09:27:49 -0700 (PDT) Received: from myhost.localdomain (mar75-2-81-56-68-112.fbx.proxad.net. [81.56.68.112]) by mx.google.com with ESMTPS id eu4sm3263359wib.2.2012.09.11.09.27.47 (version=TLSv1/SSLv3 cipher=OTHER); Tue, 11 Sep 2012 09:27:47 -0700 (PDT) Received: by myhost.localdomain (Postfix, from userid 1000) id C98A689A2; Tue, 11 Sep 2012 18:27:50 +0200 (CEST) From: Bastien In-Reply-To: <87ehm8r61x.fsf@altern.org> (Bastien's message of "Tue, 11 Sep 2012 16:24:26 +0200") References: <703AC3C70837474CADDB99BA7E9E59A1@us.oracle.com> <87vcfkr884.fsf@altern.org> <87ehm8r61x.fsf@altern.org> User-Agent: Gnus/5.130006 (Ma Gnus v0.6) Emacs/24.2.50 (gnu/linux) Date: Tue, 11 Sep 2012 18:27:50 +0200 Message-ID: <87pq5smsmx.fsf@altern.org> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.6 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.6 (--) Bastien writes: > from emacs -q, try to edebug-defun `text-scale-adjust', > then use `C-x C-+', then `c' in the debug loop, then quit. > > The temporary keymap is not temporary anymore, and the `-' > and `+' keys are still bounded to `text-scale-adjust'. I've been digging a bit further: in general, using `edebug-defun' on any command that uses `set-temporary-overlay-map' will leave the `pre-command-hook' in a dirty state. One brute-force solution is to (setq emulation-mode-map-alists nil) manually to get rid of the temporary overlay map, but that's not right. -- Bastien From unknown Mon Aug 18 11:10:05 2025 X-Loop: help-debbugs@gnu.org Subject: bug#12345: 24.2.50; doc string of `text-scale-adjust' Resent-From: Stefan Monnier Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 11 Sep 2012 17:23:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 12345 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Bastien Cc: 12345@debbugs.gnu.org Received: via spool by 12345-submit@debbugs.gnu.org id=B12345.13473841599230 (code B ref 12345); Tue, 11 Sep 2012 17:23:01 +0000 Received: (at 12345) by debbugs.gnu.org; 11 Sep 2012 17:22:39 +0000 Received: from localhost ([127.0.0.1]:54993 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TBUAX-0002Om-Cx for submit@debbugs.gnu.org; Tue, 11 Sep 2012 13:22:38 -0400 Received: from chene.dit.umontreal.ca ([132.204.246.20]:41249) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TBUAQ-0002OX-OM for 12345@debbugs.gnu.org; Tue, 11 Sep 2012 13:22:35 -0400 Received: from faina.iro.umontreal.ca (lechon.iro.umontreal.ca [132.204.27.242]) by chene.dit.umontreal.ca (8.14.1/8.14.1) with ESMTP id q8BHLjtU010521; Tue, 11 Sep 2012 13:21:45 -0400 Received: by faina.iro.umontreal.ca (Postfix, from userid 20848) id 1A096B4085; Tue, 11 Sep 2012 13:21:45 -0400 (EDT) From: Stefan Monnier Message-ID: References: <703AC3C70837474CADDB99BA7E9E59A1@us.oracle.com> <87vcfkr884.fsf@altern.org> <87ehm8r61x.fsf@altern.org> Date: Tue, 11 Sep 2012 13:21:44 -0400 In-Reply-To: <87ehm8r61x.fsf@altern.org> (Bastien's message of "Tue, 11 Sep 2012 16:24:26 +0200") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.1.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -3.9 (---) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -3.9 (---) > from emacs -q, try to edebug-defun `text-scale-adjust', > then use `C-x C-+', then `c' in the debug loop, then quit. > The temporary keymap is not temporary anymore, and the `-' > and `+' keys are still bounded to `text-scale-adjust'. Can you the patch below? Stefan === modified file 'lisp/subr.el' --- lisp/subr.el 2012-09-07 10:19:58 +0000 +++ lisp/subr.el 2012-09-11 17:20:45 +0000 @@ -3898,6 +3898,7 @@ (lookup-key ',map (this-command-keys-vector)))) (t `(funcall ',keep-pred))) + (set ',overlaysym nil) (remove-hook 'pre-command-hook ',clearfunsym) (setq emulation-mode-map-alists (delq ',alist emulation-mode-map-alists)))))) From unknown Mon Aug 18 11:10:05 2025 X-Loop: help-debbugs@gnu.org Subject: bug#12345: 24.2.50; doc string of `text-scale-adjust' Resent-From: Bastien Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 11 Sep 2012 17:33:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 12345 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Stefan Monnier Cc: 12345@debbugs.gnu.org Received: via spool by 12345-submit@debbugs.gnu.org id=B12345.134738472713479 (code B ref 12345); Tue, 11 Sep 2012 17:33:01 +0000 Received: (at 12345) by debbugs.gnu.org; 11 Sep 2012 17:32:07 +0000 Received: from localhost ([127.0.0.1]:55012 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TBUJh-0003VK-Ta for submit@debbugs.gnu.org; Tue, 11 Sep 2012 13:32:06 -0400 Received: from mail-wi0-f180.google.com ([209.85.212.180]:38208) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TBUJg-0003VD-0R for 12345@debbugs.gnu.org; Tue, 11 Sep 2012 13:32:04 -0400 Received: by wibhm6 with SMTP id hm6so747521wib.15 for <12345@debbugs.gnu.org>; Tue, 11 Sep 2012 10:31:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:from:to:cc:subject:in-reply-to:references:user-agent:date :message-id:mime-version:content-type; bh=UatgxqWJM5D7HgB5EEPpqmQ1Gc0TrQKANVISKCCvxtk=; b=thpz/NYdR4KcvcKgGvyEH61+SyOF34NjDMjFEPqosFlIjbQ1D/gKpZgxRHbWknagVE LJKyEs64MNwqF5ENsZOtxkoQfvxTJ7FzlgVdmbBh9t/cEOx3ZbJGhAPjFZNNsTGjFyLo CKI6lwc1XLaRuBGi8KJMpq+6++gdgc7IITEW2Faks+vcvoKOlGOG/KQTVzXrXl97N9SU cUpxqi49RMuelTKbrtYpiYwK11UuR/N8P/AoeqiQ0xP8RagjkwkrXUKTNRmXqJT/d4Es GZXeXn4oOg1M1Z3A+r+fqgvpVV5bBoEB3guURm43v3Mm41WT3u7dKPBl4fjXUiAnyYib TnKw== Received: by 10.180.100.35 with SMTP id ev3mr26588172wib.7.1347384681849; Tue, 11 Sep 2012 10:31:21 -0700 (PDT) Received: from myhost.localdomain (mar75-2-81-56-68-112.fbx.proxad.net. [81.56.68.112]) by mx.google.com with ESMTPS id k2sm5325675wiz.7.2012.09.11.10.31.20 (version=TLSv1/SSLv3 cipher=OTHER); Tue, 11 Sep 2012 10:31:20 -0700 (PDT) Received: by myhost.localdomain (Postfix, from userid 1000) id 5B41389A2; Tue, 11 Sep 2012 19:31:23 +0200 (CEST) From: Bastien In-Reply-To: (Stefan Monnier's message of "Tue, 11 Sep 2012 13:21:44 -0400") References: <703AC3C70837474CADDB99BA7E9E59A1@us.oracle.com> <87vcfkr884.fsf@altern.org> <87ehm8r61x.fsf@altern.org> User-Agent: Gnus/5.130006 (Ma Gnus v0.6) Emacs/24.2.50 (gnu/linux) Date: Tue, 11 Sep 2012 19:31:23 +0200 Message-ID: <87mx0wihzo.fsf@altern.org> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.6 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.6 (--) Stefan Monnier writes: >> from emacs -q, try to edebug-defun `text-scale-adjust', >> then use `C-x C-+', then `c' in the debug loop, then quit. >> The temporary keymap is not temporary anymore, and the `-' >> and `+' keys are still bounded to `text-scale-adjust'. > > Can you the patch below? I tested it and it does not work for me. -- Bastien From unknown Mon Aug 18 11:10:05 2025 X-Loop: help-debbugs@gnu.org Subject: bug#12345: 24.2.50; doc string of `text-scale-adjust' Resent-From: Bastien Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 11 Sep 2012 17:38:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 12345 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Stefan Monnier Cc: 12345@debbugs.gnu.org Received: via spool by 12345-submit@debbugs.gnu.org id=B12345.134738506214091 (code B ref 12345); Tue, 11 Sep 2012 17:38:01 +0000 Received: (at 12345) by debbugs.gnu.org; 11 Sep 2012 17:37:42 +0000 Received: from localhost ([127.0.0.1]:55034 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TBUP8-0003fD-3S for submit@debbugs.gnu.org; Tue, 11 Sep 2012 13:37:42 -0400 Received: from mail-wi0-f180.google.com ([209.85.212.180]:60197) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TBUP5-0003ew-8I for 12345@debbugs.gnu.org; Tue, 11 Sep 2012 13:37:40 -0400 Received: by wibhm6 with SMTP id hm6so753503wib.15 for <12345@debbugs.gnu.org>; Tue, 11 Sep 2012 10:36:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:from:to:cc:subject:in-reply-to:references:user-agent:date :message-id:mime-version:content-type; bh=nkhRJ1U6Nd8PtFbOPm8J9dZ59qD6tr3yZSrjCvuV/Qw=; b=Z3fxrvY+R3/a9TxODe51++ZzLaR+07bp51An0aD6VVqKgomFfwVd4yF3t8zPZh+0z5 VI0LmksO4zJn39Z46E/jtfyoEz5mjzxL5yhBM6PEt/Ht6G1UCW/iR9Wmob0c6ehcX3Hx U0q3Bx5NrgU8aNFXdiFw0Dth+D0Jd6yO+BWP36PDw6ga4EoZjNm7qOldGJlK9eo7ZibC DuJhNnc8cTm5i2mi6HtkU7zcfuo34nIbX3c1rOJ6tbzm2D/yvPFnL5cbX+cV4mnn+tVe nNipchLmCQtodO+na+AulGZ5s66AdvJ03XKt4v06qtL9ptZbXIaQLCsWUgolHqSRU/Xl qk0Q== Received: by 10.180.109.129 with SMTP id hs1mr26680246wib.0.1347385017205; Tue, 11 Sep 2012 10:36:57 -0700 (PDT) Received: from myhost.localdomain (mar75-2-81-56-68-112.fbx.proxad.net. [81.56.68.112]) by mx.google.com with ESMTPS id j6sm5371345wiy.4.2012.09.11.10.36.55 (version=TLSv1/SSLv3 cipher=OTHER); Tue, 11 Sep 2012 10:36:55 -0700 (PDT) Received: by myhost.localdomain (Postfix, from userid 1000) id 4B9C389A2; Tue, 11 Sep 2012 19:36:57 +0200 (CEST) From: Bastien In-Reply-To: (Stefan Monnier's message of "Tue, 11 Sep 2012 09:48:26 -0400") References: <703AC3C70837474CADDB99BA7E9E59A1@us.oracle.com> <87vcfkr884.fsf@altern.org> User-Agent: Gnus/5.130006 (Ma Gnus v0.6) Emacs/24.2.50 (gnu/linux) Date: Tue, 11 Sep 2012 19:36:56 +0200 Message-ID: <87ipbkihqf.fsf@altern.org> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Spam-Score: -2.6 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.6 (--) --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Stefan Monnier writes: >> I enhanced the docstring and rewrote the command so that it does >> not use a temporary keymap. > > Not using a temporary keymap means reverting to the old code: please > explain precisely why using a temporary keymap is a problem (there are > good reasons to use it: e.g. it makes key-translation-map and friends > work correctly). Here is another patch, using ̀set-temporary-overlay-map'. It fixes the problem with the message disappearing. It fixed another problem: the fact that in the current version, INC is always 1 when using the command repeatedly, as we would expect C-u 4 C-x C-+ + to increase by INC = 4 then again by INC = 4 again -- right now it increase by INC = 4 on the first hit, then INC = 1 on the second. It also changes the behavior regarding C-x C-0, which ends the loop. Let me know what you think, --=-=-= Content-Type: text/x-patch Content-Disposition: attachment; filename=face-remap.el.2.patch === modified file 'lisp/face-remap.el' --- lisp/face-remap.el 2012-07-10 11:51:54 +0000 +++ lisp/face-remap.el 2012-09-11 17:20:16 +0000 @@ -285,7 +285,9 @@ ;;;###autoload (define-key ctl-x-map [(control ?0)] 'text-scale-adjust) ;;;###autoload (defun text-scale-adjust (inc) - "Increase or decrease the height of the default face in the current buffer. + "Adjust the height of the default face by INC. + +INC may be passed as a numeric prefix argument. The actual adjustment made depends on the final component of the key-binding used to invoke the command, with all modifiers removed: @@ -294,9 +296,11 @@ - Decrease the default face height by one step 0 Reset the default face height to the global default -Then, continue to read input events and further adjust the face -height as long as the input event read (with all modifiers removed) -is one of the above. +When adjusting with `+' or `-', continue to read input events and +further adjust the face height as long as the input event read +\(with all modifiers removed) is `+' or `-'. + +When adjusting with `0', immediately finish. Each step scales the height of the default face by the variable `text-scale-mode-step' (a negative number of steps decreases the @@ -309,8 +313,7 @@ a top-level keymap, `text-scale-increase' or `text-scale-decrease' may be more appropriate." (interactive "p") - (let ((first t) - (ev last-command-event) + (let ((ev last-command-event) (echo-keystrokes nil)) (let* ((base (event-basic-type ev)) (step @@ -320,23 +323,16 @@ (?0 0) (t inc)))) (text-scale-increase step) - ;; FIXME: do it after every "iteration of the loop". - (message "+,-,0 for further adjustment: ") - (set-temporary-overlay-map - (let ((map (make-sparse-keymap))) - (dolist (mods '(() (control))) - (define-key map (vector (append mods '(?-))) 'text-scale-decrease) - (define-key map (vector (append mods '(?+))) 'text-scale-increase) - ;; = is unshifted + on most keyboards. - (define-key map (vector (append mods '(?=))) 'text-scale-increase) - (define-key map (vector (append mods '(?0))) - (lambda () (interactive) (text-scale-increase 0)))) - map) - t)))) - - -;; ---------------------------------------------------------------- -;; buffer-face-mode + (unless (zerop step) + (message "Use + or - for further adjustment") + (set-temporary-overlay-map + (let ((map (make-sparse-keymap))) + (dolist (mods '(() (control))) + (dolist (key '(?- ?+ ?=)) + (define-key map (vector (append mods (list key))) + `(lambda () (interactive) (text-scale-adjust (abs ,step)))))) + map) + t))))) (defcustom buffer-face-mode-face 'variable-pitch "The face specification used by `buffer-face-mode'. --=-=-= Content-Type: text/plain -- Bastien --=-=-=-- From unknown Mon Aug 18 11:10:05 2025 X-Loop: help-debbugs@gnu.org Subject: bug#12345: 24.2.50; doc string of `text-scale-adjust' Resent-From: Stefan Monnier Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 12 Sep 2012 13:14:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 12345 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Bastien Cc: 12345@debbugs.gnu.org Received: via spool by 12345-submit@debbugs.gnu.org id=B12345.13474556401099 (code B ref 12345); Wed, 12 Sep 2012 13:14:02 +0000 Received: (at 12345) by debbugs.gnu.org; 12 Sep 2012 13:14:00 +0000 Received: from localhost ([127.0.0.1]:56204 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TBmlU-0000Hg-Cn for submit@debbugs.gnu.org; Wed, 12 Sep 2012 09:14:00 -0400 Received: from ironport2-out.teksavvy.com ([206.248.154.182]:7373) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TBmlS-0000HZ-Au for 12345@debbugs.gnu.org; Wed, 12 Sep 2012 09:13:58 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: Ai0FAG6Zu09FpYjU/2dsb2JhbABEsEiDSYEIghUBAQQBViMFCws0EhQYDSSIHAW6CZBEA6MzgViDBYE6Gg X-IronPort-AV: E=Sophos;i="4.75,637,1330923600"; d="scan'208";a="198143412" Received: from 69-165-136-212.dsl.teksavvy.com (HELO pastel.home) ([69.165.136.212]) by ironport2-out.teksavvy.com with ESMTP/TLS/ADH-AES256-SHA; 12 Sep 2012 09:13:11 -0400 Received: by pastel.home (Postfix, from userid 20848) id CC70A58D42; Wed, 12 Sep 2012 09:13:10 -0400 (EDT) From: Stefan Monnier Message-ID: References: <703AC3C70837474CADDB99BA7E9E59A1@us.oracle.com> <87vcfkr884.fsf@altern.org> <87ehm8r61x.fsf@altern.org> Date: Wed, 12 Sep 2012 09:13:10 -0400 In-Reply-To: <87ehm8r61x.fsf@altern.org> (Bastien's message of "Tue, 11 Sep 2012 16:24:26 +0200") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.2.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -1.9 (-) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -1.9 (-) > from emacs -q, try to edebug-defun `text-scale-adjust', > then use `C-x C-+', then `c' in the debug loop, then quit. > The temporary keymap is not temporary anymore, and the `-' > and `+' keys are still bounded to `text-scale-adjust'. There was a bug in edebug.el's handling of pre/post-command-hook. I just fixed it and it fixes your above recipe. Thanks for that recipe, BTW. Stefan "haven't looked at your patch yet, sorry" From unknown Mon Aug 18 11:10:05 2025 X-Loop: help-debbugs@gnu.org Subject: bug#12345: 24.2.50; doc string of `text-scale-adjust' Resent-From: Bastien Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 12 Sep 2012 13:53:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 12345 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Stefan Monnier Cc: 12345@debbugs.gnu.org Received: via spool by 12345-submit@debbugs.gnu.org id=B12345.13474579794410 (code B ref 12345); Wed, 12 Sep 2012 13:53:02 +0000 Received: (at 12345) by debbugs.gnu.org; 12 Sep 2012 13:52:59 +0000 Received: from localhost ([127.0.0.1]:56232 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TBnNC-000195-MR for submit@debbugs.gnu.org; Wed, 12 Sep 2012 09:52:58 -0400 Received: from mail-wg0-f46.google.com ([74.125.82.46]:64936) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TBnNB-00018y-46 for 12345@debbugs.gnu.org; Wed, 12 Sep 2012 09:52:58 -0400 Received: by wgi16 with SMTP id 16so166824wgi.15 for <12345@debbugs.gnu.org>; Wed, 12 Sep 2012 06:52:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:from:to:cc:subject:in-reply-to:references:user-agent:date :message-id:mime-version:content-type; bh=hRmvZdDpTUsvVMhhsQ+SClFoysK4VV4HSXBgsqRxVsM=; b=IIjyjwWIv6E5Ze20qoysJqIHX1CoQ160Ugi+rp+HpPeSBqQ28EwUQi+4GUHHbIadKA rhF8b77e9dvz9cPUCm/MFfx6FdrA+ZwNGAP6cmZntrp3/pRWxXHenOH0o7BYgqmZ5/lQ RyT75sfNjj0NkxbtYNvICVLSlXw/GupHa4rutinR776oJzpddWugBIGMrjwtFhjwyWoL y9R1uQyqSC0RjW0U/E//SLsC9S6+ThhRlE+6J121R97WURTGmWyd1jqhnYMRxRW/jtCI DPSc0GFziW9uAEhV93G3mj9PErPt9heIZMqMVhHNOEti3cFQE555K4fzqBjXLz1hGwot T2nA== Received: by 10.180.95.193 with SMTP id dm1mr32980979wib.10.1347457930173; Wed, 12 Sep 2012 06:52:10 -0700 (PDT) Received: from myhost.localdomain (mar75-2-81-56-68-112.fbx.proxad.net. [81.56.68.112]) by mx.google.com with ESMTPS id do5sm12344171wib.10.2012.09.12.06.52.08 (version=TLSv1/SSLv3 cipher=OTHER); Wed, 12 Sep 2012 06:52:09 -0700 (PDT) Received: by myhost.localdomain (Postfix, from userid 1000) id CC3D089A2; Wed, 12 Sep 2012 15:52:08 +0200 (CEST) From: Bastien In-Reply-To: (Stefan Monnier's message of "Wed, 12 Sep 2012 09:13:10 -0400") References: <703AC3C70837474CADDB99BA7E9E59A1@us.oracle.com> <87vcfkr884.fsf@altern.org> <87ehm8r61x.fsf@altern.org> User-Agent: Gnus/5.130006 (Ma Gnus v0.6) Emacs/24.2.50 (gnu/linux) Date: Wed, 12 Sep 2012 15:52:08 +0200 Message-ID: <878vcfz6uv.fsf@altern.org> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.6 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.6 (--) Stefan Monnier writes: >> from emacs -q, try to edebug-defun `text-scale-adjust', >> then use `C-x C-+', then `c' in the debug loop, then quit. >> The temporary keymap is not temporary anymore, and the `-' >> and `+' keys are still bounded to `text-scale-adjust'. > > There was a bug in edebug.el's handling of pre/post-command-hook. > I just fixed it and it fixes your above recipe. > Thanks for that recipe, BTW. Glad I could help. > Stefan "haven't looked at your patch yet, sorry" Nothing urgent at all, -- Bastien From unknown Mon Aug 18 11:10:05 2025 X-Loop: help-debbugs@gnu.org Subject: bug#12345: 24.2.50; doc string of `text-scale-adjust' Resent-From: "Drew Adams" Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 12 Sep 2012 14:18:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 12345 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: "'Stefan Monnier'" , "'Bastien'" Cc: 12345@debbugs.gnu.org Received: via spool by 12345-submit@debbugs.gnu.org id=B12345.13474594727471 (code B ref 12345); Wed, 12 Sep 2012 14:18:02 +0000 Received: (at 12345) by debbugs.gnu.org; 12 Sep 2012 14:17:52 +0000 Received: from localhost ([127.0.0.1]:57133 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TBnlH-0001wR-OC for submit@debbugs.gnu.org; Wed, 12 Sep 2012 10:17:52 -0400 Received: from rcsinet15.oracle.com ([148.87.113.117]:40837) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TBnlF-0001wJ-K8 for 12345@debbugs.gnu.org; Wed, 12 Sep 2012 10:17:50 -0400 Received: from acsinet21.oracle.com (acsinet21.oracle.com [141.146.126.237]) by rcsinet15.oracle.com (Sentrion-MTA-4.2.2/Sentrion-MTA-4.2.2) with ESMTP id q8CEH0q0011421 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Wed, 12 Sep 2012 14:17:01 GMT Received: from acsmt357.oracle.com (acsmt357.oracle.com [141.146.40.157]) by acsinet21.oracle.com (8.14.4+Sun/8.14.4) with ESMTP id q8CEH0sC006588 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Wed, 12 Sep 2012 14:17:00 GMT Received: from abhmt102.oracle.com (abhmt102.oracle.com [141.146.116.54]) by acsmt357.oracle.com (8.12.11.20060308/8.12.11) with ESMTP id q8CEH0lt016360; Wed, 12 Sep 2012 09:17:00 -0500 Received: from dradamslap1 (/10.159.176.30) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Wed, 12 Sep 2012 07:16:59 -0700 From: "Drew Adams" References: <703AC3C70837474CADDB99BA7E9E59A1@us.oracle.com><87vcfkr884.fsf@altern.org> <87ehm8r61x.fsf@altern.org> Date: Wed, 12 Sep 2012 07:16:52 -0700 Message-ID: <8A73A81719BB46109B8B9AD938C5D993@us.oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Mailer: Microsoft Office Outlook 11 In-Reply-To: Thread-Index: Ac2Q6GcXd+LToN0UTf6qryiuqLGSJwACJ4Rw X-MimeOLE: Produced By Microsoft MimeOLE V6.00.2900.6157 X-Source-IP: acsinet21.oracle.com [141.146.126.237] X-Spam-Score: -7.3 (-------) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -7.3 (-------) > > from emacs -q, try to edebug-defun `text-scale-adjust', > > then use `C-x C-+', then `c' in the debug loop, then quit. > > The temporary keymap is not temporary anymore, and the `-' > > and `+' keys are still bounded to `text-scale-adjust'. > > There was a bug in edebug.el's handling of pre/post-command-hook. > I just fixed it and it fixes your above recipe. Do you think that fix might also help with bug #12232? That would be great. From unknown Mon Aug 18 11:10:05 2025 X-Loop: help-debbugs@gnu.org Subject: bug#12345: 24.2.50; doc string of `text-scale-adjust' Resent-From: Stefan Monnier Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 13 Sep 2012 03:20:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 12345 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: "Drew Adams" Cc: 'Bastien' , 12345@debbugs.gnu.org Received: via spool by 12345-submit@debbugs.gnu.org id=B12345.13475063812980 (code B ref 12345); Thu, 13 Sep 2012 03:20:02 +0000 Received: (at 12345) by debbugs.gnu.org; 13 Sep 2012 03:19:41 +0000 Received: from localhost ([127.0.0.1]:58302 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TBzxs-0000m1-Rw for submit@debbugs.gnu.org; Wed, 12 Sep 2012 23:19:40 -0400 Received: from ironport2-out.teksavvy.com ([206.248.154.182]:16705) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TBzxr-0000lv-OR for 12345@debbugs.gnu.org; Wed, 12 Sep 2012 23:19:39 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: Ai0FAG6Zu09FpYjU/2dsb2JhbABEsEiDSYEIghUBAQQBViMFCws0EhQYDSSIHAW6CZBEA6MzgViDBQ X-IronPort-AV: E=Sophos;i="4.75,637,1330923600"; d="scan'208";a="198217811" Received: from 69-165-136-212.dsl.teksavvy.com (HELO pastel.home) ([69.165.136.212]) by ironport2-out.teksavvy.com with ESMTP/TLS/ADH-AES256-SHA; 12 Sep 2012 23:18:49 -0400 Received: by pastel.home (Postfix, from userid 20848) id 8807259445; Wed, 12 Sep 2012 23:18:49 -0400 (EDT) From: Stefan Monnier Message-ID: References: <703AC3C70837474CADDB99BA7E9E59A1@us.oracle.com> <87vcfkr884.fsf@altern.org> <87ehm8r61x.fsf@altern.org> <8A73A81719BB46109B8B9AD938C5D993@us.oracle.com> Date: Wed, 12 Sep 2012 23:18:49 -0400 In-Reply-To: <8A73A81719BB46109B8B9AD938C5D993@us.oracle.com> (Drew Adams's message of "Wed, 12 Sep 2012 07:16:52 -0700") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.2.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -1.9 (-) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -1.9 (-) > Do you think that fix might also help with bug #12232? No, my fix only touches edebug.el which isn't even loaded in your examples. Sefan From unknown Mon Aug 18 11:10:05 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.428 (Entity 5.428) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: "Drew Adams" Subject: bug#12345: closed (Re: bug#12345: 24.2.50; doc string of `text-scale-adjust') Message-ID: References: <703AC3C70837474CADDB99BA7E9E59A1@us.oracle.com> X-Gnu-PR-Message: they-closed 12345 X-Gnu-PR-Package: emacs Reply-To: 12345@debbugs.gnu.org Date: Fri, 26 Oct 2012 17:15:02 +0000 Content-Type: multipart/mixed; boundary="----------=_1351271702-28194-1" This is a multi-part message in MIME format... ------------=_1351271702-28194-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #12345: 24.2.50; doc string of `text-scale-adjust' which was filed against the emacs package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 12345@debbugs.gnu.org. --=20 12345: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D12345 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1351271702-28194-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 12345-done) by debbugs.gnu.org; 26 Oct 2012 17:15:00 +0000 Received: from localhost ([127.0.0.1]:35033 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TRnUq-0007KU-6p for submit@debbugs.gnu.org; Fri, 26 Oct 2012 13:15:00 -0400 Received: from ironport2-out.teksavvy.com ([206.248.154.182]:9927) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TRnUo-0007KN-Gz for 12345-done@debbugs.gnu.org; Fri, 26 Oct 2012 13:14:58 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: Ai8FAG6Zu0/O+LFW/2dsb2JhbABEhS2rG4NJgQiCFQEBBAEjMyMFCwsaAhgOAgIUGA0kiBwFpw6Se4EmjgqBFAOjM4FYgwWBOho X-IronPort-AV: E=Sophos;i="4.75,637,1330923600"; d="scan'208";a="202925044" Received: from 206-248-177-86.dsl.teksavvy.com (HELO pastel.home) ([206.248.177.86]) by ironport2-out.teksavvy.com with ESMTP/TLS/ADH-AES256-SHA; 26 Oct 2012 13:12:48 -0400 Received: by pastel.home (Postfix, from userid 20848) id 50EB95940A; Fri, 26 Oct 2012 13:12:47 -0400 (EDT) From: Stefan Monnier To: Bastien Subject: Re: bug#12345: 24.2.50; doc string of `text-scale-adjust' Message-ID: References: <703AC3C70837474CADDB99BA7E9E59A1@us.oracle.com> <87vcfkr884.fsf@altern.org> <87ipbkihqf.fsf@altern.org> Date: Fri, 26 Oct 2012 13:12:47 -0400 In-Reply-To: <87ipbkihqf.fsf@altern.org> (Bastien's message of "Tue, 11 Sep 2012 19:36:56 +0200") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.2.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.8 (/) X-Debbugs-Envelope-To: 12345-done Cc: 12345-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: 0.8 (/) > Here is another patch, using =CC=80set-temporary-overlay-map'. Thanks, I installed it with a few tweaks. > It also changes the behavior regarding C-x C-0, which ends > the loop. I did not include this change. I'm not really opposed to it, except for the fact that it makes it necessary to have (and remember) the C-x C-0 binding, whereas I like to use C-x C-+ as "entry point" even if I don't actually want to increase the text size but instead reset it to its default or decrease it. Stefan ------------=_1351271702-28194-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 4 Sep 2012 02:56:27 +0000 Received: from localhost ([127.0.0.1]:37311 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1T8jJS-0008WO-Ip for submit@debbugs.gnu.org; Mon, 03 Sep 2012 22:56:27 -0400 Received: from eggs.gnu.org ([208.118.235.92]:47606) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1T8jJO-0008WG-VP for submit@debbugs.gnu.org; Mon, 03 Sep 2012 22:56:23 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1T8jHq-0000Zk-BA for submit@debbugs.gnu.org; Mon, 03 Sep 2012 22:54:47 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_HI, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.2 Received: from lists.gnu.org ([208.118.235.17]:57257) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T8jHq-0000Zg-8T for submit@debbugs.gnu.org; Mon, 03 Sep 2012 22:54:46 -0400 Received: from eggs.gnu.org ([208.118.235.92]:33898) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T8jHp-00050Z-8Q for bug-gnu-emacs@gnu.org; Mon, 03 Sep 2012 22:54:46 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1T8jHo-0000ZR-D8 for bug-gnu-emacs@gnu.org; Mon, 03 Sep 2012 22:54:45 -0400 Received: from acsinet15.oracle.com ([141.146.126.227]:51481) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T8jHo-0000ZN-7I for bug-gnu-emacs@gnu.org; Mon, 03 Sep 2012 22:54:44 -0400 Received: from acsinet22.oracle.com (acsinet22.oracle.com [141.146.126.238]) by acsinet15.oracle.com (Sentrion-MTA-4.2.2/Sentrion-MTA-4.2.2) with ESMTP id q842sfxT012232 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Tue, 4 Sep 2012 02:54:42 GMT Received: from acsmt358.oracle.com (acsmt358.oracle.com [141.146.40.158]) by acsinet22.oracle.com (8.14.4+Sun/8.14.4) with ESMTP id q842sfi8010760 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO) for ; Tue, 4 Sep 2012 02:54:41 GMT Received: from abhmt112.oracle.com (abhmt112.oracle.com [141.146.116.64]) by acsmt358.oracle.com (8.12.11.20060308/8.12.11) with ESMTP id q842sfNi031226 for ; Mon, 3 Sep 2012 21:54:41 -0500 Received: from dradamslap1 (/71.202.147.44) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Mon, 03 Sep 2012 19:54:41 -0700 From: "Drew Adams" To: Subject: 24.2.50; doc string of `text-scale-adjust' Date: Mon, 3 Sep 2012 19:54:25 -0700 Message-ID: <703AC3C70837474CADDB99BA7E9E59A1@us.oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Mailer: Microsoft Office Outlook 11 Thread-Index: Ac2KSJfDvpDRtQJ+Rn6iW7zxfzL9TA== X-MimeOLE: Produced By Microsoft MimeOLE V6.00.2900.6157 X-Source-IP: acsinet22.oracle.com [141.146.126.238] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 1) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-Received-From: 208.118.235.17 X-Spam-Score: -6.1 (------) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -6.1 (------) 1. Describe the parameter, INC. 2. Describe the use of a prefix argument. In general, describe this as a user command, from a user point of view, and not just as a function to be called from code. In GNU Emacs 24.2.50.1 (i386-mingw-nt5.1.2600) of 2012-09-02 on MARVIN Bzr revision: 109861 eggert@cs.ucla.edu-20120902171035-7mzihil3xd6bjfiy Windowing system distributor `Microsoft Corp.', version 5.1.2600 Configured using: `configure --with-gcc (4.6) --no-opt --enable-checking --cflags -ID:/devel/emacs/libs/libXpm-3.5.8/include -ID:/devel/emacs/libs/libXpm-3.5.8/src -ID:/devel/emacs/libs/libpng-dev_1.4.3-1/include -ID:/devel/emacs/libs/zlib-dev_1.2.5-2/include -ID:/devel/emacs/libs/giflib-4.1.4-1/include -ID:/devel/emacs/libs/jpeg-6b-4/include -ID:/devel/emacs/libs/tiff-3.8.2-1/include -ID:/devel/emacs/libs/gnutls-3.0.9/include -ID:/devel/emacs/libs/libiconv-1.13.1-1-dev/include -ID:/devel/emacs/libs/libxml2-2.7.8/include/libxml2' ------------=_1351271702-28194-1-- From unknown Mon Aug 18 11:10:05 2025 X-Loop: help-debbugs@gnu.org Subject: bug#12345: 24.2.50; doc string of `text-scale-adjust' Resent-From: Bastien Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 27 Oct 2012 06:14:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 12345 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Stefan Monnier Cc: 12345-done@debbugs.gnu.org Received: via spool by 12345-done@debbugs.gnu.org id=D12345.13513183916600 (code D ref 12345); Sat, 27 Oct 2012 06:14:01 +0000 Received: (at 12345-done) by debbugs.gnu.org; 27 Oct 2012 06:13:11 +0000 Received: from localhost ([127.0.0.1]:35395 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TRzdu-0001iP-QP for submit@debbugs.gnu.org; Sat, 27 Oct 2012 02:13:11 -0400 Received: from mail-wi0-f180.google.com ([209.85.212.180]:55693) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TRzds-0001iH-Eg for 12345-done@debbugs.gnu.org; Sat, 27 Oct 2012 02:13:09 -0400 Received: by mail-wi0-f180.google.com with SMTP id hm4so815903wib.15 for <12345-done@debbugs.gnu.org>; Fri, 26 Oct 2012 23:10:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:from:to:cc:subject:in-reply-to:references:user-agent:date :message-id:mime-version:content-type:content-transfer-encoding; bh=mqbYQQsHYSdjfOb+xan1WSTo0dHZ2EPTryHpVaSg4no=; b=mjIbfE+t8wvQ0gwOjcJheaOWSG9/U7UVh4lYMDGxLAwsvHG9L7vYyBUlJYdt0NXCVt hCxgqN7PUtx+IS65RF7HFmBL43bNKDvaqY6hlwSxLfBUcePRx7DljD6971lfUy2CcQUf zrVg7f9wGrwlUw0Jrn+lmcJ0HyBNVl6DkMUgxgiutwWZTAwZUnD8oHsZcR0YamROid76 E2IbOT8Yet3Bg4IGp11AQb4okILu8UN4L7hSrI48d1izvxuto4sKtoOeoC791LtB6jiX WKkSAwpOs7soh2mvtTScSHSBahRcU8BwLnqqNhimrelVPWjHeKCHo0h8EZVFQXGmMWO7 Zoew== Received: by 10.180.80.104 with SMTP id q8mr7706868wix.6.1351318254595; Fri, 26 Oct 2012 23:10:54 -0700 (PDT) Received: from bzg.localdomain (mar75-2-81-56-68-112.fbx.proxad.net. [81.56.68.112]) by mx.google.com with ESMTPS id a10sm1248936wiz.4.2012.10.26.23.10.52 (version=TLSv1/SSLv3 cipher=OTHER); Fri, 26 Oct 2012 23:10:53 -0700 (PDT) Received: by bzg.localdomain (Postfix, from userid 1000) id A877F22E87; Sat, 27 Oct 2012 08:11:13 +0200 (CEST) From: Bastien In-Reply-To: (Stefan Monnier's message of "Fri, 26 Oct 2012 13:12:47 -0400") References: <703AC3C70837474CADDB99BA7E9E59A1@us.oracle.com> <87vcfkr884.fsf@altern.org> <87ipbkihqf.fsf@altern.org> User-Agent: Gnus/5.130006 (Ma Gnus v0.6) Emacs/24.2.50 (gnu/linux) Date: Sat, 27 Oct 2012 08:11:13 +0200 Message-ID: <87sj90sav2.fsf@bzg.ath.cx> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: 0.1 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: 0.1 (/) Stefan Monnier writes: >> Here is another patch, using ̀set-temporary-overlay-map'. > > Thanks, I installed it with a few tweaks. Thanks, >> It also changes the behavior regarding C-x C-0, which ends >> the loop. > > I did not include this change. I'm not really opposed to it, except for > the fact that it makes it necessary to have (and remember) the C-x C-0 > binding, whereas I like to use C-x C-+ as "entry point" even if I don't > actually want to increase the text size but instead reset it to its > default or decrease it. Yes, I also think it's better like this. -- Bastien