GNU bug report logs - #12327
Signal-handler cleanup for Emacs

Previous Next

Package: emacs;

Reported by: Paul Eggert <eggert <at> cs.ucla.edu>

Date: Sat, 1 Sep 2012 22:41:01 UTC

Severity: normal

Tags: patch

Done: Eli Zaretskii <eliz <at> gnu.org>

Bug is archived. No further changes may be made.

Full log


Message #20 received at 12327 <at> debbugs.gnu.org (full text, mbox):

From: Paul Eggert <eggert <at> cs.ucla.edu>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: lekktu <at> gmail.com, 12327 <at> debbugs.gnu.org
Subject: Re: Signal-handler cleanup for Emacs
Date: Mon, 03 Sep 2012 01:16:08 -0700
[Message part 1 (text/plain, inline)]
On 09/02/2012 02:20 PM, Eli Zaretskii wrote:

> If that's the problem, then fix that, by changing the type.

If I understand this suggestion correctly, it's not practical.
GNU/Linux sigblock returns 'int', but its signal masks require 1024
bits, too wide for 'int'.  This is why sigblock has been removed from
POSIX and is documented as obsolete in GNU/Linux.

> Changes come at a cost, which should be justified.

My point was that the new version is smaller and faster.
How much smaller and faster doesn't matter much, as the primary
justification for the change is to reduce the confusion caused by
the current setup.

> I could go with replacing 'signal' etc. with their modern Posix
> replacements

OK, thanks, I reworked the patch to implement that suggestion.
I also modified it a bit in other ways, to boost the performance
a bit (as that suggestion caused a small performance hit).  The
result is attached.  I expect the Windows port will need a few
tweaks.
[syssignal.txt (text/plain, attachment)]

This bug report was last modified 12 years and 264 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.