GNU bug report logs - #12314
24.2.50; `add-to-history': use `setq' with `delete'

Previous Next

Full log

View this message in rfc822 format

From: Eli Zaretskii <eliz <at> gnu.org>
To: Chong Yidong <cyd <at> gnu.org>
Cc: 12314 <at> debbugs.gnu.org, drew.adams <at> oracle.com
Subject: bug#12314: 24.2.50; `add-to-history': use `setq' with `delete'
Date: Sat, 08 Sep 2012 17:43:53 +0300

> From: Chong Yidong <cyd <at> gnu.org>
> Date: Sat, 08 Sep 2012 22:32:13 +0800
> Cc: 12314 <at> debbugs.gnu.org
> 
> "Drew Adams" <drew.adams <at> oracle.com> writes:
> 
> > This line in `add-to-history':
> >  
> > (if history-delete-duplicates (delete newelt history))
> >  
> > should be this:
> >  
> > (if history-delete-duplicates (setq history (delete newelt history)))
> 
> Fixed, thanks.

Does this mean the ELisp manual is in error?  It says:

 -- Function: delete object sequence
     If `sequence' is a list, this function destructively removes all
     elements `equal' to OBJECT from SEQUENCE.
     ...
     If `sequence' is a vector or string, `delete' returns a copy of
     `sequence' with all elements `equal' to `object' removed.

'history' is a list, isn't it?

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.