From debbugs-submit-bounces@debbugs.gnu.org Sun Aug 26 00:54:42 2012 Received: (at submit) by debbugs.gnu.org; 26 Aug 2012 04:54:42 +0000 Received: from localhost ([127.0.0.1]:49231 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1T5Urx-0007cN-SH for submit@debbugs.gnu.org; Sun, 26 Aug 2012 00:54:42 -0400 Received: from eggs.gnu.org ([208.118.235.92]:60426) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1T5Urv-0007cG-LY for submit@debbugs.gnu.org; Sun, 26 Aug 2012 00:54:40 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1T5UrA-0000xa-8n for submit@debbugs.gnu.org; Sun, 26 Aug 2012 00:53:54 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_HI, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.2 Received: from lists.gnu.org ([208.118.235.17]:49190) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T5UrA-0000xW-5w for submit@debbugs.gnu.org; Sun, 26 Aug 2012 00:53:52 -0400 Received: from eggs.gnu.org ([208.118.235.92]:36261) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T5Ur9-0007uU-6T for bug-gnu-emacs@gnu.org; Sun, 26 Aug 2012 00:53:52 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1T5Ur8-0000xG-9z for bug-gnu-emacs@gnu.org; Sun, 26 Aug 2012 00:53:51 -0400 Received: from acsinet15.oracle.com ([141.146.126.227]:18602) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T5Ur8-0000xC-3e for bug-gnu-emacs@gnu.org; Sun, 26 Aug 2012 00:53:50 -0400 Received: from acsinet22.oracle.com (acsinet22.oracle.com [141.146.126.238]) by acsinet15.oracle.com (Sentrion-MTA-4.2.2/Sentrion-MTA-4.2.2) with ESMTP id q7Q4rl6o026607 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Sun, 26 Aug 2012 04:53:48 GMT Received: from acsmt358.oracle.com (acsmt358.oracle.com [141.146.40.158]) by acsinet22.oracle.com (8.14.4+Sun/8.14.4) with ESMTP id q7Q4rkZq025584 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO) for ; Sun, 26 Aug 2012 04:53:47 GMT Received: from abhmt116.oracle.com (abhmt116.oracle.com [141.146.116.68]) by acsmt358.oracle.com (8.12.11.20060308/8.12.11) with ESMTP id q7Q4rkgu011849 for ; Sat, 25 Aug 2012 23:53:46 -0500 Received: from dradamslap1 (/71.202.147.44) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Sat, 25 Aug 2012 21:53:46 -0700 From: "Drew Adams" To: Subject: 24.1.50; [PATCH] regression: `dired-pop-to-buffer': `set-window-start' to 1 Date: Sat, 25 Aug 2012 21:53:37 -0700 Message-ID: <1FB857F70592465AAD8D4DD0A0634860@us.oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Mailer: Microsoft Office Outlook 11 Thread-Index: Ac2DRsDyNX1hBvM/RrOX/E1G7yc6/g== X-MimeOLE: Produced By Microsoft MimeOLE V6.00.2900.6157 X-Source-IP: acsinet22.oracle.com [141.146.126.238] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 1) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-Received-From: 208.118.235.17 X-Spam-Score: -6.1 (------) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -6.1 (------) This regression was introduced in Emacs 23. Prior to Emacs 23, `dired-pop-to-buffer' had a more complex definition, which included calling `set-window-start' for the displayed window, setting the value to 1, to move to the buffer beginning. Now, at least for the case where the buffer is popped up in a separate frame (which is my case), the end of the buffer is shown, not the beginning. For example, if I use `C' to copy many files, the file list shows up in a separate frame, but the window is scrolled so I see only the end, not the beginning, of the buffer. Please add this line before the call to `when': (set-window-start (selected-window) 1) That fixes things. Here is the whole, patched definition. (defun dired-pop-to-buffer (buf) "Pop up buffer BUF in a way suitable for Dired." (let ((split-window-preferred-function (lambda (window) (or (and (let ((split-height-threshold 0)) (window-splittable-p (selected-window))) ;; Try to split the selected window vertically if ;; that's possible. (Bug#1806) (split-window-below)) ;; Otherwise, try to split WINDOW sensibly. (split-window-sensibly window)))) pop-up-frames) (pop-to-buffer (get-buffer-create buf))) (set-window-start (selected-window) 1) ;; If dired-shrink-to-fit is t, make its window fit its contents. (when dired-shrink-to-fit ;; Try to not delete window when we want to display less than ;; `window-min-height' lines. (fit-window-to-buffer (get-buffer-window buf) nil 1))) In GNU Emacs 24.1.50.1 (i386-mingw-nt5.1.2600) of 2012-08-13 on MARVIN Bzr revision: 109584 monnier@iro.umontreal.ca-20120813141247-76irjqslrfncn30u Windowing system distributor `Microsoft Corp.', version 5.1.2600 Configured using: `configure --with-gcc (4.6) --no-opt --enable-checking --cflags -ID:/devel/emacs/libs/libXpm-3.5.8/include -ID:/devel/emacs/libs/libXpm-3.5.8/src -ID:/devel/emacs/libs/libpng-dev_1.4.3-1/include -ID:/devel/emacs/libs/zlib-dev_1.2.5-2/include -ID:/devel/emacs/libs/giflib-4.1.4-1/include -ID:/devel/emacs/libs/jpeg-6b-4/include -ID:/devel/emacs/libs/tiff-3.8.2-1/include -ID:/devel/emacs/libs/gnutls-3.0.9/include -ID:/devel/emacs/libs/libiconv-1.13.1-1-dev/include -ID:/devel/emacs/libs/libxml2-2.7.8/include/libxml2' From debbugs-submit-bounces@debbugs.gnu.org Sun Aug 26 20:42:20 2012 Received: (at 12281) by debbugs.gnu.org; 27 Aug 2012 00:42:20 +0000 Received: from localhost ([127.0.0.1]:51438 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1T5nPH-0005l0-Qc for submit@debbugs.gnu.org; Sun, 26 Aug 2012 20:42:20 -0400 Received: from ironport2-out.teksavvy.com ([206.248.154.182]:20987) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1T5nPG-0005ks-0p for 12281@debbugs.gnu.org; Sun, 26 Aug 2012 20:42:18 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: Ai0FAG6Zu0/O+KG6/2dsb2JhbABEsEiDSYEIghYBBVYjEAs0EhQYDSSIIboJkEQDozOBWIMF X-IronPort-AV: E=Sophos;i="4.75,637,1330923600"; d="scan'208";a="196757391" Received: from 206-248-161-186.dsl.teksavvy.com (HELO pastel.home) ([206.248.161.186]) by ironport2-out.teksavvy.com with ESMTP/TLS/ADH-AES256-SHA; 26 Aug 2012 20:41:27 -0400 Received: by pastel.home (Postfix, from userid 20848) id 7433159401; Sun, 26 Aug 2012 20:41:26 -0400 (EDT) From: Stefan Monnier To: "Drew Adams" Subject: Re: bug#12281: 24.1.50; [PATCH] regression: `dired-pop-to-buffer': `set-window-start' to 1 Message-ID: References: <1FB857F70592465AAD8D4DD0A0634860@us.oracle.com> Date: Sun, 26 Aug 2012 20:41:26 -0400 In-Reply-To: <1FB857F70592465AAD8D4DD0A0634860@us.oracle.com> (Drew Adams's message of "Sat, 25 Aug 2012 21:53:37 -0700") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.2.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -1.9 (-) X-Debbugs-Envelope-To: 12281 Cc: 12281@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -1.9 (-) > (set-window-start (selected-window) 1) Please use point-min rather than hard-coded 1. Stefan From debbugs-submit-bounces@debbugs.gnu.org Sun Aug 26 22:45:33 2012 Received: (at 12281) by debbugs.gnu.org; 27 Aug 2012 02:45:33 +0000 Received: from localhost ([127.0.0.1]:51491 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1T5pKX-0008Sd-13 for submit@debbugs.gnu.org; Sun, 26 Aug 2012 22:45:33 -0400 Received: from acsinet15.oracle.com ([141.146.126.227]:30024) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1T5pKT-0008SQ-64 for 12281@debbugs.gnu.org; Sun, 26 Aug 2012 22:45:30 -0400 Received: from ucsinet22.oracle.com (ucsinet22.oracle.com [156.151.31.94]) by acsinet15.oracle.com (Sentrion-MTA-4.2.2/Sentrion-MTA-4.2.2) with ESMTP id q7R2iZfQ029005 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Mon, 27 Aug 2012 02:44:36 GMT Received: from acsmt357.oracle.com (acsmt357.oracle.com [141.146.40.157]) by ucsinet22.oracle.com (8.14.4+Sun/8.14.4) with ESMTP id q7R2iYYh004412 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Mon, 27 Aug 2012 02:44:34 GMT Received: from abhmt109.oracle.com (abhmt109.oracle.com [141.146.116.61]) by acsmt357.oracle.com (8.12.11.20060308/8.12.11) with ESMTP id q7R2iXUv002500; Sun, 26 Aug 2012 21:44:33 -0500 Received: from dradamslap1 (/71.202.147.44) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Sun, 26 Aug 2012 19:44:33 -0700 From: "Drew Adams" To: "'Stefan Monnier'" References: <1FB857F70592465AAD8D4DD0A0634860@us.oracle.com> Subject: RE: bug#12281: 24.1.50; [PATCH] regression: `dired-pop-to-buffer': `set-window-start' to 1 Date: Sun, 26 Aug 2012 19:44:20 -0700 Message-ID: <9B6C3D89824445F188CC50C43F9941AD@us.oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Mailer: Microsoft Office Outlook 11 In-Reply-To: Thread-Index: Ac2D7LJFNVZCJHHxSN2KYi+FXakumwAEICAA X-MimeOLE: Produced By Microsoft MimeOLE V6.00.2900.6157 X-Source-IP: ucsinet22.oracle.com [156.151.31.94] X-Spam-Score: -7.1 (-------) X-Debbugs-Envelope-To: 12281 Cc: 12281@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -7.1 (-------) > > (set-window-start (selected-window) 1) > > Please use point-min rather than hard-coded 1. Right, good point. From debbugs-submit-bounces@debbugs.gnu.org Mon Aug 27 05:16:54 2012 Received: (at 12281-done) by debbugs.gnu.org; 27 Aug 2012 09:16:54 +0000 Received: from localhost ([127.0.0.1]:51784 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1T5vRF-0001D9-Q7 for submit@debbugs.gnu.org; Mon, 27 Aug 2012 05:16:53 -0400 Received: from mailout-de.gmx.net ([213.165.64.23]:54490) by debbugs.gnu.org with smtp (Exim 4.72) (envelope-from ) id 1T5vRE-0001D1-5l for 12281-done@debbugs.gnu.org; Mon, 27 Aug 2012 05:16:52 -0400 Received: (qmail invoked by alias); 27 Aug 2012 09:15:59 -0000 Received: from 62-47-60-67.adsl.highway.telekom.at (EHLO [62.47.60.67]) [62.47.60.67] by mail.gmx.net (mp027) with SMTP; 27 Aug 2012 11:15:59 +0200 X-Authenticated: #14592706 X-Provags-ID: V01U2FsdGVkX18nF9oDOsAnF1u2tmbG3ChYFDaFYUnT4DS1dEY++o qoRwgmVLtK3arI Message-ID: <503B3AC5.3040007@gmx.at> Date: Mon, 27 Aug 2012 11:15:49 +0200 From: martin rudalics MIME-Version: 1.0 To: 12281-done@debbugs.gnu.org Subject: Re: bug#12281: 24.1.50; [PATCH] regression: `dired-pop-to-buffer': `set-window-start' to 1 References: <1FB857F70592465AAD8D4DD0A0634860@us.oracle.com> In-Reply-To: <1FB857F70592465AAD8D4DD0A0634860@us.oracle.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Y-GMX-Trusted: 0 X-Spam-Score: -1.9 (-) X-Debbugs-Envelope-To: 12281-done Cc: Drew Adams X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -1.9 (-) > Please add this line before the call to `when': > (set-window-start (selected-window) 1) Installed (modestly modified) in revision 109790 on trunk. Bug closed. Thanks, martin From unknown Sat Jun 14 03:57:04 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Mon, 24 Sep 2012 11:24:05 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator