GNU bug report logs - #12246
[patch] iso 8601 specifies zero padding, not space padding

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 12246 in the body.
You can then email your comments to 12246 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Ian Price <ianprice90 <at> googlemail.com>
To: bug-guile <at> gnu.org
Subject: [patch] iso 8601 specifies zero padding, not space padding
Date: Tue, 21 Aug 2012 12:21:58 +0100

[Message part 1 (text/plain, inline)]

In srfi 19, there is convenience format directives for various ISO 8601
date/time formats. i.e.

     ~2     ISO-8601 time+zone, `~k:~M:~S~z'
     ~3     ISO-8601 time, `~k:~M:~S'
     ~4     ISO-8601 date/time+zone, `~Y-~m-~dT~k:~M:~S~z'
     ~5     ISO-8601 date/time, `~Y-~m-~dT~k:~M:~S'

However, ~k is incorrect here, as iso 8601 specifies that hours have two
digits (i.e. 9am is "09") which means the ~H directive.

Funnily enough, if you look in srfi-19.scm itself you even see

(define iso-8601-date-time-format "~Y-~m-~dT~H:~M:~S~z")

note, the ~H.

I've attached a patch to fix these.
     
-- 
Ian Price -- shift-reset.com

"Programming is like pinball. The reward for doing it well is
the opportunity to do it again" - from "The Wizardy Compiled"

[0001-ISO-8601-time-format-specifies-zero-padding-for-hour.patch (text/x-patch, attachment)]

Message #10 received at 12246-done <at> debbugs.gnu.org (full text, mbox):

From: ludo <at> gnu.org (Ludovic Courtès)
To: Ian Price <ianprice90 <at> googlemail.com>
Cc: 12246-done <at> debbugs.gnu.org
Subject: Re: bug#12246: [patch] iso 8601 specifies zero padding,
	not space padding
Date: Mon, 27 Aug 2012 00:21:24 +0200

Applied, thanks!

Ludo'.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.