GNU bug report logs - #12244
[patch] URI encoding bugs

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: ludo <at> gnu.org (Ludovic Courtès)
Cc: tracker <at> debbugs.gnu.org
Subject: bug#12244: closed ([patch] URI encoding bugs)
Date: Sun, 26 Aug 2012 21:39:02 +0000

[Message part 1 (text/plain, inline)]

Your message dated Sun, 26 Aug 2012 23:37:36 +0200
with message-id <87lih1mj1b.fsf <at> gnu.org>
and subject line Re: bug#12244: [patch] URI encoding bugs
has caused the debbugs.gnu.org bug report #12244,
regarding [patch] URI encoding bugs
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
12244: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=12244
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Ian Price <ianprice90 <at> googlemail.com>
To: bug-guile <at> gnu.org
Subject: [patch] URI encoding bugs
Date: Mon, 20 Aug 2012 23:19:12 +0100

[Message part 3 (text/plain, inline)]

Hi,

There are two bugs in the current uri-encode procedure in (web
uri).

Firstly, if you have an octet less than 16 it only gets encoded to %
HEXDIGIT instead of % HEXDIGIT HEXDIGIT.

scheme@(guile−user)> (uri-encode "foo\nbar")
$30 = "foo%abar"

Secondly, if you have a string with no unreserved characters, nothing
gets encoded.
scheme@(guile−user)> (uri-encode "<>\\^")
$31 = "<>\\∧"
scheme@(guile−user)> (uri-encode "<>\\^a")
$32 = "%3c%3e%5c%5ea"

Patches attached. Cheers,

-- 
Ian Price -- shift-reset.com

"Programming is like pinball. The reward for doing it well is
the opportunity to do it again" - from "The Wizardy Compiled"

[0001-Fix-uri-encoding-for-octets-0-15.patch (text/x-patch, attachment)]

[0002-Fix-uri-encoding-for-strings-with-no-unreserved-char.patch (text/x-patch, attachment)]

[Message part 6 (message/rfc822, inline)]

From: ludo <at> gnu.org (Ludovic Courtès)
To: Ian Price <ianprice90 <at> googlemail.com>
Cc: 12244-done <at> debbugs.gnu.org
Subject: Re: bug#12244: [patch] URI encoding bugs
Date: Sun, 26 Aug 2012 23:37:36 +0200

Hi Ian,

Applied both, thanks!

Ludo’.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.