GNU bug report logs - #12239
[PATCH] try-warping-via-registry stops looking before finding the article

Previous Next

Full log

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Dave Abrahams <dave <at> boostpro.com>
To: submit <at> debbugs.gnu.org (The Gnus Bugfixing Girls + Boys)
Subject: [PATCH] try-warping-via-registry stops looking before finding the
	article
Date: Sun, 19 Aug 2012 22:47:23 -0400

[Message part 1 (text/plain, inline)]

If the article happens to have more than one group in the registry, and
the first group listed doesn't actually contain the article (e.g. the
group may not even exist anymore), warping will fail.  The enclosed
patch fixes the problem.

[0001-gnus-try-warping-via-registry-bugfix-don-t-act-as-th.patch (text/x-patch, inline)]

From 7cadc3013cde1f9db3df83bf8a7c103f73ea6fc1 Mon Sep 17 00:00:00 2001
From: Dave Abrahams <dave <at> boostpro.com>
Date: Sun, 19 Aug 2012 22:44:57 -0400
Subject: [PATCH] gnus-try-warping-via-registry: [bugfix] don't act as though
 you've found the article when you haven't

---
 lisp/gnus-registry.el |    7 ++++---
 1 files changed, 4 insertions(+), 3 deletions(-)

diff --git a/lisp/gnus-registry.el b/lisp/gnus-registry.el
index 8aecc98..71e0096 100644
--- a/lisp/gnus-registry.el
+++ b/lisp/gnus-registry.el
@@ -1169,9 +1169,10 @@ data stored in the registry."
 
             ;; Try to activate the group.  If that fails, just move
             ;; along.  We may have more groups to work with
-            (ignore-errors
-	      (gnus-select-group-with-message-id group message-id))
-            (throw 'found t)))))))
+            (when
+                (ignore-errors
+                  (gnus-select-group-with-message-id group message-id) t)
+              (throw 'found t))))))))
 
 ;; TODO: a few things
 
-- 
1.7.7.5 (Apple Git-26)

[Message part 3 (text/plain, inline)]

Ma Gnus v0.6
GNU Emacs 24.1.1 (x86_64-apple-darwin11.4.0, Carbon Version 1.6.0 AppKit 1138.47)
 of 2012-06-27 on pluto.luannocracy.com
200 news.gmane.org InterNetNews NNRP server INN 2.5.1 ready (posting ok)
101 Capability list:
VERSION 2
IMPLEMENTATION INN 2.5.1
AUTHINFO USER
HDR
LIST ACTIVE ACTIVE.TIMES DISTRIB.PATS HEADERS NEWSGROUPS OVERVIEW.FMT
OVER
POST
READER
STARTTLS
.
382 Begin TLS negotiation now
101 Capability list:
VERSION 2
IMPLEMENTATION INN 2.5.1
AUTHINFO USER
HDR
LIST ACTIVE ACTIVE.TIMES DISTRIB.PATS HEADERS NEWSGROUPS OVERVIEW.FMT
OVER
POST
READER
.

-- 
Dave Abrahams
BoostPro Computing                  Software Development        Training
http://www.boostpro.com             Clang/LLVM/EDG Compilers  C++  Boost

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.