From unknown Sat Jun 21 12:12:31 2025 X-Loop: help-debbugs@gnu.org Subject: bug#12239: [PATCH] try-warping-via-registry stops looking before finding the article Resent-From: Dave Abrahams Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bugs@gnus.org Resent-Date: Mon, 20 Aug 2012 02:48:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 12239 X-GNU-PR-Package: gnus X-GNU-PR-Keywords: patch To: 12239@debbugs.gnu.org X-Debbugs-Original-To: submit@debbugs.gnu.org (The Gnus Bugfixing Girls + Boys) Received: via spool by submit@debbugs.gnu.org id=B.13454308604131 (code B ref -1); Mon, 20 Aug 2012 02:48:01 +0000 Received: (at submit) by debbugs.gnu.org; 20 Aug 2012 02:47:40 +0000 Received: from localhost ([127.0.0.1]:39124 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1T3I1k-00014Z-6A for submit@debbugs.gnu.org; Sun, 19 Aug 2012 22:47:40 -0400 Received: from mail-vb0-f44.google.com ([209.85.212.44]:59187) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1T3I1h-00014S-Q9 for submit@debbugs.gnu.org; Sun, 19 Aug 2012 22:47:38 -0400 Received: by vbbez10 with SMTP id ez10so6246314vbb.3 for ; Sun, 19 Aug 2012 19:47:26 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=from:to:subject:x-debbugs-version:x-debbugs-package:date:message-id :user-agent:mime-version:content-type:x-gm-message-state; bh=N9Nnf5ewyjnAfHiw4/Kzzva/XkHC9lhxJgumr1qpVQo=; b=VTXLcK51GcBKrqdCZyhHA9BB5aewIuWb/J5N8/9Lc0gME49NelhPwdwJYK0wqQ7jJA /T1nBgctCvAbFNWrCFLU8aFqnUgrom33F7XWgJDPwgiU1lyuRXP19H4Sw6VYXGpSvev7 nSBHVXdf/Z1UpaFnEVoRJcQC0tJqxkfAp1zavaa/yJYCchuxvYB+sPDEaEoxyoMH1dax i0bqot0uud3vzKmbtbHCeJzb7J8U/NInvTqTgmbaAfu3IdzfzNqAmQB+KSNAdrLfkWgT Tdh/qW/YsQBLmJwTyvhachTVkeMc+ZRraWy0S9ZITlUskWL3x+gnz7MUjKeNotIOh6Pn rvSw== Received: by 10.58.229.166 with SMTP id sr6mr9554568vec.52.1345430846346; Sun, 19 Aug 2012 19:47:26 -0700 (PDT) Received: from pluto.local (207-172-223-249.c3-0.smr-ubr3.sbo-smr.ma.static.cable.rcn.com. [207.172.223.249]) by mx.google.com with ESMTPS id i13sm4722316vdj.4.2012.08.19.19.47.24 (version=TLSv1/SSLv3 cipher=OTHER); Sun, 19 Aug 2012 19:47:25 -0700 (PDT) Received: by pluto.local (Postfix, from userid 501) id 907AD5F0491C; Sun, 19 Aug 2012 22:47:23 -0400 (EDT) From: Dave Abrahams Date: Sun, 19 Aug 2012 22:47:23 -0400 Message-ID: User-Agent: Gnus/5.130006 (Ma Gnus v0.6) Emacs/24.1 (darwin) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Gm-Message-State: ALoCoQl9hTN3N2/HD7GEdqne+DIb7EU7ph9rfggDPrM+167MTSvZcVgBGLpD79DLEjHqzoix8oKm X-Spam-Score: -2.6 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.6 (--) --=-=-= Content-Type: text/plain If the article happens to have more than one group in the registry, and the first group listed doesn't actually contain the article (e.g. the group may not even exist anymore), warping will fail. The enclosed patch fixes the problem. --=-=-= Content-Type: text/x-patch Content-Disposition: inline; filename=0001-gnus-try-warping-via-registry-bugfix-don-t-act-as-th.patch >From 7cadc3013cde1f9db3df83bf8a7c103f73ea6fc1 Mon Sep 17 00:00:00 2001 From: Dave Abrahams Date: Sun, 19 Aug 2012 22:44:57 -0400 Subject: [PATCH] gnus-try-warping-via-registry: [bugfix] don't act as though you've found the article when you haven't --- lisp/gnus-registry.el | 7 ++++--- 1 files changed, 4 insertions(+), 3 deletions(-) diff --git a/lisp/gnus-registry.el b/lisp/gnus-registry.el index 8aecc98..71e0096 100644 --- a/lisp/gnus-registry.el +++ b/lisp/gnus-registry.el @@ -1169,9 +1169,10 @@ data stored in the registry." ;; Try to activate the group. If that fails, just move ;; along. We may have more groups to work with - (ignore-errors - (gnus-select-group-with-message-id group message-id)) - (throw 'found t))))))) + (when + (ignore-errors + (gnus-select-group-with-message-id group message-id) t) + (throw 'found t)))))))) ;; TODO: a few things -- 1.7.7.5 (Apple Git-26) --=-=-= Content-Type: text/plain Ma Gnus v0.6 GNU Emacs 24.1.1 (x86_64-apple-darwin11.4.0, Carbon Version 1.6.0 AppKit 1138.47) of 2012-06-27 on pluto.luannocracy.com 200 news.gmane.org InterNetNews NNRP server INN 2.5.1 ready (posting ok) 101 Capability list: VERSION 2 IMPLEMENTATION INN 2.5.1 AUTHINFO USER HDR LIST ACTIVE ACTIVE.TIMES DISTRIB.PATS HEADERS NEWSGROUPS OVERVIEW.FMT OVER POST READER STARTTLS . 382 Begin TLS negotiation now 101 Capability list: VERSION 2 IMPLEMENTATION INN 2.5.1 AUTHINFO USER HDR LIST ACTIVE ACTIVE.TIMES DISTRIB.PATS HEADERS NEWSGROUPS OVERVIEW.FMT OVER POST READER . -- Dave Abrahams BoostPro Computing Software Development Training http://www.boostpro.com Clang/LLVM/EDG Compilers C++ Boost --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Wed Sep 05 15:28:06 2012 Received: (at control) by debbugs.gnu.org; 5 Sep 2012 19:28:06 +0000 Received: from localhost ([127.0.0.1]:41118 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1T9LGf-0007ut-KO for submit@debbugs.gnu.org; Wed, 05 Sep 2012 15:28:05 -0400 Received: from hermes.netfonds.no ([80.91.224.195]:46116) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1T9LGd-0007ul-Vo for control@debbugs.gnu.org; Wed, 05 Sep 2012 15:28:04 -0400 Received: from ip-200-13-149-91.dialup.ice.net ([91.149.13.200] helo=rusty) by hermes.netfonds.no with esmtpsa (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.72) (envelope-from ) id 1T9LG6-0003R5-GV for control@debbugs.gnu.org; Wed, 05 Sep 2012 21:27:50 +0200 Date: Wed, 05 Sep 2012 21:27:02 +0200 Message-Id: <87harcp8xl.fsf@gnus.org> To: control@debbugs.gnu.org From: Lars Ingebrigtsen Subject: control message for bug #12239 X-MailScanner-ID: 1T9LG6-0003R5-GV X-Netfonds-MailScanner: Found to be clean X-Netfonds-MailScanner-From: larsi@gnus.org MailScanner-NULL-Check: 1347478070.25803@Yi2wC1ZvJgIMYL925/6EvQ X-Spam-Status: No X-Spam-Score: -1.9 (-) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -1.9 (-) tags 12239 fixed close 12239 24.3