From unknown Sat Jun 21 10:27:16 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#12236 <12236@debbugs.gnu.org> To: bug#12236 <12236@debbugs.gnu.org> Subject: Status: 24.2.50; hideshow.el: missing a `make-variable-buffer-local' Reply-To: bug#12236 <12236@debbugs.gnu.org> Date: Sat, 21 Jun 2025 17:27:16 +0000 retitle 12236 24.2.50; hideshow.el: missing a `make-variable-buffer-local' reassign 12236 emacs submitter 12236 michael_heerdegen@web.de severity 12236 normal thanks From debbugs-submit-bounces@debbugs.gnu.org Sun Aug 19 21:40:30 2012 Received: (at submit) by debbugs.gnu.org; 20 Aug 2012 01:40:30 +0000 Received: from localhost ([127.0.0.1]:39072 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1T3Gyk-0007yH-5c for submit@debbugs.gnu.org; Sun, 19 Aug 2012 21:40:30 -0400 Received: from eggs.gnu.org ([208.118.235.92]:35800) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1T3Gyi-0007yA-BF for submit@debbugs.gnu.org; Sun, 19 Aug 2012 21:40:29 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1T3GyW-0005N7-Nd for submit@debbugs.gnu.org; Sun, 19 Aug 2012 21:40:17 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=5.0 tests=BAYES_00,FREEMAIL_FROM, RCVD_IN_DNSWL_HI autolearn=unavailable version=3.3.2 Received: from lists.gnu.org ([208.118.235.17]:52321) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T3GyW-0005N3-KN for submit@debbugs.gnu.org; Sun, 19 Aug 2012 21:40:16 -0400 Received: from eggs.gnu.org ([208.118.235.92]:59089) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T3GyV-00061d-MA for bug-gnu-emacs@gnu.org; Sun, 19 Aug 2012 21:40:16 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1T3GyU-0005Mj-7w for bug-gnu-emacs@gnu.org; Sun, 19 Aug 2012 21:40:15 -0400 Received: from mout.web.de ([212.227.17.11]:49406) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T3GyT-0005MZ-UO for bug-gnu-emacs@gnu.org; Sun, 19 Aug 2012 21:40:14 -0400 Received: from snow.dragon ([82.113.98.23]) by smtp.web.de (mrweb002) with ESMTPSA (Nemesis) id 0Lcgp5-1TUwLV2f4R-00jeyv for ; Mon, 20 Aug 2012 03:40:11 +0200 Date: Mon, 20 Aug 2012 03:42:36 +0200 Message-Id: <87r4r2wd83.fsf@web.de> From: Michael Heerdegen To: bug-gnu-emacs@gnu.org Subject: 24.2.50; hideshow.el: missing a `make-variable-buffer-local' X-Provags-ID: V02:K0:6UD0xSubLuKedlAEZWtEmTKHyf6GOmTDS2iLMQBid4G GIQdDlNkkUFuLHbUi+gIFywQa8srWxUYiq+cT/W0H+JQb2Cetd FXsvlb1LC7cBiaWw4WU4dZnXFicYgCY9jvApIshMvsbfj9Sls+ GetLd4csTJHSCKX8Wub7N7o4ZsCbdIG27oJ34SXH4GzJHXTAgA +m8WrlhxcJR9Mtpj5jRNx4h0LEknRz3JrHrxwKMAgA= X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-Received-From: 208.118.235.17 X-Spam-Score: -6.9 (------) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list Reply-To: michael_heerdegen@web.de List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -6.9 (------) Hi, please look at these lines in hideshow.el: (defvar hs-c-start-regexp nil "Regexp for beginning of comments. Differs from mode-specific comment regexps in that surrounding whitespace is stripped.") (make-variable-buffer-local 'hs-c-start-regexp) (defvar hs-block-start-regexp nil "Regexp for beginning of block.") (make-variable-buffer-local 'hs-block-start-regexp) (defvar hs-block-start-mdata-select nil "Element in `hs-block-start-regexp' match data to consider as block start. The internal function `hs-forward-sexp' moves point to the beginning of this element (using `match-beginning') before calling `hs-forward-sexp-func'.") (make-variable-buffer-local 'hs-block-start-mdata-select) (defvar hs-block-end-regexp nil "Regexp for end of block.") (defvar hs-forward-sexp-func 'forward-sexp "Function used to do a `forward-sexp'. Should change for Algol-ish modes. For single-character block delimiters -- ie, the syntax table regexp for the character is either `(' or `)' -- `hs-forward-sexp-func' would just be `forward-sexp'. For other modes such as simula, a more specialized function is necessary.") (make-variable-buffer-local 'hs-forward-sexp-func) I think it is obvious that `hs-block-end-regexp' must be declared as buffer local as well. Currently, if you invoke hs-minor-mode in two different buffers with different major-modes, the setting of the second buffer overwrites the value of `hs-block-end-regexp' in the first one, making hideshow malfunctioning there. Thanks, Michael. In GNU Emacs 24.2.50.1 (i486-pc-linux-gnu, GTK+ Version 3.4.2) of 2012-08-15 on dex, modified by Debian (emacs-snapshot package, version 2:20120815-1) Windowing system distributor `The X.Org Foundation', version 11.0.11203000 Configured using: `configure '--build' 'i486-linux-gnu' '--host' 'i486-linux-gnu' '--prefix=/usr' '--sharedstatedir=/var/lib' '--libexecdir=/usr/lib' '--localstatedir=/var' '--infodir=/usr/share/info' '--mandir=/usr/share/man' '--with-pop=yes' '--enable-locallisppath=/etc/emacs-snapshot:/etc/emacs:/usr/local/share/emacs/24.2.50/site-lisp:/usr/local/share/emacs/site-lisp:/usr/share/emacs/24.2.50/site-lisp:/usr/share/emacs/site-lisp' '--without-compress-info' '--with-crt-dir=/usr/lib/i386-linux-gnu/' '--with-x=yes' '--with-x-toolkit=gtk3' '--with-imagemagick=yes' 'build_alias=i486-linux-gnu' 'host_alias=i486-linux-gnu' 'CFLAGS=-DDEBIAN -DSITELOAD_PURESIZE_EXTRA=5000 -g -O2' 'LDFLAGS=-g -Wl,--as-needed -znocombreloc' 'CPPFLAGS=-D_FORTIFY_SOURCE=2'' From debbugs-submit-bounces@debbugs.gnu.org Mon Aug 20 11:27:46 2012 Received: (at 12236) by debbugs.gnu.org; 20 Aug 2012 15:27:46 +0000 Received: from localhost ([127.0.0.1]:40222 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1T3TtK-0003vF-1h for submit@debbugs.gnu.org; Mon, 20 Aug 2012 11:27:46 -0400 Received: from fencepost.gnu.org ([208.118.235.10]:43320) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1T3TtH-0003v6-Ar for 12236@debbugs.gnu.org; Mon, 20 Aug 2012 11:27:44 -0400 Received: from dann by fencepost.gnu.org with local (Exim 4.71) (envelope-from ) id 1T3Tt2-0004Su-Jy; Mon, 20 Aug 2012 11:27:28 -0400 From: Dan Nicolaescu To: michael_heerdegen@web.de Subject: Re: bug#12236: 24.2.50; hideshow.el: missing a `make-variable-buffer-local' References: <87r4r2wd83.fsf@web.de> X-Debbugs-No-Ack: yes Date: Mon, 20 Aug 2012 11:27:28 -0400 In-Reply-To: <87r4r2wd83.fsf@web.de> (Michael Heerdegen's message of "Mon, 20 Aug 2012 03:42:36 +0200") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Spam-Score: -7.1 (-------) X-Debbugs-Envelope-To: 12236 Cc: 12236@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -7.1 (-------) Michael Heerdegen writes: > Hi, > > please look at these lines in hideshow.el: > > (defvar hs-c-start-regexp nil > "Regexp for beginning of comments. > Differs from mode-specific comment regexps in that > surrounding whitespace is stripped.") > (make-variable-buffer-local 'hs-c-start-regexp) > > (defvar hs-block-start-regexp nil > "Regexp for beginning of block.") > (make-variable-buffer-local 'hs-block-start-regexp) > > (defvar hs-block-start-mdata-select nil > "Element in `hs-block-start-regexp' match data to consider as block start. > The internal function `hs-forward-sexp' moves point to the beginning of this > element (using `match-beginning') before calling `hs-forward-sexp-func'.") > (make-variable-buffer-local 'hs-block-start-mdata-select) > > (defvar hs-block-end-regexp nil > "Regexp for end of block.") > > (defvar hs-forward-sexp-func 'forward-sexp > "Function used to do a `forward-sexp'. > Should change for Algol-ish modes. For single-character block > delimiters -- ie, the syntax table regexp for the character is > either `(' or `)' -- `hs-forward-sexp-func' would just be > `forward-sexp'. For other modes such as simula, a more specialized > function is necessary.") > (make-variable-buffer-local 'hs-forward-sexp-func) > > I think it is obvious that `hs-block-end-regexp' must be declared as > buffer local as well. Yes, that existed, but it got lost at some point. I fixed this in the emacs-24 branch which will get propagated to the trunk at some point. > Currently, if you invoke hs-minor-mode in two different buffers with > different major-modes, the setting of the second buffer overwrites the > value of `hs-block-end-regexp' in the first one, making hideshow > malfunctioning there. > > > Thanks, > > Michael. > > > In GNU Emacs 24.2.50.1 (i486-pc-linux-gnu, GTK+ Version 3.4.2) > of 2012-08-15 on dex, modified by Debian > (emacs-snapshot package, version 2:20120815-1) > Windowing system distributor `The X.Org Foundation', version 11.0.11203000 > Configured using: > `configure '--build' 'i486-linux-gnu' '--host' 'i486-linux-gnu' > '--prefix=/usr' '--sharedstatedir=/var/lib' '--libexecdir=/usr/lib' > '--localstatedir=/var' '--infodir=/usr/share/info' > '--mandir=/usr/share/man' '--with-pop=yes' > '--enable-locallisppath=/etc/emacs-snapshot:/etc/emacs:/usr/local/share/emacs/24.2.50/site-lisp:/usr/local/share/emacs/site-lisp:/usr/share/emacs/24.2.50/site-lisp:/usr/share/emacs/site-lisp' > '--without-compress-info' '--with-crt-dir=/usr/lib/i386-linux-gnu/' > '--with-x=yes' '--with-x-toolkit=gtk3' '--with-imagemagick=yes' > 'build_alias=i486-linux-gnu' 'host_alias=i486-linux-gnu' > 'CFLAGS=-DDEBIAN -DSITELOAD_PURESIZE_EXTRA=5000 -g -O2' 'LDFLAGS=-g > -Wl,--as-needed -znocombreloc' 'CPPFLAGS=-D_FORTIFY_SOURCE=2'' From debbugs-submit-bounces@debbugs.gnu.org Mon Aug 20 12:00:08 2012 Received: (at control) by debbugs.gnu.org; 20 Aug 2012 16:00:08 +0000 Received: from localhost ([127.0.0.1]:40228 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1T3UOd-0004dU-RA for submit@debbugs.gnu.org; Mon, 20 Aug 2012 12:00:08 -0400 Received: from fencepost.gnu.org ([208.118.235.10]:44033) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1T3UOb-0004dM-HS for control@debbugs.gnu.org; Mon, 20 Aug 2012 12:00:06 -0400 Received: from rgm by fencepost.gnu.org with local (Exim 4.71) (envelope-from ) id 1T3UON-0000hv-1k for control@debbugs.gnu.org; Mon, 20 Aug 2012 11:59:51 -0400 Date: Mon, 20 Aug 2012 11:59:51 -0400 Message-Id: Subject: control message for bug 12236 To: X-Mailer: mail (GNU Mailutils 2.1) From: Glenn Morris X-Spam-Score: -7.1 (-------) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -7.1 (-------) close 12236 24.2 From unknown Sat Jun 21 10:27:16 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Tue, 18 Sep 2012 11:24:03 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator