From debbugs-submit-bounces@debbugs.gnu.org Sat Aug 18 22:56:17 2012 Received: (at submit) by debbugs.gnu.org; 19 Aug 2012 02:56:17 +0000 Received: from localhost ([127.0.0.1]:38077 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1T2vgU-0008ND-Mt for submit@debbugs.gnu.org; Sat, 18 Aug 2012 22:56:15 -0400 Received: from eggs.gnu.org ([208.118.235.92]:49167) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1T2vgQ-0008N3-IZ for submit@debbugs.gnu.org; Sat, 18 Aug 2012 22:56:12 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1T2vgJ-00078F-G2 for submit@debbugs.gnu.org; Sat, 18 Aug 2012 22:56:05 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_HI, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.2 Received: from lists.gnu.org ([208.118.235.17]:50605) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T2vgJ-00077j-CF for submit@debbugs.gnu.org; Sat, 18 Aug 2012 22:56:03 -0400 Received: from eggs.gnu.org ([208.118.235.92]:37174) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T2vgH-0007QU-He for bug-gnu-emacs@gnu.org; Sat, 18 Aug 2012 22:56:03 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1T2vgF-00075l-2q for bug-gnu-emacs@gnu.org; Sat, 18 Aug 2012 22:56:01 -0400 Received: from acsinet15.oracle.com ([141.146.126.227]:34816) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T2vgE-00073L-Qb for bug-gnu-emacs@gnu.org; Sat, 18 Aug 2012 22:55:59 -0400 Received: from acsinet22.oracle.com (acsinet22.oracle.com [141.146.126.238]) by acsinet15.oracle.com (Sentrion-MTA-4.2.2/Sentrion-MTA-4.2.2) with ESMTP id q7J2ttlr005782 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Sun, 19 Aug 2012 02:55:56 GMT Received: from acsmt358.oracle.com (acsmt358.oracle.com [141.146.40.158]) by acsinet22.oracle.com (8.14.4+Sun/8.14.4) with ESMTP id q7J2tsYY016573 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO) for ; Sun, 19 Aug 2012 02:55:55 GMT Received: from abhmt107.oracle.com (abhmt107.oracle.com [141.146.116.59]) by acsmt358.oracle.com (8.12.11.20060308/8.12.11) with ESMTP id q7J2tsrb010503 for ; Sat, 18 Aug 2012 21:55:54 -0500 Received: from dradamslap1 (/10.159.171.244) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Sat, 18 Aug 2012 19:55:54 -0700 From: "Drew Adams" To: Subject: 24.1.50; regression: repeat.el commit 2012-05-05 breaks repeating commands Date: Sat, 18 Aug 2012 19:55:42 -0700 Message-ID: <26617CF879E04A6689018BFA901EF01A@us.oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Priority: 1 (Highest) X-MSMail-Priority: High X-Mailer: Microsoft Office Outlook 11 Importance: High Thread-Index: Ac19th790A4wIXJ9Tpu3w2xXIEPQ5g== X-Message-Flag: Follow up X-MimeOLE: Produced By Microsoft MimeOLE V6.00.2900.6157 X-Source-IP: acsinet22.oracle.com [141.146.126.238] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 1) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-Received-From: 208.118.235.17 X-Spam-Score: -6.1 (------) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -6.1 (------) I believe this regression was introduced by the following commit: Stefan Monnier2012-05-05 02:50:20Revision ID: monnier@iro.umontreal.ca-2012= 0505025020-ihjvoqehkrxkfxw8 Use set-temporary-overlay-map. * lisp/repeat.el: Use lexical-binding. (repeat-last-self-insert, repeat-num-input-keys-at-self-insert) (repeat-undo-count): Remove. (repeat): * lisp/progmodes/octave-mod.el (octave-abbrev-start): * lisp/progmodes/f90.el (f90-abbrev-start): * lisp/face-remap.el (text-scale-adjust): * lisp/kmacro.el (kmacro-call-macro): Use set-temporary-overlay-map. ---- I use the following idiom in more than one library, to create repeatable versions of commands - it is very handy. I use such commands to cycle through bookmarks, to move forward over thing-at-point things repeatedly, etc. The idea is this: use `repeat' to create a repeatable command that can be bound to a key sequence with a prefix key. For example, I have `C-x p n' bound to a command that cycles through bookmarks, and I have `C-x ' bound to a command that repeatedly moves forward over thing-at-point things of different kinds. Example: (defun repeat-command (command) "Repeat COMMAND. (more explanation needed)" (interactive) (let ((repeat-previous-repeated-command command) (last-repeatable-command 'repeat)) (repeat nil))) (defun backward-char-repeat () "Like `backward-char'. (more explanation needed)" (interactive) (repeat-command 'backward-char)) (define-key ctl-x-map [up] 'backward-char-repeat) Now do C-x ... to repeat the command `backward-char'. In this case, the particular command that is repeated is not very interesting, and it already has a binding that does not use a prefix key - a key (`C-b') that is itself repeatable. But you get the idea: the idiom works with any command, and it lets me put such commands along with other commands on a common prefix for a given mode. For example, I put `bookmark-map' on a prefix key `C-x p', so all bookmark commands are available on the same prefix. This includes bookmark navigation/cycling commands, which are repeatable. There are several kinds of cycling, with different bookmark navigation lists: C-x p f, C-x p b: cycle bookmarks from the current navigation list (which can be any set of bookmarks, in a particular sort order) C-x p n, C-x p p: cycle the bookmarks of the current file/buffer C-x p C-, C-x p C-: cycle highlighted bookmarks in file E.g., C-x p n n n n n n... cycles bookmarks in the current file. This technique works in all Emacs versions since repeat.el was introduced, which was Emacs 22, I believe. It works in Emacs 24 also, up through a build of 2012-04-30. It does not work in Emacs 24 builds I have, starting with 2012-05-07. This is an important feature for me. I really hope it will be fixed. The symptom of the breakage is this: It seems to work at first: it can be repeated twice (always, it seems), and then I get this when I hit the repeatable key the third time: Debugger entered--Lisp error: (error "Lisp nesting exceeds `max-lisp-eval-d= epth'") repeat(nil) call-interactively(repeat) #[0 "..." [ignore repeat-message-function this-command repeat call-intera= ctively] 2 "\n\n(fn)" nil]() call-interactively(#[0 "..." [ignore repeat-message-function this-command= repeat call-interactively] 2 "\n\n(fn)" nil]) repeat(nil) call-interactively(repeat) #[0 "..." [ignore repeat-message-function this-command repeat call-intera= ctively] 2 "\n\n(fn)" nil]() call-interactively(#[0 "..." [ignore repeat-message-function this-command repeat call-interactively] 2 "\n\n(fn)" nil]) ... repeat(nil) call-interactively(repeat) #[0 "..." [ignore repeat-message-function this-command repeat call-intera= ctively] 2 "\n\n(fn)" nil]() call-interactively(#[0 "..." [ignore repeat-message-function this-command repeat call-interactively] 2 "\n\n(fn)" nil] nil nil) Here is the backtrace when I load repeat.el instead of repeat.elc: Debugger entered--Lisp error: (error "Lisp nesting exceeds `max-lisp-eval-d= epth'") (when (eq last-repeatable-command (quote repeat)) (setq last-repeatable-c= ommand repeat-previous-repeated-command)) repeat(nil) call-interactively(repeat) (let ((repeat-message-function fun)) (setq this-command (quote repeat)) (= call-interactively (quote repeat))) (closure ((fun . ignore) (map keymap (down closure #1 nil (interactive) (= let ((repeat-message-function fun)) (setq this-command (quote repeat)) (cal= l-interactively (quote repeat))))) (repeat-repeat-char . down) (repeat-arg)= t) nil (interactive) (let ((repeat-message-function fun)) (setq this-comma= nd (quote repeat)) (call-interactively (quote repeat))))() call-interactively((closure ((fun . ignore) (map keymap (down closure #1 = nil (interactive) (let ((repeat-message-function fun)) (setq this-command (= quote repeat)) (call-interactively (quote repeat))))) (repeat-repeat-char .= down) (repeat-arg) t) nil (interactive) (let ((repeat-message-function fun= )) (setq this-command (quote repeat)) (call-interactively (quote repeat))))) (if (or (stringp indirect) (vectorp indirect)) (let ((last-repeatable-com= mand last-repeatable-command)) (execute-kbd-macro last-repeatable-command))= (call-interactively last-repeatable-command)) (let ((indirect (indirect-function last-repeatable-command))) (if (or (st= ringp indirect) (vectorp indirect)) (let ((last-repeatable-command last-rep= eatable-command)) (execute-kbd-macro last-repeatable-command)) (call-intera= ctively last-repeatable-command))) (if (memq last-repeatable-command (quote (exit-minibuffer minibuffer-comp= lete-and-exit self-insert-and-exit))) (let ((repeat-command (car command-hi= story))) (repeat-message "Repeating %S" repeat-command) (eval repeat-comman= d)) (if (null repeat-arg) (repeat-message "Repeating command %S" last-repea= table-command) (setq current-prefix-arg repeat-arg) (repeat-message "Repeat= ing command %S %S" repeat-arg last-repeatable-command)) (when (eq last-repe= atable-command (quote self-insert-command)) (setq last-command-event (char-= before))) (let ((indirect (indirect-function last-repeatable-command))) (if= (or (stringp indirect) (vectorp indirect)) (let ((last-repeatable-command = last-repeatable-command)) (execute-kbd-macro last-repeatable-command)) (cal= l-interactively last-repeatable-command)))) (let ((repeat-repeat-char (if (eq repeat-on-final-keystroke t) last-comma= nd-event (car (memq last-command-event (listify-key-sequence repeat-on-fina= l-keystroke)))))) (if (memq last-repeatable-command (quote (exit-minibuffer= minibuffer-complete-and-exit self-insert-and-exit))) (let ((repeat-command= (car command-history))) (repeat-message "Repeating %S" repeat-command) (ev= al repeat-command)) (if (null repeat-arg) (repeat-message "Repeating comman= d %S" last-repeatable-command) (setq current-prefix-arg repeat-arg) (repeat= -message "Repeating command %S %S" repeat-arg last-repeatable-command)) (wh= en (eq last-repeatable-command (quote self-insert-command)) (setq last-comm= and-event (char-before))) (let ((indirect (indirect-function last-repeatabl= e-command))) (if (or (stringp indirect) (vectorp indirect)) (let ((last-rep= eatable-command last-repeatable-command)) (execute-kbd-macro last-repeatabl= e-command)) (call-interactively last-repeatable-command)))) (when repeat-re= peat-char (set-temporary-overlay-map (let ((map (make-sparse-keymap))) (def= ine-key map (vector repeat-repeat-char) (if (null repeat-message-function) = (quote repeat) (let (...) (lambda nil ... ...)))) map)))) repeat(nil) call-interactively(repeat) (let ((repeat-message-function fun)) (setq this-command (quote repeat)) (= call-interactively (quote repeat))) (closure ((fun . ignore) (map keymap (down closure #1 nil (interactive) (= let ((repeat-message-function fun)) (setq this-command (quote repeat)) (cal= l-interactively (quote repeat))))) (repeat-repeat-char . down) (repeat-arg)= t) nil (interactive) (let ((repeat-message-function fun)) (setq this-comma= nd (quote repeat)) (call-interactively (quote repeat))))() call-interactively((closure ((fun . ignore) (map keymap (down closure #1 = nil (interactive) (let ((repeat-message-function fun)) (setq this-command (= quote repeat)) (call-interactively (quote repeat))))) (repeat-repeat-char .= down) (repeat-arg) t) nil (interactive) (let ((repeat-message-function fun= )) (setq this-command (quote repeat)) (call-interactively (quote repeat))))) (if (or (stringp indirect) (vectorp indirect)) (let ((last-repeatable-com= mand last-repeatable-command)) (execute-kbd-macro last-repeatable-command))= (call-interactively last-repeatable-command)) (let ((indirect (indirect-function last-repeatable-command))) (if (or (st= ringp indirect) (vectorp indirect)) (let ((last-repeatable-command last-rep= eatable-command)) (execute-kbd-macro last-repeatable-command)) (call-intera= ctively last-repeatable-command))) (if (memq last-repeatable-command (quote (exit-minibuffer minibuffer-comp= lete-and-exit self-insert-and-exit))) (let ((repeat-command (car command-hi= story))) (repeat-message "Repeating %S" repeat-command) (eval repeat-comman= d)) (if (null repeat-arg) (repeat-message "Repeating command %S" last-repea= table-command) (setq current-prefix-arg repeat-arg) (repeat-message "Repeat= ing command %S %S" repeat-arg last-repeatable-command)) (when (eq last-repe= atable-command (quote self-insert-command)) (setq last-command-event (char-= before))) (let ((indirect (indirect-function last-repeatable-command))) (if= (or (stringp indirect) (vectorp indirect)) (let ((last-repeatable-command = last-repeatable-command)) (execute-kbd-macro last-repeatable-command)) (cal= l-interactively last-repeatable-command)))) (let ((repeat-repeat-char (if (eq repeat-on-final-keystroke t) last-comma= nd-event (car (memq last-command-event (listify-key-sequence repeat-on-fina= l-keystroke)))))) (if (memq last-repeatable-command (quote (exit-minibuffer= minibuffer-complete-and-exit self-insert-and-exit))) (let ((repeat-command= (car command-history))) (repeat-message "Repeating %S" repeat-command) (ev= al repeat-command)) (if (null repeat-arg) (repeat-message "Repeating comman= d %S" last-repeatable-command) (setq current-prefix-arg repeat-arg) (repeat= -message "Repeating command %S %S" repeat-arg last-repeatable-command)) (wh= en (eq last-repeatable-command (quote self-insert-command)) (setq last-comm= and-event (char-before))) (let ((indirect (indirect-function last-repeatabl= e-command))) (if (or (stringp indirect) (vectorp indirect)) (let ((last-rep= eatable-command last-repeatable-command)) (execute-kbd-macro last-repeatabl= e-command)) (call-interactively last-repeatable-command)))) (when repeat-re= peat-char (set-temporary-overlay-map (let ((map (make-sparse-keymap))) (def= ine-key map (vector repeat-repeat-char) (if (null repeat-message-function) = (quote repeat) (let (...) (lambda nil ... ...)))) map)))) ... repeat(nil) call-interactively(repeat) (let ((repeat-message-function fun)) (setq this-command (quote repeat)) (= call-interactively (quote repeat))) (closure ((fun . ignore) (map keymap (down closure #1 nil (interactive) (= let ((repeat-message-function fun)) (setq this-command (quote repeat)) (cal= l-interactively (quote repeat))))) (repeat-repeat-char . down) (repeat-arg)= t) nil (interactive) (let ((repeat-message-function fun)) (setq this-comma= nd (quote repeat)) (call-interactively (quote repeat))))() call-interactively((closure ((fun . ignore) (map keymap (down closure #1 = nil (interactive) (let ((repeat-message-function fun)) (setq this-command (= quote repeat)) (call-interactively (quote repeat))))) (repeat-repeat-char .= down) (repeat-arg) t) nil (interactive) (let ((repeat-message-function fun= )) (setq this-command (quote repeat)) (call-interactively (quote repeat))))= nil nil) As you no doubt know, it is very difficult to debug uses of repeat.el. It is impossible to use the debugger, and even printing `message's is problematic. Hopefully this info will help. You should be able to reproduce the problem using the code above. If you try it in an older version you will see what it should do. In GNU Emacs 24.1.50.1 (i386-mingw-nt5.1.2600) of 2012-08-13 on MARVIN Bzr revision: 109584 monnier@iro.umontreal.ca-20120813141247-76irjqslrfncn3= 0u Windowing system distributor `Microsoft Corp.', version 5.1.2600 Configured using: `configure --with-gcc (4.6) --no-opt --enable-checking --cflags -ID:/devel/emacs/libs/libXpm-3.5.8/include -ID:/devel/emacs/libs/libXpm-3.5.8/src -ID:/devel/emacs/libs/libpng-dev_1.4.3-1/include -ID:/devel/emacs/libs/zlib-dev_1.2.5-2/include -ID:/devel/emacs/libs/giflib-4.1.4-1/include -ID:/devel/emacs/libs/jpeg-6b-4/include -ID:/devel/emacs/libs/tiff-3.8.2-1/include -ID:/devel/emacs/libs/gnutls-3.0.9/include -ID:/devel/emacs/libs/libiconv-1.13.1-1-dev/include -ID:/devel/emacs/libs/libxml2-2.7.8/include/libxml2' From debbugs-submit-bounces@debbugs.gnu.org Fri Aug 24 10:58:17 2012 Received: (at 12232) by debbugs.gnu.org; 24 Aug 2012 14:58:17 +0000 Received: from localhost ([127.0.0.1]:47001 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1T4vKy-00030L-Vt for submit@debbugs.gnu.org; Fri, 24 Aug 2012 10:58:17 -0400 Received: from acsinet15.oracle.com ([141.146.126.227]:25899) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1T4vKx-00030E-O7 for 12232@debbugs.gnu.org; Fri, 24 Aug 2012 10:58:16 -0400 Received: from ucsinet22.oracle.com (ucsinet22.oracle.com [156.151.31.94]) by acsinet15.oracle.com (Sentrion-MTA-4.2.2/Sentrion-MTA-4.2.2) with ESMTP id q7OEva2F014399 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for <12232@debbugs.gnu.org>; Fri, 24 Aug 2012 14:57:37 GMT Received: from acsmt357.oracle.com (acsmt357.oracle.com [141.146.40.157]) by ucsinet22.oracle.com (8.14.4+Sun/8.14.4) with ESMTP id q7OEva6j020113 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO) for <12232@debbugs.gnu.org>; Fri, 24 Aug 2012 14:57:36 GMT Received: from abhmt103.oracle.com (abhmt103.oracle.com [141.146.116.55]) by acsmt357.oracle.com (8.12.11.20060308/8.12.11) with ESMTP id q7OEvZBO025736 for <12232@debbugs.gnu.org>; Fri, 24 Aug 2012 09:57:35 -0500 Received: from dradamslap1 (/10.159.173.105) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Fri, 24 Aug 2012 07:57:35 -0700 From: "Drew Adams" To: <12232@debbugs.gnu.org> References: <26617CF879E04A6689018BFA901EF01A@us.oracle.com> Subject: RE: bug#12232: 24.1.50; regression: repeat.el commit 2012-05-05 breaks repeating commands Date: Fri, 24 Aug 2012 07:57:31 -0700 Message-ID: <14F60E44174644FBA0F21D20D1477DD4@us.oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Mailer: Microsoft Office Outlook 11 In-Reply-To: <26617CF879E04A6689018BFA901EF01A@us.oracle.com> X-MimeOLE: Produced By Microsoft MimeOLE V6.00.2900.6157 Thread-Index: Ac19th790A4wIXJ9Tpu3w2xXIEPQ5gEUoMhA X-Source-IP: ucsinet22.oracle.com [156.151.31.94] X-Spam-Score: -7.1 (-------) X-Debbugs-Envelope-To: 12232 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -7.1 (-------) ping. > I believe this regression was introduced by the following commit: > Stefan Monnier2012-05-05 02:50:20Revision ID: > monnier@iro.umontreal.ca-2012= > 0505025020-ihjvoqehkrxkfxw8 > > Use set-temporary-overlay-map. > * lisp/repeat.el: Use lexical-binding. > (repeat-last-self-insert, repeat-num-input-keys-at-self-insert) > (repeat-undo-count): Remove. > (repeat): From debbugs-submit-bounces@debbugs.gnu.org Mon Sep 03 11:35:07 2012 Received: (at 12232) by debbugs.gnu.org; 3 Sep 2012 15:35:07 +0000 Received: from localhost ([127.0.0.1]:36492 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1T8Yg6-0000Np-TC for submit@debbugs.gnu.org; Mon, 03 Sep 2012 11:35:07 -0400 Received: from acsinet15.oracle.com ([141.146.126.227]:18759) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1T8Yg4-0000Ng-9K for 12232@debbugs.gnu.org; Mon, 03 Sep 2012 11:35:05 -0400 Received: from acsinet21.oracle.com (acsinet21.oracle.com [141.146.126.237]) by acsinet15.oracle.com (Sentrion-MTA-4.2.2/Sentrion-MTA-4.2.2) with ESMTP id q83FXSRS027022 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Mon, 3 Sep 2012 15:33:29 GMT Received: from acsmt356.oracle.com (acsmt356.oracle.com [141.146.40.156]) by acsinet21.oracle.com (8.14.4+Sun/8.14.4) with ESMTP id q83FXRj5009401 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Mon, 3 Sep 2012 15:33:28 GMT Received: from abhmt112.oracle.com (abhmt112.oracle.com [141.146.116.64]) by acsmt356.oracle.com (8.12.11.20060308/8.12.11) with ESMTP id q83FXRwA007665; Mon, 3 Sep 2012 10:33:27 -0500 Received: from dradamslap1 (/71.202.147.44) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Mon, 03 Sep 2012 08:33:27 -0700 From: "Drew Adams" To: <12232@debbugs.gnu.org> References: <26617CF879E04A6689018BFA901EF01A@us.oracle.com> <14F60E44174644FBA0F21D20D1477DD4@us.oracle.com> Subject: RE: bug#12232: 24.1.50; regression: repeat.el commit 2012-05-05 breaks repeating commands Date: Mon, 3 Sep 2012 08:33:12 -0700 Message-ID: <54F3F95EA9924540A41367629A87A389@us.oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Priority: 1 (Highest) X-MSMail-Priority: High X-Mailer: Microsoft Office Outlook 11 In-Reply-To: <14F60E44174644FBA0F21D20D1477DD4@us.oracle.com> Thread-Index: Ac19th790A4wIXJ9Tpu3w2xXIEPQ5gEUoMhAAfdhlrA= X-MimeOLE: Produced By Microsoft MimeOLE V6.00.2900.6157 Importance: High X-Message-Flag: Follow up X-Source-IP: acsinet21.oracle.com [141.146.126.237] X-Spam-Score: -7.1 (-------) X-Debbugs-Envelope-To: 12232 Cc: Stefan Monnier X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -7.1 (-------) ping. Stefan, could you please take a look at this? I diff'd the change you made on 2012-05-05, but the code and the change is not easy (for me) to fathom. This comment in the version of repeat.el before your change might be pertinent, as it refers to a symptom (nesting exceeding `max-lisp-eval-depth') similar to what I am seeing now: ;; A simple recursion here gets into trouble with max-lisp-eval-depth ;; on long sequences of repetitions of a command like `forward-word' ;; (only 32 repetitions are possible given the default value of 200 for ;; max-lisp-eval-depth), but if I now locally disable the repeat char I ;; can iterate indefinitely here around a single level of recursion. Thx - Drew > ping. > > > I believe this regression was introduced by the following commit: > > Stefan Monnier2012-05-05 02:50:20Revision ID: > > monnier@iro.umontreal.ca-2012= > > 0505025020-ihjvoqehkrxkfxw8 > > > > Use set-temporary-overlay-map. > > * lisp/repeat.el: Use lexical-binding. > > (repeat-last-self-insert, repeat-num-input-keys-at-self-insert) > > (repeat-undo-count): Remove. > > (repeat): ... > > Debugger entered--Lisp error: (error "Lisp nesting exceeds `max-lisp-eval-d= epth'") repeat(nil) call-interactively(repeat) #[0 "..." [ignore repeat-message-function this-command repeat call-intera= ctively] 2 "\n\n(fn)" nil]() call-interactively(#[0 "..." [ignore repeat-message-function this-command= repeat call-interactively] 2 "\n\n(fn)" nil]) repeat(nil) call-interactively(repeat) #[0 "..." [ignore repeat-message-function this-command repeat call-intera= ctively] 2 "\n\n(fn)" nil]() call-interactively(#[0 "..." [ignore repeat-message-function this-command repeat call-interactively] 2 "\n\n(fn)" nil]) ... repeat(nil) call-interactively(repeat) ... From debbugs-submit-bounces@debbugs.gnu.org Mon Sep 03 23:55:44 2012 Received: (at 12232) by debbugs.gnu.org; 4 Sep 2012 03:55:44 +0000 Received: from localhost ([127.0.0.1]:37342 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1T8kEp-0001PK-FI for submit@debbugs.gnu.org; Mon, 03 Sep 2012 23:55:44 -0400 Received: from acsinet15.oracle.com ([141.146.126.227]:23412) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1T8kEn-0001PC-1X for 12232@debbugs.gnu.org; Mon, 03 Sep 2012 23:55:41 -0400 Received: from acsinet22.oracle.com (acsinet22.oracle.com [141.146.126.238]) by acsinet15.oracle.com (Sentrion-MTA-4.2.2/Sentrion-MTA-4.2.2) with ESMTP id q843s20P013485 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Tue, 4 Sep 2012 03:54:03 GMT Received: from acsmt358.oracle.com (acsmt358.oracle.com [141.146.40.158]) by acsinet22.oracle.com (8.14.4+Sun/8.14.4) with ESMTP id q843s1ll001027 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Tue, 4 Sep 2012 03:54:02 GMT Received: from abhmt119.oracle.com (abhmt119.oracle.com [141.146.116.71]) by acsmt358.oracle.com (8.12.11.20060308/8.12.11) with ESMTP id q843rxE1024447; Mon, 3 Sep 2012 22:54:01 -0500 Received: from dradamslap1 (/71.202.147.44) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Mon, 03 Sep 2012 20:53:59 -0700 From: "Drew Adams" To: <12232@debbugs.gnu.org> References: <26617CF879E04A6689018BFA901EF01A@us.oracle.com><14F60E44174644FBA0F21D20D1477DD4@us.oracle.com> <54F3F95EA9924540A41367629A87A389@us.oracle.com> Subject: RE: bug#12232: 24.1.50; regression: repeat.el commit 2012-05-05 breaks repeating commands Date: Mon, 3 Sep 2012 20:53:43 -0700 Message-ID: <4C0A1DE8E67F4B1CA042021E47552C18@us.oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Mailer: Microsoft Office Outlook 11 In-Reply-To: <54F3F95EA9924540A41367629A87A389@us.oracle.com> Thread-Index: Ac19th790A4wIXJ9Tpu3w2xXIEPQ5gEUoMhAAfdhlrAAGhyRAA== X-MimeOLE: Produced By Microsoft MimeOLE V6.00.2900.6157 X-Source-IP: acsinet22.oracle.com [141.146.126.238] X-Spam-Score: -7.1 (-------) X-Debbugs-Envelope-To: 12232 Cc: Stefan Monnier X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -7.1 (-------) > Stefan, could you please take a look at this? > > This comment in the version of repeat.el before your change > might be pertinent, as it refers to a symptom (nesting exceeding > `max-lisp-eval-depth') similar to what I am seeing now: > > ;; A simple recursion here gets into trouble with > ;; max-lisp-eval-depth on long sequences of repetitions > ;; of a command like `forward-word' (only 32 repetitions > ;; are possible given the default value of 200 for > ;; max-lisp-eval-depth), but if I now locally disable > ;; the repeat char I can iterate indefinitely here > ;; around a single level of recursion. I did not send quite the correct code to repro the problem. The problem arises when I add this binding to the let: (repeat-message-function 'ignore) I.e., (defun repeat-command (command) "Repeat COMMAND." (interactive) (let ((repeat-previous-repeated-command command) (repeat-message-function 'ignore) ; <===== (last-repeatable-command 'repeat)) (repeat nil))) (defun backward-char-repeat () "Like `backward-char'..." (interactive) (repeat-command 'backward-char)) (define-key ctl-x-map [up] 'backward-char-repeat) The binding of `repeat-message-function' to `ignore' is to suppress a repeat message. If I need to do that differently from now on, please advise how - IOW, how to work around this `max-lisp-eval-depth' bug. Thx. From debbugs-submit-bounces@debbugs.gnu.org Sun Sep 16 19:32:37 2012 Received: (at 12232) by debbugs.gnu.org; 16 Sep 2012 23:32:37 +0000 Received: from localhost ([127.0.0.1]:37644 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TDOKK-0005Dx-LL for submit@debbugs.gnu.org; Sun, 16 Sep 2012 19:32:37 -0400 Received: from rcsinet15.oracle.com ([148.87.113.117]:38558) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TDOKI-0005Dk-U6 for 12232@debbugs.gnu.org; Sun, 16 Sep 2012 19:32:35 -0400 Received: from acsinet21.oracle.com (acsinet21.oracle.com [141.146.126.237]) by rcsinet15.oracle.com (Sentrion-MTA-4.2.2/Sentrion-MTA-4.2.2) with ESMTP id q8GNVMuD024748 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for <12232@debbugs.gnu.org>; Sun, 16 Sep 2012 23:31:23 GMT Received: from acsmt358.oracle.com (acsmt358.oracle.com [141.146.40.158]) by acsinet21.oracle.com (8.14.4+Sun/8.14.4) with ESMTP id q8GNVL3U005587 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO) for <12232@debbugs.gnu.org>; Sun, 16 Sep 2012 23:31:22 GMT Received: from abhmt105.oracle.com (abhmt105.oracle.com [141.146.116.57]) by acsmt358.oracle.com (8.12.11.20060308/8.12.11) with ESMTP id q8GNVLNO008561 for <12232@debbugs.gnu.org>; Sun, 16 Sep 2012 18:31:21 -0500 Received: from dradamslap1 (/10.159.170.142) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Sun, 16 Sep 2012 16:31:21 -0700 From: "Drew Adams" To: <12232@debbugs.gnu.org> References: <26617CF879E04A6689018BFA901EF01A@us.oracle.com><14F60E44174644FBA0F21D20D1477DD4@us.oracle.com><54F3F95EA9924540A41367629A87A389@us.oracle.com> <4C0A1DE8E67F4B1CA042021E47552C18@us.oracle.com> Subject: RE: bug#12232: 24.1.50; regression: repeat.el commit 2012-05-05 breaks repeating commands Date: Sun, 16 Sep 2012 16:31:10 -0700 Message-ID: <369FB5C211D4407489000C7115235169@us.oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Mailer: Microsoft Office Outlook 11 In-Reply-To: <4C0A1DE8E67F4B1CA042021E47552C18@us.oracle.com> Thread-Index: Ac19th790A4wIXJ9Tpu3w2xXIEPQ5gEUoMhAAfdhlrAAGhyRAAKFJqyA X-MimeOLE: Produced By Microsoft MimeOLE V6.00.2900.6157 X-Source-IP: acsinet21.oracle.com [141.146.126.237] X-Spam-Score: -7.4 (-------) X-Debbugs-Envelope-To: 12232 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -7.4 (-------) > > Stefan, could you please take a look at this? > > > > This comment in the version of repeat.el before your change > > might be pertinent, as it refers to a symptom (nesting exceeding > > `max-lisp-eval-depth') similar to what I am seeing now: > > > > ;; A simple recursion here gets into trouble with > > ;; max-lisp-eval-depth on long sequences of repetitions > > ;; of a command like `forward-word' (only 32 repetitions > > ;; are possible given the default value of 200 for > > ;; max-lisp-eval-depth), but if I now locally disable > > ;; the repeat char I can iterate indefinitely here > > ;; around a single level of recursion. > > The problem arises when I add this binding to the let: > (repeat-message-function 'ignore) > > I.e., > (defun repeat-command (command) > "Repeat COMMAND." > (interactive) > (let ((repeat-previous-repeated-command command) > (repeat-message-function 'ignore) ; <===== > (last-repeatable-command 'repeat)) > (repeat nil))) > > (defun backward-char-repeat () > "Like `backward-char'..." > (interactive) > (repeat-command 'backward-char)) > > (define-key ctl-x-map [up] 'backward-char-repeat) > > The binding of `repeat-message-function' to `ignore' is to > suppress a repeat message. If I need to do that differently > from now on, please advise how - IOW, how to work around > this `max-lisp-eval-depth' bug. Thx. ping From debbugs-submit-bounces@debbugs.gnu.org Sun Sep 23 20:50:59 2012 Received: (at 12232) by debbugs.gnu.org; 24 Sep 2012 00:50:59 +0000 Received: from localhost ([127.0.0.1]:51742 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TFwt0-000416-Nn for submit@debbugs.gnu.org; Sun, 23 Sep 2012 20:50:59 -0400 Received: from rcsinet15.oracle.com ([148.87.113.117]:43686) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TFwsz-00040z-2x for 12232@debbugs.gnu.org; Sun, 23 Sep 2012 20:50:57 -0400 Received: from acsinet22.oracle.com (acsinet22.oracle.com [141.146.126.238]) by rcsinet15.oracle.com (Sentrion-MTA-4.2.2/Sentrion-MTA-4.2.2) with ESMTP id q8O0n4UY021568 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Mon, 24 Sep 2012 00:49:05 GMT Received: from acsmt356.oracle.com (acsmt356.oracle.com [141.146.40.156]) by acsinet22.oracle.com (8.14.4+Sun/8.14.4) with ESMTP id q8O0n3Gj026338 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Mon, 24 Sep 2012 00:49:04 GMT Received: from abhmt104.oracle.com (abhmt104.oracle.com [141.146.116.56]) by acsmt356.oracle.com (8.12.11.20060308/8.12.11) with ESMTP id q8O0n3Co032171; Sun, 23 Sep 2012 19:49:03 -0500 Received: from dradamslap1 (/10.159.184.34) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Sun, 23 Sep 2012 17:49:03 -0700 From: "Drew Adams" To: <12232@debbugs.gnu.org> References: <26617CF879E04A6689018BFA901EF01A@us.oracle.com><14F60E44174644FBA0F21D20D1477DD4@us.oracle.com><54F3F95EA9924540A41367629A87A389@us.oracle.com><4C0A1DE8E67F4B1CA042021E47552C18@us.oracle.com> <369FB5C211D4407489000C7115235169@us.oracle.com> Subject: RE: bug#12232: 24.1.50; regression: repeat.el commit 2012-05-05 breaks repeating commands Date: Sun, 23 Sep 2012 17:48:51 -0700 Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Mailer: Microsoft Office Outlook 11 In-Reply-To: <369FB5C211D4407489000C7115235169@us.oracle.com> X-MimeOLE: Produced By Microsoft MimeOLE V6.00.2900.6157 Thread-Index: Ac19th790A4wIXJ9Tpu3w2xXIEPQ5gEUoMhAAfdhlrAAGhyRAAKFJqyAAWKbuhA= X-Source-IP: acsinet22.oracle.com [141.146.126.238] X-Spam-Score: -7.7 (-------) X-Debbugs-Envelope-To: 12232 Cc: 'Stefan Monnier' X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -7.7 (-------) > The problem arises when I add this binding > (repeat-message-function 'ignore) > to suppress a repeat message. > > If I need to do that differently from now on, please advise > how - IOW, how to work around this `max-lisp-eval-depth' bug. > Thx. ping Note that in bug #6256, you said that no changes would be needed to code such as I've shown because of the new implementation that uses `set-temporary-overlay-map'. That was true up until the change you made on 2012-05-05. Please advise how to handle this new problem. Thx. From debbugs-submit-bounces@debbugs.gnu.org Thu Oct 18 21:56:15 2012 Received: (at 12232) by debbugs.gnu.org; 19 Oct 2012 01:56:15 +0000 Received: from localhost ([127.0.0.1]:50777 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TP1os-0005SK-Pt for submit@debbugs.gnu.org; Thu, 18 Oct 2012 21:56:15 -0400 Received: from rcsinet15.oracle.com ([148.87.113.117]:41320) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TP1oq-0005S1-65 for 12232@debbugs.gnu.org; Thu, 18 Oct 2012 21:56:12 -0400 Received: from acsinet21.oracle.com (acsinet21.oracle.com [141.146.126.237]) by rcsinet15.oracle.com (Sentrion-MTA-4.2.2/Sentrion-MTA-4.2.2) with ESMTP id q9J1scbm020075 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for <12232@debbugs.gnu.org>; Fri, 19 Oct 2012 01:54:39 GMT Received: from acsmt357.oracle.com (acsmt357.oracle.com [141.146.40.157]) by acsinet21.oracle.com (8.14.4+Sun/8.14.4) with ESMTP id q9J1scxr027107 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO) for <12232@debbugs.gnu.org>; Fri, 19 Oct 2012 01:54:38 GMT Received: from abhmt110.oracle.com (abhmt110.oracle.com [141.146.116.62]) by acsmt357.oracle.com (8.12.11.20060308/8.12.11) with ESMTP id q9J1sc9s031659 for <12232@debbugs.gnu.org>; Thu, 18 Oct 2012 20:54:38 -0500 Received: from dradamslap1 (/10.159.186.224) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Thu, 18 Oct 2012 18:54:38 -0700 From: "Drew Adams" To: <12232@debbugs.gnu.org> References: <26617CF879E04A6689018BFA901EF01A@us.oracle.com><14F60E44174644FBA0F21D20D1477DD4@us.oracle.com><54F3F95EA9924540A41367629A87A389@us.oracle.com><4C0A1DE8E67F4B1CA042021E47552C18@us.oracle.com><369FB5C211D4407489000C7115235169@us.oracle.com> Subject: RE: bug#12232: 24.1.50; regression: repeat.el commit 2012-05-05 breaks repeating commands Date: Thu, 18 Oct 2012 18:54:13 -0700 Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Mailer: Microsoft Office Outlook 11 In-Reply-To: X-MimeOLE: Produced By Microsoft MimeOLE V6.00.2900.6157 thread-index: Ac19th790A4wIXJ9Tpu3w2xXIEPQ5gEUoMhAAfdhlrAAGhyRAAKFJqyAAWKbuhAE66qpUA== X-Source-IP: acsinet21.oracle.com [141.146.126.237] X-Spam-Score: -4.6 (----) X-Debbugs-Envelope-To: 12232 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -4.6 (----) > > The problem arises when I add this binding > > (repeat-message-function 'ignore) > > to suppress a repeat message. > > > > If I need to do that differently from now on, please advise > > how - IOW, how to work around this `max-lisp-eval-depth' bug. > > Thx. > > ping > > Note that in bug #6256, you said that no changes would be > needed to code such as > I've shown because of the new implementation that uses > `set-temporary-overlay-map'. > > That was true up until the change you made on 2012-05-05. > Please advise how to handle this new problem. Thx. ping Please respond to this bug report. The regression was introduced 6 months ago. Thx. From debbugs-submit-bounces@debbugs.gnu.org Fri Oct 19 10:18:13 2012 Received: (at 12232) by debbugs.gnu.org; 19 Oct 2012 14:18:13 +0000 Received: from localhost ([127.0.0.1]:51791 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TPDOv-0006JM-6c for submit@debbugs.gnu.org; Fri, 19 Oct 2012 10:18:13 -0400 Received: from chene.dit.umontreal.ca ([132.204.246.20]:51216) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TPDOs-0006J9-OW; Fri, 19 Oct 2012 10:18:11 -0400 Received: from faina.iro.umontreal.ca (lechon.iro.umontreal.ca [132.204.27.242]) by chene.dit.umontreal.ca (8.14.1/8.14.1) with ESMTP id q9JEGdAQ026954; Fri, 19 Oct 2012 10:16:40 -0400 Received: by faina.iro.umontreal.ca (Postfix, from userid 20848) id D0012B40A1; Fri, 19 Oct 2012 10:16:39 -0400 (EDT) From: Stefan Monnier To: "Drew Adams" Subject: Re: bug#12232: 24.1.50; regression: repeat.el commit 2012-05-05 breaks repeating commands Message-ID: References: <26617CF879E04A6689018BFA901EF01A@us.oracle.com> <14F60E44174644FBA0F21D20D1477DD4@us.oracle.com> <54F3F95EA9924540A41367629A87A389@us.oracle.com> <4C0A1DE8E67F4B1CA042021E47552C18@us.oracle.com> <369FB5C211D4407489000C7115235169@us.oracle.com> Date: Fri, 19 Oct 2012 10:16:39 -0400 In-Reply-To: (Drew Adams's message of "Thu, 18 Oct 2012 18:54:13 -0700") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.2.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-NAI-Spam-Flag: NO X-NAI-Spam-Threshold: 5 X-NAI-Spam-Score: 0 X-NAI-Spam-Rules: 1 Rules triggered RV4376=0 X-NAI-Spam-Version: 2.2.0.9309 : core <4376> : streams <841312> : uri <1247177> X-Spam-Score: -1.2 (-) X-Debbugs-Envelope-To: 12232 Cc: 12232@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.0 (--) severity 12232 important thanks > The regression was introduced 6 months ago. Yes, I need to fix it before the release, I know. Stefan From debbugs-submit-bounces@debbugs.gnu.org Fri Oct 19 10:34:35 2012 Received: (at 12232) by debbugs.gnu.org; 19 Oct 2012 14:34:36 +0000 Received: from localhost ([127.0.0.1]:51825 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TPDek-0007Yr-Uj for submit@debbugs.gnu.org; Fri, 19 Oct 2012 10:34:35 -0400 Received: from acsinet15.oracle.com ([141.146.126.227]:51324) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TPDei-0007Yd-KY for 12232@debbugs.gnu.org; Fri, 19 Oct 2012 10:34:33 -0400 Received: from ucsinet22.oracle.com (ucsinet22.oracle.com [156.151.31.94]) by acsinet15.oracle.com (Sentrion-MTA-4.2.2/Sentrion-MTA-4.2.2) with ESMTP id q9JEWtLs006684 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Fri, 19 Oct 2012 14:32:56 GMT Received: from acsmt358.oracle.com (acsmt358.oracle.com [141.146.40.158]) by ucsinet22.oracle.com (8.14.4+Sun/8.14.4) with ESMTP id q9JEWsCm016537 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Fri, 19 Oct 2012 14:32:54 GMT Received: from abhmt120.oracle.com (abhmt120.oracle.com [141.146.116.72]) by acsmt358.oracle.com (8.12.11.20060308/8.12.11) with ESMTP id q9JEWsNn025193; Fri, 19 Oct 2012 09:32:54 -0500 Received: from dradamslap1 (/10.159.217.151) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Fri, 19 Oct 2012 07:32:53 -0700 From: "Drew Adams" To: "'Stefan Monnier'" References: <26617CF879E04A6689018BFA901EF01A@us.oracle.com><14F60E44174644FBA0F21D20D1477DD4@us.oracle.com><54F3F95EA9924540A41367629A87A389@us.oracle.com><4C0A1DE8E67F4B1CA042021E47552C18@us.oracle.com><369FB5C211D4407489000C7115235169@us.oracle.com> Subject: RE: bug#12232: 24.1.50; regression: repeat.el commit 2012-05-05 breaks repeating commands Date: Fri, 19 Oct 2012 07:32:27 -0700 Message-ID: <8978F49FABE64BD1A0562E5EDAD1A549@us.oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Mailer: Microsoft Office Outlook 11 In-Reply-To: Thread-Index: Ac2uBF3Gi6ighiNkSce6/FHY+MtJHgAAf+bQ X-MimeOLE: Produced By Microsoft MimeOLE V6.00.2900.6157 X-Source-IP: ucsinet22.oracle.com [156.151.31.94] X-Spam-Score: -4.6 (----) X-Debbugs-Envelope-To: 12232 Cc: 12232@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -4.6 (----) > severity 12232 important > thanks > > > The regression was introduced 6 months ago. > > Yes, I need to fix it before the release, I know. Thanks very much. That reassurance is what I was looking for. From debbugs-submit-bounces@debbugs.gnu.org Tue Oct 23 13:00:22 2012 Received: (at 12232-done) by debbugs.gnu.org; 23 Oct 2012 17:00:22 +0000 Received: from localhost ([127.0.0.1]:58051 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TQhq2-00058V-1E for submit@debbugs.gnu.org; Tue, 23 Oct 2012 13:00:22 -0400 Received: from ironport2-out.teksavvy.com ([206.248.154.182]:6529) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TQhq0-00058K-IE for 12232-done@debbugs.gnu.org; Tue, 23 Oct 2012 13:00:21 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: Ai0FAG6Zu09MCqNj/2dsb2JhbABEsEiDSYEIghYBBVYjEAs0EhQYDSSIIboJkEQDozOBWIMF X-IronPort-AV: E=Sophos;i="4.75,637,1330923600"; d="scan'208";a="202554044" Received: from 76-10-163-99.dsl.teksavvy.com (HELO pastel.home) ([76.10.163.99]) by ironport2-out.teksavvy.com with ESMTP/TLS/ADH-AES256-SHA; 23 Oct 2012 12:58:22 -0400 Received: by pastel.home (Postfix, from userid 20848) id A370058CA3; Tue, 23 Oct 2012 12:58:21 -0400 (EDT) From: Stefan Monnier To: "Drew Adams" Subject: Re: bug#12232: 24.1.50; regression: repeat.el commit 2012-05-05 breaks repeating commands Message-ID: References: <26617CF879E04A6689018BFA901EF01A@us.oracle.com> <14F60E44174644FBA0F21D20D1477DD4@us.oracle.com> <54F3F95EA9924540A41367629A87A389@us.oracle.com> <4C0A1DE8E67F4B1CA042021E47552C18@us.oracle.com> Date: Tue, 23 Oct 2012 12:58:21 -0400 In-Reply-To: <4C0A1DE8E67F4B1CA042021E47552C18@us.oracle.com> (Drew Adams's message of "Mon, 3 Sep 2012 20:53:43 -0700") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.2.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.8 (/) X-Debbugs-Envelope-To: 12232-done Cc: 12232-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: 0.8 (/) > (defun repeat-command (command) > "Repeat COMMAND." > (interactive) > (let ((repeat-previous-repeated-command command) > (repeat-message-function 'ignore) ; <===== > (last-repeatable-command 'repeat)) > (repeat nil))) Indeed, that was the trick to trigger the bug. Should be fixed now, thanks, Stefan From debbugs-submit-bounces@debbugs.gnu.org Tue Oct 23 13:10:35 2012 Received: (at 12232-done) by debbugs.gnu.org; 23 Oct 2012 17:10:36 +0000 Received: from localhost ([127.0.0.1]:58062 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TQhzv-0005Mp-Mh for submit@debbugs.gnu.org; Tue, 23 Oct 2012 13:10:35 -0400 Received: from userp1040.oracle.com ([156.151.31.81]:25398) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TQhzu-0005Mf-OX for 12232-done@debbugs.gnu.org; Tue, 23 Oct 2012 13:10:35 -0400 Received: from acsinet21.oracle.com (acsinet21.oracle.com [141.146.126.237]) by userp1040.oracle.com (Sentrion-MTA-4.2.2/Sentrion-MTA-4.2.2) with ESMTP id q9NH8YYh029390 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Tue, 23 Oct 2012 17:08:35 GMT Received: from acsmt358.oracle.com (acsmt358.oracle.com [141.146.40.158]) by acsinet21.oracle.com (8.14.4+Sun/8.14.4) with ESMTP id q9NH8XrO000487 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Tue, 23 Oct 2012 17:08:34 GMT Received: from abhmt117.oracle.com (abhmt117.oracle.com [141.146.116.69]) by acsmt358.oracle.com (8.12.11.20060308/8.12.11) with ESMTP id q9NH8X9v023714; Tue, 23 Oct 2012 12:08:33 -0500 Received: from dradamslap1 (/71.202.147.44) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Tue, 23 Oct 2012 10:08:33 -0700 From: "Drew Adams" To: "'Stefan Monnier'" References: <26617CF879E04A6689018BFA901EF01A@us.oracle.com><14F60E44174644FBA0F21D20D1477DD4@us.oracle.com><54F3F95EA9924540A41367629A87A389@us.oracle.com><4C0A1DE8E67F4B1CA042021E47552C18@us.oracle.com> Subject: RE: bug#12232: 24.1.50; regression: repeat.el commit 2012-05-05 breaks repeating commands Date: Tue, 23 Oct 2012 10:08:30 -0700 Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Mailer: Microsoft Office Outlook 11 In-Reply-To: Thread-Index: Ac2xP52saJtWq4ZzTlGC/0ft6HlOPwAASN8g X-MimeOLE: Produced By Microsoft MimeOLE V6.00.2900.6157 X-Source-IP: acsinet21.oracle.com [141.146.126.237] X-Spam-Score: 0.8 (/) X-Debbugs-Envelope-To: 12232-done Cc: 12232-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: 0.8 (/) > Indeed, that was the trick to trigger the bug. Should be fixed now, > thanks, Thanks very much for the fix. Sorry for the insistence. It wasn't clear to me that anyone had even noticed the bug report, of if noticed that it was acknowledged to be a bug. From unknown Thu Aug 14 21:51:24 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Wed, 21 Nov 2012 12:24:03 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator