GNU bug report logs - #12225
One test failed on Solaris 10 (was: Re: [platform-testers] new snapshot available: coreutils-8.18.10-46444)

Previous Next

Package: coreutils;

Reported by: Stefano Lattarini <stefano.lattarini <at> gmail.com>

Date: Sat, 18 Aug 2012 13:50:02 UTC

Severity: normal

Tags: fixed

Done: Assaf Gordon <assafgordon <at> gmail.com>

Bug is archived. No further changes may be made.

Full log


Message #14 received at 12225 <at> debbugs.gnu.org (full text, mbox):

From: Jim Meyering <jim <at> meyering.net>
To: Paul Eggert <eggert <at> cs.ucla.edu>
Cc: 12225 <at> debbugs.gnu.org, Stefano Lattarini <stefano.lattarini <at> gmail.com>
Subject: Re: bug#12225: One test failed on Solaris 10
Date: Sun, 19 Aug 2012 21:51:10 +0200
Paul Eggert wrote:
> I've reproduced that one test failing, and propose the
> following patch.  Thanks for reporting it.
>
> Subject: [PATCH] tests: port df/no-mtab-status to Solaris
>
> * tests/df/no-mtab-status: Include <mntent.h> in test program, so
> that the getmntent hack compilation fails on Solaris, as it
> should, since it's not compatible with Solaris.  Reported by
> Stefano Lattarini in <http://bugs.gnu.org/12225>.
> ---
>  tests/df/no-mtab-status |    3 ++-
>  1 files changed, 2 insertions(+), 1 deletions(-)
>
> diff --git a/tests/df/no-mtab-status b/tests/df/no-mtab-status
> index 6e07854..e434f5f 100755
> --- a/tests/df/no-mtab-status
> +++ b/tests/df/no-mtab-status
> @@ -26,6 +26,7 @@ df || skip_ "df fails"
>  cat > k.c <<'EOF' || framework_failure_
>  #include <stdio.h>
>  #include <errno.h>
> +#include <mntent.h>
>
>  struct mntent *getmntent (FILE *fp)
>  {
> @@ -44,7 +45,7 @@ EOF
>
>  # Then compile/link it:
>  $CC -shared -fPIC -ldl -O2 k.c -o k.so \
> -  || framework_failure_ 'failed to compile with -shared -fPIC'
> +  || skip_ "getmntent hack does not work on this platform"

Thanks Stefano and Paul.
That looks good for 8.19.  Please push.




This bug report was last modified 6 years and 279 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.