GNU bug report logs - #12221
24.2; shell completion can not handle multiple candidates

Previous Next

Full log

Message #17 received at 12221-done <at> debbugs.gnu.org (full text, mbox):

From: Stefan Monnier <monnier <at> iro.umontreal.ca>
To: 12221-done <at> debbugs.gnu.org
Subject: 24.2; shell completion can not handle multiple candidates
Date: Fri, 19 Oct 2012 17:11:13 -0400

I've installed the patch below which I believe fixes the bug, finally.


        Stefan


=== modified file 'lisp/ChangeLog'
--- lisp/ChangeLog	2012-10-19 09:28:50 +0000
+++ lisp/ChangeLog	2012-10-19 18:58:27 +0000
@@ -1,3 +1,8 @@
+2012-10-19  Stefan Monnier  <monnier <at> iro.umontreal.ca>
+
+	* minibuffer.el (minibuffer-force-complete): Make the next completion use
+	the same completion-field (bug <at> 12221).
+
 2012-10-19  Martin Rudalics  <rudalics <at> gmx.at>
 
 	* emacs-lisp/debug.el (debug): Record height of debugger window

=== modified file 'lisp/minibuffer.el'
--- lisp/minibuffer.el	2012-10-18 03:30:04 +0000
+++ lisp/minibuffer.el	2012-10-19 18:40:12 +0000
@@ -1134,7 +1134,23 @@
       ;; through the previous possible completions.
       (let ((last (last all)))
         (setcdr last (cons (car all) (cdr last)))
-        (completion--cache-all-sorted-completions (cdr all)))))))
+        (completion--cache-all-sorted-completions (cdr all)))
+      ;; Make sure repeated uses cycle, even though completion--done might
+      ;; have added a space or something that moved us outside of the field.
+      ;; (bug#12221).
+      (let* ((table minibuffer-completion-table)
+             (pred minibuffer-completion-predicate)
+             (extra-prop completion-extra-properties)
+             (cmd
+              (lambda () "Cycle through the possible completions."
+                (interactive)
+                (let ((completion-extra-properties extra-prop))
+                  (completion-in-region start (point) table pred)))))
+        (set-temporary-overlay-map
+         (let ((map (make-sparse-keymap)))
+           (define-key map [remap completion-at-point] cmd)
+           (define-key map (vector last-command-event) cmd)
+           map)))))))
 
 (defvar minibuffer-confirm-exit-commands
   '(completion-at-point minibuffer-complete
@@ -1557,7 +1573,6 @@
   (let* ((exit-fun (plist-get completion-extra-properties :exit-function))
          (pre-msg (and exit-fun (current-message))))
     (cl-assert (memq finished '(exact sole finished unknown)))
-    ;; FIXME: exit-fun should receive `finished' as a parameter.
     (when exit-fun
       (when (eq finished 'unknown)
         (setq finished

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.