From unknown Mon Jun 16 23:50:39 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#12220 <12220@debbugs.gnu.org> To: bug#12220 <12220@debbugs.gnu.org> Subject: Status: 24.2; [PATCH] completion completely broken in sh-script Reply-To: bug#12220 <12220@debbugs.gnu.org> Date: Tue, 17 Jun 2025 06:50:39 +0000 retitle 12220 24.2; [PATCH] completion completely broken in sh-script reassign 12220 emacs submitter 12220 Leo severity 12220 normal tag 12220 patch thanks From debbugs-submit-bounces@debbugs.gnu.org Fri Aug 17 15:40:29 2012 Received: (at submit) by debbugs.gnu.org; 17 Aug 2012 19:40:30 +0000 Received: from localhost ([127.0.0.1]:35846 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1T2SPF-0002gE-H0 for submit@debbugs.gnu.org; Fri, 17 Aug 2012 15:40:29 -0400 Received: from eggs.gnu.org ([208.118.235.92]:44488) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1T2SPD-0002g7-9a for submit@debbugs.gnu.org; Fri, 17 Aug 2012 15:40:28 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1T2SGX-0005cm-QG for submit@debbugs.gnu.org; Fri, 17 Aug 2012 15:31:30 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=5.0 tests=BAYES_00,FREEMAIL_FROM, RCVD_IN_DNSWL_HI,T_DKIM_INVALID autolearn=unavailable version=3.3.2 Received: from lists.gnu.org ([208.118.235.17]:43198) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T2SGX-0005ci-Mx for submit@debbugs.gnu.org; Fri, 17 Aug 2012 15:31:29 -0400 Received: from eggs.gnu.org ([208.118.235.92]:50725) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T2SGW-0006qU-9r for bug-gnu-emacs@gnu.org; Fri, 17 Aug 2012 15:31:29 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1T2SGV-0005c9-8X for bug-gnu-emacs@gnu.org; Fri, 17 Aug 2012 15:31:28 -0400 Received: from mail-pb0-f41.google.com ([209.85.160.41]:34366) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T2SGV-0005c3-1g for bug-gnu-emacs@gnu.org; Fri, 17 Aug 2012 15:31:27 -0400 Received: by pbbro12 with SMTP id ro12so4202502pbb.0 for ; Fri, 17 Aug 2012 12:31:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:subject:date:message-id:mime-version:content-type; bh=tt/Sr+DAC08rFgvDCMjNtN+u0SmJXDRORA0LQiclaGE=; b=FEhDqwHQv7l4Vl79J/6A9AOkVXAunsQqCWmzGcr++N8o8XKSS6tGqAUxY196/0hr0Y ig7UR8xRE7IxZ8vYHfWHcvRhZIGE9TPUM+Q+07zAhWGO6YDt8VfFItj03bip9p5tK8Fg IGFG1JGo4eh2VkGGz16pu90sZIDj6vovS2obv0gyD9VkqC3FpgyymRSI5jlDMC/PT+ve i4oKt0j1A4CvnpeV8aJ7T8h7VnQf5C5a0CeOWbbhnEAlDyCBzyuqngLJT8Tj9xWeQG1t QmjIuBiDVUwGG0imLMbVr10ZgmphlDDbTZDJGgzW1Emt34GPN/qTwaSYOkryA04svW1Q DqQQ== Received: by 10.68.130.37 with SMTP id ob5mr13972704pbb.62.1345231885967; Fri, 17 Aug 2012 12:31:25 -0700 (PDT) Received: from localhost ([123.123.253.132]) by mx.google.com with ESMTPS id nv6sm5474082pbc.42.2012.08.17.12.31.23 (version=TLSv1/SSLv3 cipher=OTHER); Fri, 17 Aug 2012 12:31:25 -0700 (PDT) From: Leo To: bug-gnu-emacs@gnu.org Subject: 24.2; [PATCH] completion completely broken in sh-script Date: Sat, 18 Aug 2012 03:31:18 +0800 Message-ID: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-Received-From: 208.118.235.17 X-Spam-Score: -6.1 (------) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -6.1 (------) --=-=-= Content-Type: text/plain As suggested by the subject. The bug is caused by blindly aliasing comint-dynamic-complete to completion-at-point. --=-=-= Content-Type: text/x-patch Content-Disposition: inline; filename=0001-Fix-broken-completion-in-sh-script.patch >From a986b6d40ccd76e7576cf4de678372c5bdd1713d Mon Sep 17 00:00:00 2001 From: Leo Liu Date: Sat, 18 Aug 2012 02:48:15 +0800 Subject: [PATCH] Fix broken completion in sh-script --- lisp/progmodes/sh-script.el | 27 +++++++++------------------ 1 file changed, 9 insertions(+), 18 deletions(-) diff --git a/lisp/progmodes/sh-script.el b/lisp/progmodes/sh-script.el index 7d38df6a..f0dec93f 100644 --- a/lisp/progmodes/sh-script.el +++ b/lisp/progmodes/sh-script.el @@ -202,6 +202,11 @@ (eval-when-compile (require 'comint)) (require 'executable) +(autoload 'comint-completion-at-point "comint") +(autoload 'comint-filename-completion "comint") +(autoload 'shell-command-completion "shell") +(autoload 'shell-environment-variable-completion "shell") + (defvar font-lock-comment-face) (defvar font-lock-set-defaults) (defvar font-lock-string-face) @@ -469,7 +474,6 @@ (defvar sh-mode-map (define-key map "`" 'skeleton-pair-insert-maybe) (define-key map "\"" 'skeleton-pair-insert-maybe) - (define-key map [remap complete-tag] 'comint-dynamic-complete) (define-key map [remap delete-backward-char] 'backward-delete-char-untabify) (define-key map "\C-c:" 'sh-set-shell) @@ -556,9 +560,9 @@ (defvar sh-skeleton-pair-default-alist '((?( _ ?)) (?\)) "Value to use for `skeleton-pair-default-alist' in Shell-Script mode.") (defcustom sh-dynamic-complete-functions - '(shell-dynamic-complete-environment-variable - shell-dynamic-complete-command - comint-dynamic-complete-filename) + '(shell-environment-variable-completion + shell-command-completion + comint-filename-completion) "Functions for doing TAB dynamic completion." :type '(repeat function) :group 'sh-script) @@ -1489,6 +1493,7 @@ (define-derived-mode sh-mode prog-mode "Shell-script" (set (make-local-variable 'local-abbrev-table) sh-mode-abbrev-table) (set (make-local-variable 'comint-dynamic-complete-functions) sh-dynamic-complete-functions) + (add-hook 'completion-at-point-functions 'comint-completion-at-point nil t) ;; we can't look if previous line ended with `\' (set (make-local-variable 'comint-prompt-regexp) "^[ \t]*") (set (make-local-variable 'imenu-case-fold-search) nil) @@ -3681,20 +3686,6 @@ (defun sh-maybe-here-document (arg) ;; various other commands -(autoload 'comint-dynamic-complete "comint" - "Dynamically perform completion at point." t) - -(autoload 'shell-dynamic-complete-command "shell" - "Dynamically complete the command at point." t) - -(autoload 'comint-dynamic-complete-filename "comint" - "Dynamically complete the filename at point." t) - -(autoload 'shell-dynamic-complete-environment-variable "shell" - "Dynamically complete the environment variable at point." t) - - - (defun sh-beginning-of-command () "Move point to successive beginnings of commands." (interactive) -- 1.7.9.6 (Apple Git-31.1) --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Mon Aug 27 08:37:34 2012 Received: (at 12220-done) by debbugs.gnu.org; 27 Aug 2012 12:37:34 +0000 Received: from localhost ([127.0.0.1]:52009 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1T5yZR-0006Zk-Ul for submit@debbugs.gnu.org; Mon, 27 Aug 2012 08:37:34 -0400 Received: from mail-pz0-f44.google.com ([209.85.210.44]:51499) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1T5yZQ-0006Zd-IX for 12220-done@debbugs.gnu.org; Mon, 27 Aug 2012 08:37:33 -0400 Received: by dadf8 with SMTP id f8so2437725dad.3 for <12220-done@debbugs.gnu.org>; Mon, 27 Aug 2012 05:36:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:subject:references:face:date:in-reply-to:message-id :user-agent:mime-version:content-type; bh=NXIb4PrNB/C/UKJtIbDe9Fu+eqCcDkFF6SkTqRMi544=; b=a28/RnfCfixL2CggJf9jNnvpcP1HcgNPIXv6lyZkLlMVOX4/FiDOlXiMH9Ssw8hX8B P0T5VA+11bvWCXebIi0zDFjZKsRf0+ocA0zEDrjJkP90aTYsOWtdsnDWRcRI2QtPUr20 XaTzE35naXfo/+gWpS2yow7qx5pwajy/qEpqHFW1doSSzDP0arNFwkJSbcOeiHfpDK4/ Unqx+LA8rdnXWiG/3ZXabbO96UKZ5+DhGaQ0E88zaAzyzgpuVpmIiM1E45CHkHuNQJlD zWCvd0qgBYNIOELczo6HqgrwYxKcQn+OQHb6nA0cYKc+1tdSvp1j3hYU0gsa+SjzuQ5j vKJQ== Received: by 10.68.194.169 with SMTP id hx9mr34189433pbc.8.1346070999167; Mon, 27 Aug 2012 05:36:39 -0700 (PDT) Received: from localhost ([123.114.53.125]) by mx.google.com with ESMTPS id qo8sm14645185pbb.19.2012.08.27.05.36.35 (version=TLSv1/SSLv3 cipher=OTHER); Mon, 27 Aug 2012 05:36:38 -0700 (PDT) From: Leo To: 12220-done@debbugs.gnu.org Subject: Re: bug#12220: 24.2; [PATCH] completion completely broken in sh-script References: Face: iVBORw0KGgoAAAANSUhEUgAAACgAAAAoBAMAAAB+0KVeAAAAG1BMVEUAAAA9Cgm3Hx1WWFWA gn+WmJWsrqv4+vcCAwCRl2MkAAAAAXRSTlMAQObYZgAAAAFiS0dEAIgFHUgAAAAJcEhZcwAAAYoA AAGKATOXMFgAAAAHdElNRQfXAQwDNR+ZJmElAAABIklEQVQoz22SPW+DQAyGWUq65qasd9PNUSX4 AZHK2C1rJy5jpDS4IwRVup9dn7GNafpKIPPgzztXFSujqq1eM2n8h22oMkvxI/i9C97kRfMRUN55 dS3BrsAwBXUtMLAO4lryh8kTjOxKpQNniNxAgZOEe4bZwsDTFhKdqZRLNII4OQNHhEuq/RMkm6Cj TnnEA/fk0BorcYn5qA3oaeAxbaBOLrX+9G48NZ2Fzc2tzDM8Q+tMypEOqYHh8mAWaaK3U/cDMOT5 aMZMABgPXc7zPMs1A8DXO756GFJ/4fMEq47hTsAdn5avoxZ4ywl0c2w4Flu2Ybeyb3S+EqxX2DYA H8veJGEDTnHnrXvRaPyt+2kSfK6rfBZ2tUtfP/mR+pR6sX8BUZ/cDV7tvkoAAAAASUVORK5CYII= Date: Mon, 27 Aug 2012 20:36:26 +0800 In-Reply-To: (Leo's message of "Sat, 18 Aug 2012 03:31:18 +0800") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.2 (OS X 10.8.1) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.6 (--) X-Debbugs-Envelope-To: 12220-done X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.6 (--) Fixed in emacs-24 From unknown Mon Jun 16 23:50:39 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Tue, 25 Sep 2012 11:24:03 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator