GNU bug report logs - #12198
automake 1.12.3 self-tests failure: t/distcheck-override-infodir

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 12198 in the body.
You can then email your comments to 12198 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Simon Josefsson <simon <at> josefsson.org>
To: bug-automake <at> gnu.org
Subject: automake 1.12.3 self-tests failure: t/distcheck-override-infodir
Date: Tue, 14 Aug 2012 15:14:56 +0200

Hi.  It builds and passes self-checks except for the
t/distcheck-override-infodir test.  Output below.

/Simon

FAIL: t/distcheck-override-infodir
==================================

distcheck-override-infodir: running makeinfo --version
makeinfo (GNU texinfo) 4.13

Copyright © 2008 Free Software Foundation, Inc.
Licens GPLv3+: GNU GPL version 3 eller senare <http://gnu.org/licenses/gpl.html>
(Följande text är en informell översättning som enbart tillhandahålls
 i informativt syfte. För alla juridiska tolkningar gäller den engelska
 originaltexten.)
Det här är fri programvara. Du kan fritt modifiera det och
vidaredistribuera det. Det finns INGEN GARANTI, i den omfattning som
medges av gällande lag.
distcheck-override-infodir: running texi2dvi --version
texi2dvi (GNU Texinfo 4.13) 1.135

Copyright (C) 2008 Free Software Foundation, Inc.
License GPLv3+: GNU GPL version 3 or later <http://gnu.org/licenses/gpl.html>
This is free software: you are free to change and redistribute it.
There is NO WARRANTY, to the extent permitted by law.
distcheck-override-infodir: running install-info --version
This is not dpkg install-info anymore, but GNU install-info
See the man page for ginstall-info for command line arguments
install-info (GNU texinfo) 4.13

Copyright © 2008 Free Software Foundation, Inc.
Licens GPLv3+: GNU GPL version 3 eller senare <http://gnu.org/licenses/gpl.html>
(Följande text är en informell översättning som enbart tillhandahålls
 i informativt syfte. För alla juridiska tolkningar gäller den engelska
 originaltexten.)
Det här är fri programvara. Du kan fritt modifiera det och
vidaredistribuera det. Det finns INGEN GARANTI, i den omfattning som
medges av gällande lag.
Running from installcheck: no
Test Protocol: none
PATH = /home/jas/src/automake-1.12.3/t/wrap:/home/jas/src/automake-1.12.3/t/ax:/home/jas/bin:/usr/lib/lightdm/lightdm:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/usr/games:/home/jas/bin
++ pwd
/home/jas/src/automake-1.12.3/t/distcheck-override-infodir.dir
+ cat
+ cat
+ sed 's/^ #//'
+ aclocal-1.12 -Werror
+ automake-1.12 --foreign -Werror -Wall -a
Makefile.am: error: './main.texi' missing @setfilename
Makefile.am:2: installing './texinfo.tex'
+ am_exit_trap 1
+ exit_status=1
+ set +e
+ cd /home/jas/src/automake-1.12.3
+ test none = tap
+ case $am_explicit_skips in
+ test 1 -eq 0
+ keep_testdirs=yes
+ am_keeping_testdirs
+ case $keep_testdirs in
+ return 0
+ set +x
distcheck-override-infodir: exit 1

Message #8 received at 12198 <at> debbugs.gnu.org (full text, mbox):

From: Peter Rosin <peda <at> lysator.liu.se>
To: Simon Josefsson <simon <at> josefsson.org>
Cc: 12198 <at> debbugs.gnu.org
Subject: Re: bug#12198: automake 1.12.3 self-tests failure:
	t/distcheck-override-infodir
Date: Tue, 14 Aug 2012 15:38:52 +0200

On 2012-08-14 15:14, Simon Josefsson wrote:
> Hi.  It builds and passes self-checks except for the
> t/distcheck-override-infodir test.  Output below.
> 
> /Simon
> 
> FAIL: t/distcheck-override-infodir

A post is (soon) available in automake-patches, I posted it
10 minutes before seeing your report but it hasn't gone full
circle yet.

Stefano: How did this one slip through your pre-release
checks?

Cheers,
Peter

Message #11 received at 12198 <at> debbugs.gnu.org (full text, mbox):

From: Stefano Lattarini <stefano.lattarini <at> gmail.com>
To: Peter Rosin <peda <at> lysator.liu.se>
Cc: 12198 <at> debbugs.gnu.org,
	"automake-patches <at> gnu.org" <automake-patches <at> gnu.org>
Subject: Re: [PATCH] tests: fixup: make distcheck-override-infodir pass again
Date: Tue, 14 Aug 2012 18:53:46 +0200

On 08/14/2012 06:44 PM, Stefano Lattarini wrote:
> Hi Peter, thanks for the report and the fix.
> 
> On 08/14/2012 03:25 PM, Peter Rosin wrote:
>>
>> Ok to push this fix to maint?
>>
>> Cheers,
>> Peter
>>
>> [Subject] tests: fixup: make distcheck-override-infodir pass again
>>
> I'd suggest being a little more precise:
> 
>   tests: fixup: avoid spurious failure on Cygwin for distcheck-override-infodir
>
Forget it, I've seen that the failure is cross-system (reported in automake
bug#12198).  Your origin summary line was correct, sorry.  However, may I ask
that, the next time you send the fix for a bug, you CC: the relevant bug
report (as I'm doing now) and add a reference to the bug number in the commit
message?  In this case, change it to read:

    tests: fixup: make distcheck-override-infodir pass again

    Fixes Automake bug#12198.

    * t/distcheck-override-infodir.sh (main.texi): Remove all leading
    cruft added by commit v1.12.2-96-g133307b "maintcheck: fix spurious
    warnings".

>> diff --git a/t/distcheck-override-infodir.sh b/t/distcheck-override-infodir.sh
>> index 74f6c67..eb41a37 100755
>> --- a/t/distcheck-override-infodir.sh
>> +++ b/t/distcheck-override-infodir.sh
>> @@ -39,7 +39,7 @@ installcheck-local:
>>  END
>>  
>>  # Protect with leading " # " to avoid spurious maintainer-check failures.
>> -sed 's/^ #//' > main.texi << 'END'
>> +sed 's/^ # //' > main.texi << 'END'
>>
> I'd say we might be even safer and do 's/^ *# *//'.  OK?
> 
>>   # \input texinfo
>>   # @setfilename main.info
>>   # @settitle main
>>
> ACK with those two nits addressed.
>
Ditto :-)

Thanks,
  Stefano

Message #14 received at 12198 <at> debbugs.gnu.org (full text, mbox):

From: Stefano Lattarini <stefano.lattarini <at> gmail.com>
To: Peter Rosin <peda <at> lysator.liu.se>
Cc: Simon Josefsson <simon <at> josefsson.org>, 12198 <at> debbugs.gnu.org
Subject: Re: bug#12198: automake 1.12.3 self-tests failure:
	t/distcheck-override-infodir
Date: Tue, 14 Aug 2012 19:19:39 +0200

On 08/14/2012 03:38 PM, Peter Rosin wrote:
> On 2012-08-14 15:14, Simon Josefsson wrote:
>> Hi.  It builds and passes self-checks except for the
>> t/distcheck-override-infodir test.  Output below.
>>
>> /Simon
>>
>> FAIL: t/distcheck-override-infodir
> 
> A post is (soon) available in automake-patches, I posted it
> 10 minutes before seeing your report but it hasn't gone full
> circle yet.
> 
> Stefano: How did this one slip through your pre-release
> checks?
>
Now, that is a good question...  Ah, the test was skipped because
'install-info' wasn't installed on the system where I did the last
test before pushing :-/

Maybe, in the future, it would be a good idea to refrain from
last-minute changes just to pacify some overly eager maintainer
check ...

Thanks,
  Stefano

Message #17 received at 12198 <at> debbugs.gnu.org (full text, mbox):

From: Peter Rosin <peda <at> lysator.liu.se>
To: Stefano Lattarini <stefano.lattarini <at> gmail.com>
Cc: 12198 <at> debbugs.gnu.org,
	"automake-patches <at> gnu.org" <automake-patches <at> gnu.org>
Subject: Re: bug#12198: [PATCH] tests: fixup: make distcheck-override-infodir
	pass again
Date: Tue, 14 Aug 2012 19:49:47 +0200

On 2012-08-14 18:53, Stefano Lattarini wrote:
> On 08/14/2012 06:44 PM, Stefano Lattarini wrote:
>> Hi Peter, thanks for the report and the fix.
>>
>> On 08/14/2012 03:25 PM, Peter Rosin wrote:
>>>
>>> Ok to push this fix to maint?
>>>
>>> Cheers,
>>> Peter
>>>
>>> [Subject] tests: fixup: make distcheck-override-infodir pass again
>>>
>> I'd suggest being a little more precise:
>>
>>   tests: fixup: avoid spurious failure on Cygwin for distcheck-override-infodir
>>
> Forget it, I've seen that the failure is cross-system (reported in automake
> bug#12198).  Your origin summary line was correct, sorry.  However, may I ask
> that, the next time you send the fix for a bug, you CC: the relevant bug
> report (as I'm doing now) and add a reference to the bug number in the commit
> message?  In this case, change it to read:
> 
>     tests: fixup: make distcheck-override-infodir pass again
> 
>     Fixes Automake bug#12198.
> 
>     * t/distcheck-override-infodir.sh (main.texi): Remove all leading
>     cruft added by commit v1.12.2-96-g133307b "maintcheck: fix spurious
>     warnings".
> 

Done, but note that I posted the patch before the bug report arrived in
my mailbox. I'm still causal, so it would have been a neat trick to
include that bug number from the start. :-)

>>> diff --git a/t/distcheck-override-infodir.sh b/t/distcheck-override-infodir.sh
>>> index 74f6c67..eb41a37 100755
>>> --- a/t/distcheck-override-infodir.sh
>>> +++ b/t/distcheck-override-infodir.sh
>>> @@ -39,7 +39,7 @@ installcheck-local:
>>>  END
>>>  
>>>  # Protect with leading " # " to avoid spurious maintainer-check failures.
>>> -sed 's/^ #//' > main.texi << 'END'
>>> +sed 's/^ # //' > main.texi << 'END'
>>>
>> I'd say we might be even safer and do 's/^ *# *//'.  OK?
>>
>>>   # \input texinfo
>>>   # @setfilename main.info
>>>   # @settitle main
>>>
>> ACK with those two nits addressed.
>>
> Ditto :-)

Pushed with nits fixed...

Cheers,
Peter

Message #20 received at 12198 <at> debbugs.gnu.org (full text, mbox):

From: Stefano Lattarini <stefano.lattarini <at> gmail.com>
To: Peter Rosin <peda <at> lysator.liu.se>
Cc: 12198 <at> debbugs.gnu.org,
	"automake-patches <at> gnu.org" <automake-patches <at> gnu.org>
Subject: Re: bug#12198: [PATCH] tests: fixup: make distcheck-override-infodir
	pass again
Date: Tue, 14 Aug 2012 22:13:34 +0200

tags 12198 + patch
severity 12198 minor
close 12198
thanks

On 08/14/2012 07:49 PM, Peter Rosin wrote:
> On 2012-08-14 18:53, Stefano Lattarini wrote:
>> On 08/14/2012 06:44 PM, Stefano Lattarini wrote:
>>> Hi Peter, thanks for the report and the fix.
>>>
>>> On 08/14/2012 03:25 PM, Peter Rosin wrote:
>>>>
>>>> Ok to push this fix to maint?
>>>>
>>>> Cheers,
>>>> Peter
>>>>
>>>> [Subject] tests: fixup: make distcheck-override-infodir pass again
>>>>
>>> I'd suggest being a little more precise:
>>>
>>>   tests: fixup: avoid spurious failure on Cygwin for distcheck-override-infodir
>>>
>> Forget it, I've seen that the failure is cross-system (reported in automake
>> bug#12198).  Your origin summary line was correct, sorry.  However, may I ask
>> that, the next time you send the fix for a bug, you CC: the relevant bug
>> report (as I'm doing now) and add a reference to the bug number in the commit
>> message?  In this case, change it to read:
>>
>>     tests: fixup: make distcheck-override-infodir pass again
>>
>>     Fixes Automake bug#12198.
>>
>>     * t/distcheck-override-infodir.sh (main.texi): Remove all leading
>>     cruft added by commit v1.12.2-96-g133307b "maintcheck: fix spurious
>>     warnings".
>>
> 
> Done, but note that I posted the patch before the bug report arrived in
> my mailbox.
>
Well, that explain it.  Sorry for the unwarranted lessoning !

> I'm still causal, so it would have been a neat trick to
> include that bug number from the start. :-)
>
Indeed :-)

> Pushed with nits fixed...
> 
I'm closing this bug report then.

Thanks,
  Stefano

Message #29 received at 12198 <at> debbugs.gnu.org (full text, mbox):

From: Simon Josefsson <simon <at> josefsson.org>
To: Stefano Lattarini <stefano.lattarini <at> gmail.com>
Cc: Peter Rosin <peda <at> lysator.liu.se>, 12198 <at> debbugs.gnu.org
Subject: Re: bug#12198: automake 1.12.3 self-tests failure:
	t/distcheck-override-infodir
Date: Wed, 15 Aug 2012 09:35:10 +0200

Stefano Lattarini <stefano.lattarini <at> gmail.com> writes:

> On 08/14/2012 03:38 PM, Peter Rosin wrote:
>> On 2012-08-14 15:14, Simon Josefsson wrote:
>>> Hi.  It builds and passes self-checks except for the
>>> t/distcheck-override-infodir test.  Output below.
>>>
>>> /Simon
>>>
>>> FAIL: t/distcheck-override-infodir
>> 
>> A post is (soon) available in automake-patches, I posted it
>> 10 minutes before seeing your report but it hasn't gone full
>> circle yet.

Thanks!

>> Stefano: How did this one slip through your pre-release
>> checks?
>>
> Now, that is a good question...  Ah, the test was skipped because
> 'install-info' wasn't installed on the system where I did the last
> test before pushing :-/
>
> Maybe, in the future, it would be a good idea to refrain from
> last-minute changes just to pacify some overly eager maintainer
> check ...

Maybe you could include a test for whether 'install-info' is available
in your release scripts?  That would help to avoid this ever happening
again.  I find such tests useful, because I usually forget about
checking such things manually sooner or later.

/Simon

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.