GNU bug report logs - #12174
24.1.50; C-h f and non-symbol remap targets

Previous Next

Full log

View this message in rfc822 format

From: Christopher Schmidt <christopher <at> ch.ristopher.com>
To: 12174 <at> debbugs.gnu.org
Subject: bug#12174: 24.1.50; C-h f and non-symbol remap targets
Date: Tue, 14 Aug 2012 19:12:38 +0100 (BST)

[Message part 1 (text/plain, inline)]

Christopher Schmidt <christopher <at> ch.ristopher.com> writes:
> Here is a patch that abbreviates non-symbol remap targets with "??".
> This is consistent with what describe-bindings displays.

A sobering thought - ?? does not need to be quoted.

[help-fns--key-bindings-2.diff (text/x-diff, inline)]

=== modified file 'lisp/ChangeLog'
--- lisp/ChangeLog	2012-08-14 12:38:11 +0000
+++ lisp/ChangeLog	2012-08-14 13:46:05 +0000
@@ -1,3 +1,8 @@
+2012-08-14  Christopher Schmidt  <christopher <at> ch.ristopher.com>
+
+	* help-fns.el (help-fns--key-bindings): Abbreviate non-symbol
+	remap targets with ?? (Bug#12174).
+
 2012-08-14  Dmitry Gutov  <dgutov <at> yandex.ru>
 
 	* progmodes/ruby-mode.el: Improve percent literals (bug#6286).

=== modified file 'lisp/help-fns.el'
--- lisp/help-fns.el	2012-08-06 21:05:48 +0000
+++ lisp/help-fns.el	2012-08-14 13:44:48 +0000
@@ -397,9 +397,11 @@
               (if (member (event-modifiers (aref key 0)) '(nil (shift)))
                   (push key non-modified-keys)))
             (when remapped
-              (princ "Its keys are remapped to `")
-              (princ (symbol-name remapped))
-              (princ "'.\n"))
+              (princ "Its keys are remapped to ")
+              (princ (if (symbolp remapped)
+			 (concat "`" (symbol-name remapped) "'")
+		       "??"))
+              (princ ".\n"))
 
             (when keys
               (princ (if remapped

[Message part 3 (text/plain, inline)]

Please commit and/or close this bug report.

        Christopher

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.