GNU bug report logs - #12174
24.1.50; C-h f and non-symbol remap targets

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Christopher Schmidt <christopher <at> ch.ristopher.com>
Subject: bug#12174: closed (Re: bug#12174: 24.1.50; C-h f and non-symbol
 remap targets)
Date: Wed, 22 Aug 2012 07:03:03 +0000

[Message part 1 (text/plain, inline)]

Your bug report

#12174: 24.1.50; C-h f and non-symbol remap targets

which was filed against the emacs package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to 12174 <at> debbugs.gnu.org.

-- 
12174: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=12174
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Glenn Morris <rgm <at> gnu.org>
To: 12174-done <at> debbugs.gnu.org
Subject: Re: bug#12174: 24.1.50; C-h f and non-symbol remap targets
Date: Wed, 22 Aug 2012 03:02:16 -0400

Version: 24.3

Thanks; applied to trunk.

[Message part 3 (message/rfc822, inline)]

From: Christopher Schmidt <christopher <at> ch.ristopher.com>
To: bug-gnu-emacs <at> gnu.org
Subject: 24.1.50; C-h f and non-symbol remap targets
Date: Fri, 10 Aug 2012 22:55:42 +0100 (BST)

[Message part 4 (text/plain, inline)]

    (global-set-key [remap write-file] (lambda () (interactive) 'rms))
    C-h f write-file RET

This yields in an error because help-fns--key-bindings expects
(command-remapping 'write-file) to be a symbol.

Here is a patch that abbreviates non-symbol remap targets with "??".
This is consistent with what describe-bindings displays.

[help-fns--key-bindings.diff (text/x-diff, inline)]

=== modified file 'lisp/ChangeLog'
--- lisp/ChangeLog	2012-08-10 21:03:10 +0000
+++ lisp/ChangeLog	2012-08-10 21:53:48 +0000
@@ -1,3 +1,8 @@
+2012-08-10  Christopher Schmidt  <christopher <at> ch.ristopher.com>
+
+	* help-fns.el (help-fns--key-bindings): Abbreviate non-symbol
+	remap targets with ?? (Bug#).
+
 2012-08-10  Stefan Monnier  <monnier <at> iro.umontreal.ca>
 
 	* emacs-lisp/rx.el (rx-constituents): Don't define as constant.

=== modified file 'lisp/help-fns.el'
--- lisp/help-fns.el	2012-08-06 21:05:48 +0000
+++ lisp/help-fns.el	2012-08-10 21:28:18 +0000
@@ -398,7 +398,7 @@
                   (push key non-modified-keys)))
             (when remapped
               (princ "Its keys are remapped to `")
-              (princ (symbol-name remapped))
+              (princ (if (symbolp remapped) (symbol-name remapped) "??"))
               (princ "'.\n"))
 
             (when keys

[Message part 6 (text/plain, inline)]

        Christopher

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.