Subject: bug#12174: closed (Re: bug#12174: 24.1.50; C-h f and non-symbol remap targets)

From: [email-masked] (GNU bug Tracking System)
Date: Wed, 22 Aug 2012 07:03:03 +0000

Your bug report

#12174: 24.1.50; C-h f and non-symbol remap targets

which was filed against the emacs package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to [email-masked].

-- 
12174: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=12174
GNU Bug Tracking System
Contact [email-masked] with problems

Subject: Re: bug#12174: 24.1.50; C-h f and non-symbol remap targets
From: Glenn Morris <[email-masked]>
To: [email-masked]
Date: Wed, 22 Aug 2012 03:02:16 -0400
List-Id: <debbugs-submit.debbugs.gnu.org>

Version: 24.3

Thanks; applied to trunk.

Subject: 24.1.50; C-h f and non-symbol remap targets
From: Christopher Schmidt <[email-masked]>
To: [email-masked]
Date: Fri, 10 Aug 2012 22:55:42 +0100 (BST)
List-Id: <debbugs-submit.debbugs.gnu.org>

    (global-set-key [remap write-file] (lambda () (interactive) 'rms))
    C-h f write-file RET

This yields in an error because help-fns--key-bindings expects
(command-remapping 'write-file) to be a symbol.

Here is a patch that abbreviates non-symbol remap targets with "??".
This is consistent with what describe-bindings displays.
=== modified file 'lisp/ChangeLog'
--- lisp/ChangeLog	2012-08-10 21:03:10 +0000
+++ lisp/ChangeLog	2012-08-10 21:53:48 +0000
@@ -1,3 +1,8 @@
+2012-08-10  Christopher Schmidt  <[email-masked]>
+
+	* help-fns.el (help-fns--key-bindings): Abbreviate non-symbol
+	remap targets with ?? (Bug#).
+
 2012-08-10  Stefan Monnier  <[email-masked]>
 
 	* emacs-lisp/rx.el (rx-constituents): Don't define as constant.

=== modified file 'lisp/help-fns.el'
--- lisp/help-fns.el	2012-08-06 21:05:48 +0000
+++ lisp/help-fns.el	2012-08-10 21:28:18 +0000
@@ -398,7 +398,7 @@
                   (push key non-modified-keys)))
             (when remapped
               (princ "Its keys are remapped to `")
-              (princ (symbol-name remapped))
+              (princ (if (symbolp remapped) (symbol-name remapped) "??"))
               (princ "'.\n"))
 
             (when keys

        Christopher