GNU bug report logs - #12161
24.1.50; delete-selection mode vs ask-user-about-supersession-threat

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Stefan Monnier <monnier <at> iro.umontreal.ca>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#12161: closed (24.1.50; delete-selection mode vs
 ask-user-about-supersession-threat)
Date: Thu, 09 Aug 2012 02:28:02 +0000

[Message part 1 (text/plain, inline)]

Your message dated Wed, 08 Aug 2012 22:19:33 -0400
with message-id <jwvr4rgyfhv.fsf-monnier+emacs <at> gnu.org>
and subject line Re: bug#12161: 24.1.50; delete-selection mode vs ask-user-about-supersession-threat
has caused the debbugs.gnu.org bug report #12161,
regarding 24.1.50; delete-selection mode vs ask-user-about-supersession-threat
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
12161: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=12161
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Matthew Woodcraft <matthew <at> woodcraft.me.uk>
To: bug-gnu-emacs <at> gnu.org
Subject: 24.1.50; delete-selection mode vs ask-user-about-supersession-threat
Date: Wed, 08 Aug 2012 23:49:16 +0100

The following code in delsel.el doesn't seem to be working any more:

	(file-supersession
	 ;; If ask-user-about-supersession-threat signals an error,
	 ;; stop safe_run_hooks from clearing out pre-command-hook.
	 (and (eq inhibit-quit 'pre-command-hook)
	      (setq inhibit-quit 'delete-selection-dummy))

I think it hasn't been adjusted for the changes in Emacs 24 which make
safe_run_hooks remove a single function from the hook, rather than
clearing out the hook altogether.

If I change the (eq inhibit-quit 'pre-command-hook) to
(equal inhibit-quit '(pre-command-hook . delete-selection-pre-hook))
then it works again for me.


Full recipe to reproduce:

echo 12345 > /tmp/testfile
emacs -Q /tmp/testfile
M-x delete-selection-mode
  (in another console: touch /tmp/testfile)
C-M-h
DEL
At the prompt 'testfile changed on disk; really edit the buffer?', enter 'n'
The prompt appears a second time; enter 'n' (or 'y')

Now Emacs thinks it is in delete-selection-mode, but the pre-command-hook has
mysteriously evaporated.

-----

In GNU Emacs 24.1.50.2 (i486-pc-linux-gnu, GTK+ Version 3.4.2)
 of 2012-08-08 on golux, modified by Debian
 (emacs-snapshot package, version 2:20120807-1mjw1)

[Message part 3 (message/rfc822, inline)]

From: Stefan Monnier <monnier <at> iro.umontreal.ca>
To: Matthew Woodcraft <matthew <at> woodcraft.me.uk>
Cc: 12161-done <at> debbugs.gnu.org
Subject: Re: bug#12161: 24.1.50;
	delete-selection mode vs ask-user-about-supersession-threat
Date: Wed, 08 Aug 2012 22:19:33 -0400

> The following code in delsel.el doesn't seem to be working any more:

> 	(file-supersession
> 	 ;; If ask-user-about-supersession-threat signals an error,
> 	 ;; stop safe_run_hooks from clearing out pre-command-hook.
> 	 (and (eq inhibit-quit 'pre-command-hook)
> 	      (setq inhibit-quit 'delete-selection-dummy))

Indeed, thanks.
I've simplified it so it doesn't need to know about how
safe_run_hook works.


        Stefan

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.