From unknown Fri Jun 20 05:28:10 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#12087 <12087@debbugs.gnu.org> To: bug#12087 <12087@debbugs.gnu.org> Subject: Status: Wrong comment in passfd.c? Reply-To: bug#12087 <12087@debbugs.gnu.org> Date: Fri, 20 Jun 2025 12:28:10 +0000 retitle 12087 Wrong comment in passfd.c? reassign 12087 coreutils submitter 12087 Jann Horn severity 12087 normal tag 12087 fixed thanks From debbugs-submit-bounces@debbugs.gnu.org Sun Jul 29 18:54:18 2012 Received: (at submit) by debbugs.gnu.org; 29 Jul 2012 22:54:18 +0000 Received: from localhost ([127.0.0.1]:49430 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SvcNM-0007mv-KC for submit@debbugs.gnu.org; Sun, 29 Jul 2012 18:54:17 -0400 Received: from eggs.gnu.org ([208.118.235.92]:49655) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SvZzY-0004KK-GI for submit@debbugs.gnu.org; Sun, 29 Jul 2012 16:21:33 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SvZsb-00020v-Uw for submit@debbugs.gnu.org; Sun, 29 Jul 2012 16:14:22 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=5.0 tests=BAYES_00,FREEMAIL_FROM, RCVD_IN_DNSWL_HI,T_DKIM_INVALID autolearn=unavailable version=3.3.2 Received: from lists.gnu.org ([208.118.235.17]:33010) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SvZsb-00020r-Rj for submit@debbugs.gnu.org; Sun, 29 Jul 2012 16:14:21 -0400 Received: from eggs.gnu.org ([208.118.235.92]:44144) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SvZsb-0004IV-1O for bug-coreutils@gnu.org; Sun, 29 Jul 2012 16:14:21 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SvZsa-00020e-1F for bug-coreutils@gnu.org; Sun, 29 Jul 2012 16:14:20 -0400 Received: from mail-bk0-f41.google.com ([209.85.214.41]:50122) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SvZsZ-00020a-QB for bug-coreutils@gnu.org; Sun, 29 Jul 2012 16:14:19 -0400 Received: by bkcjc3 with SMTP id jc3so2329197bkc.0 for ; Sun, 29 Jul 2012 13:14:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlemail.com; s=20120113; h=date:from:to:subject:message-id:mime-version:content-type :content-disposition:user-agent; bh=JkkbwtJLCEVmFsF6r4oI2Qx+xdCjyL1i8/sXebAJ/+g=; b=zrx+4KrxUn+5TVndFeoTi4TF6qVDDpDefY5Bq3rHwgXOxLlXsCUvegKLjplWJ2Ny33 nTmc851BE02uWv+OYQW3y/d1ZHfOIlXArOqaUS1hlNsJ9/oyd3BoPJOD4VMRsot1Nwep ZWn6G2KNXnWmJNrxvVFsxsEX/2Jpl1vWFPC4GuDq4OJA/+d+R8RrYD32FgWWrFi5wqci CSWI5kazJ/xwdRxd/n8bKqXY4Pbah5TI4UmkPVozbbOUFV1TF/j5XltyIfGqHv4tUVJD c1jAw2bYajmkAH/e5hg+32NMqNAFlawW8S2JtIFBOEM6aVnpnBeA/KnrVZ9dyYp0JJcJ S79Q== Received: by 10.204.152.6 with SMTP id e6mr3150927bkw.85.1343592858339; Sun, 29 Jul 2012 13:14:18 -0700 (PDT) Received: from Jann-PC.fritz.box (77-23-225-249-dynip.superkabel.de. [77.23.225.249]) by mx.google.com with ESMTPS id u8sm2780907bks.0.2012.07.29.13.14.17 (version=SSLv3 cipher=OTHER); Sun, 29 Jul 2012 13:14:17 -0700 (PDT) Date: Sun, 29 Jul 2012 22:14:15 +0200 From: Jann Horn To: bug-coreutils@gnu.org Subject: Wrong comment in passfd.c? Message-ID: <20120729201415.GB3162@Jann-PC.fritz.box> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="24zk1gE8NUlDmwG9" Content-Disposition: inline User-Agent: Mutt/1.5.21 (2010-09-15) X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-Received-From: 208.118.235.17 X-Spam-Score: -6.1 (------) X-Debbugs-Envelope-To: submit X-Mailman-Approved-At: Sun, 29 Jul 2012 18:54:15 -0400 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -6.1 (------) --24zk1gE8NUlDmwG9 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hello, it looks to me like this comment is wrong: gnulib/lib/passfd.c: 101 /* recvfd receives a file descriptor through the socket. 102 The flags are a bitmask, possibly including O_CLOEXEC (defined in ). 103=20 104 Return 0 on success, or -1 with errno set in case of error. 105 */ 106 int 107 recvfd (int sock, int flags) It returns the fd, not 0, on success, right? Jann --24zk1gE8NUlDmwG9 Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (GNU/Linux) iQIcBAEBAgAGBQJQFZmXAAoJEGhmizV0f2d1GZ0QAICvQo/J6bv9eX6jQF+fHDQx TWH4DKaICWwgur6WCmWs9DIzdtSobZHkty3EiferNYcPmDj2lCiAHTEOuIfyReXZ yVp6CRf72wbsrohGHcl/DrkXQqDLM6iESJUaV3tKgKUDDulfo0UL0clN7cixRlxf sFSibISt76IwZdwD9QvHDAbB7nnuDaCB7WP3xmqhrpaVs+Z3HHVLoMErNDDYd2Uv cQEzda73JqizxZjEmzG6gPw7G7yt8GzlACoc35q3xE1D8i6/ZY/V1gDgLOLwZxz6 FHWPOvnOThUFdUTOnLpx+QS2rW2BeZqv4uC1pvDVHUReIakd6xMBJxeZ7c8ocYYH p3H4qmfYm2P7L2UTcvzZayAMgNi9vNthePG4P1tbEosA2EpHzbfyAWfBeUbUx/HE ILhD5f9Fbd/4VZKiucm9FSYNGbTYXrRvqJok8M/5/mFSMyibp/zp35JTeNVFjbCe hJmavKiNQknCSro9gODVqjT1O4BZSovg44xUtECVxlovskCEg5sh/OIsl4L1XL7m M+ddsmovTMkSj3F+uoZTMDazaCBk2fLT8KJ5jYOioUl+3NS688EMJt8ElIhme/mf UUBwA3bhomsx64QNuZLyAJImddbdjM9TqZW+bRCfio71Xp0dlsty2fsPD4DfnOSZ Tf5dWE8P/xSMoiMoC4OT =JZw+ -----END PGP SIGNATURE----- --24zk1gE8NUlDmwG9-- From debbugs-submit-bounces@debbugs.gnu.org Mon Jul 30 08:31:43 2012 Received: (at control) by debbugs.gnu.org; 30 Jul 2012 12:31:43 +0000 Received: from localhost ([127.0.0.1]:50209 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1Svp8Q-0006uM-PQ for submit@debbugs.gnu.org; Mon, 30 Jul 2012 08:31:43 -0400 Received: from mx1.redhat.com ([209.132.183.28]:42373) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1Svp8L-0006u5-Vf; Mon, 30 Jul 2012 08:31:41 -0400 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q6UCONL8021166 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Mon, 30 Jul 2012 08:24:23 -0400 Received: from [10.3.113.103] (ovpn-113-103.phx2.redhat.com [10.3.113.103]) by int-mx01.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id q6UCOM8F006089; Mon, 30 Jul 2012 08:24:22 -0400 Message-ID: <50167CF5.2090403@redhat.com> Date: Mon, 30 Jul 2012 06:24:21 -0600 From: Eric Blake Organization: Red Hat User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:14.0) Gecko/20120717 Thunderbird/14.0 MIME-Version: 1.0 To: Jann Horn Subject: Re: bug#12087: Wrong comment in passfd.c? References: <20120729201415.GB3162@Jann-PC.fritz.box> In-Reply-To: <20120729201415.GB3162@Jann-PC.fritz.box> X-Enigmail-Version: 1.4.3 OpenPGP: url=http://people.redhat.com/eblake/eblake.gpg Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------enig13B83650F6BF9DA9D088FB6D" X-Scanned-By: MIMEDefang 2.67 on 10.5.11.11 X-Spam-Score: -6.9 (------) X-Debbugs-Envelope-To: control Cc: bug-gnulib , 12087-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -6.9 (------) This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enig13B83650F6BF9DA9D088FB6D Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable tag 12087 fixed thanks [adding bug-gnulib, as the source of the bug] On 07/29/2012 02:14 PM, Jann Horn wrote: > Hello, > it looks to me like this comment is wrong: >=20 > gnulib/lib/passfd.c: > 101 /* recvfd receives a file descriptor through the socket. > 102 The flags are a bitmask, possibly including O_CLOEXEC (defined i= n ). > 103=20 > 104 Return 0 on success, or -1 with errno set in case of error. > 105 */ > 106 int > 107 recvfd (int sock, int flags) >=20 > It returns the fd, not 0, on success, right? You are correct. Thanks for the report; I've pushed a fix to gnulib. Coreutils will pick it up on the next gnulib update; but as it is of minor severity, I'm going to close this coreutils bug report now. Feel free to provide further comments! --=20 Eric Blake eblake@redhat.com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --------------enig13B83650F6BF9DA9D088FB6D Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iQEcBAEBCAAGBQJQFnz2AAoJEKeha0olJ0Nq86gH/jJWNXVlP3/LmkHDsjyxq2q/ ajHWs/SV/9NuAeU0B4KygMO4XxEZWP/fijeI4M4ReSSJVX5nCz3yGtbo2kB4Qy9J 0pC5Q4uVlrO1myKeH3TOahTibWcIFoxUx5xJKbcwFkf4zLfgbnbKBZX8O7YpcyVR kMRL19I0Pr1at9bl/LiFUqmUzm3YYkqGl65pYX92iVamKf4QSxWkrZtUbvXCFCz9 5JJ57/QzssYLw1/0bGRvCW/BHnoCPdeQ1cti7UQbNxwJ4vf/lvZQ/gqLRStULlRu dhopiDYFMazLjRSGcYIzUMemZSTvP92xgvk9zpjQv/csFfeewc9OpnSVkg7VE5A= =nVen -----END PGP SIGNATURE----- --------------enig13B83650F6BF9DA9D088FB6D-- From unknown Fri Jun 20 05:28:10 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Tue, 28 Aug 2012 11:24:03 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator