From unknown Sun Jun 22 17:17:05 2025 X-Loop: help-debbugs@gnu.org Subject: bug#12051: 24.1; rcirc-send-message doesn't take multibyte into account. Resent-From: Li Ian-Xue Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 26 Jul 2012 01:17:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 12051 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: 12051@debbugs.gnu.org X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.134326539912993 (code B ref -1); Thu, 26 Jul 2012 01:17:02 +0000 Received: (at submit) by debbugs.gnu.org; 26 Jul 2012 01:16:39 +0000 Received: from localhost ([127.0.0.1]:39944 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SuCgw-0003NR-IZ for submit@debbugs.gnu.org; Wed, 25 Jul 2012 21:16:39 -0400 Received: from eggs.gnu.org ([208.118.235.92]:60349) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1Su4nT-0000Pi-9f for submit@debbugs.gnu.org; Wed, 25 Jul 2012 12:50:52 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Su4gp-0006hd-D2 for submit@debbugs.gnu.org; Wed, 25 Jul 2012 12:44:05 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.2 Received: from lists.gnu.org ([208.118.235.17]:46862) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Su4gp-0006hY-9o for submit@debbugs.gnu.org; Wed, 25 Jul 2012 12:43:59 -0400 Received: from eggs.gnu.org ([208.118.235.92]:40654) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Su4gn-0002Mn-J8 for bug-gnu-emacs@gnu.org; Wed, 25 Jul 2012 12:43:59 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Su4gm-0006h9-IB for bug-gnu-emacs@gnu.org; Wed, 25 Jul 2012 12:43:57 -0400 Received: from 122-117-157-82.hinet-ip.hinet.net ([122.117.157.82]:43083 helo=bephor.org) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Su4gm-0006f1-6a for bug-gnu-emacs@gnu.org; Wed, 25 Jul 2012 12:43:56 -0400 Received: from 114-47-18-1.dynamic.hinet.net ([114.47.18.1] helo=acerpad.localdomain) by bephor.org with esmtpsa (TLSv1.2:DHE-RSA-AES128-SHA:128) (Exim 4.80) (envelope-from ) id 1Su4JU-00030d-Lo for bug-gnu-emacs@gnu.org; Thu, 26 Jul 2012 00:19:52 +0800 From: Li Ian-Xue Date: Thu, 26 Jul 2012 00:18:29 +0800 Message-ID: <87boj3byqy.fsf@acerpad.localdomain> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-Received-From: 208.118.235.17 X-Spam-Score: -6.9 (------) X-Mailman-Approved-At: Wed, 25 Jul 2012 21:16:36 -0400 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -6.9 (------) --=-=-= Content-Type: text/plain Hello developers, I discovered recently that the irc client `rcirc', although has an max-message-length set, but it simply uses (length str) for detecting the output length, which is not desirable for multibyte users because usually our characters encode to more than one byte, and this causes an error that the client actually sends out more bytes than the standard has required (512 bytes to my understanding). This limit is easily reached since chinese characters are usually encoded with 3 bytes for one character. By this error, if the server truncates the result string simply by bytes, then it's known to cause the string to become entirely scrambles for xchat. I'm attaching a patch to perform an binary search for multibyte strings, and this patch should not have any penalties for original ascii users since it begins with a (multibyte-string-p) to decide which style to use. --=-=-= Content-Type: text/x-patch Content-Disposition: inline; filename=rcirc-fix-multibyte-overflow.patch --- rcirc.el 2012-07-25 23:52:41.813226461 +0800 +++ rcirc-1.el 2012-07-25 23:55:20.813220626 +0800 @@ -792,21 +792,40 @@ (defvar rcirc-max-message-length 420 "Messages longer than this value will be split.") +(defun rcirc-multibyte-position-at-byte (str bytes) + (if (multibyte-string-p str) + (rcirc-multibyte-position-at-byte-1 str bytes 0 0) + bytes)) + +(defun rcirc-multibyte-position-at-byte-1 (str bytes now-chars now-bytes) + (let ((len (length str))) + (if (<= len 1) + now-chars + (let* ((half-len (/ len 2)) + (lstr (substring str 0 half-len)) + (rstr (substring str half-len len)) + (now-bytes-1 (+ now-bytes (string-bytes lstr)))) + (if (> now-bytes-1 bytes) + (rcirc-multibyte-position-at-byte-1 lstr bytes now-chars now-bytes) + (rcirc-multibyte-position-at-byte-1 rstr bytes (+ half-len now-chars) now-bytes-1)))))) + (defun rcirc-send-message (process target message &optional noticep silent) "Send TARGET associated with PROCESS a privmsg with text MESSAGE. If NOTICEP is non-nil, send a notice instead of privmsg. If SILENT is non-nil, do not print the message in any irc buffer." ;; max message length is 512 including CRLF (let* ((response (if noticep "NOTICE" "PRIVMSG")) - (oversize (> (length message) rcirc-max-message-length)) + (oversize (> (string-bytes message) rcirc-max-message-length)) + (adjusted-pos (if oversize + (rcirc-multibyte-position-at-byte message rcirc-max-message-length))) (text (if oversize - (substring message 0 rcirc-max-message-length) + (substring message 0 adjusted-pos) message)) (text (if (string= text "") " " text)) (more (if oversize - (substring message rcirc-max-message-length)))) + (substring message adjusted-pos)))) (rcirc-get-buffer-create process target) (rcirc-send-string process (concat response " " target " :" text)) (unless silent --=-=-=-- From unknown Sun Jun 22 17:17:05 2025 X-Loop: help-debbugs@gnu.org Subject: bug#12051: 24.1; rcirc-send-message doesn't take multibyte into account. Resent-From: Leo Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 13 Aug 2012 02:05:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 12051 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Li Ian-Xue Cc: 12051@debbugs.gnu.org Received: via spool by 12051-submit@debbugs.gnu.org id=B12051.134482347513821 (code B ref 12051); Mon, 13 Aug 2012 02:05:01 +0000 Received: (at 12051) by debbugs.gnu.org; 13 Aug 2012 02:04:35 +0000 Received: from localhost ([127.0.0.1]:52202 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1T0k1C-0003ar-Oa for submit@debbugs.gnu.org; Sun, 12 Aug 2012 22:04:35 -0400 Received: from mail-pb0-f44.google.com ([209.85.160.44]:38236) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1T0k1A-0003aj-0A for 12051@debbugs.gnu.org; Sun, 12 Aug 2012 22:04:33 -0400 Received: by pbbrr4 with SMTP id rr4so8436619pbb.3 for <12051@debbugs.gnu.org>; Sun, 12 Aug 2012 18:55:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-type; bh=jo5Z3slIXgpSalzwFcUmLEGe+z/Mf6RQFPTMSr1YECM=; b=E/eb9JshXaGVdlpUTDci/VEkGVgLDtvg6s36IuCY/s67u7HVFkvZeflVJx9Iae2Flx KYZ+hpAlXXqtiwdCM4SNFhSkBqqNhp6N4LYANqSJivTwvDpS+dCSupu0cm7ej1yNmMfG eOtWlq1zIMTAaxvFR+fxOOMU1ajwXz0gTGFTDNLiyEoJMFy0VcudL7ObgqICx8k/lrmR GVAgw7QRRn5A0z3WuMow3T9zrg2HFTkxd9r1OjDj3Et0gyNRecfVojgVy3dOdPOQ82w7 D3G+vRU1u/mp8HRL8Et2Ue3UYZknTtOOrl2cudZOqmig+uk9SStn3b1fbxMHQnU0nL7/ ra5Q== Received: by 10.68.221.3 with SMTP id qa3mr30904094pbc.42.1344822959335; Sun, 12 Aug 2012 18:55:59 -0700 (PDT) Received: from localhost ([119.255.41.67]) by mx.google.com with ESMTPS id mr2sm932940pbb.16.2012.08.12.18.55.56 (version=TLSv1/SSLv3 cipher=OTHER); Sun, 12 Aug 2012 18:55:58 -0700 (PDT) From: Leo References: <87boj3byqy.fsf@acerpad.localdomain> Date: Mon, 13 Aug 2012 09:53:42 +0800 In-Reply-To: <87boj3byqy.fsf@acerpad.localdomain> (Li Ian-Xue's message of "Thu, 26 Jul 2012 00:18:29 +0800") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.1 (OS X 10.8) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Spam-Score: -2.6 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.6 (--) --=-=-= Content-Type: text/plain On 2012-07-26 00:18 +0800, Li Ian-Xue wrote: > I discovered recently that the irc client `rcirc', although has an > max-message-length set, but it simply uses (length str) for detecting > the output length, which is not desirable for multibyte users because > usually our characters encode to more than one byte, and this causes an > error that the client actually sends out more bytes than the standard > has required (512 bytes to my understanding). Could you test if the attached patch fixes this problem? Thanks. --=-=-= Content-Type: text/x-patch Content-Disposition: inline; filename=0001-Fix-bug-12051.patch Content-Description: 0001-Fix-bug-12051.patch diff --git a/lisp/net/rcirc.el b/lisp/net/rcirc.el index e34b7c79..19f54a8e 100644 --- a/lisp/net/rcirc.el +++ b/lisp/net/rcirc.el @@ -794,26 +794,34 @@ (defun rcirc-buffer-nick (&optional buffer) (defvar rcirc-max-message-length 420 "Messages longer than this value will be split.") +(defun rcirc-split-message (message) + (with-temp-buffer + (insert message) + (goto-char (point-min)) + (let (result) + (while (not (eobp)) + (goto-char (or (byte-to-position rcirc-max-message-length) + (point-max))) + (while (and (not (bobp)) + (> (length + (encode-coding-region (point-min) (point) + rcirc-encode-coding-system t)) + rcirc-max-message-length)) + (forward-char -1)) + (push (delete-and-extract-region (point-min) (point)) result)) + (nreverse result)))) + (defun rcirc-send-message (process target message &optional noticep silent) "Send TARGET associated with PROCESS a privmsg with text MESSAGE. If NOTICEP is non-nil, send a notice instead of privmsg. If SILENT is non-nil, do not print the message in any irc buffer." ;; max message length is 512 including CRLF - (let* ((response (if noticep "NOTICE" "PRIVMSG")) - (oversize (> (length message) rcirc-max-message-length)) - (text (if oversize - (substring message 0 rcirc-max-message-length) - message)) - (text (if (string= text "") - " " - text)) - (more (if oversize - (substring message rcirc-max-message-length)))) + (let ((response (if noticep "NOTICE" "PRIVMSG"))) (rcirc-get-buffer-create process target) - (rcirc-send-string process (concat response " " target " :" text)) - (unless silent - (rcirc-print process (rcirc-nick process) response target text)) - (when more (rcirc-send-message process target more noticep)))) + (dolist (msg (rcirc-split-message message)) + (rcirc-send-string process (concat response " " target " :" msg)) + (unless silent + (rcirc-print process (rcirc-nick process) response target msg))))) (defvar rcirc-input-ring nil) (defvar rcirc-input-ring-index 0) -- 1.7.9.6 (Apple Git-31.1) --=-=-=-- From unknown Sun Jun 22 17:17:05 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.428 (Entity 5.428) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: Li Ian-Xue Subject: bug#12051: closed (Re: bug#12051: 24.1; rcirc-send-message doesn't take multibyte into account.) Message-ID: References: <87boj3byqy.fsf@acerpad.localdomain> X-Gnu-PR-Message: they-closed 12051 X-Gnu-PR-Package: emacs Reply-To: 12051@debbugs.gnu.org Date: Tue, 14 Aug 2012 13:21:02 +0000 Content-Type: multipart/mixed; boundary="----------=_1344950462-14065-1" This is a multi-part message in MIME format... ------------=_1344950462-14065-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #12051: 24.1; rcirc-send-message doesn't take multibyte into account. which was filed against the emacs package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 12051@debbugs.gnu.org. --=20 12051: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D12051 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1344950462-14065-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 12051-done) by debbugs.gnu.org; 14 Aug 2012 13:20:02 +0000 Received: from localhost ([127.0.0.1]:55439 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1T1H2P-0003dV-Uj for submit@debbugs.gnu.org; Tue, 14 Aug 2012 09:20:02 -0400 Received: from mail-yw0-f44.google.com ([209.85.213.44]:41998) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1T1H2N-0003dA-7S for 12051-done@debbugs.gnu.org; Tue, 14 Aug 2012 09:19:59 -0400 Received: by yhq56 with SMTP id 56so501796yhq.3 for <12051-done@debbugs.gnu.org>; Tue, 14 Aug 2012 06:11:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:subject:references:face:date:in-reply-to:message-id :user-agent:mime-version:content-type; bh=5u/tbG92JHLc/t4CbNE12eOFqRknMt+lcH5wRYjXOVE=; b=N6cPWZzWl4HCO/AtbuXDXDi6AYjf/t/yRzwZRfcRkUUyZdOrO8BuF2PxKsXeTz/J9Y tS8aVZajSkG6qnGaZ2AyPzo+JuyxSC7Xd02olu06+dynEPcxmoS8l8uF9VDS7Sn20K53 La6bHO2vJea+RjZSlAYXdT8c8qB4z9D17+pHHrmVZUD+VgK+4Tmy5EvxV3Hybj1PyN1v AzGyIw5OJqc6IFG5pgRQqdFjaed2VDGDAJ9GpidXAza2ZD1H8ZqI7WG2XCFA0hX24tSx G623FqtDcE6WS7kzlc2tyBb04QlRb+haaeCAF9Znisi9TXOcXimJTObwLRWHZ7c8GdFt HAgA== Received: by 10.68.116.48 with SMTP id jt16mr37169374pbb.101.1344949880246; Tue, 14 Aug 2012 06:11:20 -0700 (PDT) Received: from localhost ([222.130.134.66]) by mx.google.com with ESMTPS id wn1sm766845pbc.57.2012.08.14.06.11.16 (version=TLSv1/SSLv3 cipher=OTHER); Tue, 14 Aug 2012 06:11:18 -0700 (PDT) From: Leo To: 12051-done@debbugs.gnu.org Subject: Re: bug#12051: 24.1; rcirc-send-message doesn't take multibyte into account. References: <87boj3byqy.fsf@acerpad.localdomain> Face: iVBORw0KGgoAAAANSUhEUgAAACgAAAAoBAMAAAB+0KVeAAAAMFBMVEUaFRZLMy1dTENxVzKQ WiCrXQ97cmO/dSqSh3akjGTApXy5sJ7Sxo/Sz8Xo6eP9//xJbkruAAAAAWJLR0QAiAUdSAAAAAlw SFlzAAACxQAAAsUBidZ/7wAAAAd0SU1FB9cBBwMJOwHXewoAAAIBSURBVCjPVdNBiNNAFADQ6J4F x3hThHZBBC+WCFI8SS0iezRDcMHLHkLAg6gJH/fgYQ9xYlj2sLK4KHgqCgXFhda2Idmr4kkQPZQ0 nkQMbTypbMmMM2m7ZgYSmMef/5OZPwo7HFnx3uKPcmj0Dht1LWZJ+Hvr7dIFZXRUwl9VRTuuKDJ+ U44gjscknK4hhJaCkYRsWjmBtLqXlJAG2wipNe18OZJu1BBq1E8xafl4s6Jq2mUZGftU1y7CCxnp FVUDWJXx4C66BKBnErbuoaYNtoRTu6EZBsCbMn7W+5qOAR6WvxNOby9jHWC9hAf3n304CdiAByXs 3Nh9roLDkyb/sWV712vYwaLSAn8CPMHIAAzOPDKP2COAFm4Y4ODVWc6xG7KXsN7UeUJjjimx2uwd gCgNhr0i8C/xyCD5CiCKAMY3Bf5oDzx//w/fimscdcAZU2jv9sedx6+nYPPFIoWI/GK6QZ+EFGOR ErAjCnV3vPZ7XqlTIMbOLY7fLcvvmT7rXNWaGDexIY44N12TG2PDp7vqyl57dnCeuWwyNpnEURxk fTbDYeBnKRn4oejPYI4sH6WviBumEZ/GxX4X/x6EcURFZ7E071bjQGAxpcOAEOJuTiroDEea5Szv rVWLYfl7ZiQwSUToxrkux7OLixAWGz22+HIyWTRYcVfomOwvzusfjtVIGgLHf3MAAAAASUVORK5C YII= Date: Tue, 14 Aug 2012 21:11:15 +0800 In-Reply-To: (Leo's message of "Mon, 13 Aug 2012 09:53:42 +0800") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.1 (OS X 10.8) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.6 (--) X-Debbugs-Envelope-To: 12051-done X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.6 (--) Fixed in emacs 24.2 ------------=_1344950462-14065-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 26 Jul 2012 01:16:39 +0000 Received: from localhost ([127.0.0.1]:39944 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SuCgw-0003NR-IZ for submit@debbugs.gnu.org; Wed, 25 Jul 2012 21:16:39 -0400 Received: from eggs.gnu.org ([208.118.235.92]:60349) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1Su4nT-0000Pi-9f for submit@debbugs.gnu.org; Wed, 25 Jul 2012 12:50:52 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Su4gp-0006hd-D2 for submit@debbugs.gnu.org; Wed, 25 Jul 2012 12:44:05 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.2 Received: from lists.gnu.org ([208.118.235.17]:46862) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Su4gp-0006hY-9o for submit@debbugs.gnu.org; Wed, 25 Jul 2012 12:43:59 -0400 Received: from eggs.gnu.org ([208.118.235.92]:40654) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Su4gn-0002Mn-J8 for bug-gnu-emacs@gnu.org; Wed, 25 Jul 2012 12:43:59 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Su4gm-0006h9-IB for bug-gnu-emacs@gnu.org; Wed, 25 Jul 2012 12:43:57 -0400 Received: from 122-117-157-82.hinet-ip.hinet.net ([122.117.157.82]:43083 helo=bephor.org) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Su4gm-0006f1-6a for bug-gnu-emacs@gnu.org; Wed, 25 Jul 2012 12:43:56 -0400 Received: from 114-47-18-1.dynamic.hinet.net ([114.47.18.1] helo=acerpad.localdomain) by bephor.org with esmtpsa (TLSv1.2:DHE-RSA-AES128-SHA:128) (Exim 4.80) (envelope-from ) id 1Su4JU-00030d-Lo for bug-gnu-emacs@gnu.org; Thu, 26 Jul 2012 00:19:52 +0800 From: Li Ian-Xue To: bug-gnu-emacs@gnu.org Subject: 24.1; rcirc-send-message doesn't take multibyte into account. Date: Thu, 26 Jul 2012 00:18:29 +0800 Message-ID: <87boj3byqy.fsf@acerpad.localdomain> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-Received-From: 208.118.235.17 X-Spam-Score: -6.9 (------) X-Debbugs-Envelope-To: submit X-Mailman-Approved-At: Wed, 25 Jul 2012 21:16:36 -0400 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -6.9 (------) --=-=-= Content-Type: text/plain Hello developers, I discovered recently that the irc client `rcirc', although has an max-message-length set, but it simply uses (length str) for detecting the output length, which is not desirable for multibyte users because usually our characters encode to more than one byte, and this causes an error that the client actually sends out more bytes than the standard has required (512 bytes to my understanding). This limit is easily reached since chinese characters are usually encoded with 3 bytes for one character. By this error, if the server truncates the result string simply by bytes, then it's known to cause the string to become entirely scrambles for xchat. I'm attaching a patch to perform an binary search for multibyte strings, and this patch should not have any penalties for original ascii users since it begins with a (multibyte-string-p) to decide which style to use. --=-=-= Content-Type: text/x-patch Content-Disposition: inline; filename=rcirc-fix-multibyte-overflow.patch --- rcirc.el 2012-07-25 23:52:41.813226461 +0800 +++ rcirc-1.el 2012-07-25 23:55:20.813220626 +0800 @@ -792,21 +792,40 @@ (defvar rcirc-max-message-length 420 "Messages longer than this value will be split.") +(defun rcirc-multibyte-position-at-byte (str bytes) + (if (multibyte-string-p str) + (rcirc-multibyte-position-at-byte-1 str bytes 0 0) + bytes)) + +(defun rcirc-multibyte-position-at-byte-1 (str bytes now-chars now-bytes) + (let ((len (length str))) + (if (<= len 1) + now-chars + (let* ((half-len (/ len 2)) + (lstr (substring str 0 half-len)) + (rstr (substring str half-len len)) + (now-bytes-1 (+ now-bytes (string-bytes lstr)))) + (if (> now-bytes-1 bytes) + (rcirc-multibyte-position-at-byte-1 lstr bytes now-chars now-bytes) + (rcirc-multibyte-position-at-byte-1 rstr bytes (+ half-len now-chars) now-bytes-1)))))) + (defun rcirc-send-message (process target message &optional noticep silent) "Send TARGET associated with PROCESS a privmsg with text MESSAGE. If NOTICEP is non-nil, send a notice instead of privmsg. If SILENT is non-nil, do not print the message in any irc buffer." ;; max message length is 512 including CRLF (let* ((response (if noticep "NOTICE" "PRIVMSG")) - (oversize (> (length message) rcirc-max-message-length)) + (oversize (> (string-bytes message) rcirc-max-message-length)) + (adjusted-pos (if oversize + (rcirc-multibyte-position-at-byte message rcirc-max-message-length))) (text (if oversize - (substring message 0 rcirc-max-message-length) + (substring message 0 adjusted-pos) message)) (text (if (string= text "") " " text)) (more (if oversize - (substring message rcirc-max-message-length)))) + (substring message adjusted-pos)))) (rcirc-get-buffer-create process target) (rcirc-send-string process (concat response " " target " :" text)) (unless silent --=-=-=-- ------------=_1344950462-14065-1-- From unknown Sun Jun 22 17:17:05 2025 X-Loop: help-debbugs@gnu.org Subject: bug#12051: 24.1; rcirc-send-message doesn't take multibyte into account. Resent-From: Eli Zaretskii Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 14 Aug 2012 15:55:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 12051 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Leo Cc: b4283@bephor.org, 12051@debbugs.gnu.org Reply-To: Eli Zaretskii Received: via spool by 12051-submit@debbugs.gnu.org id=B12051.134495967228468 (code B ref 12051); Tue, 14 Aug 2012 15:55:02 +0000 Received: (at 12051) by debbugs.gnu.org; 14 Aug 2012 15:54:32 +0000 Received: from localhost ([127.0.0.1]:56486 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1T1JRw-0007P7-5S for submit@debbugs.gnu.org; Tue, 14 Aug 2012 11:54:32 -0400 Received: from mtaout20.012.net.il ([80.179.55.166]:47243) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1T1JRt-0007Oz-My for 12051@debbugs.gnu.org; Tue, 14 Aug 2012 11:54:30 -0400 Received: from conversion-daemon.a-mtaout20.012.net.il by a-mtaout20.012.net.il (HyperSendmail v2007.08) id <0M8R00H0053ICC00@a-mtaout20.012.net.il> for 12051@debbugs.gnu.org; Tue, 14 Aug 2012 18:45:43 +0300 (IDT) Received: from HOME-C4E4A596F7 ([87.69.4.28]) by a-mtaout20.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0M8R00GY5546Y070@a-mtaout20.012.net.il>; Tue, 14 Aug 2012 18:45:43 +0300 (IDT) Date: Tue, 14 Aug 2012 18:45:46 +0300 From: Eli Zaretskii In-reply-to: X-012-Sender: halo1@inter.net.il Message-id: <83k3x1jx3p.fsf@gnu.org> References: <87boj3byqy.fsf@acerpad.localdomain> X-Spam-Score: -1.2 (-) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -1.2 (-) > From: Leo > Date: Mon, 13 Aug 2012 09:53:42 +0800 > Cc: 12051@debbugs.gnu.org > > Could you test if the attached patch fixes this problem? Thanks. > > > [2:text/x-patch Hide] > > diff --git a/lisp/net/rcirc.el b/lisp/net/rcirc.el > index e34b7c79..19f54a8e 100644 > --- a/lisp/net/rcirc.el > +++ b/lisp/net/rcirc.el > @@ -794,26 +794,34 @@ (defun rcirc-buffer-nick (&optional buffer) > (defvar rcirc-max-message-length 420 > "Messages longer than this value will be split.") > > +(defun rcirc-split-message (message) > + (with-temp-buffer > + (insert message) > + (goto-char (point-min)) > + (let (result) > + (while (not (eobp)) > + (goto-char (or (byte-to-position rcirc-max-message-length) > + (point-max))) > + (while (and (not (bobp)) > + (> (length > + (encode-coding-region (point-min) (point) > + rcirc-encode-coding-system t)) > + rcirc-max-message-length)) > + (forward-char -1)) > + (push (delete-and-extract-region (point-min) (point)) result)) > + (nreverse result)))) > + > (defun rcirc-send-message (process target message &optional noticep silent) > "Send TARGET associated with PROCESS a privmsg with text MESSAGE. > If NOTICEP is non-nil, send a notice instead of privmsg. > If SILENT is non-nil, do not print the message in any irc buffer." > ;; max message length is 512 including CRLF > - (let* ((response (if noticep "NOTICE" "PRIVMSG")) > - (oversize (> (length message) rcirc-max-message-length)) > - (text (if oversize > - (substring message 0 rcirc-max-message-length) > - message)) > - (text (if (string= text "") > - " " > - text)) > - (more (if oversize > - (substring message rcirc-max-message-length)))) > + (let ((response (if noticep "NOTICE" "PRIVMSG"))) > (rcirc-get-buffer-create process target) > - (rcirc-send-string process (concat response " " target " :" text)) > - (unless silent > - (rcirc-print process (rcirc-nick process) response target text)) > - (when more (rcirc-send-message process target more noticep)))) > + (dolist (msg (rcirc-split-message message)) > + (rcirc-send-string process (concat response " " target " :" msg)) > + (unless silent > + (rcirc-print process (rcirc-nick process) response target msg))))) Isn't it better and simpler to split the string after it is encoded inside rcirc-send-string? From unknown Sun Jun 22 17:17:05 2025 X-Loop: help-debbugs@gnu.org Subject: bug#12051: 24.1; rcirc-send-message doesn't take multibyte into account. Resent-From: Eli Zaretskii Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 15 Aug 2012 03:07:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 12051 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Li Ian-Xue Cc: 12051@debbugs.gnu.org Reply-To: Eli Zaretskii Received: via spool by 12051-submit@debbugs.gnu.org id=B12051.134499999617800 (code B ref 12051); Wed, 15 Aug 2012 03:07:01 +0000 Received: (at 12051) by debbugs.gnu.org; 15 Aug 2012 03:06:36 +0000 Received: from localhost ([127.0.0.1]:57372 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1T1TwI-0004d1-U0 for submit@debbugs.gnu.org; Tue, 14 Aug 2012 23:06:36 -0400 Received: from mtaout21.012.net.il ([80.179.55.169]:42733) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1T1TwG-0004cs-Gl for 12051@debbugs.gnu.org; Tue, 14 Aug 2012 23:06:33 -0400 Received: from conversion-daemon.a-mtaout21.012.net.il by a-mtaout21.012.net.il (HyperSendmail v2007.08) id <0M8R00B00ZSQVO00@a-mtaout21.012.net.il> for 12051@debbugs.gnu.org; Wed, 15 Aug 2012 05:57:50 +0300 (IDT) Received: from HOME-C4E4A596F7 ([87.69.4.28]) by a-mtaout21.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0M8S00B1F08DVB20@a-mtaout21.012.net.il>; Wed, 15 Aug 2012 05:57:50 +0300 (IDT) Date: Wed, 15 Aug 2012 05:57:55 +0300 From: Eli Zaretskii In-reply-to: <874no4apau.fsf@acerpad.localdomain> X-012-Sender: halo1@inter.net.il Message-id: <83628kkgjw.fsf@gnu.org> References: <87boj3byqy.fsf@acerpad.localdomain> <83k3x1jx3p.fsf@gnu.org> <874no4apau.fsf@acerpad.localdomain> X-Spam-Score: -1.2 (-) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -1.2 (-) > From: Li Ian-Xue > Date: Wed, 15 Aug 2012 09:59:05 +0800 > > Eli Zaretskii writes: > > > Isn't it better and simpler to split the string after it is encoded > > inside rcirc-send-string? > But by then one wouldn't know at which byte to cut. For example when > it's a multibyte-ascii mixed string. You can always stop at known characters, like whitespace. Anyway, another way is simply to assume the worst possible expansion ratio, and estimate the byte count before encoding. From unknown Sun Jun 22 17:17:05 2025 X-Loop: help-debbugs@gnu.org Subject: bug#12051: 24.1; rcirc-send-message doesn't take multibyte into account. Resent-From: Leo Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 15 Aug 2012 13:20:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 12051 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Eli Zaretskii Cc: Li Ian-Xue , 12051@debbugs.gnu.org Received: via spool by 12051-submit@debbugs.gnu.org id=B12051.13450367819915 (code B ref 12051); Wed, 15 Aug 2012 13:20:02 +0000 Received: (at 12051) by debbugs.gnu.org; 15 Aug 2012 13:19:41 +0000 Received: from localhost ([127.0.0.1]:58153 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1T1dVd-0002Zr-5e for submit@debbugs.gnu.org; Wed, 15 Aug 2012 09:19:41 -0400 Received: from mail-gg0-f172.google.com ([209.85.161.172]:35027) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1T1dVa-0002Zj-MD for 12051@debbugs.gnu.org; Wed, 15 Aug 2012 09:19:39 -0400 Received: by ggnh4 with SMTP id h4so1977598ggn.3 for <12051@debbugs.gnu.org>; Wed, 15 Aug 2012 06:10:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:references:face:date:in-reply-to:message-id :user-agent:mime-version:content-type; bh=gQz43NZPeV5NJGIMUTYXcy7X+xUP6Ly11MhRW3crY4g=; b=IcO8prpfY7vOFTmUxpC+6v713pmr4jLKGH7bzwnpsK0lGKPTrI2o2McgwcupVJbIK6 ec3YVXz5oEk9sGi1joPsxPCs6O9klMlOq/uKTjWGdhXIxgmmaKhhRKSFJ0eqTZWjMIi8 w23zDpTS6F6ZKIIRVt56PYTjFN/aFWnjxYOMweSHqm3nk3bdQd8hRhWxLFzaZ3kxSvNI P1gZ5dieyVqRHKiRQ0NR/RQi4Zj5vLffEOa4hifbGZhERJZdxZZ0kYSa7P7wCZ1yu7VQ ptKYitfDafmhKBb0Drg0+c+45yDH4wwyYmUmTKu2FKfvuF6L77LbB8/yuFPzm1x1nAgZ VAUg== Received: by 10.68.203.67 with SMTP id ko3mr26305891pbc.126.1345036253996; Wed, 15 Aug 2012 06:10:53 -0700 (PDT) Received: from Zeuss-MacBook.local ([222.130.135.207]) by mx.google.com with ESMTPS id qn3sm582286pbc.6.2012.08.15.06.10.47 (version=TLSv1/SSLv3 cipher=OTHER); Wed, 15 Aug 2012 06:10:53 -0700 (PDT) From: Leo References: <87boj3byqy.fsf@acerpad.localdomain> <83k3x1jx3p.fsf@gnu.org> <874no4apau.fsf@acerpad.localdomain> <83628kkgjw.fsf@gnu.org> Face: iVBORw0KGgoAAAANSUhEUgAAACgAAAAoBAMAAAB+0KVeAAAAElBMVEUAAAAAAP+LRRP0pGC+ vr7///+7mT1iAAAAAWJLR0QAiAUdSAAAAAlwSFlzAAALEwAACxMBAJqcGAAAAAd0SU1FB9cBBwMO DhglKe4AAAEsSURBVCjPbZNBboQwDEV/Cd4X9QJRThApmn0XYW+Jyf2v0m+HhqDBgiAe9rcTG7QH w/1Vn2Ar8gBb/ocywSN3qK9T3z4eFDB4eApocBpeBs1RSykoJd8gQcm8pGmHXFso3ajnmsqV0TnY DQkOfXUfN5NwaI7AWTVOyEhcu1aHmdWItHddUVUcUgUBCkitu8V6ditHVOVdqzl2EQ1ZVGTbdK0V 7cqn8vWzoU5Q/bF9Y/Y0cRU1xwkys5dJ+Dt6pBDWifcNQml8Gh2JVmPSoQzo7en0grswkxrUGYJ7 0hSxxAGr7ZMwYcHIzprpi7TENEE1xtiYxixRlCfPBsUUrwHD7uGIwATrbnODJcVrPpVn3hxiGloe m/S+z3CtuzUSMo83N4DPH+F0evwR3P4A2k+75838OKQAAAAASUVORK5CYII= Date: Wed, 15 Aug 2012 21:10:45 +0800 In-Reply-To: <83628kkgjw.fsf@gnu.org> (Eli Zaretskii's message of "Wed, 15 Aug 2012 05:57:55 +0300") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.1 (OS X 10.8) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.6 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.6 (--) On 2012-08-15 10:57 +0800, Eli Zaretskii wrote: > You can always stop at known characters, like whitespace. > > Anyway, another way is simply to assume the worst possible expansion > ratio, and estimate the byte count before encoding. I make a small optimisation that calls encode-coding-region char by char. Comments? === modified file 'lisp/net/rcirc.el' --- lisp/net/rcirc.el 2012-08-15 12:26:48 +0000 +++ lisp/net/rcirc.el 2012-08-15 13:06:15 +0000 @@ -797,22 +797,24 @@ (defun rcirc-split-message (message) "Split MESSAGE into chunks within `rcirc-max-message-length'." ;; `rcirc-encode-coding-system' can have buffer-local value. - (let ((encoding rcirc-encode-coding-system)) + (let ((encoding rcirc-encode-coding-system) + result oversize) (with-temp-buffer (insert message) (goto-char (point-min)) - (let (result) - (while (not (eobp)) - (goto-char (or (byte-to-position rcirc-max-message-length) - (point-max))) - ;; max message length is 512 including CRLF - (while (and (not (bobp)) - (> (length (encode-coding-region - (point-min) (point) encoding t)) - rcirc-max-message-length)) - (forward-char -1)) - (push (delete-and-extract-region (point-min) (point)) result)) - (nreverse result))))) + (while (not (eobp)) + (goto-char (or (byte-to-position rcirc-max-message-length) + (point-max))) + ;; Max message length is 512 including CRLF + (setq oversize (- (length (encode-coding-region + (point-min) (point) encoding t)) + rcirc-max-message-length)) + (while (and (not (bobp)) (> oversize 0)) + (decf oversize (length (encode-coding-region + (1- (point)) (point) encoding t))) + (forward-char -1)) + (push (delete-and-extract-region (point-min) (point)) result))) + (nreverse result))) (defun rcirc-send-message (process target message &optional noticep silent) "Send TARGET associated with PROCESS a privmsg with text MESSAGE. From unknown Sun Jun 22 17:17:05 2025 X-Loop: help-debbugs@gnu.org Subject: bug#12051: 24.1; rcirc-send-message doesn't take multibyte into account. Resent-From: Chong Yidong Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 15 Aug 2012 13:38:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 12051 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Leo Cc: Li Ian-Xue , Eli Zaretskii , 12051@debbugs.gnu.org Received: via spool by 12051-submit@debbugs.gnu.org id=B12051.134503787711513 (code B ref 12051); Wed, 15 Aug 2012 13:38:02 +0000 Received: (at 12051) by debbugs.gnu.org; 15 Aug 2012 13:37:57 +0000 Received: from localhost ([127.0.0.1]:58196 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1T1dnI-0002zd-Aa for submit@debbugs.gnu.org; Wed, 15 Aug 2012 09:37:56 -0400 Received: from mail-qc0-f172.google.com ([209.85.216.172]:52400) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1T1dnF-0002zW-LI for 12051@debbugs.gnu.org; Wed, 15 Aug 2012 09:37:54 -0400 Received: by qcac10 with SMTP id c10so1322653qca.3 for <12051@debbugs.gnu.org>; Wed, 15 Aug 2012 06:29:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-type; bh=bPrdWjBUAyrJ/Ev5DZvQ8F0YVNtwZMY7IcH4gLwTF1g=; b=ZtUWqmWKLrwc8bTdS6vmqfsv6Yue0w8JVGFDZra66JMZOwX2Y9AizivBl9IEIH7GS6 t0kUTjf52xY9/jCiOLg3PtPWORadtJJijGGzLC3Xj8p6atCWInhAgI9gu18OKsCnzYMT fOh35e5PKrKLWKc5cQfUbe4ZIVJDb2ixDknj9xXLywA1yh3Y6aiG8uTYulDw08TuR+YB FU70SDYdZRCo5zalDLgES998lD3mVipDopH+4a2uSQDfQUGSb32X7Rx25e8XT6Soviho DhaiLNaBViqdmXjOdszpCu+vcCAEkZXauweaiNMkqGzW4dGX+SjMimzf2wvRO7AvJcQh HnVQ== Received: by 10.60.169.196 with SMTP id ag4mr1695227oec.118.1345037349297; Wed, 15 Aug 2012 06:29:09 -0700 (PDT) Received: from ulysses (cm162.gamma80.maxonline.com.sg. [202.156.80.162]) by mx.google.com with ESMTPS id r1sm1051739oea.4.2012.08.15.06.29.06 (version=SSLv3 cipher=OTHER); Wed, 15 Aug 2012 06:29:08 -0700 (PDT) From: Chong Yidong References: <87boj3byqy.fsf@acerpad.localdomain> <83k3x1jx3p.fsf@gnu.org> <874no4apau.fsf@acerpad.localdomain> <83628kkgjw.fsf@gnu.org> Date: Wed, 15 Aug 2012 21:29:04 +0800 In-Reply-To: (Leo's message of "Wed, 15 Aug 2012 21:10:45 +0800") Message-ID: <87lihgffmn.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.6 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.6 (--) Leo writes: > I make a small optimisation that calls encode-coding-region char by > char. Comments? If you are still working on this bug and not really sure what's the best way to solve it, please revert it ASAP and move the bugfix to the trunk. It is holding up the 24.2 release. From unknown Sun Jun 22 17:17:05 2025 X-Loop: help-debbugs@gnu.org Subject: bug#12051: 24.1; rcirc-send-message doesn't take multibyte into account. Resent-From: Chong Yidong Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 15 Aug 2012 15:55:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 12051 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Leo Cc: Li Ian-Xue , Eli Zaretskii , 12051@debbugs.gnu.org Received: via spool by 12051-submit@debbugs.gnu.org id=B12051.134504605424368 (code B ref 12051); Wed, 15 Aug 2012 15:55:02 +0000 Received: (at 12051) by debbugs.gnu.org; 15 Aug 2012 15:54:14 +0000 Received: from localhost ([127.0.0.1]:59290 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1T1fvB-0006Kz-UY for submit@debbugs.gnu.org; Wed, 15 Aug 2012 11:54:14 -0400 Received: from mail-gh0-f172.google.com ([209.85.160.172]:40692) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1T1fv9-0006Kr-UG for 12051@debbugs.gnu.org; Wed, 15 Aug 2012 11:54:12 -0400 Received: by ghbg16 with SMTP id g16so2173476ghb.3 for <12051@debbugs.gnu.org>; Wed, 15 Aug 2012 08:45:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-type; bh=pjWWcKo6sBSefGQpz21Aguikjtp5QC3bnWVBGF9wW0g=; b=rrFKECcf8dQL6VcKklDiGTGZ9apELo6taUJHKva8PcU9fFhkG0aYdDmsfGRpAGjuXT tdTxXX2lMKIyXWivQ/roVjqg+RhdyLeMlUz7LCCgYqjDFtwKn/Xrw/TA8xKz7bgJsQLG v3yvKZ+Nmoy0qcjGQG4F4It9i9cVs05jif+LrGa0xw/Dh/vSmvK2WOHXrUDWjZ4Bn1Nr aE+rwzyqIBscHvUUTbLNQpexuTRMO7VcKgeJFASe2lshn+UN6nPqrmCcH86K8/S+YTa6 kOcFN5Sita7WfwBrCg4gxscnnKJINW22J+drCw1Gdx1JOHiziqDV1o8SC6TIeZAG5LgJ kI9A== Received: by 10.68.130.65 with SMTP id oc1mr6451807pbb.29.1345045526798; Wed, 15 Aug 2012 08:45:26 -0700 (PDT) Received: from ulysses (cm162.gamma80.maxonline.com.sg. [202.156.80.162]) by mx.google.com with ESMTPS id rn4sm664748pbb.51.2012.08.15.08.45.22 (version=SSLv3 cipher=OTHER); Wed, 15 Aug 2012 08:45:25 -0700 (PDT) From: Chong Yidong References: <87boj3byqy.fsf@acerpad.localdomain> <83k3x1jx3p.fsf@gnu.org> <874no4apau.fsf@acerpad.localdomain> <83628kkgjw.fsf@gnu.org> <87lihgffmn.fsf@gnu.org> Date: Wed, 15 Aug 2012 23:45:19 +0800 In-Reply-To: <87lihgffmn.fsf@gnu.org> (Chong Yidong's message of "Wed, 15 Aug 2012 21:29:04 +0800") Message-ID: <87pq6scg6o.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.2.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.6 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.6 (--) Chong Yidong writes: > Leo writes: > >> I make a small optimisation that calls encode-coding-region char by >> char. Comments? > > If you are still working on this bug and not really sure what's the best > way to solve it, please revert it ASAP and move the bugfix to the trunk. > It is holding up the 24.2 release. OK, I just took a look at the relevant patches. Personally I think the previous patch is easier to understand, so unless this new version has significantly improved performance, I wouldn't bother with it. But in any case, please commit future versions of this fix to the trunk, not the branch, unless you find a regression with it. Thanks. From unknown Sun Jun 22 17:17:05 2025 X-Loop: help-debbugs@gnu.org Subject: bug#12051: 24.1; rcirc-send-message doesn't take multibyte into account. Resent-From: Eli Zaretskii Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 15 Aug 2012 17:09:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 12051 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Leo Cc: b4283@bephor.org, 12051@debbugs.gnu.org Reply-To: Eli Zaretskii Received: via spool by 12051-submit@debbugs.gnu.org id=B12051.134505053531182 (code B ref 12051); Wed, 15 Aug 2012 17:09:01 +0000 Received: (at 12051) by debbugs.gnu.org; 15 Aug 2012 17:08:55 +0000 Received: from localhost ([127.0.0.1]:59407 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1T1h5T-00086t-Ch for submit@debbugs.gnu.org; Wed, 15 Aug 2012 13:08:55 -0400 Received: from mtaout20.012.net.il ([80.179.55.166]:39856) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1T1h5Q-00086j-D5 for 12051@debbugs.gnu.org; Wed, 15 Aug 2012 13:08:53 -0400 Received: from conversion-daemon.a-mtaout20.012.net.il by a-mtaout20.012.net.il (HyperSendmail v2007.08) id <0M8T00A0033LBR00@a-mtaout20.012.net.il> for 12051@debbugs.gnu.org; Wed, 15 Aug 2012 19:59:31 +0300 (IDT) Received: from HOME-C4E4A596F7 ([87.69.4.28]) by a-mtaout20.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0M8T009DV376TVA0@a-mtaout20.012.net.il>; Wed, 15 Aug 2012 19:59:30 +0300 (IDT) Date: Wed, 15 Aug 2012 19:59:36 +0300 From: Eli Zaretskii In-reply-to: X-012-Sender: halo1@inter.net.il Message-id: <831uj8jdl3.fsf@gnu.org> References: <87boj3byqy.fsf@acerpad.localdomain> <83k3x1jx3p.fsf@gnu.org> <874no4apau.fsf@acerpad.localdomain> <83628kkgjw.fsf@gnu.org> X-Spam-Score: -1.2 (-) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -1.2 (-) > From: Leo > Cc: Li Ian-Xue , 12051@debbugs.gnu.org > Date: Wed, 15 Aug 2012 21:10:45 +0800 > > On 2012-08-15 10:57 +0800, Eli Zaretskii wrote: > > You can always stop at known characters, like whitespace. > > > > Anyway, another way is simply to assume the worst possible expansion > > ratio, and estimate the byte count before encoding. > > I make a small optimisation that calls encode-coding-region char by > char. Comments? I think it's terribly inefficient to encode the string one character at a time. Again, assuming the worst expansion is IMO much better, and will not force you to encode in a loop. But that's me. From unknown Sun Jun 22 17:17:05 2025 X-Loop: help-debbugs@gnu.org Subject: bug#12051: 24.1; rcirc-send-message doesn't take multibyte into account. In-Reply-To: <87boj3byqy.fsf@acerpad.localdomain> Resent-From: Li Ian-Xue Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 15 Aug 2012 18:05:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 12051 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Eli Zaretskii Cc: 12051@debbugs.gnu.org, Leo Received: via spool by 12051-submit@debbugs.gnu.org id=B12051.13450538896917 (code B ref 12051); Wed, 15 Aug 2012 18:05:02 +0000 Received: (at 12051) by debbugs.gnu.org; 15 Aug 2012 18:04:49 +0000 Received: from localhost ([127.0.0.1]:59484 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1T1hxZ-0001nW-3l for submit@debbugs.gnu.org; Wed, 15 Aug 2012 14:04:49 -0400 Received: from 122-117-157-82.hinet-ip.hinet.net ([122.117.157.82]:37188 helo=bephor.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1T1hxX-0001nM-Ck for 12051@debbugs.gnu.org; Wed, 15 Aug 2012 14:04:48 -0400 Received: from 114-47-11-121.dynamic.hinet.net ([114.47.11.121] helo=acerpad.localdomain) by bephor.org with esmtpsa (TLSv1.2:DHE-RSA-AES128-SHA:128) (Exim 4.80) (envelope-from ) id 1T1hq5-0000F7-Ks; Thu, 16 Aug 2012 01:57:05 +0800 From: Li Ian-Xue References: <87boj3byqy.fsf@acerpad.localdomain> <83k3x1jx3p.fsf@gnu.org> <874no4apau.fsf@acerpad.localdomain> <83628kkgjw.fsf@gnu.org> <831uj8jdl3.fsf@gnu.org> Date: Thu, 16 Aug 2012 01:53:55 +0800 Message-ID: <87has4ghxo.fsf@acerpad.localdomain> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.9 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -0.9 (/) Eli Zaretskii writes: >> I make a small optimisation that calls encode-coding-region char by >> char. Comments? > I think it's terribly inefficient to encode the string one character > at a time. > Again, assuming the worst expansion is IMO much better, and will not > force you to encode in a loop. But that's me. Why, no one is interested in the patch i submitted in July ? that patched used a binary search. http://lists.gnu.org/archive/html/bug-gnu-emacs/2012-07/msg00937.html -- ps: it might need a liitle rework because the mailing list wrapped the lines. i'll re-post it on a pastebin if anyone is still interested. http://paste.debian.net/?show=183709 From unknown Sun Jun 22 17:17:05 2025 X-Loop: help-debbugs@gnu.org Subject: bug#12051: 24.1; rcirc-send-message doesn't take multibyte into account. Resent-From: Leo Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 15 Aug 2012 23:04:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 12051 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Li Ian-Xue Cc: Eli Zaretskii , 12051@debbugs.gnu.org Received: via spool by 12051-submit@debbugs.gnu.org id=B12051.1345071784585 (code B ref 12051); Wed, 15 Aug 2012 23:04:01 +0000 Received: (at 12051) by debbugs.gnu.org; 15 Aug 2012 23:03:04 +0000 Received: from localhost ([127.0.0.1]:59833 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1T1mcB-00009O-Tz for submit@debbugs.gnu.org; Wed, 15 Aug 2012 19:03:04 -0400 Received: from mail-pb0-f44.google.com ([209.85.160.44]:64759) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1T1mc9-00008y-TE for 12051@debbugs.gnu.org; Wed, 15 Aug 2012 19:03:02 -0400 Received: by pbbrr4 with SMTP id rr4so599032pbb.3 for <12051@debbugs.gnu.org>; Wed, 15 Aug 2012 15:54:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:references:face:date:in-reply-to:message-id :user-agent:mime-version:content-type; bh=0eBewv0Yds+q5RDYXpwVJ22oHNKLREdFlanxC70I1CU=; b=tYd7UhB2j7BUo4LZksxnNLFe3UPx0XlMhC8LALVH3HYhRr/80mL6RxQ3IWwIRFafDZ +HfypanTzUZ5p1BA8Oygc80U5zbBsbDaIsJMY8MzFWnOCpp+VXVPDQ3EYG8E0SaAkMmk zM1oajXr4FHA3t7Gbxm6mzp3gHqsAfVj6xWicckyS9YFsJkSCgafPcAqnZl63dqHYHyy sM1kSUaXd4fndSQoSgO0Bve21cn95+d5dwMeIbMuH0OUcn/cEEXkAYWrJxspeaGww4GH Ss12+dXs0Y1Bw7b9wgEjBUXw8fU7IPo1AZ0l0rzrgJYdpOFTpUcp5xh+iJJzWcFCnThi BNdA== Received: by 10.68.231.130 with SMTP id tg2mr43532571pbc.70.1345071254129; Wed, 15 Aug 2012 15:54:14 -0700 (PDT) Received: from Zeuss-MacBook.local ([123.123.253.166]) by mx.google.com with ESMTPS id hr1sm1266859pbc.23.2012.08.15.15.54.10 (version=TLSv1/SSLv3 cipher=OTHER); Wed, 15 Aug 2012 15:54:13 -0700 (PDT) From: Leo References: <87boj3byqy.fsf@acerpad.localdomain> <83k3x1jx3p.fsf@gnu.org> <874no4apau.fsf@acerpad.localdomain> <83628kkgjw.fsf@gnu.org> <831uj8jdl3.fsf@gnu.org> <87has4ghxo.fsf@acerpad.localdomain> Face: iVBORw0KGgoAAAANSUhEUgAAACgAAAAoBAMAAAB+0KVeAAAAElBMVEUAAAAAAP+LRRP0pGC+ vr7///+7mT1iAAAAAWJLR0QAiAUdSAAAAAlwSFlzAAALEwAACxMBAJqcGAAAAAd0SU1FB9cBBwMO DhglKe4AAAEsSURBVCjPbZNBboQwDEV/Cd4X9QJRThApmn0XYW+Jyf2v0m+HhqDBgiAe9rcTG7QH w/1Vn2Ar8gBb/ocywSN3qK9T3z4eFDB4eApocBpeBs1RSykoJd8gQcm8pGmHXFso3ajnmsqV0TnY DQkOfXUfN5NwaI7AWTVOyEhcu1aHmdWItHddUVUcUgUBCkitu8V6ditHVOVdqzl2EQ1ZVGTbdK0V 7cqn8vWzoU5Q/bF9Y/Y0cRU1xwkys5dJ+Dt6pBDWifcNQml8Gh2JVmPSoQzo7en0grswkxrUGYJ7 0hSxxAGr7ZMwYcHIzprpi7TENEE1xtiYxixRlCfPBsUUrwHD7uGIwATrbnODJcVrPpVn3hxiGloe m/S+z3CtuzUSMo83N4DPH+F0evwR3P4A2k+75838OKQAAAAASUVORK5CYII= Date: Thu, 16 Aug 2012 06:54:17 +0800 In-Reply-To: <87has4ghxo.fsf@acerpad.localdomain> (Li Ian-Xue's message of "Thu, 16 Aug 2012 01:53:55 +0800") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.1 (OS X 10.8) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.6 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.6 (--) On 2012-08-16 01:53 +0800, Li Ian-Xue wrote: > Why, no one is interested in the patch i submitted in July ? > that patched used a binary search. > > http://lists.gnu.org/archive/html/bug-gnu-emacs/2012-07/msg00937.html Note, you are working with emacs internal encoding and not take into account rcirc's allowing own encoding. Leo From unknown Sun Jun 22 17:17:05 2025 X-Loop: help-debbugs@gnu.org Subject: bug#12051: 24.1; rcirc-send-message doesn't take multibyte into account. In-Reply-To: <87boj3byqy.fsf@acerpad.localdomain> Resent-From: Leo Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 15 Aug 2012 23:05:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 12051 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: 12051@debbugs.gnu.org X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.1345071870723 (code B ref -1); Wed, 15 Aug 2012 23:05:01 +0000 Received: (at submit) by debbugs.gnu.org; 15 Aug 2012 23:04:30 +0000 Received: from localhost ([127.0.0.1]:59837 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1T1mdZ-0000Bc-Rq for submit@debbugs.gnu.org; Wed, 15 Aug 2012 19:04:30 -0400 Received: from eggs.gnu.org ([208.118.235.92]:55062) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1T1mdW-0000BK-SA for submit@debbugs.gnu.org; Wed, 15 Aug 2012 19:04:28 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1T1mV2-0004yw-1E for submit@debbugs.gnu.org; Wed, 15 Aug 2012 18:55:41 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-5.7 required=5.0 tests=BAYES_00,FREEMAIL_FROM, RCVD_IN_DNSWL_HI,RCVD_NUMERIC_HELO autolearn=ham version=3.3.2 Received: from lists.gnu.org ([208.118.235.17]:47167) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T1mV1-0004ys-UW for submit@debbugs.gnu.org; Wed, 15 Aug 2012 18:55:39 -0400 Received: from eggs.gnu.org ([208.118.235.92]:42754) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T1mV0-0000dv-WD for bug-gnu-emacs@gnu.org; Wed, 15 Aug 2012 18:55:39 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1T1mV0-0004yJ-1w for bug-gnu-emacs@gnu.org; Wed, 15 Aug 2012 18:55:38 -0400 Received: from plane.gmane.org ([80.91.229.3]:49362) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T1mUz-0004xy-Rb for bug-gnu-emacs@gnu.org; Wed, 15 Aug 2012 18:55:37 -0400 Received: from list by plane.gmane.org with local (Exim 4.69) (envelope-from ) id 1T1mUt-0003ZF-4E for bug-gnu-emacs@gnu.org; Thu, 16 Aug 2012 00:55:31 +0200 Received: from 123.123.253.166 ([123.123.253.166]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Thu, 16 Aug 2012 00:55:31 +0200 Received: from sdl.web by 123.123.253.166 with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Thu, 16 Aug 2012 00:55:31 +0200 X-Injected-Via-Gmane: http://gmane.org/ From: Leo Date: Thu, 16 Aug 2012 06:55:30 +0800 Lines: 10 Message-ID: References: <87boj3byqy.fsf@acerpad.localdomain> <83k3x1jx3p.fsf@gnu.org> <874no4apau.fsf@acerpad.localdomain> <83628kkgjw.fsf@gnu.org> <87lihgffmn.fsf@gnu.org> <87pq6scg6o.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain X-Complaints-To: usenet@ger.gmane.org X-Gmane-NNTP-Posting-Host: 123.123.253.166 Face: iVBORw0KGgoAAAANSUhEUgAAACgAAAAoBAMAAAB+0KVeAAAAMFBMVEUaFRZLMy1dTENxVzKQ WiCrXQ97cmO/dSqSh3akjGTApXy5sJ7Sxo/Sz8Xo6eP9//xJbkruAAAAAWJLR0QAiAUdSAAAAAlw SFlzAAACxQAAAsUBidZ/7wAAAAd0SU1FB9cBBwMJOwHXewoAAAIBSURBVCjPVdNBiNNAFADQ6J4F x3hThHZBBC+WCFI8SS0iezRDcMHLHkLAg6gJH/fgYQ9xYlj2sLK4KHgqCgXFhda2Idmr4kkQPZQ0 nkQMbTypbMmMM2m7ZgYSmMef/5OZPwo7HFnx3uKPcmj0Dht1LWZJ+Hvr7dIFZXRUwl9VRTuuKDJ+ U44gjscknK4hhJaCkYRsWjmBtLqXlJAG2wipNe18OZJu1BBq1E8xafl4s6Jq2mUZGftU1y7CCxnp FVUDWJXx4C66BKBnErbuoaYNtoRTu6EZBsCbMn7W+5qOAR6WvxNOby9jHWC9hAf3n304CdiAByXs 3Nh9roLDkyb/sWV712vYwaLSAn8CPMHIAAzOPDKP2COAFm4Y4ODVWc6xG7KXsN7UeUJjjimx2uwd gCgNhr0i8C/xyCD5CiCKAMY3Bf5oDzx//w/fimscdcAZU2jv9sedx6+nYPPFIoWI/GK6QZ+EFGOR ErAjCnV3vPZ7XqlTIMbOLY7fLcvvmT7rXNWaGDexIY44N12TG2PDp7vqyl57dnCeuWwyNpnEURxk fTbDYeBnKRn4oejPYI4sH6WviBumEZ/GxX4X/x6EcURFZ7E071bjQGAxpcOAEOJuTiroDEea5Szv rVWLYfl7ZiQwSUToxrkux7OLixAWGz22+HIyWTRYcVfomOwvzusfjtVIGgLHf3MAAAAASUVORK5C YII= User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.1 (OS X 10.8) Cancel-Lock: sha1:wPfAzKgvSg3DwN9A5kTKu17BAS4= X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-Received-From: 208.118.235.17 X-Spam-Score: -5.7 (-----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -5.7 (-----) On 2012-08-15 23:45 +0800, Chong Yidong wrote: > OK, I just took a look at the relevant patches. Personally I think the > previous patch is easier to understand, so unless this new version has > significantly improved performance, I wouldn't bother with it. But in > any case, please commit future versions of this fix to the trunk, not > the branch, unless you find a regression with it. Thanks. OK. Optimisation if any will be done after the 24.2 release. Leo From unknown Sun Jun 22 17:17:05 2025 X-Loop: help-debbugs@gnu.org Subject: bug#12051: 24.1; rcirc-send-message doesn't take multibyte into account. Resent-From: Leo Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 15 Aug 2012 23:10:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 12051 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Eli Zaretskii Cc: 12051@debbugs.gnu.org Received: via spool by 12051-submit@debbugs.gnu.org id=B12051.13450721651132 (code B ref 12051); Wed, 15 Aug 2012 23:10:01 +0000 Received: (at 12051) by debbugs.gnu.org; 15 Aug 2012 23:09:25 +0000 Received: from localhost ([127.0.0.1]:59844 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1T1miK-0000ID-NJ for submit@debbugs.gnu.org; Wed, 15 Aug 2012 19:09:24 -0400 Received: from mail-pb0-f44.google.com ([209.85.160.44]:33131) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1T1miI-0000I5-58 for 12051@debbugs.gnu.org; Wed, 15 Aug 2012 19:09:23 -0400 Received: by pbbrr4 with SMTP id rr4so609117pbb.3 for <12051@debbugs.gnu.org>; Wed, 15 Aug 2012 16:00:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:references:face:date:in-reply-to:message-id :user-agent:mime-version:content-type; bh=bQ0MVwKrRg+6XtoDwK6Dy/G1KjqH9UCc0mWFzhAfeRc=; b=IAu7lBCoI4ARDuZ2PxohpezBGiajEo1TNzOhCEQe7Zo3cECRStVF2FBrarnud/vgw8 byEQfh/cFTYbSf5X0pefXdJBVbpN3U1ovcCq8HTFp16ZNlZXqL3lRmXpd3Iqg92+BM6N HYar4Cfvgabk3aq2zuRPi9rQrFcKELYcLMlW6XcG4AaPqByUODWzDuVehuW4WzTkkim3 cLwwlVgClghQpOZBBt5I4v7MsyFWzi5VC3gaZXTs+hdg780tECx8EJKMc2ixSv5TpL7F z8UbScpJYEigFcsDieF5evEaix6C6fy3oPGiRbI2oixzGTxjwtZ95hIDvtE+h6tO/4ez WZlQ== Received: by 10.68.125.133 with SMTP id mq5mr5768048pbb.42.1345071635316; Wed, 15 Aug 2012 16:00:35 -0700 (PDT) Received: from Zeuss-MacBook.local ([123.123.253.166]) by mx.google.com with ESMTPS id uy3sm634139pbc.29.2012.08.15.16.00.32 (version=TLSv1/SSLv3 cipher=OTHER); Wed, 15 Aug 2012 16:00:34 -0700 (PDT) From: Leo References: <87boj3byqy.fsf@acerpad.localdomain> <83k3x1jx3p.fsf@gnu.org> <874no4apau.fsf@acerpad.localdomain> <83628kkgjw.fsf@gnu.org> <831uj8jdl3.fsf@gnu.org> Face: iVBORw0KGgoAAAANSUhEUgAAACgAAAAoBAMAAAB+0KVeAAAAGFBMVEUKDAg1NjRWV1V9fnyg op/DxcLk5uP8/voi63ReAAAACXBIWXMAAAWJAAAFiQFtaJ36AAAAB3RJTUUH1goZAgAz00bgXgAA AeVJREFUKM9lk0Fz2jAQhQXJD3CCO70CmcC1YMtcWyTZ14Bl69xats4N9r6/3zWQBlodNKNPu/s0 b1cCQFuZGpfVVh3vAvBJolIXRkapSuoRUtIdFyo1Y5xSdlAj7OtvD1XnXxmWRi+eWgcxyCed1lVV B1CrKyujMoi+eLA5kU1SsjoHlW+nQjTtFxk4MXgrOxvIqzoTZR8XgPaLl419zgsMaSGFPiUOZCIh thsx5Xy9NsK8Kwf/JoQgMxcVJ301HKkcSWaT0O7FY056J4U9xcYfnmVXG4801lW6lqwu2nKFZoHC HuzvaTVndZ+LaRQgZdthXw1cpynEkLEwyFHXk/aIxNQ6QeooJuzPMB+wn+D7JJNsiCcVA13/A3h/ xE9J+WidpAwoYNmRFwyvSRhNVtsdaAewzZZP5uw82QL9+tyNfocyP0McAzICUr5Mk9RdIjWasUNx aIIt6NK4ZtXIMdfMQt3nuMAyWbLI4DqZ4xPq/ag8jPond4XU/cLuOgw6XCFX/YCUfcDAMMH58fD4 G9kDchwfqVefkBwup2uZM+Q4WhJt5jN3AxXCsaS2yXEDuWgS8VOzW0gFjhEPmLyFMKBFaLb1HRwc DiaKwx0EeTMRYnYPQRW3PP4HApvlMv0PttX5v/D6Aws3IOSEwzmLAAAAAElFTkSuQmCC Date: Thu, 16 Aug 2012 07:00:39 +0800 In-Reply-To: <831uj8jdl3.fsf@gnu.org> (Eli Zaretskii's message of "Wed, 15 Aug 2012 19:59:36 +0300") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.1 (OS X 10.8) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.6 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.6 (--) On 2012-08-16 00:59 +0800, Eli Zaretskii wrote: > Again, assuming the worst expansion is IMO much better, and will not > force you to encode in a loop. But that's me. By worst expansion, do you mean assuming each char to be 5 bytes? Please feel free to make the improvement (after 24.2 release per yidong's request). Leo From unknown Sun Jun 22 17:17:05 2025 X-Loop: help-debbugs@gnu.org Subject: bug#12051: 24.1; rcirc-send-message doesn't take multibyte into account. Resent-From: Eli Zaretskii Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 16 Aug 2012 03:00:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 12051 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Leo Cc: 12051@debbugs.gnu.org Reply-To: Eli Zaretskii Received: via spool by 12051-submit@debbugs.gnu.org id=B12051.134508598120752 (code B ref 12051); Thu, 16 Aug 2012 03:00:02 +0000 Received: (at 12051) by debbugs.gnu.org; 16 Aug 2012 02:59:41 +0000 Received: from localhost ([127.0.0.1]:60056 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1T1qJ8-0005Ob-E1 for submit@debbugs.gnu.org; Wed, 15 Aug 2012 22:59:41 -0400 Received: from mtaout20.012.net.il ([80.179.55.166]:42004) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1T1qJ3-0005OQ-Og for 12051@debbugs.gnu.org; Wed, 15 Aug 2012 22:59:37 -0400 Received: from conversion-daemon.a-mtaout20.012.net.il by a-mtaout20.012.net.il (HyperSendmail v2007.08) id <0M8T00F00UD0S400@a-mtaout20.012.net.il> for 12051@debbugs.gnu.org; Thu, 16 Aug 2012 05:50:45 +0300 (IDT) Received: from HOME-C4E4A596F7 ([87.69.4.28]) by a-mtaout20.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0M8T00FHOUKKJ4B0@a-mtaout20.012.net.il>; Thu, 16 Aug 2012 05:50:45 +0300 (IDT) Date: Thu, 16 Aug 2012 05:50:52 +0300 From: Eli Zaretskii In-reply-to: X-012-Sender: halo1@inter.net.il Message-id: <83d32rv9bn.fsf@gnu.org> References: <87boj3byqy.fsf@acerpad.localdomain> <83k3x1jx3p.fsf@gnu.org> <874no4apau.fsf@acerpad.localdomain> <83628kkgjw.fsf@gnu.org> <831uj8jdl3.fsf@gnu.org> X-Spam-Score: -1.2 (-) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -1.2 (-) > From: Leo > Cc: 12051@debbugs.gnu.org > Date: Thu, 16 Aug 2012 07:00:39 +0800 > > On 2012-08-16 00:59 +0800, Eli Zaretskii wrote: > > Again, assuming the worst expansion is IMO much better, and will not > > force you to encode in a loop. But that's me. > > By worst expansion, do you mean assuming each char to be 5 bytes? Yes. From unknown Sun Jun 22 17:17:05 2025 X-Loop: help-debbugs@gnu.org Subject: bug#12051: 24.1; rcirc-send-message doesn't take multibyte into account. Resent-From: Leo Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 16 Aug 2012 03:26:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 12051 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Eli Zaretskii Cc: 12051@debbugs.gnu.org Received: via spool by 12051-submit@debbugs.gnu.org id=B12051.134508750922976 (code B ref 12051); Thu, 16 Aug 2012 03:26:01 +0000 Received: (at 12051) by debbugs.gnu.org; 16 Aug 2012 03:25:09 +0000 Received: from localhost ([127.0.0.1]:60066 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1T1qhp-0005yX-Av for submit@debbugs.gnu.org; Wed, 15 Aug 2012 23:25:09 -0400 Received: from mail-pb0-f44.google.com ([209.85.160.44]:34708) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1T1qhn-0005yQ-JR for 12051@debbugs.gnu.org; Wed, 15 Aug 2012 23:25:08 -0400 Received: by pbbrr4 with SMTP id rr4so990075pbb.3 for <12051@debbugs.gnu.org>; Wed, 15 Aug 2012 20:16:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-type; bh=FnHkudfVxcw5Ol3rr0Zkf8bz874YQO75ucKeKSXrzWc=; b=GemU46PjSwRAQV/nCtTltMExbf3VLX1nmGSiHAn8jTfQBq7AmuupgwsFEh5ktCVTUf 2NEsD2Nh5Tu5iUUvjnbAPW8u8FZ2GDMvQ+c5Y2QxSVDO6UyfNQhD2KMgeDhVPhi4WJtk 6FxrD+MdtjigL/BS3USiv2hbIW/h+zWby3W3+JgV60Mssv+e4/L0M84tF5IOraZY/6jx N0v53gYsNTW9V2QQzNUknrLVnFnc5AlURBEmtM2SRVSVbwX6imB3K95uumyl4AjR7IaI CMP6qZdgIJ6ewQB0bm4LklqTwCiTYxCalN07dRHgrFtVQ5NbnYs+k2TRf0GNGFPbjsS6 uooQ== Received: by 10.68.242.228 with SMTP id wt4mr169051pbc.89.1345086978681; Wed, 15 Aug 2012 20:16:18 -0700 (PDT) Received: from localhost ([119.255.41.67]) by mx.google.com with ESMTPS id hr1sm1684237pbc.23.2012.08.15.20.16.15 (version=TLSv1/SSLv3 cipher=OTHER); Wed, 15 Aug 2012 20:16:17 -0700 (PDT) From: Leo References: <87boj3byqy.fsf@acerpad.localdomain> <83k3x1jx3p.fsf@gnu.org> <874no4apau.fsf@acerpad.localdomain> <83628kkgjw.fsf@gnu.org> <831uj8jdl3.fsf@gnu.org> <83d32rv9bn.fsf@gnu.org> Date: Thu, 16 Aug 2012 11:16:04 +0800 In-Reply-To: <83d32rv9bn.fsf@gnu.org> (Eli Zaretskii's message of "Thu, 16 Aug 2012 05:50:52 +0300") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.1 (OS X 10.8) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.6 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.6 (--) On 2012-08-16 10:50 +0800, Eli Zaretskii wrote: >> By worst expansion, do you mean assuming each char to be 5 bytes? > > Yes. The will split English text at the boundary of 84 chars which seems sub-optimal. In the current implementation of rcirc-split-message, the inner loop might not be run if the encoding is utf-8, which we can assume to be 90% of the cases. So my suggestion is to leave it alone until we hit a real case of inefficiency. What do you think? Leo From unknown Sun Jun 22 17:17:05 2025 X-Loop: help-debbugs@gnu.org Subject: bug#12051: 24.1; rcirc-send-message doesn't take multibyte into account. Resent-From: Eli Zaretskii Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 16 Aug 2012 15:31:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 12051 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Leo Cc: 12051@debbugs.gnu.org Reply-To: Eli Zaretskii Received: via spool by 12051-submit@debbugs.gnu.org id=B12051.13451310273104 (code B ref 12051); Thu, 16 Aug 2012 15:31:02 +0000 Received: (at 12051) by debbugs.gnu.org; 16 Aug 2012 15:30:27 +0000 Received: from localhost ([127.0.0.1]:33628 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1T221i-0000o0-EB for submit@debbugs.gnu.org; Thu, 16 Aug 2012 11:30:26 -0400 Received: from mtaout22.012.net.il ([80.179.55.172]:64275) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1T221f-0000nr-Tn for 12051@debbugs.gnu.org; Thu, 16 Aug 2012 11:30:24 -0400 Received: from conversion-daemon.a-mtaout22.012.net.il by a-mtaout22.012.net.il (HyperSendmail v2007.08) id <0M8U00E00T6U2T00@a-mtaout22.012.net.il> for 12051@debbugs.gnu.org; Thu, 16 Aug 2012 18:20:31 +0300 (IDT) Received: from HOME-C4E4A596F7 ([87.69.4.28]) by a-mtaout22.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0M8U00DY1TA7VH50@a-mtaout22.012.net.il>; Thu, 16 Aug 2012 18:20:31 +0300 (IDT) Date: Thu, 16 Aug 2012 18:20:40 +0300 From: Eli Zaretskii In-reply-to: X-012-Sender: halo1@inter.net.il Message-id: <83a9xuvp6f.fsf@gnu.org> References: <87boj3byqy.fsf@acerpad.localdomain> <83k3x1jx3p.fsf@gnu.org> <874no4apau.fsf@acerpad.localdomain> <83628kkgjw.fsf@gnu.org> <831uj8jdl3.fsf@gnu.org> <83d32rv9bn.fsf@gnu.org> X-Spam-Score: -1.2 (-) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -1.2 (-) > From: Leo > Cc: 12051@debbugs.gnu.org > Date: Thu, 16 Aug 2012 11:16:04 +0800 > > On 2012-08-16 10:50 +0800, Eli Zaretskii wrote: > >> By worst expansion, do you mean assuming each char to be 5 bytes? > > > > Yes. > > The will split English text at the boundary of 84 chars which seems > sub-optimal. Why is it suboptimal? (I don't know anything about rcirc.) If it's important to be better in this case, you could detect it (e.g., by matching the string against [:ascii:]). Another ide is to use string-bytes to find out where to break a string on a character boundary without exceeding the maximum allowed byte count in a message. > In the current implementation of rcirc-split-message, the inner loop > might not be run if the encoding is utf-8, which we can assume to be 90% > of the cases. So my suggestion is to leave it alone until we hit a real > case of inefficiency. What do you think? I'm okay with the current code if you are, but I still think a more elegant solution should be possible. From unknown Sun Jun 22 17:17:05 2025 X-Loop: help-debbugs@gnu.org Subject: bug#12051: 24.1; rcirc-send-message doesn't take multibyte into account. In-Reply-To: <87boj3byqy.fsf@acerpad.localdomain> Resent-From: Leo Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 16 Aug 2012 17:27:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 12051 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: 12051@debbugs.gnu.org X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.134513800419991 (code B ref -1); Thu, 16 Aug 2012 17:27:02 +0000 Received: (at submit) by debbugs.gnu.org; 16 Aug 2012 17:26:44 +0000 Received: from localhost ([127.0.0.1]:33861 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1T23qF-0005CO-Gc for submit@debbugs.gnu.org; Thu, 16 Aug 2012 13:26:44 -0400 Received: from eggs.gnu.org ([208.118.235.92]:38734) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1T23qD-0005CG-3B for submit@debbugs.gnu.org; Thu, 16 Aug 2012 13:26:42 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1T23he-0000gD-0I for submit@debbugs.gnu.org; Thu, 16 Aug 2012 13:17:50 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-5.7 required=5.0 tests=BAYES_00,FREEMAIL_FROM, RCVD_IN_DNSWL_HI,RCVD_NUMERIC_HELO autolearn=ham version=3.3.2 Received: from lists.gnu.org ([208.118.235.17]:53148) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T23hd-0000g9-TV for submit@debbugs.gnu.org; Thu, 16 Aug 2012 13:17:49 -0400 Received: from eggs.gnu.org ([208.118.235.92]:45184) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T23hd-00021J-4O for bug-gnu-emacs@gnu.org; Thu, 16 Aug 2012 13:17:49 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1T23hc-0000fT-05 for bug-gnu-emacs@gnu.org; Thu, 16 Aug 2012 13:17:48 -0400 Received: from plane.gmane.org ([80.91.229.3]:49353) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T23hb-0000f7-PZ for bug-gnu-emacs@gnu.org; Thu, 16 Aug 2012 13:17:47 -0400 Received: from list by plane.gmane.org with local (Exim 4.69) (envelope-from ) id 1T23hX-00035p-DS for bug-gnu-emacs@gnu.org; Thu, 16 Aug 2012 19:17:43 +0200 Received: from 123.114.42.138 ([123.114.42.138]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Thu, 16 Aug 2012 19:17:43 +0200 Received: from sdl.web by 123.114.42.138 with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Thu, 16 Aug 2012 19:17:43 +0200 X-Injected-Via-Gmane: http://gmane.org/ From: Leo Date: Fri, 17 Aug 2012 01:17:25 +0800 Lines: 7 Message-ID: References: <87boj3byqy.fsf@acerpad.localdomain> <83k3x1jx3p.fsf@gnu.org> <874no4apau.fsf@acerpad.localdomain> <83628kkgjw.fsf@gnu.org> <831uj8jdl3.fsf@gnu.org> <83d32rv9bn.fsf@gnu.org> <83a9xuvp6f.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain X-Complaints-To: usenet@ger.gmane.org X-Gmane-NNTP-Posting-Host: 123.114.42.138 Face: iVBORw0KGgoAAAANSUhEUgAAACgAAAAoAgMAAADxkFD+AAAADFBMVEUvT09qWs3/pQD///+J kUVcAAAAAWJLR0QAiAUdSAAAAAlwSFlzAAALEwAACxMBAJqcGAAAAAd0SU1FB9cBBwMLOd3veKQA AACuSURBVBjTldE9CgIxEAXgB+lEyFUC2wo5ikdZ8DSypxhMY7H9VuIVwlqkGRgnm59VsHGafIQ3 CZlAtmKIRaHETgYa12lqvEsPYKf8wXHsPGfqPaUM0g9aJPKFXkmNQmSDqwzz4Fpgpz+6WAPY2z5o uPJJpu0uypcl4nyCibMLQ8lCiVjayLoQvw5LsVKQuHPRR958HZbOcVsKeepcLxpByjycGvnKmY+c MBvrtyjfe0vmuLvdq/kAAAAASUVORK5CYII= User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.1 (OS X 10.8) Cancel-Lock: sha1:v30iMO30Edo7MmRE1hqjtF7V9v4= X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-Received-From: 208.118.235.17 X-Spam-Score: -5.7 (-----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -5.7 (-----) On 2012-08-16 23:20 +0800, Eli Zaretskii wrote: > I'm okay with the current code if you are, but I still think a more > elegant solution should be possible. OK let's leave it here. Thanks for suggesting. Leo