GNU bug report logs - #12034
24.1.50; pp-display-expression may select deleted window

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: martin rudalics <rudalics <at> gmx.at>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#12034: closed (24.1.50; pp-display-expression may select
 deleted window)
Date: Wed, 25 Jul 2012 09:55:01 +0000

[Message part 1 (text/plain, inline)]

Your message dated Wed, 25 Jul 2012 11:47:51 +0200
with message-id <500FC0C7.7060604 <at> gmx.at>
and subject line Re: bug#12034: 24.1.50; pp-display-expression may select deleted window
has caused the debbugs.gnu.org bug report #12034,
regarding 24.1.50; pp-display-expression may select deleted window
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
12034: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=12034
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Christopher Schmidt <christopher <at> ch.ristopher.com>
To: bug-gnu-emacs <at> gnu.org
Subject: 24.1.50; pp-display-expression may select deleted window
Date: Mon, 23 Jul 2012 15:04:32 +0100 (BST)

[Message part 3 (text/plain, inline)]

In pp-display-expression there is this sexp:

    (let ((temp-buffer-show-function old-show-function)
          (old-selected (selected-window))
          (window (display-buffer buf)))
                  ^^^^^^^^^^^^^^^^^^^^
      (goto-char (point-min)) ; expected by some hooks ...
      (make-frame-visible (window-frame window))
      (unwind-protect
          (progn
            (select-window window)
            (run-hooks 'temp-buffer-show-hook))
        (select-window old-selected)
        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
        (message "See buffer %s." out-buffer-name)))

An user may implement an overriding action for display-buffer that could
delete old-selected.

[pp-display-expression.diff (text/x-diff, inline)]

=== modified file 'lisp/ChangeLog'
--- lisp/ChangeLog	2012-07-22 21:14:12 +0000
+++ lisp/ChangeLog	2012-07-23 12:49:21 +0000
@@ -1,3 +1,8 @@
+2012-07-23  Christopher Schmidt  <christopher <at> ch.ristopher.com>
+
+	* emacs-lisp/pp.el (pp-display-expression): Select old selected
+	window only if it is still live (Bug#).
+
 2012-07-22  Vincent Belaïche  <vincentb1 <at> users.sourceforge.net>
 
 	* ses.el (ses-cell-formula-aset): New macro.

=== modified file 'lisp/emacs-lisp/pp.el'
--- lisp/emacs-lisp/pp.el	2012-02-05 02:09:35 +0000
+++ lisp/emacs-lisp/pp.el	2012-07-23 12:44:07 +0000
@@ -110,7 +110,8 @@
 			 (progn
 			   (select-window window)
 			   (run-hooks 'temp-buffer-show-hook))
-		       (select-window old-selected)
+		       (when (window-live-p old-selected)
+			 (select-window old-selected))
 		       (message "See buffer %s." out-buffer-name)))
 		 (message "%s" (buffer-substring (point-min) (point)))
 		 ))))))

[Message part 5 (text/plain, inline)]

        Christopher

[Message part 6 (message/rfc822, inline)]

From: martin rudalics <rudalics <at> gmx.at>
To: 12034-done <at> debbugs.gnu.org
Subject: Re: bug#12034: 24.1.50; pp-display-expression may select deleted
	window
Date: Wed, 25 Jul 2012 11:47:51 +0200

> In pp-display-expression there is this sexp:
> 
>     (let ((temp-buffer-show-function old-show-function)
>           (old-selected (selected-window))
>           (window (display-buffer buf)))
>                   ^^^^^^^^^^^^^^^^^^^^
>       (goto-char (point-min)) ; expected by some hooks ...
>       (make-frame-visible (window-frame window))
>       (unwind-protect
>           (progn
>             (select-window window)
>             (run-hooks 'temp-buffer-show-hook))
>         (select-window old-selected)
>         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
>         (message "See buffer %s." out-buffer-name)))
> 
> An user may implement an overriding action for display-buffer that could
> delete old-selected.

Patch applied, bug closed.

Thanks, martin

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.