From unknown Wed Sep 10 10:36:06 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#12034 <12034@debbugs.gnu.org> To: bug#12034 <12034@debbugs.gnu.org> Subject: Status: 24.1.50; pp-display-expression may select deleted window Reply-To: bug#12034 <12034@debbugs.gnu.org> Date: Wed, 10 Sep 2025 17:36:06 +0000 retitle 12034 24.1.50; pp-display-expression may select deleted window reassign 12034 emacs submitter 12034 Christopher Schmidt severity 12034 normal thanks From debbugs-submit-bounces@debbugs.gnu.org Mon Jul 23 10:11:35 2012 Received: (at submit) by debbugs.gnu.org; 23 Jul 2012 14:11:35 +0000 Received: from localhost ([127.0.0.1]:60792 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1StJME-0005ag-5t for submit@debbugs.gnu.org; Mon, 23 Jul 2012 10:11:35 -0400 Received: from eggs.gnu.org ([208.118.235.92]:44428) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1StJMB-0005aZ-Uh for submit@debbugs.gnu.org; Mon, 23 Jul 2012 10:11:33 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1StJFl-00008W-0w for submit@debbugs.gnu.org; Mon, 23 Jul 2012 10:04:57 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_HI, T_DKIM_INVALID autolearn=unavailable version=3.3.2 Received: from lists.gnu.org ([208.118.235.17]:42845) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1StJFk-00008R-Tt for submit@debbugs.gnu.org; Mon, 23 Jul 2012 10:04:52 -0400 Received: from eggs.gnu.org ([208.118.235.92]:46911) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1StJFg-0000x4-Un for bug-gnu-emacs@gnu.org; Mon, 23 Jul 2012 10:04:52 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1StJFT-00005i-Ie for bug-gnu-emacs@gnu.org; Mon, 23 Jul 2012 10:04:48 -0400 Received: from ristopher.com ([146.185.21.93]:40171 helo=saturn.ch.ristopher.com) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1StJFT-00005F-9M for bug-gnu-emacs@gnu.org; Mon, 23 Jul 2012 10:04:35 -0400 Received: by saturn.ch.ristopher.com (Postfix, from userid 0) id D628D20BB8; Mon, 23 Jul 2012 15:04:32 +0100 (BST) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=ch.ristopher.com; s=mail; t=1343052272; bh=4X/h2jAwf6XRHam2v22oq9JjzRIGNWzhbf4cUD2N324=; h=From:To:Subject:Message-ID:MIME-Version:Content-Type:Date; b=F2j1R5JezqXq1G7VyFFkHgIVYUQrKlacTbzfmcs3UYU0qjAcs8Xu9jDVp6huZNa+Q epIwMjcctSB1waZFxz+1iJ+TekXLsPhTtlQN4WFrhVXnWA7px8G8sx5uN8Cf5JTFfe ul6diavWXOfC4LRu/vEjG1EeEoLCORJmQCycD1lk= From: Christopher Schmidt To: bug-gnu-emacs@gnu.org Subject: 24.1.50; pp-display-expression may select deleted window Message-ID: <87a9yqwp3n@ch.ristopher.com> Mail-Followup-To: bug-gnu-emacs@gnu.org MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Date: Mon, 23 Jul 2012 15:04:32 +0100 (BST) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6, seldom 2.4 (older, 4) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-Received-From: 208.118.235.17 X-Spam-Score: -6.9 (------) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -6.9 (------) --=-=-= Content-Type: text/plain In pp-display-expression there is this sexp: (let ((temp-buffer-show-function old-show-function) (old-selected (selected-window)) (window (display-buffer buf))) ^^^^^^^^^^^^^^^^^^^^ (goto-char (point-min)) ; expected by some hooks ... (make-frame-visible (window-frame window)) (unwind-protect (progn (select-window window) (run-hooks 'temp-buffer-show-hook)) (select-window old-selected) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ (message "See buffer %s." out-buffer-name))) An user may implement an overriding action for display-buffer that could delete old-selected. --=-=-= Content-Type: text/x-diff; charset=utf-8 Content-Disposition: inline; filename=pp-display-expression.diff Content-Transfer-Encoding: quoted-printable =3D=3D=3D modified file 'lisp/ChangeLog' --- lisp/ChangeLog 2012-07-22 21:14:12 +0000 +++ lisp/ChangeLog 2012-07-23 12:49:21 +0000 @@ -1,3 +1,8 @@ +2012-07-23 Christopher Schmidt + + * emacs-lisp/pp.el (pp-display-expression): Select old selected + window only if it is still live (Bug#). + 2012-07-22 Vincent Bela=C3=AFche =20 * ses.el (ses-cell-formula-aset): New macro. =3D=3D=3D modified file 'lisp/emacs-lisp/pp.el' --- lisp/emacs-lisp/pp.el 2012-02-05 02:09:35 +0000 +++ lisp/emacs-lisp/pp.el 2012-07-23 12:44:07 +0000 @@ -110,7 +110,8 @@ (progn (select-window window) (run-hooks 'temp-buffer-show-hook)) - (select-window old-selected) + (when (window-live-p old-selected) + (select-window old-selected)) (message "See buffer %s." out-buffer-name))) (message "%s" (buffer-substring (point-min) (point))) )))))) --=-=-= Content-Type: text/plain Christopher --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Wed Jul 25 05:54:20 2012 Received: (at 12034-done) by debbugs.gnu.org; 25 Jul 2012 09:54:20 +0000 Received: from localhost ([127.0.0.1]:38451 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1StyIO-0005xh-2b for submit@debbugs.gnu.org; Wed, 25 Jul 2012 05:54:20 -0400 Received: from mailout-de.gmx.net ([213.165.64.23]:50358) by debbugs.gnu.org with smtp (Exim 4.72) (envelope-from ) id 1StyIM-0005xa-Ea for 12034-done@debbugs.gnu.org; Wed, 25 Jul 2012 05:54:19 -0400 Received: (qmail invoked by alias); 25 Jul 2012 09:47:33 -0000 Received: from 62-47-42-102.adsl.highway.telekom.at (EHLO [62.47.42.102]) [62.47.42.102] by mail.gmx.net (mp031) with SMTP; 25 Jul 2012 11:47:33 +0200 X-Authenticated: #14592706 X-Provags-ID: V01U2FsdGVkX18NJKNG2FMNbNkzuYdJx83usXjznfnDN/GaipuKMm bDLnKpAzkxBayf Message-ID: <500FC0C7.7060604@gmx.at> Date: Wed, 25 Jul 2012 11:47:51 +0200 From: martin rudalics MIME-Version: 1.0 To: 12034-done@debbugs.gnu.org Subject: Re: bug#12034: 24.1.50; pp-display-expression may select deleted window References: <87a9yqwp3n@ch.ristopher.com> In-Reply-To: <87a9yqwp3n@ch.ristopher.com> Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-Transfer-Encoding: 7bit X-Y-GMX-Trusted: 0 X-Spam-Score: -1.9 (-) X-Debbugs-Envelope-To: 12034-done X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -1.9 (-) > In pp-display-expression there is this sexp: > > (let ((temp-buffer-show-function old-show-function) > (old-selected (selected-window)) > (window (display-buffer buf))) > ^^^^^^^^^^^^^^^^^^^^ > (goto-char (point-min)) ; expected by some hooks ... > (make-frame-visible (window-frame window)) > (unwind-protect > (progn > (select-window window) > (run-hooks 'temp-buffer-show-hook)) > (select-window old-selected) > ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ > (message "See buffer %s." out-buffer-name))) > > An user may implement an overriding action for display-buffer that could > delete old-selected. Patch applied, bug closed. Thanks, martin From unknown Wed Sep 10 10:36:06 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Wed, 22 Aug 2012 11:24:03 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator