From unknown Wed Sep 10 20:08:02 2025 X-Loop: help-debbugs@gnu.org Subject: bug#12030: 24.0.97; y-or-n-p and redirect-frame-focus Resent-From: martin rudalics Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 23 Jul 2012 09:42:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 12030 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: 12030@debbugs.gnu.org X-Debbugs-Original-To: Bug-Gnu-Emacs Received: via spool by submit@debbugs.gnu.org id=B.134303650416032 (code B ref -1); Mon, 23 Jul 2012 09:42:01 +0000 Received: (at submit) by debbugs.gnu.org; 23 Jul 2012 09:41:44 +0000 Received: from localhost ([127.0.0.1]:58980 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1StF95-0004AW-NA for submit@debbugs.gnu.org; Mon, 23 Jul 2012 05:41:43 -0400 Received: from eggs.gnu.org ([208.118.235.92]:60559) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1StF93-0004AM-Gl for submit@debbugs.gnu.org; Mon, 23 Jul 2012 05:41:42 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1StF2e-0003Xw-Lm for submit@debbugs.gnu.org; Mon, 23 Jul 2012 05:35:08 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=5.0 tests=BAYES_00,FREEMAIL_FROM, RCVD_IN_DNSWL_HI autolearn=unavailable version=3.3.2 Received: from lists.gnu.org ([208.118.235.17]:35380) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1StF2e-0003X4-IH for submit@debbugs.gnu.org; Mon, 23 Jul 2012 05:35:04 -0400 Received: from eggs.gnu.org ([208.118.235.92]:49616) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1StF2Y-0002LT-TA for bug-gnu-emacs@gnu.org; Mon, 23 Jul 2012 05:35:04 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1StF2T-0003Ke-9R for bug-gnu-emacs@gnu.org; Mon, 23 Jul 2012 05:34:58 -0400 Received: from mailout-de.gmx.net ([213.165.64.22]:54956) by eggs.gnu.org with smtp (Exim 4.71) (envelope-from ) id 1StF2S-0003KQ-Us for bug-gnu-emacs@gnu.org; Mon, 23 Jul 2012 05:34:53 -0400 Received: (qmail invoked by alias); 23 Jul 2012 09:34:52 -0000 Received: from 62-47-50-184.adsl.highway.telekom.at (EHLO [62.47.50.184]) [62.47.50.184] by mail.gmx.net (mp032) with SMTP; 23 Jul 2012 11:34:52 +0200 X-Authenticated: #14592706 X-Provags-ID: V01U2FsdGVkX1+2JRlSyx627XmShILUHSZg2kp5qHzU/TpKgtNPlL 6jOjTHaNE5ogpb Message-ID: <500D1AD1.8030704@gmx.at> Date: Mon, 23 Jul 2012 11:35:13 +0200 From: martin rudalics MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-Transfer-Encoding: 7bit X-Y-GMX-Trusted: 0 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-Received-From: 208.118.235.17 X-Spam-Score: -6.9 (------) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -6.9 (------) `yes-or-no-p' eventually winds up calling read_minibuf which does if (minibuffer_auto_raise) Fraise_frame (mini_frame); ... if (!EQ (mini_frame, selected_frame)) Fredirect_frame_focus (selected_frame, mini_frame); `y-or-n-p' instead does (when minibuffer-auto-raise (raise-frame (window-frame (minibuffer-window)))) ... (redirect-frame-focus (window-frame (minibuffer-window))) which strikes me as incongruent with the former since IIUC the last form only redirects the minibuffer-window frame's focus to itself. If this is not the intended behavior, a possible source of the bug is that the second argument of `redirect-frame-focus' is not mandatory. As a consequence, authors (including me) tend to consider its first argument reference the frame that shall be focused. martin From unknown Wed Sep 10 20:08:02 2025 X-Loop: help-debbugs@gnu.org Subject: bug#12030: 24.0.97; y-or-n-p and redirect-frame-focus Resent-From: Stefan Monnier Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 23 Jul 2012 10:16:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 12030 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: martin rudalics Cc: 12030@debbugs.gnu.org Received: via spool by 12030-submit@debbugs.gnu.org id=B12030.134303853425623 (code B ref 12030); Mon, 23 Jul 2012 10:16:01 +0000 Received: (at 12030) by debbugs.gnu.org; 23 Jul 2012 10:15:34 +0000 Received: from localhost ([127.0.0.1]:59181 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1StFfp-0006eP-6X for submit@debbugs.gnu.org; Mon, 23 Jul 2012 06:15:33 -0400 Received: from pruche.dit.umontreal.ca ([132.204.246.22]:48205) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1StFfn-0006c2-M7 for 12030@debbugs.gnu.org; Mon, 23 Jul 2012 06:15:32 -0400 Received: from fmsmemgm.homelinux.net (lechon.iro.umontreal.ca [132.204.27.242]) by pruche.dit.umontreal.ca (8.14.1/8.14.1) with ESMTP id q6NA8tLc017880; Mon, 23 Jul 2012 06:08:56 -0400 Received: by fmsmemgm.homelinux.net (Postfix, from userid 20848) id 3038EAE323; Mon, 23 Jul 2012 06:08:55 -0400 (EDT) From: Stefan Monnier Message-ID: References: <500D1AD1.8030704@gmx.at> Date: Mon, 23 Jul 2012 06:08:55 -0400 In-Reply-To: <500D1AD1.8030704@gmx.at> (martin rudalics's message of "Mon, 23 Jul 2012 11:35:13 +0200") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.1.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-NAI-Spam-Flag: NO X-NAI-Spam-Level: X-NAI-Spam-Threshold: 5 X-NAI-Spam-Score: 0.2 X-NAI-Spam-Rules: 2 Rules triggered GEN_SPAM_FEATRE=0.2, RV4287=0 X-NAI-Spam-Version: 2.2.0.9309 : core <4287> : streams <789228> : uri <1172549> X-Spam-Score: -3.5 (---) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -3.5 (---) > only redirects the minibuffer-window frame's focus to itself. If this > is not the intended behavior, a possible source of the bug is that the > second argument of `redirect-frame-focus' is not mandatory. As a I think you're right. Could you make it "soft-mandatory" by adding an `advertised-signature'? Stefan From unknown Wed Sep 10 20:08:02 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.428 (Entity 5.428) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: martin rudalics Subject: bug#12030: closed (Re: bug#12030: 24.0.97; y-or-n-p and redirect-frame-focus) Message-ID: References: <500FC081.40809@gmx.at> <500D1AD1.8030704@gmx.at> X-Gnu-PR-Message: they-closed 12030 X-Gnu-PR-Package: emacs Reply-To: 12030@debbugs.gnu.org Date: Wed, 25 Jul 2012 09:54:02 +0000 Content-Type: multipart/mixed; boundary="----------=_1343210042-22863-1" This is a multi-part message in MIME format... ------------=_1343210042-22863-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #12030: 24.0.97; y-or-n-p and redirect-frame-focus which was filed against the emacs package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 12030@debbugs.gnu.org. --=20 12030: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D12030 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1343210042-22863-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 12030-done) by debbugs.gnu.org; 25 Jul 2012 09:53:11 +0000 Received: from localhost ([127.0.0.1]:38444 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1StyHG-0005vj-NW for submit@debbugs.gnu.org; Wed, 25 Jul 2012 05:53:10 -0400 Received: from mailout-de.gmx.net ([213.165.64.23]:44058) by debbugs.gnu.org with smtp (Exim 4.72) (envelope-from ) id 1StyHF-0005va-Ci for 12030-done@debbugs.gnu.org; Wed, 25 Jul 2012 05:53:10 -0400 Received: (qmail invoked by alias); 25 Jul 2012 09:46:23 -0000 Received: from 62-47-42-102.adsl.highway.telekom.at (EHLO [62.47.42.102]) [62.47.42.102] by mail.gmx.net (mp031) with SMTP; 25 Jul 2012 11:46:23 +0200 X-Authenticated: #14592706 X-Provags-ID: V01U2FsdGVkX1+rSQEDWrqrST/KXziEzoQdiOTYjZrEe62gBrDnNl 0zXxgaa2YlBuvO Message-ID: <500FC081.40809@gmx.at> Date: Wed, 25 Jul 2012 11:46:41 +0200 From: martin rudalics MIME-Version: 1.0 To: 12030-done@debbugs.gnu.org Subject: Re: bug#12030: 24.0.97; y-or-n-p and redirect-frame-focus References: <500D1AD1.8030704@gmx.at> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-Transfer-Encoding: 7bit X-Y-GMX-Trusted: 0 X-Spam-Score: -1.9 (-) X-Debbugs-Envelope-To: 12030-done Cc: Stefan Monnier X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -1.9 (-) > I think you're right. Could you make it "soft-mandatory" by adding > an `advertised-signature'? Done. martin ------------=_1343210042-22863-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 23 Jul 2012 09:41:44 +0000 Received: from localhost ([127.0.0.1]:58980 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1StF95-0004AW-NA for submit@debbugs.gnu.org; Mon, 23 Jul 2012 05:41:43 -0400 Received: from eggs.gnu.org ([208.118.235.92]:60559) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1StF93-0004AM-Gl for submit@debbugs.gnu.org; Mon, 23 Jul 2012 05:41:42 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1StF2e-0003Xw-Lm for submit@debbugs.gnu.org; Mon, 23 Jul 2012 05:35:08 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=5.0 tests=BAYES_00,FREEMAIL_FROM, RCVD_IN_DNSWL_HI autolearn=unavailable version=3.3.2 Received: from lists.gnu.org ([208.118.235.17]:35380) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1StF2e-0003X4-IH for submit@debbugs.gnu.org; Mon, 23 Jul 2012 05:35:04 -0400 Received: from eggs.gnu.org ([208.118.235.92]:49616) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1StF2Y-0002LT-TA for bug-gnu-emacs@gnu.org; Mon, 23 Jul 2012 05:35:04 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1StF2T-0003Ke-9R for bug-gnu-emacs@gnu.org; Mon, 23 Jul 2012 05:34:58 -0400 Received: from mailout-de.gmx.net ([213.165.64.22]:54956) by eggs.gnu.org with smtp (Exim 4.71) (envelope-from ) id 1StF2S-0003KQ-Us for bug-gnu-emacs@gnu.org; Mon, 23 Jul 2012 05:34:53 -0400 Received: (qmail invoked by alias); 23 Jul 2012 09:34:52 -0000 Received: from 62-47-50-184.adsl.highway.telekom.at (EHLO [62.47.50.184]) [62.47.50.184] by mail.gmx.net (mp032) with SMTP; 23 Jul 2012 11:34:52 +0200 X-Authenticated: #14592706 X-Provags-ID: V01U2FsdGVkX1+2JRlSyx627XmShILUHSZg2kp5qHzU/TpKgtNPlL 6jOjTHaNE5ogpb Message-ID: <500D1AD1.8030704@gmx.at> Date: Mon, 23 Jul 2012 11:35:13 +0200 From: martin rudalics MIME-Version: 1.0 To: Bug-Gnu-Emacs Subject: 24.0.97; y-or-n-p and redirect-frame-focus Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-Transfer-Encoding: 7bit X-Y-GMX-Trusted: 0 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-Received-From: 208.118.235.17 X-Spam-Score: -6.9 (------) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -6.9 (------) `yes-or-no-p' eventually winds up calling read_minibuf which does if (minibuffer_auto_raise) Fraise_frame (mini_frame); ... if (!EQ (mini_frame, selected_frame)) Fredirect_frame_focus (selected_frame, mini_frame); `y-or-n-p' instead does (when minibuffer-auto-raise (raise-frame (window-frame (minibuffer-window)))) ... (redirect-frame-focus (window-frame (minibuffer-window))) which strikes me as incongruent with the former since IIUC the last form only redirects the minibuffer-window frame's focus to itself. If this is not the intended behavior, a possible source of the bug is that the second argument of `redirect-frame-focus' is not mandatory. As a consequence, authors (including me) tend to consider its first argument reference the frame that shall be focused. martin ------------=_1343210042-22863-1--