GNU bug report logs - #12018
24.1.50; Calendar HTML export breaks with no holidays in month

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Glenn Morris <rgm <at> gnu.org>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#12018: closed (24.1.50; Calendar HTML export breaks with no
 holidays in month)
Date: Wed, 01 Aug 2012 07:25:02 +0000

[Message part 1 (text/plain, inline)]

Your message dated Wed, 01 Aug 2012 03:16:34 -0400
with message-id <coboivqdyl.fsf <at> fencepost.gnu.org>
and subject line Re: bug#12018: 24.1.50; Calendar HTML export breaks with no holidays in month
has caused the debbugs.gnu.org bug report #12018,
regarding 24.1.50; Calendar HTML export breaks with no holidays in month
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
12018: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=12018
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Rupert Swarbrick <rswarbrick <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: 24.1.50; Calendar HTML export breaks with no holidays in month
Date: Sat, 21 Jul 2012 12:09:36 +0100

[Message part 3 (text/plain, inline)]

Calling cal-html-cursor-month from a *Calendar* buffer using H-m
triggers an error in cal-html-insert-agenda-days (in
lisp/calendar/cal-html.el) if there are no holidays in the given
month. Since this is true for August, I've just triggered it!

The problem is the

    (and holiday-list diary-list "<BR>\n")

(line 399 in current trunk) inside an insert. (insert NIL) is not
ok. Changing the line to

    (if (and holiday-list diary-list) "<BR>\n" "")

Fixes the issue.

Thanks,

Rupert

[Message part 4 (application/pgp-signature, inline)]

[Message part 5 (message/rfc822, inline)]

From: Glenn Morris <rgm <at> gnu.org>
To: 12018-done <at> debbugs.gnu.org
Subject: Re: bug#12018: 24.1.50;
	Calendar HTML export breaks with no holidays in month
Date: Wed, 01 Aug 2012 03:16:34 -0400

Thanks; applied.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.