From unknown Thu Sep 11 10:42:24 2025 X-Loop: help-debbugs@gnu.org Subject: bug#12018: 24.1.50; Calendar HTML export breaks with no holidays in month Resent-From: Rupert Swarbrick Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 21 Jul 2012 21:17:05 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 12018 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: 12018@debbugs.gnu.org X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.13429054154219 (code B ref -1); Sat, 21 Jul 2012 21:17:05 +0000 Received: (at submit) by debbugs.gnu.org; 21 Jul 2012 21:16:55 +0000 Received: from localhost ([127.0.0.1]:56290 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1Ssh2k-00015v-UF for submit@debbugs.gnu.org; Sat, 21 Jul 2012 17:16:55 -0400 Received: from eggs.gnu.org ([208.118.235.92]:55156) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SsXfN-0002Yl-3Y for submit@debbugs.gnu.org; Sat, 21 Jul 2012 07:16:09 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SsXZB-0001ZP-T8 for submit@debbugs.gnu.org; Sat, 21 Jul 2012 07:09:46 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=5.0 tests=BAYES_00,FREEMAIL_FROM, RCVD_IN_DNSWL_HI,T_DKIM_INVALID autolearn=unavailable version=3.3.2 Received: from lists.gnu.org ([208.118.235.17]:55648) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SsXZB-0001ZL-Q6 for submit@debbugs.gnu.org; Sat, 21 Jul 2012 07:09:45 -0400 Received: from eggs.gnu.org ([208.118.235.92]:44431) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SsXZA-0007Ox-SW for bug-gnu-emacs@gnu.org; Sat, 21 Jul 2012 07:09:45 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SsXZA-0001Z7-04 for bug-gnu-emacs@gnu.org; Sat, 21 Jul 2012 07:09:44 -0400 Received: from mail-wi0-f177.google.com ([209.85.212.177]:64963) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SsXZ9-0001Yz-Q4 for bug-gnu-emacs@gnu.org; Sat, 21 Jul 2012 07:09:43 -0400 Received: by wibhm11 with SMTP id hm11so1092626wib.12 for ; Sat, 21 Jul 2012 04:09:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:subject:date:message-id:user-agent:mime-version :content-type; bh=k07fmbJPzFPRcrKRjLB3t9vfoAOvOiL2c3tlbl3LhDo=; b=vLtQSts8vVHuWseO+/9+z8nHEoz7/T0EX2pdfaJXCp4EYmdRu8IMaA0gGIXCFCKkJ5 iFLDZXX9v8k3QotqDspGjjYR325DiSMighij4e5AHao81H9ghd2qMwu/5DKEM9aIKetd cxT2Yut6//lkz/2qv0/JkYdVou+4V7jLoPRHrz3RKijOO9nnJKx2WILv1D4A36fFP2F3 wXsPhHSamplNxFrc2SiZ34PXBFS2eoSn5OQD4BrMtmi/kETmGWUyo/iGb1RS1/lWjkFW ry7tAYisZqyy5rrPJ6q6GSrFk++r9GSBZszctF/qfMcfGvS4YksXAeQ3uDp/PTiAMtPH 1xuQ== Received: by 10.180.81.138 with SMTP id a10mr21522725wiy.7.1342868982745; Sat, 21 Jul 2012 04:09:42 -0700 (PDT) Received: from hake.rswarbrick.dnsalias.com (cpc1-cove3-0-0-cust941.3-1.cable.virginmedia.com. [86.20.31.174]) by mx.google.com with ESMTPS id k20sm3422701wiv.11.2012.07.21.04.09.40 (version=TLSv1/SSLv3 cipher=OTHER); Sat, 21 Jul 2012 04:09:41 -0700 (PDT) Received: from hake.rswarbrick.dnsalias.com (localhost [127.0.0.1]) (using TLSv1.2 with cipher DHE-RSA-AES128-SHA (128/128 bits)) (No client certificate requested) by hake.rswarbrick.dnsalias.com (Postfix) with ESMTPS id 95DCA167504 for ; Sat, 21 Jul 2012 12:09:39 +0100 (BST) From: Rupert Swarbrick Date: Sat, 21 Jul 2012 12:09:36 +0100 Message-ID: <87mx2t1ibz.fsf@hake.rswarbrick.dnsalias.com> User-Agent: Gnus/5.130006 (Ma Gnus v0.6) Emacs/24.1.50 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha1; protocol="application/pgp-signature" X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-Received-From: 208.118.235.17 X-Spam-Score: -6.1 (------) X-Mailman-Approved-At: Sat, 21 Jul 2012 17:16:45 -0400 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -6.1 (------) --=-=-= Content-Type: text/plain Calling cal-html-cursor-month from a *Calendar* buffer using H-m triggers an error in cal-html-insert-agenda-days (in lisp/calendar/cal-html.el) if there are no holidays in the given month. Since this is true for August, I've just triggered it! The problem is the (and holiday-list diary-list "
\n") (line 399 in current trunk) inside an insert. (insert NIL) is not ok. Changing the line to (if (and holiday-list diary-list) "
\n" "") Fixes the issue. Thanks, Rupert --=-=-= Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (GNU/Linux) iJwEAQECAAYFAlAKjfAACgkQRtd/pJbYVoZvxQP+JBrpb8BhXZk8hK+tLoIkR23i 7mk/hC27jPC2d30sSkihWFw9Gik0UOQZ46oy9IXXNdQ2ThShew3/YWrznjUbLPb1 L6JizRBzO+PrhUv4QxNJYdLrbhjVOIMup4T7IvwhrL5tDEAPop1FWtslkojisffb k1Rg6+SNqS72Ef8eq30= =6shu -----END PGP SIGNATURE----- --=-=-=-- From unknown Thu Sep 11 10:42:24 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.428 (Entity 5.428) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: Rupert Swarbrick Subject: bug#12018: closed (Re: bug#12018: 24.1.50; Calendar HTML export breaks with no holidays in month) Message-ID: References: <87mx2t1ibz.fsf@hake.rswarbrick.dnsalias.com> X-Gnu-PR-Message: they-closed 12018 X-Gnu-PR-Package: emacs X-Gnu-PR-Keywords: patch Reply-To: 12018@debbugs.gnu.org Date: Wed, 01 Aug 2012 07:25:02 +0000 Content-Type: multipart/mixed; boundary="----------=_1343805902-7957-1" This is a multi-part message in MIME format... ------------=_1343805902-7957-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #12018: 24.1.50; Calendar HTML export breaks with no holidays in month which was filed against the emacs package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 12018@debbugs.gnu.org. --=20 12018: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D12018 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1343805902-7957-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 12018-done) by debbugs.gnu.org; 1 Aug 2012 07:24:01 +0000 Received: from localhost ([127.0.0.1]:53824 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SwTHl-00022t-Ds for submit@debbugs.gnu.org; Wed, 01 Aug 2012 03:24:01 -0400 Received: from fencepost.gnu.org ([208.118.235.10]:45047) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SwTHj-00022m-Ml for 12018-done@debbugs.gnu.org; Wed, 01 Aug 2012 03:24:00 -0400 Received: from rgm by fencepost.gnu.org with local (Exim 4.71) (envelope-from ) id 1SwTAY-0002A6-IG; Wed, 01 Aug 2012 03:16:34 -0400 From: Glenn Morris To: 12018-done@debbugs.gnu.org Subject: Re: bug#12018: 24.1.50; Calendar HTML export breaks with no holidays in month References: <87mx2t1ibz.fsf@hake.rswarbrick.dnsalias.com> X-Spook: Plame anarchy constitution keyhole AFSPC Area 51 class X-Ran: qgv{Hdw6+h(oF*B,#Hck{pO|>#+E]Be5Ab$0}s)(Xl|6`Z&0NJAP[m7+!R*X@1$j4$ptx1 X-Hue: red X-Debbugs-No-Ack: yes X-Attribution: GM Date: Wed, 01 Aug 2012 03:16:34 -0400 In-Reply-To: <87mx2t1ibz.fsf@hake.rswarbrick.dnsalias.com> (Rupert Swarbrick's message of "Sat, 21 Jul 2012 12:09:36 +0100") Message-ID: User-Agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Spam-Score: -6.9 (------) X-Debbugs-Envelope-To: 12018-done X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -6.9 (------) Thanks; applied. ------------=_1343805902-7957-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 21 Jul 2012 21:16:55 +0000 Received: from localhost ([127.0.0.1]:56290 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1Ssh2k-00015v-UF for submit@debbugs.gnu.org; Sat, 21 Jul 2012 17:16:55 -0400 Received: from eggs.gnu.org ([208.118.235.92]:55156) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SsXfN-0002Yl-3Y for submit@debbugs.gnu.org; Sat, 21 Jul 2012 07:16:09 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SsXZB-0001ZP-T8 for submit@debbugs.gnu.org; Sat, 21 Jul 2012 07:09:46 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=5.0 tests=BAYES_00,FREEMAIL_FROM, RCVD_IN_DNSWL_HI,T_DKIM_INVALID autolearn=unavailable version=3.3.2 Received: from lists.gnu.org ([208.118.235.17]:55648) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SsXZB-0001ZL-Q6 for submit@debbugs.gnu.org; Sat, 21 Jul 2012 07:09:45 -0400 Received: from eggs.gnu.org ([208.118.235.92]:44431) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SsXZA-0007Ox-SW for bug-gnu-emacs@gnu.org; Sat, 21 Jul 2012 07:09:45 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SsXZA-0001Z7-04 for bug-gnu-emacs@gnu.org; Sat, 21 Jul 2012 07:09:44 -0400 Received: from mail-wi0-f177.google.com ([209.85.212.177]:64963) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SsXZ9-0001Yz-Q4 for bug-gnu-emacs@gnu.org; Sat, 21 Jul 2012 07:09:43 -0400 Received: by wibhm11 with SMTP id hm11so1092626wib.12 for ; Sat, 21 Jul 2012 04:09:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:subject:date:message-id:user-agent:mime-version :content-type; bh=k07fmbJPzFPRcrKRjLB3t9vfoAOvOiL2c3tlbl3LhDo=; b=vLtQSts8vVHuWseO+/9+z8nHEoz7/T0EX2pdfaJXCp4EYmdRu8IMaA0gGIXCFCKkJ5 iFLDZXX9v8k3QotqDspGjjYR325DiSMighij4e5AHao81H9ghd2qMwu/5DKEM9aIKetd cxT2Yut6//lkz/2qv0/JkYdVou+4V7jLoPRHrz3RKijOO9nnJKx2WILv1D4A36fFP2F3 wXsPhHSamplNxFrc2SiZ34PXBFS2eoSn5OQD4BrMtmi/kETmGWUyo/iGb1RS1/lWjkFW ry7tAYisZqyy5rrPJ6q6GSrFk++r9GSBZszctF/qfMcfGvS4YksXAeQ3uDp/PTiAMtPH 1xuQ== Received: by 10.180.81.138 with SMTP id a10mr21522725wiy.7.1342868982745; Sat, 21 Jul 2012 04:09:42 -0700 (PDT) Received: from hake.rswarbrick.dnsalias.com (cpc1-cove3-0-0-cust941.3-1.cable.virginmedia.com. [86.20.31.174]) by mx.google.com with ESMTPS id k20sm3422701wiv.11.2012.07.21.04.09.40 (version=TLSv1/SSLv3 cipher=OTHER); Sat, 21 Jul 2012 04:09:41 -0700 (PDT) Received: from hake.rswarbrick.dnsalias.com (localhost [127.0.0.1]) (using TLSv1.2 with cipher DHE-RSA-AES128-SHA (128/128 bits)) (No client certificate requested) by hake.rswarbrick.dnsalias.com (Postfix) with ESMTPS id 95DCA167504 for ; Sat, 21 Jul 2012 12:09:39 +0100 (BST) From: Rupert Swarbrick To: bug-gnu-emacs@gnu.org Subject: 24.1.50; Calendar HTML export breaks with no holidays in month Date: Sat, 21 Jul 2012 12:09:36 +0100 Message-ID: <87mx2t1ibz.fsf@hake.rswarbrick.dnsalias.com> User-Agent: Gnus/5.130006 (Ma Gnus v0.6) Emacs/24.1.50 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha1; protocol="application/pgp-signature" X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-Received-From: 208.118.235.17 X-Spam-Score: -6.1 (------) X-Debbugs-Envelope-To: submit X-Mailman-Approved-At: Sat, 21 Jul 2012 17:16:45 -0400 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -6.1 (------) --=-=-= Content-Type: text/plain Calling cal-html-cursor-month from a *Calendar* buffer using H-m triggers an error in cal-html-insert-agenda-days (in lisp/calendar/cal-html.el) if there are no holidays in the given month. Since this is true for August, I've just triggered it! The problem is the (and holiday-list diary-list "
\n") (line 399 in current trunk) inside an insert. (insert NIL) is not ok. Changing the line to (if (and holiday-list diary-list) "
\n" "") Fixes the issue. Thanks, Rupert --=-=-= Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (GNU/Linux) iJwEAQECAAYFAlAKjfAACgkQRtd/pJbYVoZvxQP+JBrpb8BhXZk8hK+tLoIkR23i 7mk/hC27jPC2d30sSkihWFw9Gik0UOQZ46oy9IXXNdQ2ThShew3/YWrznjUbLPb1 L6JizRBzO+PrhUv4QxNJYdLrbhjVOIMup4T7IvwhrL5tDEAPop1FWtslkojisffb k1Rg6+SNqS72Ef8eq30= =6shu -----END PGP SIGNATURE----- --=-=-=-- ------------=_1343805902-7957-1--