From unknown Fri Jun 20 19:52:53 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#12002 <12002@debbugs.gnu.org> To: bug#12002 <12002@debbugs.gnu.org> Subject: Status: 24.1.50; ERC nick change trouble Reply-To: bug#12002 <12002@debbugs.gnu.org> Date: Sat, 21 Jun 2025 02:52:53 +0000 retitle 12002 24.1.50; ERC nick change trouble reassign 12002 emacs submitter 12002 Antoine Levitt severity 12002 normal tag 12002 patch thanks From debbugs-submit-bounces@debbugs.gnu.org Fri Jul 20 19:02:54 2012 Received: (at submit) by debbugs.gnu.org; 20 Jul 2012 23:02:54 +0000 Received: from localhost ([127.0.0.1]:53190 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SsMDl-000262-LX for submit@debbugs.gnu.org; Fri, 20 Jul 2012 19:02:54 -0400 Received: from eggs.gnu.org ([208.118.235.92]:51914) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SsMDj-00025s-13 for submit@debbugs.gnu.org; Fri, 20 Jul 2012 19:02:51 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SsM7a-0006U8-Oo for submit@debbugs.gnu.org; Fri, 20 Jul 2012 18:56:31 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=5.0 tests=BAYES_00,FREEMAIL_FROM, RCVD_IN_DNSWL_HI,T_DKIM_INVALID autolearn=unavailable version=3.3.2 Received: from lists.gnu.org ([208.118.235.17]:58627) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SsM7a-0006U4-Ji for submit@debbugs.gnu.org; Fri, 20 Jul 2012 18:56:30 -0400 Received: from eggs.gnu.org ([208.118.235.92]:45991) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SsM7Z-0003d2-Or for bug-gnu-emacs@gnu.org; Fri, 20 Jul 2012 18:56:30 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SsM7Y-0006Tl-KS for bug-gnu-emacs@gnu.org; Fri, 20 Jul 2012 18:56:29 -0400 Received: from mail-wg0-f49.google.com ([74.125.82.49]:42297) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SsM7Y-0006Tg-E7 for bug-gnu-emacs@gnu.org; Fri, 20 Jul 2012 18:56:28 -0400 Received: by wgbez12 with SMTP id ez12so3199784wgb.30 for ; Fri, 20 Jul 2012 15:56:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:subject:date:message-id:user-agent:mime-version :content-type; bh=BmjpQuzS6aDksik7xqHSHR5VYQO5HN+I8TYHD5rfqrc=; b=BnHPgVDKbKn/pJ6kIxiomFFildavU2Aka6kaU9+NOIQQWdUPDeABoFtxms7ROwRTNh 1aYFbu8UlfuBCXhNOzgyNDmI/ZKHDaJHitzQTdllZWq8n+F14dT2fWIyw/abhT4Y5O9s G4XDIFytHh6i5mv96+oAEMworehI6cwGSYs3xSURPNdo9nFmayi+HEsJBPcbOOaC6Y0+ zhq4HtO64yZDILN6CdJkNff+WnGqKm/pxvwUcL2kBIWLRzcRg7b52eAXtwFH/ZMxwLIb KCQdiwd7f8xzkDH+U5l1tJSt99pvmkxyMJ9udXnaFf1cFzA+YMtNHUJbU90RG0ZRFvvE 4E2w== Received: by 10.217.5.130 with SMTP id w2mr29352wes.45.1342824986923; Fri, 20 Jul 2012 15:56:26 -0700 (PDT) Received: from lambda (ney92-7-78-233-218-202.fbx.proxad.net. [78.233.218.202]) by mx.google.com with ESMTPS id y5sm254938wiw.9.2012.07.20.15.56.26 (version=TLSv1/SSLv3 cipher=OTHER); Fri, 20 Jul 2012 15:56:26 -0700 (PDT) From: Antoine Levitt To: bug-gnu-emacs@gnu.org Subject: 24.1.50; ERC nick change trouble Date: Sat, 21 Jul 2012 00:56:25 +0200 Message-ID: <87sjcmkpnq.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.1.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-Received-From: 208.118.235.17 X-Spam-Score: -6.1 (------) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -6.1 (------) Hi, There's a bug in ERC nick change handling. Imagine you have a query with john, who has a timeout. He then comes back as john-, and queries you. Then, when his old timeout goes away, he changes nick back to john. The ERC response handler then tries to change the john- query buffer name to john, which clashes with the old buffer. Since there was an error in the execution flow, everything is messed up. Here's a patch that doesn't try to change the name back when a buffer of the same name exists. It still notifies the old query buffer of the name change though. I haven't tested it but it should be fine. (I think ...) I'm not holding my breath on this, because of the lack of activity of ERC maintainers. Still, at least the patch is out there. diff --git a/lisp/erc/erc-backend.el b/lisp/erc/erc-backend.el index cce24e6..115c31f 100644 --- a/lisp/erc/erc-backend.el +++ b/lisp/erc/erc-backend.el @@ -1313,10 +1313,11 @@ add things to `%s' instead." (erc-buffer-filter (lambda () (when (equal (erc-default-target) nick) - (setq erc-default-recipients - (cons nn (cdr erc-default-recipients))) - (rename-buffer nn) - (erc-update-mode-line) + (unless (get-buffer nn) + (setq erc-default-recipients + (cons nn (cdr erc-default-recipients))) + (rename-buffer nn) + (erc-update-mode-line)) (add-to-list 'bufs (current-buffer))))) (erc-update-user-nick nick nn host nil nil login) (cond From debbugs-submit-bounces@debbugs.gnu.org Sat Oct 06 21:29:45 2012 Received: (at 12002-done) by debbugs.gnu.org; 7 Oct 2012 01:29:46 +0000 Received: from localhost ([127.0.0.1]:58781 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TKfgf-0005ik-Fk for submit@debbugs.gnu.org; Sat, 06 Oct 2012 21:29:45 -0400 Received: from fencepost.gnu.org ([208.118.235.10]:39107 ident=Debian-exim) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TKfgd-0005id-4N for 12002-done@debbugs.gnu.org; Sat, 06 Oct 2012 21:29:43 -0400 Received: from rgm by fencepost.gnu.org with local (Exim 4.71) (envelope-from ) id 1TKfgJ-0004h5-3i; Sat, 06 Oct 2012 21:29:23 -0400 From: Glenn Morris To: 12002-done@debbugs.gnu.org Subject: Re: bug#12002: 24.1.50; ERC nick change trouble References: <87sjcmkpnq.fsf@gmail.com> X-Spook: TWA CIDA Mossad nitrate Albright covert video computer X-Ran: Edby<>h&.w(!/(o'dD9mSzSA^{aWcQ,hD9L34 (Antoine Levitt's message of "Sat, 21 Jul 2012 00:56:25 +0200") Message-ID: User-Agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Spam-Score: -6.3 (------) X-Debbugs-Envelope-To: 12002-done X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -6.3 (------) Version: 24.3 Thanks. I installed a simpler change (below). Please let me know if it is not ok, since I don't use erc. *** lisp/erc/erc-backend.el 2012-10-06 01:04:53 +0000 --- lisp/erc/erc-backend.el 2012-10-07 01:25:39 +0000 *************** *** 1316,1322 **** (when (equal (erc-default-target) nick) (setq erc-default-recipients (cons nn (cdr erc-default-recipients))) ! (rename-buffer nn) (erc-update-mode-line) (add-to-list 'bufs (current-buffer))))) (erc-update-user-nick nick nn host nil nil login) --- 1316,1322 ---- (when (equal (erc-default-target) nick) (setq erc-default-recipients (cons nn (cdr erc-default-recipients))) ! (rename-buffer nn t) ; bug#12002 (erc-update-mode-line) (add-to-list 'bufs (current-buffer))))) (erc-update-user-nick nick nn host nil nil login) From debbugs-submit-bounces@debbugs.gnu.org Sat Oct 06 21:48:04 2012 Received: (at control) by debbugs.gnu.org; 7 Oct 2012 01:48:04 +0000 Received: from localhost ([127.0.0.1]:58808 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TKfyO-0006C6-Fq for submit@debbugs.gnu.org; Sat, 06 Oct 2012 21:48:04 -0400 Received: from fencepost.gnu.org ([208.118.235.10]:39280 ident=Debian-exim) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TKfyL-0006Bb-Ml for control@debbugs.gnu.org; Sat, 06 Oct 2012 21:48:02 -0400 Received: from rgm by fencepost.gnu.org with local (Exim 4.71) (envelope-from ) id 1TKfy2-0000nb-9x for control@debbugs.gnu.org; Sat, 06 Oct 2012 21:47:42 -0400 Date: Sat, 06 Oct 2012 21:47:42 -0400 Message-Id: Subject: control message for bug 6016 To: X-Mailer: mail (GNU Mailutils 2.1) From: Glenn Morris X-Spam-Score: -6.3 (------) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -6.3 (------) forcemerge 12002 6016 From unknown Fri Jun 20 19:52:53 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Sun, 04 Nov 2012 12:24:02 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator