GNU bug report logs - #11995
vc-compilation-mode name and implementation

Previous Next

Full log

Message #8 received at 11995 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Dan Nicolaescu <dann <at> gnu.org>
Cc: 11995 <at> debbugs.gnu.org
Subject: Re: bug#11995: vc-compilation-mode name and implementation
Date: Wed, 20 Jan 2021 05:20:37 +0100

Dan Nicolaescu <dann <at> gnu.org> writes:

> The newly added vc-compilation-mode function does not have the best
> name, -mode functions stand for modes, this is not one.

(I'm going through old bug reports that unfortunately got no response at
the time.)

It is perhaps not an ideal name, but it's probably too late to change
now, though.

> Currently the preferred way to define modes is to use
> `defined-derived-mode'...
>
> Also the implementation seems to be a bit more complicated than needed:
> there
>
> Defining a vc-default-compilation-mode function should simplify the
> implementation.  vc-make-backend-sym is something that very few things
> need to call.

I think it looks like something was left out of this message?  I'm not
sure what this is referring to.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.